[maven-surefire] branch master updated (3a6b00a -> 891a7b9)

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[maven-surefire] branch master updated (3a6b00a -> 891a7b9)

Tibor Digana
This is an automated email from the ASF dual-hosted git repository.

tibordigana pushed a change to branch master
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git.


    from 3a6b00a  integration tests with Java 9+ should use <maven.compiler.release>${java.specification.version}</maven.compiler.release>
     new 6e5ecba  H31 gives OOME (let's see if others are stable again...)
     new 8a769ca  scheduleAtFixedRate() runs too frequent runs after GC paused the scheduler
     new 891a7b9  dump command output when fails

The 3 revisions listed above as "new" are entirely new to this
repository and will be described in separate emails.  The revisions
listed as "add" were already present in the repository and have only
been added to this reference.


Summary of changes:
 Jenkinsfile                                              |  2 +-
 .../maven/plugin/surefire/booterclient/ForkStarter.java  |  6 +++---
 .../org/apache/maven/surefire/booter/PpidChecker.java    | 16 ++++++++++++++--
 3 files changed, 18 insertions(+), 6 deletions(-)

Reply | Threaded
Open this post in threaded view
|

[maven-surefire] 01/03: H31 gives OOME (let's see if others are stable again...)

Tibor Digana
This is an automated email from the ASF dual-hosted git repository.

tibordigana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git

commit 6e5ecba0ae88a6f3059b117b61274386ab4086ff
Author: tibordigana <[hidden email]>
AuthorDate: Sun Nov 10 19:09:16 2019 +0100

    H31 gives OOME (let's see if others are stable again...)
---
 Jenkinsfile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/Jenkinsfile b/Jenkinsfile
index 986c1bf..a17c200 100644
--- a/Jenkinsfile
+++ b/Jenkinsfile
@@ -30,7 +30,7 @@ properties(
     ]
 )
 
-final def oses = ['linux':'ubuntu', 'windows':'Windows']
+final def oses = ['linux':'ubuntu && !H31', 'windows':'Windows']
 final def mavens = env.BRANCH_NAME == 'master' ? ['3.6.x', '3.2.x'] : ['3.6.x']
 // all non-EOL versions and the first EA
 final def jdks = [14, 13, 11, 8, 7]

Reply | Threaded
Open this post in threaded view
|

[maven-surefire] 02/03: scheduleAtFixedRate() runs too frequent runs after GC paused the scheduler

Tibor Digana
In reply to this post by Tibor Digana
This is an automated email from the ASF dual-hosted git repository.

tibordigana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git

commit 8a769ca6ce97d890da4fd07d1e3d4f53f556625a
Author: tibordigana <[hidden email]>
AuthorDate: Sun Nov 10 19:19:44 2019 +0100

    scheduleAtFixedRate() runs too frequent runs after GC paused the scheduler
---
 .../org/apache/maven/plugin/surefire/booterclient/ForkStarter.java  | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java
index 5ee5538..2570977 100644
--- a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java
+++ b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/booterclient/ForkStarter.java
@@ -779,7 +779,7 @@ public class ForkStarter
 
     private ScheduledFuture<?> triggerPingTimerForShutdown( final TestLessInputStreamBuilder builder )
     {
-        return pingThreadScheduler.scheduleAtFixedRate( new Runnable()
+        return pingThreadScheduler.scheduleWithFixedDelay( new Runnable()
         {
             @Override
             public void run()
@@ -791,7 +791,7 @@ public class ForkStarter
 
     private ScheduledFuture<?> triggerPingTimerForShutdown( final Iterable<TestProvidingInputStream> streams )
     {
-        return pingThreadScheduler.scheduleAtFixedRate( new Runnable()
+        return pingThreadScheduler.scheduleWithFixedDelay( new Runnable()
         {
             @Override
             public void run()
@@ -806,7 +806,7 @@ public class ForkStarter
 
     private ScheduledFuture<?> triggerTimeoutCheck()
     {
-        return timeoutCheckScheduler.scheduleAtFixedRate( new Runnable()
+        return timeoutCheckScheduler.scheduleWithFixedDelay( new Runnable()
         {
             @Override
             public void run()

Reply | Threaded
Open this post in threaded view
|

[maven-surefire] 03/03: dump command output when fails

Tibor Digana
In reply to this post by Tibor Digana
This is an automated email from the ASF dual-hosted git repository.

tibordigana pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/maven-surefire.git

commit 891a7b9c1c1d9b7bca397025efdecbc64ef130d9
Author: tibordigana <[hidden email]>
AuthorDate: Sun Nov 10 19:20:57 2019 +0100

    dump command output when fails
---
 .../org/apache/maven/surefire/booter/PpidChecker.java    | 16 ++++++++++++++--
 1 file changed, 14 insertions(+), 2 deletions(-)

diff --git a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
index 4a89b59..3b5a007 100644
--- a/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
+++ b/surefire-booter/src/main/java/org/apache/maven/surefire/booter/PpidChecker.java
@@ -47,6 +47,7 @@ import static org.apache.maven.surefire.booter.ProcessInfo.unixProcessInfo;
 import static org.apache.maven.surefire.booter.ProcessInfo.windowsProcessInfo;
 import static org.apache.maven.surefire.booter.ProcessInfo.ERR_PROCESS_INFO;
 import static org.apache.maven.surefire.booter.ProcessInfo.INVALID_PROCESS_INFO;
+import static org.apache.maven.surefire.util.internal.StringUtils.NL;
 
 /**
  * Recognizes PID of Plugin process and determines lifetime.
@@ -384,6 +385,7 @@ final class PpidChecker
             processBuilder.redirectErrorStream( true );
             Process process = null;
             ProcessInfo processInfo = INVALID_PROCESS_INFO;
+            StringBuilder out = new StringBuilder( 64 );
             try
             {
                 if ( IS_OS_HP_UX ) // force to run shell commands in UNIX Standard mode on HP-UX
@@ -395,16 +397,26 @@ final class PpidChecker
                 Scanner scanner = new Scanner( process.getInputStream(), charset );
                 while ( scanner.hasNextLine() )
                 {
-                    String line = scanner.nextLine().trim();
-                    processInfo = consumeLine( line, processInfo );
+                    String line = scanner.nextLine();
+                    out.append( line ).append( NL );
+                    processInfo = consumeLine( line.trim(), processInfo );
                 }
                 checkValid( scanner );
                 int exitCode = process.waitFor();
+                if ( exitCode != 0 || isStopped() )
+                {
+                    out.append( "<<exit>> <<" ).append( exitCode ).append( ">>" ).append( NL );
+                    DumpErrorSingleton.getSingleton()
+                            .dumpText( out.toString() );
+                }
                 return isStopped() ? ERR_PROCESS_INFO : exitCode == 0 ? processInfo : INVALID_PROCESS_INFO;
             }
             catch ( Exception e )
             {
                 DumpErrorSingleton.getSingleton()
+                        .dumpText( out.toString() );
+
+                DumpErrorSingleton.getSingleton()
                         .dumpException( e );
 
                 return ERR_PROCESS_INFO;