maven-compiler-plugin master build

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

maven-compiler-plugin master build

Karl Heinz Marbaise-3
Hi to all,

does someone has an idea about the reason why master of maven-compiler
plugin is RED ?

I wanted to update some parts related to JDK 10 and want to make a
release but based on the RED master I won't do so..

Kind regards
Karl Heinz Marbaise

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: maven-compiler-plugin master build

Karl Heinz Marbaise-3
Hi Robert,

On 25/03/18 18:42, Robert Scholte wrote:
> Hi Karl Heinz,
>
> let me refresh your memory ;)

Outch ...Yes...there was somethig I can remember fogged ;-)...


Thanks...

Kind regards
Karl Heinz

>
> In some cases the IT for MCOMPILER-192 fails. It was never discovered
> before run #4 because failing ITs were silently ignored.
> I'd like to see this fixed before continuing on the compiler-plugin.
> In fact, there are a number of issues I like to see fixed for the next
> release, all related to the Java Platform Modular System.
>
> thanks,
> Robert
>
> On Sun, 25 Mar 2018 17:33:02 +0200, Karl Heinz Marbaise
> <[hidden email]> wrote:
>
>> Hi to all,
>>
>> does someone has an idea about the reason why master of maven-compiler
>> plugin is RED ?
>>
>> I wanted to update some parts related to JDK 10 and want to make a
>> release but based on the RED master I won't do so..
>>
>> Kind regards
>> Karl Heinz Marbaise
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: maven-compiler-plugin master build

Karl Heinz Marbaise-3
Hi,

so after some testing (deactivated failFast) I could got it downto the
following: (Branch: TEST_TO_FIX_MCOMPILER-192):

MCOMPILER-192:
   verify.groovy changed to identify different output's on different
   platforms. Currently working on all platforms.

   The question is: Is this correct?


MCOMPILER-197: (Windows/Linux JDK9 failing)
   I tried to use newest openjpa 2.4.2 which unfortunately
   does not work with JDK 9+

   Consequence: I would suggest not to run it with JDK9+

groovy-project-with-new-plexus-compiler: (Windows/Linux JDK 9 failing)
   I'm trying to upgrade groovy versions to see if this
   will work or ot...but I don't have success...

   Consequence? Not running with JDK9+ ? Or trying to use
   different Groovy versions?


Kind regards
Karl Heinz Marbaise

On 25/03/18 18:48, Karl Heinz Marbaise wrote:

> Hi Robert,
>
> On 25/03/18 18:42, Robert Scholte wrote:
>> Hi Karl Heinz,
>>
>> let me refresh your memory ;)
>
> Outch ...Yes...there was somethig I can remember fogged ;-)...
>
>
> Thanks...
>
> Kind regards
> Karl Heinz
>
>>
>> In some cases the IT for MCOMPILER-192 fails. It was never discovered
>> before run #4 because failing ITs were silently ignored.
>> I'd like to see this fixed before continuing on the compiler-plugin.
>> In fact, there are a number of issues I like to see fixed for the next
>> release, all related to the Java Platform Modular System.
>>
>> thanks,
>> Robert
>>
>> On Sun, 25 Mar 2018 17:33:02 +0200, Karl Heinz Marbaise
>> <[hidden email]> wrote:
>>
>>> Hi to all,
>>>
>>> does someone has an idea about the reason why master of
>>> maven-compiler plugin is RED ?
>>>
>>> I wanted to update some parts related to JDK 10 and want to make a
>>> release but based on the RED master I won't do so..
>>>
>>> Kind regards
>>> Karl Heinz Marbaise
>>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: maven-compiler-plugin master build

Robert Scholte-8
I agree that the ITs for groovy-project-with-new-plexus-compiler and  
MCOMPILER-197 only work for pre Java 9.

Looks like OpenJPA and the GroovyCompiler are not Java 9 compatible. Not  
really a maven-compiler-plugin issue, those IT's should show that the  
compiler-plugin can handle jpa annotation processing and switching to a  
different compiler.

The solution for MCOMPILER-197 has resulted in quite an ugly verification  
script, but maybe that's the best for now. I really hope we can improve  
something in the Jenkins scripts, there are probably more ITs suffering  
with similar issues.

I noticed there's a JDK 10 (latest) available, I'll add that one to the  
default JDKs to test with.

thanks,
Robert

On Sun, 25 Mar 2018 21:48:57 +0200, Karl Heinz Marbaise  
<[hidden email]> wrote:

> Hi,
>
> with the made suggestions the build is now green ah...sorry blue ..
>
> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-compiler-plugin/job/TEST_TO_FIX_MCOMPILER-192/
>
> Kind regards
> Karl Heinz Marbaise
> On 25/03/18 21:29, Karl Heinz Marbaise wrote:
>> Hi,
>>  so after some testing (deactivated failFast) I could got it downto the  
>> following: (Branch: TEST_TO_FIX_MCOMPILER-192):
>>  MCOMPILER-192:
>>    verify.groovy changed to identify different output's on different
>>    platforms. Currently working on all platforms.
>>     The question is: Is this correct?
>>   MCOMPILER-197: (Windows/Linux JDK9 failing)
>>    I tried to use newest openjpa 2.4.2 which unfortunately
>>    does not work with JDK 9+
>>     Consequence: I would suggest not to run it with JDK9+
>>  groovy-project-with-new-plexus-compiler: (Windows/Linux JDK 9 failing)
>>    I'm trying to upgrade groovy versions to see if this
>>    will work or ot...but I don't have success...
>>     Consequence? Not running with JDK9+ ? Or trying to use
>>    different Groovy versions?
>>   Kind regards
>> Karl Heinz Marbaise
>>  On 25/03/18 18:48, Karl Heinz Marbaise wrote:
>>> Hi Robert,
>>>
>>> On 25/03/18 18:42, Robert Scholte wrote:
>>>> Hi Karl Heinz,
>>>>
>>>> let me refresh your memory ;)
>>>
>>> Outch ...Yes...there was somethig I can remember fogged ;-)...
>>>
>>>
>>> Thanks...
>>>
>>> Kind regards
>>> Karl Heinz
>>>
>>>>
>>>> In some cases the IT for MCOMPILER-192 fails. It was never discovered  
>>>> before run #4 because failing ITs were silently ignored.
>>>> I'd like to see this fixed before continuing on the compiler-plugin.
>>>> In fact, there are a number of issues I like to see fixed for the  
>>>> next release, all related to the Java Platform Modular System.
>>>>
>>>> thanks,
>>>> Robert
>>>>
>>>> On Sun, 25 Mar 2018 17:33:02 +0200, Karl Heinz Marbaise  
>>>> <[hidden email]> wrote:
>>>>
>>>>> Hi to all,
>>>>>
>>>>> does someone has an idea about the reason why master of  
>>>>> maven-compiler plugin is RED ?
>>>>>
>>>>> I wanted to update some parts related to JDK 10 and want to make a  
>>>>> release but based on the RED master I won't do so..
>>>>>
>>>>> Kind regards
>>>>> Karl Heinz Marbaise
>>>>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: maven-compiler-plugin master build

Karl Heinz Marbaise-3
Hi,

On 25/03/18 23:10, Robert Scholte wrote:
> I agree that the ITs for groovy-project-with-new-plexus-compiler and
> MCOMPILER-197 only work for pre Java 9.

>
> Looks like OpenJPA and the GroovyCompiler are not Java 9 compatible. Not
> really a maven-compiler-plugin issue, those IT's should show that the
> compiler-plugin can handle jpa annotation processing and switching to a
> different compiler.
>
> The solution for MCOMPILER-197 has resulted in quite an ugly

> verification script, but maybe that's the best for now. I really hope we
> can improve something in the Jenkins scripts, there are probably more
> ITs suffering with similar issues.

You meant MCOMPILER-192..

But the word I had in mind sounds very similar to "ugly" ..;-)

>
> I noticed there's a JDK 10 (latest) available, I'll add that one to the
> default JDKs to test with.

Yes that should be done also...

Kind regards
Karl Heinz Marbaise

>
> thanks,
> Robert
>
> On Sun, 25 Mar 2018 21:48:57 +0200, Karl Heinz Marbaise
> <[hidden email]> wrote:
>
>> Hi,
>>
>> with the made suggestions the build is now green ah...sorry blue ..
>>
>> https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-compiler-plugin/job/TEST_TO_FIX_MCOMPILER-192/ 
>>
>>
>> Kind regards
>> Karl Heinz Marbaise
>> On 25/03/18 21:29, Karl Heinz Marbaise wrote:
>>> Hi,
>>>  so after some testing (deactivated failFast) I could got it downto
>>> the following: (Branch: TEST_TO_FIX_MCOMPILER-192):
>>>  MCOMPILER-192:
>>>    verify.groovy changed to identify different output's on different
>>>    platforms. Currently working on all platforms.
>>>     The question is: Is this correct?
>>>   MCOMPILER-197: (Windows/Linux JDK9 failing)
>>>    I tried to use newest openjpa 2.4.2 which unfortunately
>>>    does not work with JDK 9+
>>>     Consequence: I would suggest not to run it with JDK9+
>>>  groovy-project-with-new-plexus-compiler: (Windows/Linux JDK 9 failing)
>>>    I'm trying to upgrade groovy versions to see if this
>>>    will work or ot...but I don't have success...
>>>     Consequence? Not running with JDK9+ ? Or trying to use
>>>    different Groovy versions?
>>>   Kind regards
>>> Karl Heinz Marbaise
>>>  On 25/03/18 18:48, Karl Heinz Marbaise wrote:
>>>> Hi Robert,
>>>>
>>>> On 25/03/18 18:42, Robert Scholte wrote:
>>>>> Hi Karl Heinz,
>>>>>
>>>>> let me refresh your memory ;)
>>>>
>>>> Outch ...Yes...there was somethig I can remember fogged ;-)...
>>>>
>>>>
>>>> Thanks...
>>>>
>>>> Kind regards
>>>> Karl Heinz
>>>>
>>>>>
>>>>> In some cases the IT for MCOMPILER-192 fails. It was never
>>>>> discovered before run #4 because failing ITs were silently ignored.
>>>>> I'd like to see this fixed before continuing on the compiler-plugin.
>>>>> In fact, there are a number of issues I like to see fixed for the
>>>>> next release, all related to the Java Platform Modular System.
>>>>>
>>>>> thanks,
>>>>> Robert
>>>>>
>>>>> On Sun, 25 Mar 2018 17:33:02 +0200, Karl Heinz Marbaise
>>>>> <[hidden email]> wrote:
>>>>>
>>>>>> Hi to all,
>>>>>>
>>>>>> does someone has an idea about the reason why master of
>>>>>> maven-compiler plugin is RED ?
>>>>>>
>>>>>> I wanted to update some parts related to JDK 10 and want to make a
>>>>>> release but based on the RED master I won't do so..
>>>>>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]