[maven-artifact-transfer] branch CODE-IMPROVEMENTS updated: Make isMaven..()/canFindCoreClass() private instead of protected static.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[maven-artifact-transfer] branch CODE-IMPROVEMENTS updated: Make isMaven..()/canFindCoreClass() private instead of protected static.

khmarbaise
This is an automated email from the ASF dual-hosted git repository.

khmarbaise pushed a commit to branch CODE-IMPROVEMENTS
in repository https://gitbox.apache.org/repos/asf/maven-artifact-transfer.git


The following commit(s) were added to refs/heads/CODE-IMPROVEMENTS by this push:
     new d435da3  Make isMaven..()/canFindCoreClass() private instead of protected static.
d435da3 is described below

commit d435da34821369d727a09d2b3db2eccfeb88221d
Author: Karl Heinz Marbaise <[hidden email]>
AuthorDate: Thu Aug 9 20:38:49 2018 +0200

    Make isMaven..()/canFindCoreClass() private instead of protected static.
---
 .../artifact/install/internal/DefaultArtifactInstaller.java         | 4 ++--
 .../transfer/artifact/resolve/internal/DefaultArtifactResolver.java | 4 ++--
 .../dependencies/collect/internal/DefaultDependencyCollector.java   | 4 ++--
 .../dependencies/resolve/internal/DefaultDependencyResolver.java    | 4 ++--
 .../transfer/repository/internal/DefaultRepositoryManager.java      | 6 +++---
 5 files changed, 11 insertions(+), 11 deletions(-)

diff --git a/src/main/java/org/apache/maven/shared/transfer/artifact/install/internal/DefaultArtifactInstaller.java b/src/main/java/org/apache/maven/shared/transfer/artifact/install/internal/DefaultArtifactInstaller.java
index 61ee226..574d208 100644
--- a/src/main/java/org/apache/maven/shared/transfer/artifact/install/internal/DefaultArtifactInstaller.java
+++ b/src/main/java/org/apache/maven/shared/transfer/artifact/install/internal/DefaultArtifactInstaller.java
@@ -112,12 +112,12 @@ class DefaultArtifactInstaller
     /**
      * @return true if the current Maven version is Maven 3.1.
      */
-    protected static boolean isMaven31()
+    private boolean isMaven31()
     {
         return canFindCoreClass( "org.eclipse.aether.artifact.Artifact" ); // Maven 3.1 specific
     }
 
-    private static boolean canFindCoreClass( String className )
+    private boolean canFindCoreClass( String className )
     {
         try
         {
diff --git a/src/main/java/org/apache/maven/shared/transfer/artifact/resolve/internal/DefaultArtifactResolver.java b/src/main/java/org/apache/maven/shared/transfer/artifact/resolve/internal/DefaultArtifactResolver.java
index 7e25f1f..ae709a5 100644
--- a/src/main/java/org/apache/maven/shared/transfer/artifact/resolve/internal/DefaultArtifactResolver.java
+++ b/src/main/java/org/apache/maven/shared/transfer/artifact/resolve/internal/DefaultArtifactResolver.java
@@ -107,12 +107,12 @@ class DefaultArtifactResolver
     /**
      * @return true if the current Maven version is Maven 3.1.
      */
-    protected static boolean isMaven31()
+    private boolean isMaven31()
     {
         return canFindCoreClass( "org.eclipse.aether.artifact.Artifact" ); // Maven 3.1 specific
     }
 
-    private static boolean canFindCoreClass( String className )
+    private boolean canFindCoreClass( String className )
     {
         try
         {
diff --git a/src/main/java/org/apache/maven/shared/transfer/dependencies/collect/internal/DefaultDependencyCollector.java b/src/main/java/org/apache/maven/shared/transfer/dependencies/collect/internal/DefaultDependencyCollector.java
index 6e5ecc7..863c326 100644
--- a/src/main/java/org/apache/maven/shared/transfer/dependencies/collect/internal/DefaultDependencyCollector.java
+++ b/src/main/java/org/apache/maven/shared/transfer/dependencies/collect/internal/DefaultDependencyCollector.java
@@ -142,12 +142,12 @@ class DefaultDependencyCollector implements DependencyCollector, Contextualizabl
     /**
      * @return true if the current Maven version is Maven 3.1.
      */
-    protected static boolean isMaven31()
+    private boolean isMaven31()
     {
         return canFindCoreClass( "org.eclipse.aether.artifact.Artifact" ); // Maven 3.1 specific
     }
 
-    private static boolean canFindCoreClass( String className )
+    private boolean canFindCoreClass( String className )
     {
         try
         {
diff --git a/src/main/java/org/apache/maven/shared/transfer/dependencies/resolve/internal/DefaultDependencyResolver.java b/src/main/java/org/apache/maven/shared/transfer/dependencies/resolve/internal/DefaultDependencyResolver.java
index 9a1637d..7d08436 100644
--- a/src/main/java/org/apache/maven/shared/transfer/dependencies/resolve/internal/DefaultDependencyResolver.java
+++ b/src/main/java/org/apache/maven/shared/transfer/dependencies/resolve/internal/DefaultDependencyResolver.java
@@ -112,12 +112,12 @@ class DefaultDependencyResolver
     /**
      * @return true if the current Maven version is Maven 3.1.
      */
-    protected static boolean isMaven31()
+    private boolean isMaven31()
     {
         return canFindCoreClass( "org.eclipse.aether.artifact.Artifact" ); // Maven 3.1 specific
     }
 
-    private static boolean canFindCoreClass( String className )
+    private boolean canFindCoreClass( String className )
     {
         try
         {
diff --git a/src/main/java/org/apache/maven/shared/transfer/repository/internal/DefaultRepositoryManager.java b/src/main/java/org/apache/maven/shared/transfer/repository/internal/DefaultRepositoryManager.java
index 0bc3ffa..b14ae41 100644
--- a/src/main/java/org/apache/maven/shared/transfer/repository/internal/DefaultRepositoryManager.java
+++ b/src/main/java/org/apache/maven/shared/transfer/repository/internal/DefaultRepositoryManager.java
@@ -144,7 +144,7 @@ class DefaultRepositoryManager
     /**
      * @return true if the current Maven version is Maven 3.1.
      */
-    protected static boolean isMaven31()
+    private boolean isMaven31()
     {
         return canFindCoreClass( "org.eclipse.aether.artifact.Artifact" ); // Maven 3.1 specific
     }
@@ -152,12 +152,12 @@ class DefaultRepositoryManager
     /**
      * @return true if the current Maven version is Maven 3.0.2
      */
-    protected static boolean isMaven302()
+    private boolean isMaven302()
     {
         return canFindCoreClass( "org.sonatype.aether.spi.localrepo.LocalRepositoryManagerFactory" );
     }
 
-    private static boolean canFindCoreClass( String className )
+    private boolean canFindCoreClass( String className )
     {
         try
         {