maven-archiver/mave-jar-plugin - Need Help...

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

maven-archiver/mave-jar-plugin - Need Help...

Karl Heinz Marbaise-3
Hi,

can someone take a deep look at this commit (maven-archiver):

commit b2e019439a6dcd4f6ffe897cca832d9db4091fd5
Author: Karl Heinz Marbaise <[hidden email]>
Date:   Sat Jul 28 23:06:50 2018 +0200

     @Ignore test which looks like a JDK bug.

which contains a test
(src/test/java/org/apache/maven/archiver/MavenArchiverTest.java#testRecreation)
which is constantly failing on JDK 9...

Based on my current state of research this looks like a JDK 9 bug...

+
+        // Based on some experiments with a result like this:
+        // History 1532810292406 time:1532810292000
expected:<1532810352000> but was:<1532810292000>
+        // It looks like a JDK Bug:
https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8177809
          assertEquals( "History " + history + " time:" + time ,
jarFile.lastModified(), time );


Furthermore it looks like the failing build for maven-jar-plugin looks
like the same cause?

I would like to know if I'm just blind / oversight something ?


Kind regards
Karl Heinz Marbaise

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: maven-archiver/mave-jar-plugin - Need Help...

Robert Scholte-8
Looks like the test (and main code?) needs a check for OS+JDK version.

The JDK bugreport states that it is fixed in JDK10, not in 9 (even though  
the resolution date might suggest otherwise).

To me this all seems in line.

Robert

On Sun, 29 Jul 2018 20:21:01 +0200, Karl Heinz Marbaise  
<[hidden email]> wrote:

> Hi,
>
> can someone take a deep look at this commit (maven-archiver):
>
> commit b2e019439a6dcd4f6ffe897cca832d9db4091fd5
> Author: Karl Heinz Marbaise <[hidden email]>
> Date:   Sat Jul 28 23:06:50 2018 +0200
>
>      @Ignore test which looks like a JDK bug.
>
> which contains a test  
> (src/test/java/org/apache/maven/archiver/MavenArchiverTest.java#testRecreation)  
> which is constantly failing on JDK 9...
>
> Based on my current state of research this looks like a JDK 9 bug...
>
> +
> +        // Based on some experiments with a result like this:
> +        // History 1532810292406 time:1532810292000  
> expected:<1532810352000> but was:<1532810292000>
> +        // It looks like a JDK Bug:  
> https://bugs.java.com/bugdatabase/view_bug.do?bug_id=8177809
>           assertEquals( "History " + history + " time:" + time ,  
> jarFile.lastModified(), time );
>
>
> Furthermore it looks like the failing build for maven-jar-plugin looks  
> like the same cause?
>
> I would like to know if I'm just blind / oversight something ?
>
>
> Kind regards
> Karl Heinz Marbaise
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]