maven-archiver build on Jenkins - Test Failures

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

maven-archiver build on Jenkins - Test Failures

Karl Heinz Marbaise-3
Hi,

currently I'm observing a strange thing..cause the build on Jenkins
produces test failure with JDK 9

https://builds.apache.org/job/maven-box/job/maven-archiver/job/master/5/consoleFull

The problem I'm currently having is that I can't reproduce this..

I have tested with Maven 3.5.2 and JDK 9.0.1 without any problem on my
Mac ...

Is someone out there who can check the current state of maven-archiver
git repo on Windows and can reproduce the issue ?

It would be great..Thanks in advance.

Kind regards
Karl Heinz Marbaise

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: maven-archiver build on Jenkins - Test Failures

Karl Heinz Marbaise-3
Hi Robert,

I will try and see the result..

Thanks.

Kind regards
Karl Heinz


On 26/12/17 20:27, Robert Scholte wrote:

> The job starting quite some time ago. Maybe better to kill the it and
> start over again.
> I had trouble visiting builds.apache.org this afternoon, could be related.
>
> thanks,
> Robert
>
> On Tue, 26 Dec 2017 20:01:02 +0100, Karl Heinz Marbaise
> <[hidden email]> wrote:
>
>> Hi,
>>
>> currently I'm observing a strange thing..cause the build on Jenkins
>> produces test failure with JDK 9
>>
>> https://builds.apache.org/job/maven-box/job/maven-archiver/job/master/5/consoleFull 
>>
>>
>> The problem I'm currently having is that I can't reproduce this..
>>
>> I have tested with Maven 3.5.2 and JDK 9.0.1 without any problem on my
>> Mac ...
>>
>> Is someone out there who can check the current state of maven-archiver
>> git repo on Windows and can reproduce the issue ?
>>
>> It would be great..Thanks in advance.
>>
>> Kind regards
>> Karl Heinz Marbaise

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: maven-archiver build on Jenkins - Test Failures

rfscholte
Interesting...

The pipeline steps[1] say all succeeded, however #6 overview[2] complaints  
about failing tests.

Robert

[1]  
https://builds.apache.org/job/maven-box/job/maven-archiver/job/master/6/flowGraphTable/
[2]  
https://builds.apache.org/job/maven-box/job/maven-archiver/job/master/6/

On Tue, 26 Dec 2017 20:44:35 +0100, Karl Heinz Marbaise  
<[hidden email]> wrote:

> Hi Robert,
>
> I will try and see the result..
>
> Thanks.
>
> Kind regards
> Karl Heinz
>
>
> On 26/12/17 20:27, Robert Scholte wrote:
>> The job starting quite some time ago. Maybe better to kill the it and  
>> start over again.
>> I had trouble visiting builds.apache.org this afternoon, could be  
>> related.
>>  thanks,
>> Robert
>>  On Tue, 26 Dec 2017 20:01:02 +0100, Karl Heinz Marbaise  
>> <[hidden email]> wrote:
>>
>>> Hi,
>>>
>>> currently I'm observing a strange thing..cause the build on Jenkins  
>>> produces test failure with JDK 9
>>>
>>> https://builds.apache.org/job/maven-box/job/maven-archiver/job/master/5/consoleFull 
>>> The problem I'm currently having is that I can't reproduce this..
>>>
>>> I have tested with Maven 3.5.2 and JDK 9.0.1 without any problem on my  
>>> Mac ...
>>>
>>> Is someone out there who can check the current state of maven-archiver  
>>> git repo on Windows and can reproduce the issue ?
>>>
>>> It would be great..Thanks in advance.
>>>
>>> Kind regards
>>> Karl Heinz Marbaise
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: maven-archiver build on Jenkins - Test Failures

Plamen Totev-2
In reply to this post by Karl Heinz Marbaise-3
And if this could help (I know it's obvious but may safe time) it
looks the reason for the failing tests is the same. The following code
fails with assertion error:

        final Manifest manifest = getJarFileManifest( jarFile );
        String classPath = manifest.getMainAttributes().getValue(
Attributes.Name.CLASS_PATH );
        assertNotNull( classPath );

The NullPointerExceptions from the rest of the tests are coming from
the same expression (`manifest.getMainAttributes().getValue(
"Class-Path" ).getBytes()`).

On Wed, Dec 27, 2017 at 9:39 AM, Plamen Totev <[hidden email]> wrote:

> Hi,
>
> On Tue, Dec 26, 2017 at 9:01 PM, Karl Heinz Marbaise <[hidden email]> wrote:
>
>> Is someone out there who can check the current state of maven-archiver git
>> repo on Windows and can reproduce the issue ?
>
> I ran the build a couple of times(just in case) on Windows 10, Maven
> 3.5.2, JDK 9.0.1 and everything is ok. And it looks like the build is
> failing on Linux JDK 9 and Windows JDK 8 as well, so if there is a bug
> (and not a problem with the build) then it is probably not a Windows
> or JDK 9 related.
>
> Regards,
> Plamen Totev

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: plexus-archiver / plexus-util Issue

Karl Heinz Marbaise-3
Hi,

On 28/12/17 20:46, Stephen Connolly wrote:
> But shouldn’t we be copying the last modified time stamp always anyway

I'm the same opinion...but that means in consequence that the test in
plexus-archiver is not correct...cause it's waiting for a change in the
last-modified time ...

Hm...

Kind regards
Karl Heinz Marbaise


>
> On Thu 28 Dec 2017 at 14:52, Karl Heinz Marbaise <[hidden email]
> <mailto:[hidden email]>> wrote:
>
>     Hi,
>
>     after diving more into this..
>
>     I found that if I upgrade plexus-utils to 3.1.0 in plexus-archiver the
>     tests in plexus-archiver stuck completely...as I already observed (which
>     I though was another cause)...
>
>     https://travis-ci.org/codehaus-plexus/plexus-archiver/jobs/321821294
>
>     So more diving into the details I realized that the following code in
>     plexus-utils causes the issue:
>
>     FileUtils.java:
>
>           private static void doCopyFile( File source, File destination )
>               throws IOException
>           {
>               // offload to operating system if supported
>               if ( Java7Detector.isJava7() )
>               {
>                   doCopyFileUsingNewIO( source, destination );
>               }
>               else
>               {
>                   doCopyFileUsingLegacyIO( source, destination );
>               }
>           }
>
>     The real issue is located in the implementation of doCopyFileUsingNewIO
>     which uses:
>
>
>
>           public static File copy( File source, File target )
>               throws IOException
>           {
>               Path copy = Files.copy( source.toPath(), target.toPath(),
>                          StandardCopyOption.REPLACE_EXISTING,
>                          StandardCopyOption.COPY_ATTRIBUTES,
>                          LinkOption.NOFOLLOW_LINKS );
>               return copy.toFile();
>           }
>
>     and If I correctly understand the whole thing is the real cause of that
>     based on the usage of StandardCopyOption.COPY_ATTRIBUTES which includes
>     copying of the last-modified of the file...which means not to change the
>     last-modified entry of the file and in result that is the reason of not
>     changing it and the stucking of the unit test in plexus-archiver...(see
>     travis build above)..
>
>
>     After I have changed that and only use
>
>           public static File copy( File source, File target )
>               throws IOException
>           {
>               Path copy = Files.copy( source.toPath(), target.toPath(),
>                          StandardCopyOption.REPLACE_EXISTING,
>                          LinkOption.NOFOLLOW_LINKS );
>               return copy.toFile();
>           }
>
>     it looks like working (see branch issue-fix):
>
>     What Do you think?
>
>     Kind regards
>     Karl Heinz Marbaise

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]