Quantcast

[jira] Created: (MNGECLIPSE-280) Picks up pom.xml in current project or in target of another project

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] Created: (MNGECLIPSE-280) Picks up pom.xml in current project or in target of another project

JIRA jira@codehaus.org
Picks up pom.xml in current project or in target of another project
-------------------------------------------------------------------

                 Key: MNGECLIPSE-280
                 URL: http://jira.codehaus.org/browse/MNGECLIPSE-280
             Project: Maven Integration for Eclipse
          Issue Type: Bug
    Affects Versions: 0.0.10
         Environment: Eclipse 3.2

            Reporter: Ben Tatham


When a pom.xml of a dependency is found anywhere in the Eclipse Workspace, the Eclipse project containing that dependency is added to the Maven2 Dependencies Library.  Normally, this is great.  It means you can modify the project pom to point to a dependency that is also in development together with the current project.  

However, some use cases require that Maven unpack some dependencies for a variety of reasons (like war overlays).  Therefore, the pom.xml of the dependency shows up in the target folder somewhere.  This results in one of two things happening:
1) If the dependency pom is found in the target of another project, that other project is added to the Maven2 Dependencies Library.  However, that project may or may not actually have the jars/classes needed in its classpath.  And this can also lead to depending on a parent project sometimes.

2) If the dependency pom is found in the same eclipse project, nothing happens, and you cannot build.  I assume that the current project is attempted to be added to the Maven2 Dependencies Library and Eclipse itself (JDT?) blocks that because it makes no sense.  

I suggest an (optional) filter on what is searched when looking for projects in the Eclipse Workspace.  Perhaps blocking all pom.xml's under target would make sense.  Or perhaps make it a white list, such that only pom.xml in the root of a project is allowed to be searched.  


--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] Commented: (MNGECLIPSE-280) Picks up pom.xml in current project or in target of another project

JIRA jira@codehaus.org

    [ http://jira.codehaus.org/browse/MNGECLIPSE-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_88738 ]

Stefan Seidel commented on MNGECLIPSE-280:
------------------------------------------

AFAICR it used to be that only the project root pom.xml was used, to which I would object, because it can happen that you have two maven projects within the same eclipse project without a parent pom.xml.

Therefore, I second the blacklist/filter solution (perhaps even with excluding target/** as default).

> Picks up pom.xml in current project or in target of another project
> -------------------------------------------------------------------
>
>                 Key: MNGECLIPSE-280
>                 URL: http://jira.codehaus.org/browse/MNGECLIPSE-280
>             Project: Maven Integration for Eclipse
>          Issue Type: Bug
>    Affects Versions: 0.0.10
>         Environment: Eclipse 3.2
>            Reporter: Ben Tatham
>
> When a pom.xml of a dependency is found anywhere in the Eclipse Workspace, the Eclipse project containing that dependency is added to the Maven2 Dependencies Library.  Normally, this is great.  It means you can modify the project pom to point to a dependency that is also in development together with the current project.  
> However, some use cases require that Maven unpack some dependencies for a variety of reasons (like war overlays).  Therefore, the pom.xml of the dependency shows up in the target folder somewhere.  This results in one of two things happening:
> 1) If the dependency pom is found in the target of another project, that other project is added to the Maven2 Dependencies Library.  However, that project may or may not actually have the jars/classes needed in its classpath.  And this can also lead to depending on a parent project sometimes.
> 2) If the dependency pom is found in the same eclipse project, nothing happens, and you cannot build.  I assume that the current project is attempted to be added to the Maven2 Dependencies Library and Eclipse itself (JDT?) blocks that because it makes no sense.  
> I suggest an (optional) filter on what is searched when looking for projects in the Eclipse Workspace.  Perhaps blocking all pom.xml's under target would make sense.  Or perhaps make it a white list, such that only pom.xml in the root of a project is allowed to be searched.  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] Commented: (MNGECLIPSE-280) Picks up pom.xml in current project or in target of another project

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org

    [ http://jira.codehaus.org/browse/MNGECLIPSE-280?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_98172 ]

Eugene Kuleshov commented on MNGECLIPSE-280:
--------------------------------------------

Can someone please cook a test project that would have those poms in target folder?

On a side note, project scanner should actually use maven model and only look for poms at the known locations (i.e. root and then recursively in each module deirectory).

> Picks up pom.xml in current project or in target of another project
> -------------------------------------------------------------------
>
>                 Key: MNGECLIPSE-280
>                 URL: http://jira.codehaus.org/browse/MNGECLIPSE-280
>             Project: Maven Integration for Eclipse
>          Issue Type: Bug
>    Affects Versions: 0.0.10
>         Environment: Eclipse 3.2
>            Reporter: Ben Tatham
>
> When a pom.xml of a dependency is found anywhere in the Eclipse Workspace, the Eclipse project containing that dependency is added to the Maven2 Dependencies Library.  Normally, this is great.  It means you can modify the project pom to point to a dependency that is also in development together with the current project.  
> However, some use cases require that Maven unpack some dependencies for a variety of reasons (like war overlays).  Therefore, the pom.xml of the dependency shows up in the target folder somewhere.  This results in one of two things happening:
> 1) If the dependency pom is found in the target of another project, that other project is added to the Maven2 Dependencies Library.  However, that project may or may not actually have the jars/classes needed in its classpath.  And this can also lead to depending on a parent project sometimes.
> 2) If the dependency pom is found in the same eclipse project, nothing happens, and you cannot build.  I assume that the current project is attempted to be added to the Maven2 Dependencies Library and Eclipse itself (JDT?) blocks that because it makes no sense.  
> I suggest an (optional) filter on what is searched when looking for projects in the Eclipse Workspace.  Perhaps blocking all pom.xml's under target would make sense.  Or perhaps make it a white list, such that only pom.xml in the root of a project is allowed to be searched.  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list please visit:

    http://xircles.codehaus.org/manage_email

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

[jira] Closed: (MNGECLIPSE-280) Picks up pom.xml in current project or in target of another project

JIRA jira@codehaus.org
In reply to this post by JIRA jira@codehaus.org

     [ http://jira.codehaus.org/browse/MNGECLIPSE-280?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Eugene Kuleshov closed MNGECLIPSE-280.
--------------------------------------

    Resolution: Incomplete

Please feel free to reopen this and provide test project that would allow us to reproduce this issue. Thanks.

> Picks up pom.xml in current project or in target of another project
> -------------------------------------------------------------------
>
>                 Key: MNGECLIPSE-280
>                 URL: http://jira.codehaus.org/browse/MNGECLIPSE-280
>             Project: Maven Integration for Eclipse
>          Issue Type: Bug
>    Affects Versions: 0.0.10
>         Environment: Eclipse 3.2
>            Reporter: Ben Tatham
>
> When a pom.xml of a dependency is found anywhere in the Eclipse Workspace, the Eclipse project containing that dependency is added to the Maven2 Dependencies Library.  Normally, this is great.  It means you can modify the project pom to point to a dependency that is also in development together with the current project.  
> However, some use cases require that Maven unpack some dependencies for a variety of reasons (like war overlays).  Therefore, the pom.xml of the dependency shows up in the target folder somewhere.  This results in one of two things happening:
> 1) If the dependency pom is found in the target of another project, that other project is added to the Maven2 Dependencies Library.  However, that project may or may not actually have the jars/classes needed in its classpath.  And this can also lead to depending on a parent project sometimes.
> 2) If the dependency pom is found in the same eclipse project, nothing happens, and you cannot build.  I assume that the current project is attempted to be added to the Maven2 Dependencies Library and Eclipse itself (JDT?) blocks that because it makes no sense.  
> I suggest an (optional) filter on what is searched when looking for projects in the Eclipse Workspace.  Perhaps blocking all pom.xml's under target would make sense.  Or perhaps make it a white list, such that only pom.xml in the root of a project is allowed to be searched.  

--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: http://jira.codehaus.org/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira

       

---------------------------------------------------------------------
To unsubscribe from this list, please visit:

    http://xircles.codehaus.org/manage_email


Loading...