finishing build/consumer implementation

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

finishing build/consumer implementation

rfscholte
I've done some refactoring and the code is now ready for testing and merging.[1]
I'd like to finish this soon, so I can focus on the maven-wrapper part.
Any feedback is appreciated.

Robert 

[1] https://github.com/apache/maven/pull/286

[2] https://issues.apache.org/jira/browse/MNG-6656
Reply | Threaded
Open this post in threaded view
|

Re: finishing build/consumer implementation

Enrico Olivelli
Great.
I have followed the development.

I will give a final review and finally try to test it

Thank you Robert, this patch will open up the way to major changes in Maven
without breaking compatibility

Enrico

Il Dom 1 Mar 2020, 23:06 Robert Scholte <[hidden email]> ha scritto:

> I've done some refactoring and the code is now ready for testing and
> merging.[1]
> I'd like to finish this soon, so I can focus on the maven-wrapper part.
> Any feedback is appreciated.
>
> Robert
>
> [1] https://github.com/apache/maven/pull/286
>
> [2] https://issues.apache.org/jira/browse/MNG-6656
Reply | Threaded
Open this post in threaded view
|

Re: finishing build/consumer implementation

michaelo
In reply to this post by rfscholte
Am 2020-03-01 um 23:06 schrieb Robert Scholte:
> I've done some refactoring and the code is now ready for testing and merging.[1]
> I'd like to finish this soon, so I can focus on the maven-wrapper part.
> Any feedback is appreciated.

I have left a few comments...

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: finishing build/consumer implementation

rfscholte
I should have handled all review comments by now.
The infinitive loop of the maven-shade-plugin was unrelated and has already been fixed on master.
Give it another try and let me know if it is ready to be merged to master.

thanks,
Robert

On 2-3-2020 20:05:44, Michael Osipov <[hidden email]> wrote:
Am 2020-03-01 um 23:06 schrieb Robert Scholte:
> I've done some refactoring and the code is now ready for testing and merging.[1]
> I'd like to finish this soon, so I can focus on the maven-wrapper part.
> Any feedback is appreciated.

I have left a few comments...

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]