[VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

Robert Scholte-8
Hi,

I'd like to do a bootstrap release of the maven-wrapper-plugin, in order to configure it in the next maven-core. 

We solved 1 issue:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721&version=12348346&styleName=Text

There are no issues in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MWRAPPER%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC

Staging repo:
https://repository.apache.org/service/local/repositories/maven-1584/
https://repository.apache.org/service/local/repositories/maven-1584/content/org/apache/maven/plugins/maven-wrapper-plugin/3.0.1/maven-wrapper-plugin-3.0.1-source-release.zip

(note: there are some issues with https://repository.apache.org/ : you cannot browse through the content, but you can download the zip )

Source release checksum(s):
maven-wrapper-plugin-3.0.1-source-release.zip sha512: 04084e8806af4507996ce7d9caafc1a9ff2c9e278ba1c0f41552edb6516d75f1685177130c76c04c262376437d96be3083c2b46309c482ab07b74785c35dafcb

Staging site:
https://maven.apache.org/plugins-archives/maven-wrapper-plugin-LATEST/

Guide to testing staged releases:
As this is a special bootstrapping release, the following instructions are a proper way of testing:

- clone/download+unpack current master branch of Apache Maven core ( https://github.com/apache/maven ) (this will make all apache-maven-wrapper distributions available in your local repository)
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo install'
- download+unpack sources from maven-wrapper-plugin (see above)
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo install'
- go to the root of any Maven project
- run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo wrapper:wrapper -DwrapperVersion=3.7.0-SNAPSHOT' with optional extra arguments

NOTE: be aware of the difference between maven-wrapper and the maven-wrapper-plugin.
The maven-wrapper-plugin only downloads and unpacks the maven wrapper scripts.
The content of the maven-wrapper scripts are not part of the plugin, hence not part of this release.
Adjustments to that content belong to Maven core

https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

Hervé BOUTEMY
I fear there is a major issue: I could not make the injected scripts work because of a Windows newline:

$ ./mvnw clean
--2020-06-01 18:19:55--  https://repository.apache.org/snapshots/org/apache/maven/maven-wrapper/3.7.0-SNAPSHOT/maven-wrapper-3.7.0-20200527.125905-8.jar%0D
Resolving repository.apache.org (repository.apache.org)... 2a01:4f8:171:1513::2, 136.243.146.148
Connecting to repository.apache.org (repository.apache.org)|2a01:4f8:171:1513::2|:443... connected.
HTTP request sent, awaiting response... 401 Unauthorized

notice the %0D at the end of the downloaded url
the .mvn/maven-wrapper.properties has Windows newlines even if I'm on Linux, and it has more impact that expected

While at it, when download fails, there is an empty .mvn/maven-wrapper.jar remaining that does not trigger the download any more but
$ ./mvnw clean
Error: Could not find or load main class org.apache.maven.wrapper.MavenWrapperMain


I don't know what has to be fixed at scripts level, then not really part of the maven-wrapper-plugin release: I'll wait for the evaluation before voting

I already fixed in Git little issues I found in sources or documentation
the release is reproducible (built with JDK 8 on Windows)

One key issue that will have to be fixed is that master is not the default branch (but MWRAPPER-0_WIP), then probably not protected against rewrite: I suppose it will require infra to be updated
https://github.com/apache/maven-wrapper-plugin/

Regards,

Hervé

Le samedi 30 mai 2020, 11:17:43 CEST Robert Scholte a écrit :

> Hi,
>
> I'd like to do a bootstrap release of the maven-wrapper-plugin, in order to
> configure it in the next maven-core.
>
> We solved 1 issue:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721&ve
> rsion=12348346&styleName=Text
>
> There are no issues in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MWRAPPER%20AND%20
> resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
>
> Staging repo:
> https://repository.apache.org/service/local/repositories/maven-1584/
> https://repository.apache.org/service/local/repositories/maven-1584/content/
> org/apache/maven/plugins/maven-wrapper-plugin/3.0.1/maven-wrapper-plugin-3.0
> .1-source-release.zip
>
> (note: there are some issues with https://repository.apache.org/ : you
> cannot browse through the content, but you can download the zip )
>
> Source release checksum(s):
> maven-wrapper-plugin-3.0.1-source-release.zip sha512: 04084e8806af4507996ce7
> d9caafc1a9ff2c9e278ba1c0f41552edb6516d75f1685177130c76c04c262376437d96be3083
> c2b46309c482ab07b74785c35dafcb
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-wrapper-plugin-LATEST/
>
> Guide to testing staged releases:
> As this is a special bootstrapping release, the following instructions are a
> proper way of testing:
>
> - clone/download+unpack current master branch of Apache Maven core (
> https://github.com/apache/maven ) (this will make all apache-maven-wrapper
> distributions available in your local repository) - run 'mvn
> -Dmaven.repo.local=/temp/wrapper-itrepo install'
> - download+unpack sources from maven-wrapper-plugin (see above)
> - run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo install'
> - go to the root of any Maven project
> - run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo wrapper:wrapper
> -DwrapperVersion=3.7.0-SNAPSHOT' with optional extra arguments
>
> NOTE: be aware of the difference between maven-wrapper and the
> maven-wrapper-plugin. The maven-wrapper-plugin only downloads and unpacks
> the maven wrapper scripts. The content of the maven-wrapper scripts are not
> part of the plugin, hence not part of this release. Adjustments to that
> content belong to Maven core
>
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1





---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Wrapper Plugin version 3.0.1

Robert Scholte-8
if you call ./mvnw, then you are already beyond the purpose of the plugin.
The maven-wrapper-plugin is about an easy way to download and unpack the wrapper distribution. 
What you are facing is an issue in the maven wrapper distribution, hence unrelated to the release of the maven-wrapper-plugin. 

Robert


On 1-6-2020 18:25:02, Hervé BOUTEMY <[hidden email]> wrote:
I fear there is a major issue: I could not make the injected scripts work because of a Windows newline:

$ ./mvnw clean
--2020-06-01 18:19:55-- https://repository.apache.org/snapshots/org/apache/maven/maven-wrapper/3.7.0-SNAPSHOT/maven-wrapper-3.7.0-20200527.125905-8.jar%0D
Resolving repository.apache.org (repository.apache.org)... 2a01:4f8:171:1513::2, 136.243.146.148
Connecting to repository.apache.org (repository.apache.org)|2a01:4f8:171:1513::2|:443... connected.
HTTP request sent, awaiting response... 401 Unauthorized

notice the %0D at the end of the downloaded url
the .mvn/maven-wrapper.properties has Windows newlines even if I'm on Linux, and it has more impact that expected

While at it, when download fails, there is an empty .mvn/maven-wrapper.jar remaining that does not trigger the download any more but
$ ./mvnw clean
Error: Could not find or load main class org.apache.maven.wrapper.MavenWrapperMain


I don't know what has to be fixed at scripts level, then not really part of the maven-wrapper-plugin release: I'll wait for the evaluation before voting

I already fixed in Git little issues I found in sources or documentation
the release is reproducible (built with JDK 8 on Windows)

One key issue that will have to be fixed is that master is not the default branch (but MWRAPPER-0_WIP), then probably not protected against rewrite: I suppose it will require infra to be updated
https://github.com/apache/maven-wrapper-plugin/

Regards,

Hervé

Le samedi 30 mai 2020, 11:17:43 CEST Robert Scholte a écrit :

> Hi,
>
> I'd like to do a bootstrap release of the maven-wrapper-plugin, in order to
> configure it in the next maven-core.
>
> We solved 1 issue:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12323721&ve
> rsion=12348346&styleName=Text
>
> There are no issues in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MWRAPPER%20AND%20
> resolution%20%3D%20Unresolved%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
>
> Staging repo:
> https://repository.apache.org/service/local/repositories/maven-1584/
> https://repository.apache.org/service/local/repositories/maven-1584/content/
> org/apache/maven/plugins/maven-wrapper-plugin/3.0.1/maven-wrapper-plugin-3.0
> .1-source-release.zip
>
> (note: there are some issues with https://repository.apache.org/ : you
> cannot browse through the content, but you can download the zip )
>
> Source release checksum(s):
> maven-wrapper-plugin-3.0.1-source-release.zip sha512: 04084e8806af4507996ce7
> d9caafc1a9ff2c9e278ba1c0f41552edb6516d75f1685177130c76c04c262376437d96be3083
> c2b46309c482ab07b74785c35dafcb
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-wrapper-plugin-LATEST/
>
> Guide to testing staged releases:
> As this is a special bootstrapping release, the following instructions are a
> proper way of testing:
>
> - clone/download+unpack current master branch of Apache Maven core (
> https://github.com/apache/maven ) (this will make all apache-maven-wrapper
> distributions available in your local repository) - run 'mvn
> -Dmaven.repo.local=/temp/wrapper-itrepo install'
> - download+unpack sources from maven-wrapper-plugin (see above)
> - run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo install'
> - go to the root of any Maven project
> - run 'mvn -Dmaven.repo.local=/temp/wrapper-itrepo wrapper:wrapper
> -DwrapperVersion=3.7.0-SNAPSHOT' with optional extra arguments
>
> NOTE: be aware of the difference between maven-wrapper and the
> maven-wrapper-plugin. The maven-wrapper-plugin only downloads and unpacks
> the maven wrapper scripts. The content of the maven-wrapper scripts are not
> part of the plugin, hence not part of this release. Adjustments to that
> content belong to Maven core
>
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1





---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]