[VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Tibor Digana
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Enrico Olivelli
Using the '-Dgroups' parameter I get this warning.
It seems not a showstopper but the fix may be simple.
Surefire itself is corrupting stdout while writing a WARNING.
It is related to my issue
https://issues.apache.org/jira/plugins/servlet/mobile#issue/SUREFIRE-1453


Thoughts?
Enrico


# Created on 2018-03-04T08:36:54.490
Corrupted STDOUT by directly writing to native stream in forked JVM 1.
Stream '[WARNING] Couldn't load group class 'MinimumAcceptance' in
Surefire|Failsafe plugin. The group class is ignored!'.
java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma
after third character in command '[WARNING] Couldn't load group class
'MinimumAcceptance' in Surefire|Failsafe plugin. The group class is
ignored!'.
at
org.apache.maven.plugin.surefire.booterclient.output.ForkClient$OperationalData.<init>(ForkClient.java:511)
at
org.apache.maven.plugin.surefire.booterclient.output.ForkClient.processLine(ForkClient.java:209)
at
org.apache.maven.plugin.surefire.booterclient.output.ForkClient.consumeLine(ForkClient.java:176)
at
org.apache.maven.plugin.surefire.booterclient.output.ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
at java.base/java.lang.Thread.run(Thread.java:844)
Il sab 3 mar 2018, 13:34 Tibor Digana <[hidden email]> ha scritto:

> Maybe disappointed a bit on how we run the build with Java 1.8 and another
> J7 - J10 used in all Tests (unit + integration tests).
> $ mvn install -P run-its -nsu -Dintegration-test-port=8000
> -Dintegration-test-stop-port=8001 "-Djdk.home=d:\Program Files\Java\jdk10"
> -Djacoco.skip=true
> There were several reasons.
> Maven plugins failed with J9, JUnit 5 Provider in future Surefire requires
> J8, and the last is the JavaDoc check which runs within JavaC and it forced
> the contributors to write JavaDoc correctly in the beginning of
> development.
>
> T
>
> On Sat, Mar 3, 2018 at 12:48 PM, Tibor Digana <[hidden email]>
> wrote:
>
> > Typo, the version is 2.21.0 of course.
> >
> > On Sat, Mar 3, 2018 at 12:42 PM, Tibor Digana <[hidden email]>
> > wrote:
> >
> >> Hi,
> >>
> >> We solved 33 issues:
> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
> >> ctId=12317927&version=12341630
> >>
> >> There are still a couple of issues left in JIRA:
> >> https://issues.apache.org/jira/i#issues/?jql=project+%3D+
> >> SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> >>
> >> Staging repo:
> >> https://repository.apache.org/content/repositories/maven-1402/
> >> https://repository.apache.org/content/repositories/maven-140
> >> 2/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.
> >> 0-source-release.zip
> >>
> >> Source release checksum(s):
> >> surefire-2.21.0-source-release.zip sha1: 6927024eefa0b8c80dee70efa014f1
> >> f421d7844b
> >>
> >> Staging site:
> >> http://maven.apache.org/surefire-archives/surefire-LATEST/
> >>
> >> Guide to testing staged releases:
> >> http://maven.apache.org/guides/development/guide-testing-releases.html
> >>
> >> Vote open for 72 hours.
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> Cheers
> >> Tibor
> >>
> >
> >
>
--


-- Enrico Olivelli
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Stephane Nicoll
In reply to this post by Tibor Digana
+1 (also tested on JDK10)

Thanks,
S.

On Sat, Mar 3, 2018 at 12:42 PM, Tibor Digana <[hidden email]>
wrote:

> Hi,
>
> We solved 33 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12317927&version=12341630
>
> There are still a couple of issues left in JIRA:
> <a href="https://issues.apache.org/jira/i#issues/?jql=project+%">https://issues.apache.org/jira/i#issues/?jql=project+%
> 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1402/
> https://repository.apache.org/content/repositories/maven-
> 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
> release.zip
>
> Source release checksum(s):
> surefire-2.21.0-source-release.zip sha1:
> 6927024eefa0b8c80dee70efa014f1f421d7844b
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.21.0

rfscholte
In reply to this post by Tibor Digana
+1

On Sat, 03 Mar 2018 12:42:48 +0100, Tibor Digana <[hidden email]>  
wrote:

> Hi,
>
> We solved 33 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12341630
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1402/
> https://repository.apache.org/content/repositories/maven-1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-release.zip
>
> Source release checksum(s):
> surefire-2.21.0-source-release.zip sha1:
> 6927024eefa0b8c80dee70efa014f1f421d7844b
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Tibor Digana
In reply to this post by Tibor Digana
Hello Gary, yes but my typo was corrected in the second e-mail.

On Tue, Mar 6, 2018 at 5:16 PM, Gary Gregory <[hidden email]> wrote:

> This thread has the wrong VERSION in its subject.
>
> Gary
>
> On Sat, Mar 3, 2018 at 4:42 AM, Tibor Digana <[hidden email]>
> wrote:
>
> > Hi,
> >
> > We solved 33 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12317927&version=12341630
> >
> > There are still a couple of issues left in JIRA:
> > <a href="https://issues.apache.org/jira/i#issues/?jql=project+%">https://issues.apache.org/jira/i#issues/?jql=project+%
> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1402/
> > https://repository.apache.org/content/repositories/maven-
> > 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
> > release.zip
> >
> > Source release checksum(s):
> > surefire-2.21.0-source-release.zip sha1:
> > 6927024eefa0b8c80dee70efa014f1f421d7844b
> >
> > Staging site:
> > http://maven.apache.org/surefire-archives/surefire-LATEST/
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > Cheers
> > Tibor
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Enrico Olivelli
2018-03-09 9:55 GMT+01:00 Tibor Digana <[hidden email]>:

> Hi Enrico, Karl, Herve,
>
> We reported the issues [1] found during the Vote. They are fixed in
> branches [2] and CI builds [3].
> We can make a code review.
> Additionally, we fixed SUREFIRE-1490 which was in progress but we did not
> have spare time to include it in the Release 2.21.0. Now it is fixed in [4].
>



Thank you Tibor,
I did not have time to create issues yet and you already have resolved them
!!

I can confirm that I am now using 2.21.0 and I am really happy with it.

I have reviewed your commits and they looks good to me,
today I do not have time to test your fixes on my "real" projects but
surely I will do it next week, I guess we will not release 3.0.0M1
immediately

Cheers
Enrico



>
> [1]:
> https://issues.apache.org/jira/browse/SUREFIRE-1495
> https://issues.apache.org/jira/browse/SUREFIRE-1498
>
> [2]:
> https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=
> c496ebf3b4518c25787d5eac9f54b2a220a59447
> https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=
> af7ae9ef933873a038b2817d6430859f2a5bd1c7
>
> [3]:
> https://builds.apache.org/job/maven-wip/job/maven-surefire/
> job/SUREFIRE-1495/4/
> https://builds.apache.org/job/maven-wip/job/maven-surefire/
> job/SUREFIRE-1498/1/
>
> [4]:
> https://issues.apache.org/jira/browse/SUREFIRE-1490
> https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=
> 6174be76f52ffc2873a18a5215f60767843d7479
> https://builds.apache.org/job/maven-wip/job/maven-surefire/
> job/SUREFIRE-1490/2/
>
> Cheers
> Tibor
>
>
> On Tue, Mar 6, 2018 at 5:33 PM, Tibor Digana <[hidden email]>
> wrote:
>
>> Hello Gary, yes but my typo was corrected in the second e-mail.
>>
>> On Tue, Mar 6, 2018 at 5:16 PM, Gary Gregory <[hidden email]>
>> wrote:
>>
>>> This thread has the wrong VERSION in its subject.
>>>
>>> Gary
>>>
>>> On Sat, Mar 3, 2018 at 4:42 AM, Tibor Digana <[hidden email]>
>>> wrote:
>>>
>>> > Hi,
>>> >
>>> > We solved 33 issues:
>>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>>> > projectId=12317927&version=12341630
>>> >
>>> > There are still a couple of issues left in JIRA:
>>> > <a href="https://issues.apache.org/jira/i#issues/?jql=project+%">https://issues.apache.org/jira/i#issues/?jql=project+%
>>> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>>> >
>>> > Staging repo:
>>> > https://repository.apache.org/content/repositories/maven-1402/
>>> > https://repository.apache.org/content/repositories/maven-
>>> > 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
>>> > release.zip
>>> >
>>> > Source release checksum(s):
>>> > surefire-2.21.0-source-release.zip sha1:
>>> > 6927024eefa0b8c80dee70efa014f1f421d7844b
>>> >
>>> > Staging site:
>>> > http://maven.apache.org/surefire-archives/surefire-LATEST/
>>> >
>>> > Guide to testing staged releases:
>>> > http://maven.apache.org/guides/development/guide-testing-releases.html
>>> >
>>> > Vote open for 72 hours.
>>> >
>>> > [ ] +1
>>> > [ ] +0
>>> > [ ] -1
>>> >
>>> > Cheers
>>> > Tibor
>>> >
>>>
>>
>>
>