[VOTE] Release Apache Maven Compiler Plugin version 3.7.0

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

[VOTE] Release Apache Maven Compiler Plugin version 3.7.0

Robert Scholte-6
Hi,

We solved 6 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317225&version=12341266&styleName=Text

There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%2012317225%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC

Staging repo:
https://repository.apache.org/content/repositories/maven-1359/
https://repository.apache.org/service/local/repositories/maven-1359/content/org/apache/maven/plugins/maven-compiler-plugin/3.7.0/maven-compiler-plugin-3.7.0-source-release.zip

Source release checksum(s):
maven-compiler-plugin-3.7.0-source-release.zip sha1:  
1148d8a1f89e6900afb0ca1dbf74f64932402cfd

Staging site:
https://maven.apache.org/plugins-archives/maven-compiler-plugin-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Compiler Plugin version 3.7.0

Karl Heinz Marbaise-3
Hi,

I have tested the following combinations:

jdk1.7.0_79.jdk
   apache-maven-3.0.5
   apache-maven-3.1.1
   apache-maven-3.2.5
   apache-maven-3.3.1
   apache-maven-3.3.9
   apache-maven-3.5.0
jdk1.8.0_131.jdk
   apache-maven-3.0.5
   apache-maven-3.1.1
   apache-maven-3.2.5
   apache-maven-3.3.1
   apache-maven-3.3.9
   apache-maven-3.5.0
jdk1.8.0_144.jdk
   apache-maven-3.0.5
   apache-maven-3.1.1
   apache-maven-3.2.5
   apache-maven-3.3.1
   apache-maven-3.3.9
   apache-maven-3.5.0
jdk1.9.0_ea+181.jdk
   apache-maven-3.0.5 FAILED!!
   apache-maven-3.1.1 FAILED!!
   apache-maven-3.2.5 FAILED!!
   apache-maven-3.3.1 FAILED!!
   apache-maven-3.3.9 FAILED!!
   apache-maven-3.5.0 FAILED!!


But the JDK1.9.0_ea+181 have show the following result (for all Maven
versions):

        [ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile
(default-compile) on project error-prone-compiler: Fatal error
compiling: CompilerException: InvocationTargetException:
java.nio.file.NotDirectoryException:
/Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/lib/modules
-> [Help 1]
        org.apache.maven.lifecycle.LifecycleExecutionException: Failed
to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile
(default-compile) on project error-prone-compiler: Fatal error compiling
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:217)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:153)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:145)
        at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
        at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
        at
org.apache.maven.lifecycle.internal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
        at
org.apache.maven.lifecycle.internal.LifecycleStarter.execute(LifecycleStarter.java:161)
        at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:320)
        at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
        at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
        at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
        at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
        at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
        at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:564)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
        at
org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
        Caused by: org.apache.maven.plugin.MojoExecutionException: Fatal
error compiling
        at
org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1086)
        at
org.apache.maven.plugin.compiler.CompilerMojo.execute(CompilerMojo.java:168)
        at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
        at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:209)
        ... 19 more
        Caused by: org.codehaus.plexus.compiler.CompilerException
        at
org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne.performCompile(JavacCompilerWithErrorProne.java:95)
        at
org.apache.maven.plugin.compiler.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1075)
        ... 22 more
        Caused by: java.lang.reflect.InvocationTargetException
        at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
Method)
        at
java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
        at
java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.base/java.lang.reflect.Method.invoke(Method.java:564)
        at
org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne.performCompile(JavacCompilerWithErrorProne.java:91)
        ... 23 more
        Caused by: java.io.UncheckedIOException:
java.nio.file.NotDirectoryException:
/Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/lib/modules
        at
com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.lazy(Locations.java:725)
        at
com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.isDefault(Locations.java:559)
        at
com.sun.tools.javac.file.Locations.isDefaultBootClassPath(Locations.java:129)
        at
com.sun.tools.javac.file.BaseFileManager.isDefaultBootClassPath(BaseFileManager.java:149)
        at com.sun.tools.javac.main.Arguments.validate(Arguments.java:411)
        at com.sun.tools.javac.main.Main.compile(Main.java:218)
        at
com.google.errorprone.BaseErrorProneCompiler.run(BaseErrorProneCompiler.java:187)
        at
com.google.errorprone.BaseErrorProneCompiler.run(BaseErrorProneCompiler.java:98)
        at
com.google.errorprone.ErrorProneCompiler.run(ErrorProneCompiler.java:128)
        at
org.codehaus.plexus.compiler.javac.errorprone.JavacCompilerWithErrorProne$CompilerInvoker.compile(JavacCompilerWithErrorProne.java:222)
        ... 28 more
        Caused by: java.nio.file.NotDirectoryException:
/Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/lib/modules
        at
java.base/sun.nio.fs.UnixFileSystemProvider.newDirectoryStream(UnixFileSystemProvider.java:407)
        at java.base/java.nio.file.Files.newDirectoryStream(Files.java:465)
        at java.base/java.nio.file.Files.list(Files.java:3524)
        at
com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.systemClasses(Locations.java:678)
        at
com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.computePath(Locations.java:634)
        at
com.sun.tools.javac.file.Locations$BootClassPathLocationHandler.lazy(Locations.java:722)
        ... 37 more
        [ERROR]
        [ERROR]
        [ERROR] For more information about the errors and possible
solutions, please read the following articles:
        [ERROR] [Help 1]
http://cwiki.apache.org/confluence/display/MAVEN/MojoExecutionException
        Running post-build script:
/Users/kama/maven-release-checker/release-test/jdk1.9.0_ea+181.jdk/apache-maven-3.0.5/maven-compiler-plugin-3.7.0/target/it/error-prone-compiler/verify.groovy


Based on what I can see here on MacOS: The modules in JDK 9 is a file
and not directory...The question is this an MacOS only phenomenon ? Or
is this a general situation?

Kind regards
Karl Heinz Marbaise


On 01/09/17 15:50, Robert Scholte wrote:
---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Compiler Plugin version 3.7.0

Mark Derricutt
The problems with errorprone have been fixed in the recent 2.1.1 release so
you could update the tests with that maybe?

--
"Great artists are extremely selfish and arrogant things" — Steven Wilson,
Porcupine Tree

On Sat, Sep 2, 2017 at 11:30 PM, Robert Scholte <[hidden email]>
wrote:

> Hi Karl Heinz,
>
> this is a problem with the error-prone-compiler[1], a specific
> implementation of the compiler-api and also where this must be fixed.
> You might wonder if it should be tested here, but now we are at least
> aware that current error-prone-compiler is not Java9 compatible. It should
> not be a blocker for the maven-compiler-plugin itself.
>
> thank,
> Robert
>
> [1] https://github.com/codehaus-plexus/plexus-compiler/tree/mast
> er/plexus-compilers/plexus-compiler-javac-errorprone
>
>
>
> On Sat, 02 Sep 2017 13:23:50 +0200, Karl Heinz Marbaise <[hidden email]>
> wrote:
>
> Hi,
>>
>> I have tested the following combinations:
>>
>> jdk1.7.0_79.jdk
>>    apache-maven-3.0.5
>>    apache-maven-3.1.1
>>    apache-maven-3.2.5
>>    apache-maven-3.3.1
>>    apache-maven-3.3.9
>>    apache-maven-3.5.0
>> jdk1.8.0_131.jdk
>>    apache-maven-3.0.5
>>    apache-maven-3.1.1
>>    apache-maven-3.2.5
>>    apache-maven-3.3.1
>>    apache-maven-3.3.9
>>    apache-maven-3.5.0
>> jdk1.8.0_144.jdk
>>    apache-maven-3.0.5
>>    apache-maven-3.1.1
>>    apache-maven-3.2.5
>>    apache-maven-3.3.1
>>    apache-maven-3.3.9
>>    apache-maven-3.5.0
>> jdk1.9.0_ea+181.jdk
>>    apache-maven-3.0.5 FAILED!!
>>    apache-maven-3.1.1 FAILED!!
>>    apache-maven-3.2.5 FAILED!!
>>    apache-maven-3.3.1 FAILED!!
>>    apache-maven-3.3.9 FAILED!!
>>    apache-maven-3.5.0 FAILED!!
>>
>>
>> But the JDK1.9.0_ea+181 have show the following result (for all Maven
>> versions):
>>
>>         [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile
>> (default-compile) on project error-prone-compiler: Fatal error compiling:
>> CompilerException: InvocationTargetException: java.nio.file.NotDirectoryException:
>> /Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/Contents/Home/lib/modules
>> -> [Help 1]
>>         org.apache.maven.lifecycle.LifecycleExecutionException: Failed
>> to execute goal org.apache.maven.plugins:maven-compiler-plugin:3.7.0:compile
>> (default-compile) on project error-prone-compiler: Fatal error compiling
>>                 at org.apache.maven.lifecycle.int
>> ernal.MojoExecutor.execute(MojoExecutor.java:217)
>>                 at org.apache.maven.lifecycle.int
>> ernal.MojoExecutor.execute(MojoExecutor.java:153)
>>                 at org.apache.maven.lifecycle.int
>> ernal.MojoExecutor.execute(MojoExecutor.java:145)
>>                 at org.apache.maven.lifecycle.int
>> ernal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:84)
>>                 at org.apache.maven.lifecycle.int
>> ernal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:59)
>>                 at org.apache.maven.lifecycle.int
>> ernal.LifecycleStarter.singleThreadedBuild(LifecycleStarter.java:183)
>>                 at org.apache.maven.lifecycle.int
>> ernal.LifecycleStarter.execute(LifecycleStarter.java:161)
>>                 at org.apache.maven.DefaultMaven.
>> doExecute(DefaultMaven.java:320)
>>                 at org.apache.maven.DefaultMaven.
>> execute(DefaultMaven.java:156)
>>                 at org.apache.maven.cli.MavenCli.
>> execute(MavenCli.java:537)
>>                 at org.apache.maven.cli.MavenCli.
>> doMain(MavenCli.java:196)
>>                 at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
>>                 at java.base/jdk.internal.reflect
>> .NativeMethodAccessorImpl.invoke0(Native Method)
>>                 at java.base/jdk.internal.reflect
>> .NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>>                 at java.base/jdk.internal.reflect
>> .DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso
>> rImpl.java:43)
>>                 at java.base/java.lang.reflect.Me
>> thod.invoke(Method.java:564)
>>                 at org.codehaus.plexus.classworld
>> s.launcher.Launcher.launchEnhanced(Launcher.java:290)
>>                 at org.codehaus.plexus.classworld
>> s.launcher.Launcher.launch(Launcher.java:230)
>>                 at org.codehaus.plexus.classworld
>> s.launcher.Launcher.mainWithExitCode(Launcher.java:409)
>>                 at org.codehaus.plexus.classworld
>> s.launcher.Launcher.main(Launcher.java:352)
>>         Caused by: org.apache.maven.plugin.MojoExecutionException: Fatal
>> error compiling
>>                 at org.apache.maven.plugin.compil
>> er.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1086)
>>                 at org.apache.maven.plugin.compil
>> er.CompilerMojo.execute(CompilerMojo.java:168)
>>                 at org.apache.maven.plugin.Defaul
>> tBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:101)
>>                 at org.apache.maven.lifecycle.int
>> ernal.MojoExecutor.execute(MojoExecutor.java:209)
>>                 ... 19 more
>>         Caused by: org.codehaus.plexus.compiler.CompilerException
>>                 at org.codehaus.plexus.compiler.j
>> avac.errorprone.JavacCompilerWithErrorProne.performCompile(J
>> avacCompilerWithErrorProne.java:95)
>>                 at org.apache.maven.plugin.compil
>> er.AbstractCompilerMojo.execute(AbstractCompilerMojo.java:1075)
>>                 ... 22 more
>>         Caused by: java.lang.reflect.InvocationTargetException
>>                 at java.base/jdk.internal.reflect
>> .NativeMethodAccessorImpl.invoke0(Native Method)
>>                 at java.base/jdk.internal.reflect
>> .NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
>>                 at java.base/jdk.internal.reflect
>> .DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccesso
>> rImpl.java:43)
>>                 at java.base/java.lang.reflect.Me
>> thod.invoke(Method.java:564)
>>                 at org.codehaus.plexus.compiler.j
>> avac.errorprone.JavacCompilerWithErrorProne.performCompile(J
>> avacCompilerWithErrorProne.java:91)
>>                 ... 23 more
>>         Caused by: java.io.UncheckedIOException:
>> java.nio.file.NotDirectoryException: /Library/Java/JavaVirtualMachi
>> nes/jdk1.9.0_ea+181.jdk/Contents/Home/lib/modules
>>                 at com.sun.tools.javac.file.Locat
>> ions$BootClassPathLocationHandler.lazy(Locations.java:725)
>>                 at com.sun.tools.javac.file.Locat
>> ions$BootClassPathLocationHandler.isDefault(Locations.java:559)
>>                 at com.sun.tools.javac.file.Locat
>> ions.isDefaultBootClassPath(Locations.java:129)
>>                 at com.sun.tools.javac.file.BaseF
>> ileManager.isDefaultBootClassPath(BaseFileManager.java:149)
>>                 at com.sun.tools.javac.main.Argum
>> ents.validate(Arguments.java:411)
>>                 at com.sun.tools.javac.main.Main.compile(Main.java:218)
>>                 at com.google.errorprone.BaseErro
>> rProneCompiler.run(BaseErrorProneCompiler.java:187)
>>                 at com.google.errorprone.BaseErro
>> rProneCompiler.run(BaseErrorProneCompiler.java:98)
>>                 at com.google.errorprone.ErrorPro
>> neCompiler.run(ErrorProneCompiler.java:128)
>>                 at org.codehaus.plexus.compiler.j
>> avac.errorprone.JavacCompilerWithErrorProne$CompilerInvoker.
>> compile(JavacCompilerWithErrorProne.java:222)
>>                 ... 28 more
>>         Caused by: java.nio.file.NotDirectoryException:
>> /Library/Java/JavaVirtualMachines/jdk1.9.0_ea+181.jdk/
>> Contents/Home/lib/modules
>>                 at java.base/sun.nio.fs.UnixFileS
>> ystemProvider.newDirectoryStream(UnixFileSystemProvider.java:407)
>>                 at java.base/java.nio.file.Files.
>> newDirectoryStream(Files.java:465)
>>                 at java.base/java.nio.file.Files.list(Files.java:3524)
>>                 at com.sun.tools.javac.file.Locat
>> ions$BootClassPathLocationHandler.systemClasses(Locations.java:678)
>>                 at com.sun.tools.javac.file.Locat
>> ions$BootClassPathLocationHandler.computePath(Locations.java:634)
>>                 at com.sun.tools.javac.file.Locat
>> ions$BootClassPathLocationHandler.lazy(Locations.java:722)
>>                 ... 37 more
>>         [ERROR]
>>         [ERROR]
>>         [ERROR] For more information about the errors and possible
>> solutions, please read the following articles:
>>         [ERROR] [Help 1] http://cwiki.apache.org/conflu
>> ence/display/MAVEN/MojoExecutionException
>>         Running post-build script: /Users/kama/maven-release-chec
>> ker/release-test/jdk1.9.0_ea+181.jdk/apache-maven-3.0.5/mav
>> en-compiler-plugin-3.7.0/target/it/error-prone-compiler/verify.groovy
>>
>>
>> Based on what I can see here on MacOS: The modules in JDK 9 is a file and
>> not directory...The question is this an MacOS only phenomenon ? Or is this
>> a general situation?
>>
>> Kind regards
>> Karl Heinz Marbaise
>>
>>
>> On 01/09/17 15:50, Robert Scholte wrote:
>>
>>> Hi,
>>>  We solved 6 issues:
>>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>>> ctId=12317225&version=12341266&styleName=Text   There are still a
>>> couple of issues left in JIRA:
>>> <a href="https://issues.apache.org/jira/issues/?jql=project%20%3D%">https://issues.apache.org/jira/issues/?jql=project%20%3D%
>>> 2012317225%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%
>>> 20DESC%2C%20priority%20DESC   Staging repo:
>>> https://repository.apache.org/content/repositories/maven-1359/
>>> https://repository.apache.org/service/local/repositories/mav
>>> en-1359/content/org/apache/maven/plugins/maven-compiler-plug
>>> in/3.7.0/maven-compiler-plugin-3.7.0-source-release.zip   Source
>>> release checksum(s):
>>> maven-compiler-plugin-3.7.0-source-release.zip sha1:
>>> 1148d8a1f89e6900afb0ca1dbf74f64932402cfd
>>>  Staging site:
>>> https://maven.apache.org/plugins-archives/maven-compiler-plugin-LATEST/
>>>  Guide to testing staged releases:
>>> https://maven.apache.org/guides/development/guide-testing-releases.html
>>>  Vote open for at least 72 hours.
>>>  [ ] +1
>>> [ ] +0
>>> [ ] -1
>>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>