[VOTE] Release Apache Maven Checkstyle Plugin version 3.1.2

[slachiewicz]

Hi,

We solved 5 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&version=12347024&styleName=Text

There are still a couple of issues left in JIRA:
https://issues.apache.org/jira/issues/?jql=project%20%3D%20MCHECKSTYLE%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC

Staging repo:
https://repository.apache.org/content/repositories/maven-1624/
https://repository.apache.org/content/repositories/maven-1624/org/apache/maven/plugins/maven-checkstyle-plugin/3.1.2/maven-checkstyle-plugin-3.1.2-source-release.zip

Source release checksum(s):
maven-checkstyle-plugin-3.1.2-source-release.zip sha512:
4d90277a306390ec5a6434e01631295654fc4c45c1a4a0b5fae6c7c000a40e8357667fa943d05ddb55d1d742eae7628f371e4aba637941c538791bdd9ef39d08

Staging site:
https://maven.apache.org/plugins-archives/maven-checkstyle-plugin-LATEST/

Guide to testing staged releases:
https://maven.apache.org/guides/development/guide-testing-releases.html

Vote open for at least 72 hours.

[ ] +1
[ ] +0
[ ] -1

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

[Tibor Digana]

+1

Cheers
Tibor

On Sun, Jan 24, 2021 at 12:02 AM Sylwester Lachiewicz <
[hidden email]> wrote:

> Hi,
>
> We solved 5 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&version=12347024&styleName=Text
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MCHECKSTYLE%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1624/
>
> https://repository.apache.org/content/repositories/maven-1624/org/apache/maven/plugins/maven-checkstyle-plugin/3.1.2/maven-checkstyle-plugin-3.1.2-source-release.zip
>
> Source release checksum(s):
> maven-checkstyle-plugin-3.1.2-source-release.zip sha512:
>
> 4d90277a306390ec5a6434e01631295654fc4c45c1a4a0b5fae6c7c000a40e8357667fa943d05ddb55d1d742eae7628f371e4aba637941c538791bdd9ef39d08
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-checkstyle-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

[Romain Manni-Bucau]

+1 (non binding)

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le dim. 24 janv. 2021 à 00:39, Tibor Digana <[hidden email]> a
écrit :

> +1
>
> Cheers
> Tibor
>
> On Sun, Jan 24, 2021 at 12:02 AM Sylwester Lachiewicz <
> [hidden email]> wrote:
>
> > Hi,
> >
> > We solved 5 issues:
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&version=12347024&styleName=Text
> >
> > There are still a couple of issues left in JIRA:
> >
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MCHECKSTYLE%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1624/
> >
> >
> https://repository.apache.org/content/repositories/maven-1624/org/apache/maven/plugins/maven-checkstyle-plugin/3.1.2/maven-checkstyle-plugin-3.1.2-source-release.zip
> >
> > Source release checksum(s):
> > maven-checkstyle-plugin-3.1.2-source-release.zip sha512:
> >
> >
> 4d90277a306390ec5a6434e01631295654fc4c45c1a4a0b5fae6c7c000a40e8357667fa943d05ddb55d1d742eae7628f371e4aba637941c538791bdd9ef39d08
> >
> > Staging site:
> >
> https://maven.apache.org/plugins-archives/maven-checkstyle-plugin-LATEST/
> >
> > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for at least 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>

[Benjamin Marwell-2]

Depends. But good catch anyway.

Offending line:

        && file.equals( violation.file )

The only field without null check in the constructor or using
Objects.equals.

Can there be a violation without a file though? Ie outside a file?
If not, let's "fix" it in the next release.

On Sun, 24 Jan 2021, 15:43 Elliotte Rusty Harold, <[hidden email]>
wrote:

> There's at least one NullPointerException in the new Violation class's
> equals method, possibly others. I'm -1.
>
>
> package org.apache.maven.plugins.checkstyle;
>
> import org.junit.Assert;
> import org.junit.Test;
>
> public class ViolationTest
> {
>
>     @Test
>     public void testEquals() {
>         Violation v1 = new Violation("", null, "", "", "", "", "");
>         Violation v2 = new Violation("", null, "", "", "", "", "");
>         Assert.assertEquals( v1, v2 );
>     }
>
>
> }
>
> On Sun, Jan 24, 2021 at 12:33 PM Benjamin Marwell <[hidden email]>
> wrote:
> >
> > [X] +1 (non binding)
> >
> > sha512 is correct for me
> > Works in a sample project.
> >
> > Am So., 24. Jan. 2021 um 00:02 Uhr schrieb Sylwester Lachiewicz
> > <[hidden email]>:
> > >
> > > Hi,
> > >
> > > We solved 5 issues:
> > >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&version=12347024&styleName=Text
> > >
> > > There are still a couple of issues left in JIRA:
> > >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MCHECKSTYLE%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> > >
> > > Staging repo:
> > > https://repository.apache.org/content/repositories/maven-1624/
> > >
> https://repository.apache.org/content/repositories/maven-1624/org/apache/maven/plugins/maven-checkstyle-plugin/3.1.2/maven-checkstyle-plugin-3.1.2-source-release.zip
> > >
> > > Source release checksum(s):
> > > maven-checkstyle-plugin-3.1.2-source-release.zip sha512:
> > >
> 4d90277a306390ec5a6434e01631295654fc4c45c1a4a0b5fae6c7c000a40e8357667fa943d05ddb55d1d742eae7628f371e4aba637941c538791bdd9ef39d08
> > >
> > > Staging site:
> > >
> https://maven.apache.org/plugins-archives/maven-checkstyle-plugin-LATEST/
> > >
> > > Guide to testing staged releases:
> > >
> https://maven.apache.org/guides/development/guide-testing-releases.html
> > >
> > > Vote open for at least 72 hours.
> > >
> > > [ ] +1
> > > [ ] +0
> > > [ ] -1
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [hidden email]
> > > For additional commands, e-mail: [hidden email]
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
>
> --
> Elliotte Rusty Harold
> [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

[Enrico Olivelli]

+1


Enrico

Il giorno mer 27 gen 2021 alle ore 00:51 Hervé BOUTEMY <
[hidden email]> ha scritto:

> +1
>
> checked that the build is reproducible, built with JDK 11 on Windows
>
> Regards,
>
> Hervé
>
> Le dimanche 24 janvier 2021, 00:02:19 CET Sylwester Lachiewicz a écrit :
> > Hi,
> >
> > We solved 5 issues:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&ve
> > rsion=12347024&styleName=Text
> >
> > There are still a couple of issues left in JIRA:
> >
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MCHECKSTYLE%20AND
> >
> %20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated
> > %20DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1624/
> >
> https://repository.apache.org/content/repositories/maven-1624/org/apache/mav
> >
> en/plugins/maven-checkstyle-plugin/3.1.2/maven-checkstyle-plugin-3.1.2-sourc
> > e-release.zip
> >
> > Source release checksum(s):
> > maven-checkstyle-plugin-3.1.2-source-release.zip sha512:
> >
> 4d90277a306390ec5a6434e01631295654fc4c45c1a4a0b5fae6c7c000a40e8357667fa943d0
> > 5ddb55d1d742eae7628f371e4aba637941c538791bdd9ef39d08
> >
> > Staging site:
> >
> https://maven.apache.org/plugins-archives/maven-checkstyle-plugin-LATEST/
> >
> > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for at least 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

[Sylwester Lachiewicz]

+1
Sylwester

niedz., 24 sty 2021 o 13:33 Benjamin Marwell <[hidden email]> napisał(a):

>
> [X] +1 (non binding)
>
> sha512 is correct for me
> Works in a sample project.
>
> Am So., 24. Jan. 2021 um 00:02 Uhr schrieb Sylwester Lachiewicz
> <[hidden email]>:
> >
> > Hi,
> >
> > We solved 5 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317223&version=12347024&styleName=Text
> >
> > There are still a couple of issues left in JIRA:
> > https://issues.apache.org/jira/issues/?jql=project%20%3D%20MCHECKSTYLE%20AND%20resolution%20%3D%20Unresolved%20ORDER%20BY%20priority%20DESC%2C%20updated%20DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1624/
> > https://repository.apache.org/content/repositories/maven-1624/org/apache/maven/plugins/maven-checkstyle-plugin/3.1.2/maven-checkstyle-plugin-3.1.2-source-release.zip
> >
> > Source release checksum(s):
> > maven-checkstyle-plugin-3.1.2-source-release.zip sha512:
> > 4d90277a306390ec5a6434e01631295654fc4c45c1a4a0b5fae6c7c000a40e8357667fa943d05ddb55d1d742eae7628f371e4aba637941c538791bdd9ef39d08
> >
> > Staging site:
> > https://maven.apache.org/plugins-archives/maven-checkstyle-plugin-LATEST/
> >
> > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for at least 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]