Unpacking from the reactor

[Guillaume Nodet]

With the current maven 4 branch, some projects fail when they are not built
from the top of the reactor.  This happens when unpacking an artifact using
the maven-dependency-plugin.  This is definitely a regression which I
suspect is caused by the changes in the reactor.  The question is more what
to do about it ?  Do you guys agree it should still work or should the
plugins we adapted somehow to the changes ?

Cheers,
Guillaume Nodet


[INFO] --- maven-dependency-plugin:3.1.2:unpack (process-sources) @
camel-spring-xml ---
[INFO] Configured Artifact:
org.apache.camel:camel-api:sources:3.9.0-SNAPSHOT:jar
[INFO] Configured Artifact:
org.apache.camel:camel-core-model:sources:3.9.0-SNAPSHOT:jar
[INFO] Configured Artifact:
org.apache.camel:camel-core-xml:sources:3.9.0-SNAPSHOT:jar
[INFO] Configured Artifact:
org.apache.camel:camel-util:sources:3.9.0-SNAPSHOT:jar
[INFO] Unpacking /Users/gnodet/work/git/camel/core/camel-api/target/classes
to
/Users/gnodet/work/git/camel/components/camel-spring-xml/target/sources/camel-api
with includes "**/*" and excludes ""
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time:  3.010 s (Wall Clock)
[INFO] Finished at: 2021-03-16T14:40:51+01:00
[INFO]
------------------------------------------------------------------------
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack
(process-sources) on project camel-spring-xml: Artifact has not been
packaged yet. When used on reactor artifact, unpack should be executed
after packaging: see MDEP-98. -> [Help 1]
org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack
(process-sources) on project camel-spring-xml: Artifact has not been
packaged yet. When used on reactor artifact, unpack should be executed
after packaging: see MDEP-98.
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:218)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:159)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:151)
at
org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:115)
at
org.mvndaemon.mvnd.builder.SmartBuilderImpl.buildProject(SmartBuilderImpl.java:178)
at
org.mvndaemon.mvnd.builder.SmartBuilderImpl$ProjectBuildTask.run(SmartBuilderImpl.java:198)
at
java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
at
java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
at
java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
at java.base/java.lang.Thread.run(Thread.java:834)
Caused by: org.apache.maven.plugin.MojoExecutionException: Artifact has not
been packaged yet. When used on reactor artifact, unpack should be executed
after packaging: see MDEP-98.
at
org.apache.maven.plugins.dependency.AbstractDependencyMojo.unpack(AbstractDependencyMojo.java:257)
at
org.apache.maven.plugins.dependency.fromConfiguration.UnpackMojo.unpackArtifact(UnpackMojo.java:137)
at
org.apache.maven.plugins.dependency.fromConfiguration.UnpackMojo.doExecute(UnpackMojo.java:116)
at
org.apache.maven.plugins.dependency.AbstractDependencyMojo.execute(AbstractDependencyMojo.java:144)
at
org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:136)
at
org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
... 10 common frames omitted


--
------------------------
Guillaume Nodet

[Guillaume Nodet]

I'll raise a JIRA and provide an IT.  No idea yet on how to solve the
problem but I'll have a quick look. Ideas where to investigate are welcomed
!

Le mar. 16 mars 2021 à 14:50, Romain Manni-Bucau <[hidden email]> a
écrit :

> Hi Guillaume,
>
> I see no reason except a missing IT for it to not work anymore, sounds very
> basic and common as use case.
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le mar. 16 mars 2021 à 14:45, Guillaume Nodet <[hidden email]> a écrit
> :
>
> > With the current maven 4 branch, some projects fail when they are not
> built
> > from the top of the reactor.  This happens when unpacking an artifact
> using
> > the maven-dependency-plugin.  This is definitely a regression which I
> > suspect is caused by the changes in the reactor.  The question is more
> what
> > to do about it ?  Do you guys agree it should still work or should the
> > plugins we adapted somehow to the changes ?
> >
> > Cheers,
> > Guillaume Nodet
> >
> >
> > [INFO] --- maven-dependency-plugin:3.1.2:unpack (process-sources) @
> > camel-spring-xml ---
> > [INFO] Configured Artifact:
> > org.apache.camel:camel-api:sources:3.9.0-SNAPSHOT:jar
> > [INFO] Configured Artifact:
> > org.apache.camel:camel-core-model:sources:3.9.0-SNAPSHOT:jar
> > [INFO] Configured Artifact:
> > org.apache.camel:camel-core-xml:sources:3.9.0-SNAPSHOT:jar
> > [INFO] Configured Artifact:
> > org.apache.camel:camel-util:sources:3.9.0-SNAPSHOT:jar
> > [INFO] Unpacking
> /Users/gnodet/work/git/camel/core/camel-api/target/classes
> > to
> >
> >
> /Users/gnodet/work/git/camel/components/camel-spring-xml/target/sources/camel-api
> > with includes "**/*" and excludes ""
> > [INFO]
> > ------------------------------------------------------------------------
> > [INFO] BUILD FAILURE
> > [INFO]
> > ------------------------------------------------------------------------
> > [INFO] Total time:  3.010 s (Wall Clock)
> > [INFO] Finished at: 2021-03-16T14:40:51+01:00
> > [INFO]
> > ------------------------------------------------------------------------
> > [ERROR] Failed to execute goal
> > org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack
> > (process-sources) on project camel-spring-xml: Artifact has not been
> > packaged yet. When used on reactor artifact, unpack should be executed
> > after packaging: see MDEP-98. -> [Help 1]
> > org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute
> > goal org.apache.maven.plugins:maven-dependency-plugin:3.1.2:unpack
> > (process-sources) on project camel-spring-xml: Artifact has not been
> > packaged yet. When used on reactor artifact, unpack should be executed
> > after packaging: see MDEP-98.
> > at
> >
> >
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:218)
> > at
> >
> >
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:159)
> > at
> >
> >
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:151)
> > at
> >
> >
> org.apache.maven.lifecycle.internal.LifecycleModuleBuilder.buildProject(LifecycleModuleBuilder.java:115)
> > at
> >
> >
> org.mvndaemon.mvnd.builder.SmartBuilderImpl.buildProject(SmartBuilderImpl.java:178)
> > at
> >
> >
> org.mvndaemon.mvnd.builder.SmartBuilderImpl$ProjectBuildTask.run(SmartBuilderImpl.java:198)
> > at
> >
> >
> java.base/java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:515)
> > at java.base/java.util.concurrent.FutureTask.run(FutureTask.java:264)
> > at
> >
> >
> java.base/java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1128)
> > at
> >
> >
> java.base/java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:628)
> > at java.base/java.lang.Thread.run(Thread.java:834)
> > Caused by: org.apache.maven.plugin.MojoExecutionException: Artifact has
> not
> > been packaged yet. When used on reactor artifact, unpack should be
> executed
> > after packaging: see MDEP-98.
> > at
> >
> >
> org.apache.maven.plugins.dependency.AbstractDependencyMojo.unpack(AbstractDependencyMojo.java:257)
> > at
> >
> >
> org.apache.maven.plugins.dependency.fromConfiguration.UnpackMojo.unpackArtifact(UnpackMojo.java:137)
> > at
> >
> >
> org.apache.maven.plugins.dependency.fromConfiguration.UnpackMojo.doExecute(UnpackMojo.java:116)
> > at
> >
> >
> org.apache.maven.plugins.dependency.AbstractDependencyMojo.execute(AbstractDependencyMojo.java:144)
> > at
> >
> >
> org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo(DefaultBuildPluginManager.java:136)
> > at
> >
> >
> org.apache.maven.lifecycle.internal.MojoExecutor.execute(MojoExecutor.java:213)
> > ... 10 common frames omitted
> >
> >
> > --
> > ------------------------
> > Guillaume Nodet
> >
>

--
------------------------
Guillaume Nodet