Re: switch from Git WIP to GitBox

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: switch from Git WIP to GitBox

Tibor Digana
Hi Stephen,

You probably mean -Djenkins.branch.WorkspaceLocatorImpl.PATH_MAX=50
Our INFRA set it to 50.
Can it be smaller as well?
The artifacts [1] says "The default value is 80; values as low as 54 (but
no lower) are possible."
Not sure if the min 54 is still valid after version 1.11 (2016).
[1]:
https://wiki.jenkins.io/display/JENKINS/Branch+API+Plugin

Cheers
Tibor


On Sun, Mar 18, 2018 at 1:48 PM, Stephen Connolly <
[hidden email]> wrote:

> On Sun 18 Mar 2018 at 12:13, Tibor Digana <[hidden email]> wrote:
>
> > The "maven-surefire" in
> > https://builds.apache.org/job/maven-box/job/maven-surefire  is
> determined
> > by Git repo name?
> > If it was only "surefire" the Windows paths could be shorter.
> > Currently we have a problem with "Access denied.", see
> > https://issues.apache.org/jira/browse/INFRA-16191.
> > I only guess it has to do with long paths or long commandline. The Infra
> > team says that they set long paths limit to 32K characters.
> > The root cause is still unknown!
> >
> > Can you help investigating?
>
>
> There’s a property that can be set to use shorter workspace names.
>
> The workspace names are not the job name but a “magical” flattened form
> that includes a long hash
>
>
> >
> > On Sun, Mar 18, 2018 at 12:55 PM, Tibor Digana <[hidden email]>
> > wrote:
> >
> > > Hi Herve,
> > >
> > > I have assigned your jira SUREFIRE-1504 to version 3.0.0-M1.
> > > Are you fine with that?
> > >
> > > Cheers
> > > Tibor
> > >
> > >
> > > On Sun, Mar 18, 2018 at 11:20 AM, Hervé BOUTEMY <[hidden email]
> >
> > > wrote:
> > >
> > >> Hi,
> > >>
> > >> As you may have noticed, the issue was filed a long time ago
> > >> https://issues.apache.org/jira/browse/INFRA-15436
> > >> and the work just started now: Wagon is migrated.
> > >>
> > >> Gavin should do the remaining 8 repos soon: if you're working on these
> > Git
> > >> repos currently, be prepared to the switch if anything is strange :)
> > >>
> > >> Regards,
> > >>
> > >> Hervé
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: [hidden email]
> > >> For additional commands, e-mail: [hidden email]
> > >>
> > >>
> > >
> >
> --
> Sent from my phone
>
Reply | Threaded
Open this post in threaded view
|

Re: switch from Git WIP to GitBox

hboutemy
Hi Tibor,

NP: I just updated master, without really checking which version it was
you know better than me :)

Regards,

Hervé

Le dimanche 18 mars 2018, 12:55:30 CET Tibor Digana a écrit :

> Hi Herve,
>
> I have assigned your jira SUREFIRE-1504 to version 3.0.0-M1.
> Are you fine with that?
>
> Cheers
> Tibor
>
>
> On Sun, Mar 18, 2018 at 11:20 AM, Hervé BOUTEMY <[hidden email]>
>
> wrote:
> > Hi,
> >
> > As you may have noticed, the issue was filed a long time ago
> > https://issues.apache.org/jira/browse/INFRA-15436
> > and the work just started now: Wagon is migrated.
> >
> > Gavin should do the remaining 8 repos soon: if you're working on these Git
> > repos currently, be prepared to the switch if anything is strange :)
> >
> > Regards,
> >
> > Hervé
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: switch from Git WIP to GitBox

stephenconnolly
In reply to this post by Tibor Digana
On 18 March 2018 at 12:55, Tibor Digana <[hidden email]> wrote:

> Hi Stephen,
>
> You probably mean -Djenkins.branch.WorkspaceLocatorImpl.PATH_MAX=50
> Our INFRA set it to 50.
> Can it be smaller as well?
> The artifacts [1] says "The default value is 80; values as low as 54 (but
> no lower) are possible."
> Not sure if the min 54 is still valid after version 1.11 (2016).
>

Well the issue with that property IIRC is that it is global for all
workspaces. What is probably needed is a per-node property... but that
might need coding up. I think if we used
https://github.com/jenkinsci/branch-api-plugin/blob/master/src/main/java/jenkins/branch/NameMangler.java#L42
instead of
https://github.com/jenkinsci/branch-api-plugin/blob/master/src/main/java/jenkins/branch/WorkspaceLocatorImpl.java#L114-L131
we could keep the name to < 31 characters... that would leave the workspace
at (length(WORKSPACE_ROOT)+32), if ops put the workspace root at something
like C:\J\ that would leave us with 217 characters which *should* be plenty.

The alternative would be to figure out what exact APIs we are triggering in
launching maven & surefire that put us on the old windows APIs and require
the 255 char maximum (probably users would love us if we could fix that...
but perhaps to get there we need to do some hacks first)


> [1]:
> https://wiki.jenkins.io/display/JENKINS/Branch+API+Plugin
>
> Cheers
> Tibor
>
>
> On Sun, Mar 18, 2018 at 1:48 PM, Stephen Connolly <
> [hidden email]> wrote:
>
> > On Sun 18 Mar 2018 at 12:13, Tibor Digana <[hidden email]>
> wrote:
> >
> > > The "maven-surefire" in
> > > https://builds.apache.org/job/maven-box/job/maven-surefire  is
> > determined
> > > by Git repo name?
> > > If it was only "surefire" the Windows paths could be shorter.
> > > Currently we have a problem with "Access denied.", see
> > > https://issues.apache.org/jira/browse/INFRA-16191.
> > > I only guess it has to do with long paths or long commandline. The
> Infra
> > > team says that they set long paths limit to 32K characters.
> > > The root cause is still unknown!
> > >
> > > Can you help investigating?
> >
> >
> > There’s a property that can be set to use shorter workspace names.
> >
> > The workspace names are not the job name but a “magical” flattened form
> > that includes a long hash
> >
> >
> > >
> > > On Sun, Mar 18, 2018 at 12:55 PM, Tibor Digana <[hidden email]
> >
> > > wrote:
> > >
> > > > Hi Herve,
> > > >
> > > > I have assigned your jira SUREFIRE-1504 to version 3.0.0-M1.
> > > > Are you fine with that?
> > > >
> > > > Cheers
> > > > Tibor
> > > >
> > > >
> > > > On Sun, Mar 18, 2018 at 11:20 AM, Hervé BOUTEMY <
> [hidden email]
> > >
> > > > wrote:
> > > >
> > > >> Hi,
> > > >>
> > > >> As you may have noticed, the issue was filed a long time ago
> > > >> https://issues.apache.org/jira/browse/INFRA-15436
> > > >> and the work just started now: Wagon is migrated.
> > > >>
> > > >> Gavin should do the remaining 8 repos soon: if you're working on
> these
> > > Git
> > > >> repos currently, be prepared to the switch if anything is strange :)
> > > >>
> > > >> Regards,
> > > >>
> > > >> Hervé
> > > >>
> > > >> ------------------------------------------------------------
> ---------
> > > >> To unsubscribe, e-mail: [hidden email]
> > > >> For additional commands, e-mail: [hidden email]
> > > >>
> > > >>
> > > >
> > >
> > --
> > Sent from my phone
> >
>