Re: svn commit: r1799189 - /maven/plugins/trunk/maven-assembly-plugin/pom.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: svn commit: r1799189 - /maven/plugins/trunk/maven-assembly-plugin/pom.xml

Michael Osipov-2
Am 2017-06-20 um 18:58 schrieb Guillaume Boué:
> Yes, 3.0.0 is selected during conflict resolution. And this is part of
> the issue: some classes of plexus-io 2.7.1, on which plexus-archiver 3.4
> depends on, were removed in 3.0.0. So they are not present within the
> resolved dependencies because 2.7.1 was (rightfully) omitted.
>
> Did you run them on a Linux platform? I couldn't reproduce it from Windows.

Funny thing:
> Tests in error:
>   AssemblyProxyArchiverTest.addDirectory_NoPerms_CallAcceptFilesOnlyOnce:173 » NoClassDefFound                                            oClassDefFound
>
> Tests run: 273, Failures: 0, Errors: 1, Skipped: 0

on

> $ mvn -v
> Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5; 2015-11-10T17:41:47+01:00)
> Maven home: /usr/local/apache-maven-3.3.9
> Java version: 1.8.0_131, vendor: Oracle Corporation
> Java home: /usr/local/openjdk8/jre
> Default locale: de_DE, platform encoding: UTF-8
> OS name: "freebsd", version: "10.3-release-p18", arch: "amd64", family: "unix"

I am convinced that this is a classloader order issue we cannot solve
quickly and it will go away with 3.5. I do plan to release Plexus
Archiver by the end of the week.

Michael

> Le 20/06/2017 à 13:46, Michael Osipov a écrit :
>> How is this possible? I ran the UTs twice. Did you check the dep tree?
>> 3.0.0 should have been mediated.
>>
>>> Gesendet: Montag, 19. Juni 2017 um 22:13 Uhr
>>> Von: "Guillaume Boué" <[hidden email]>
>>> An: [hidden email], "Michael Osipov" <[hidden email]>
>>> Betreff: Re: svn commit: r1799189 -
>>> /maven/plugins/trunk/maven-assembly-plugin/pom.xml
>>>
>>> Hi,
>>>
>>> The unit test
>>> AssemblyProxyArchiverTest#addDirectory_NoPerms_CallAcceptFilesOnlyOnce
>>> is failing with this commit, and I can reproduce the failure on Ubuntu
>>> with OpenJDK 7. It turns out to be coming from conflicting plexus-io
>>> dependencies:
>>>
>>> - The plugin now depends on a JDK 7 version of plexus-io (3.0.0).
>>> - But the plugin also depends on plexus-archiver 3.4, which depends on a
>>> JDK 6 version plexus-io (2.7.1).
>>>
>>> Some plexus-io classes that were used reflectively in plexus-archiver
>>> (when JDK 7 is used), like Java7Reflector, are thus missing now, since
>>> they were removed in plexus-io 3.0.0. This explains the
>>> NoClassDefFoundError in the unit test. I noticed Plexus Archiver trunk
>>> has moved to JDK 7 also, so we'll need to upgrade to plexus-archiver 3.5
>>> as soon as possible.
>>>
>>> Guillaume
>>>
>>>
>>> Le 19/06/2017 à 14:18, [hidden email] a écrit :
>>>> Author: michaelo
>>>> Date: Mon Jun 19 12:18:42 2017
>>>> New Revision: 1799189
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1799189&view=rev
>>>> Log:
>>>> [MASSEMBLY-859] Upgrade to Plexus IO 3.0.0
>>>>
>>>> This closes #117
>>>>
>>>> Modified:
>>>>       maven/plugins/trunk/maven-assembly-plugin/pom.xml
>>>>
>>>> Modified: maven/plugins/trunk/maven-assembly-plugin/pom.xml
>>>> URL:
>>>> http://svn.apache.org/viewvc/maven/plugins/trunk/maven-assembly-plugin/pom.xml?rev=1799189&r1=1799188&r2=1799189&view=diff
>>>>
>>>> ==============================================================================
>>>>
>>>> --- maven/plugins/trunk/maven-assembly-plugin/pom.xml (original)
>>>> +++ maven/plugins/trunk/maven-assembly-plugin/pom.xml Mon Jun 19
>>>> 12:18:42 2017
>>>> @@ -157,7 +157,7 @@ under the License.
>>>>        <dependency>
>>>>          <groupId>org.codehaus.plexus</groupId>
>>>>          <artifactId>plexus-io</artifactId>
>>>> -      <version>2.7.1</version>
>>>> +      <version>3.0.0</version>
>>>>        </dependency>
>>>>        <dependency>
>>>>          <groupId>org.apache.maven</groupId>
>>>>
>>>>
>>>
>>> ---
>>> L'absence de virus dans ce courrier électronique a été vérifiée par
>>> le logiciel antivirus Avast.
>>> https://www.avast.com/antivirus
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...