Re: [maven-jenkins-lib] branch master updated: Add Java 11 to defaults

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [maven-jenkins-lib] branch master updated: Add Java 11 to defaults

Olivier Lamy
hehe we may see a lot of red :)

On Wed, 3 Oct 2018 at 15:46, <[hidden email]> wrote:

> This is an automated email from the ASF dual-hosted git repository.
>
> rfscholte pushed a commit to branch master
> in repository https://gitbox.apache.org/repos/asf/maven-jenkins-lib.git
>
>
> The following commit(s) were added to refs/heads/master by this push:
>      new 097a623  Add Java 11 to defaults
> 097a623 is described below
>
> commit 097a623bb5c3f24e94f24a86f83e8b272a1aae61
> Author: rfscholte <[hidden email]>
> AuthorDate: Wed Oct 3 07:46:15 2018 +0200
>
>     Add Java 11 to defaults
> ---
>  vars/asfMavenTlpPlgnBuild.groovy | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/vars/asfMavenTlpPlgnBuild.groovy
> b/vars/asfMavenTlpPlgnBuild.groovy
> index dc07d6e..cf0bde1 100644
> --- a/vars/asfMavenTlpPlgnBuild.groovy
> +++ b/vars/asfMavenTlpPlgnBuild.groovy
> @@ -33,7 +33,7 @@ def call(Map params = [:]) {
>
>      // now determine the matrix of parallel builds
>      def oses = params.containsKey('os') ? params.os : ['linux', 'windows']
> -    def jdks = params.containsKey('jdks') ? params.jdks :
> params.containsKey('jdk') ? params.jdk : ['7','8','9','10']
> +    def jdks = params.containsKey('jdks') ? params.jdks :
> params.containsKey('jdk') ? params.jdk : ['7','8','9','10','11']
>      def jdkMin = jdks[0];
>      def mavens = params.containsKey('maven') ? params.maven :
> ['3.2.x','3.3.x','3.5.x']
>      // def failFast = params.containsKey('failFast') ? params.failFast :
> true
>
>

--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Reply | Threaded
Open this post in threaded view
|

Re: [maven-jenkins-lib] branch master updated: Add Java 11 to defaults

Olivier Lamy
+1

On Wed, 3 Oct 2018 at 20:06, Michael Osipov <[hidden email]> wrote:

> I'd boldly drop 9 and 10, they're dead.
>
> Am 2018-10-03 um 10:56 schrieb Olivier Lamy:
> > hehe we may see a lot of red :)
> >
> > On Wed, 3 Oct 2018 at 15:46, <[hidden email]> wrote:
> >
> >> This is an automated email from the ASF dual-hosted git repository.
> >>
> >> rfscholte pushed a commit to branch master
> >> in repository https://gitbox.apache.org/repos/asf/maven-jenkins-lib.git
> >>
> >>
> >> The following commit(s) were added to refs/heads/master by this push:
> >>       new 097a623  Add Java 11 to defaults
> >> 097a623 is described below
> >>
> >> commit 097a623bb5c3f24e94f24a86f83e8b272a1aae61
> >> Author: rfscholte <[hidden email]>
> >> AuthorDate: Wed Oct 3 07:46:15 2018 +0200
> >>
> >>      Add Java 11 to defaults
> >> ---
> >>   vars/asfMavenTlpPlgnBuild.groovy | 2 +-
> >>   1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/vars/asfMavenTlpPlgnBuild.groovy
> >> b/vars/asfMavenTlpPlgnBuild.groovy
> >> index dc07d6e..cf0bde1 100644
> >> --- a/vars/asfMavenTlpPlgnBuild.groovy
> >> +++ b/vars/asfMavenTlpPlgnBuild.groovy
> >> @@ -33,7 +33,7 @@ def call(Map params = [:]) {
> >>
> >>       // now determine the matrix of parallel builds
> >>       def oses = params.containsKey('os') ? params.os : ['linux',
> 'windows']
> >> -    def jdks = params.containsKey('jdks') ? params.jdks :
> >> params.containsKey('jdk') ? params.jdk : ['7','8','9','10']
> >> +    def jdks = params.containsKey('jdks') ? params.jdks :
> >> params.containsKey('jdk') ? params.jdk : ['7','8','9','10','11']
> >>       def jdkMin = jdks[0];
> >>       def mavens = params.containsKey('maven') ? params.maven :
> >> ['3.2.x','3.3.x','3.5.x']
> >>       // def failFast = params.containsKey('failFast') ?
> params.failFast :
> >> true
> >>
> >>
> >
>
>

--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Reply | Threaded
Open this post in threaded view
|

Re: [maven-jenkins-lib] branch master updated: Add Java 11 to defaults

Robert Scholte-8
0: the versions are available and it makes our message to the community a  
lot easier: it all works with Java 7 and above. And what do we really  
gain? The more different versions we test with, the more we can confirm  
the stability.
I don't expect tests to fail only for 9 or 10. On the other hand, if  
something fails starting from Java X it might be easier to identify the  
issue.

Robert


On Wed, 03 Oct 2018 12:27:24 +0200, Sylwester Lachiewicz  
<[hidden email]> wrote:

> +1
>
> On Wed, Oct 3, 2018, 12:11 PM Olivier Lamy <[hidden email]> wrote:
>
>> +1
>>
>> On Wed, 3 Oct 2018 at 20:06, Michael Osipov <[hidden email]> wrote:
>>
>> > I'd boldly drop 9 and 10, they're dead.
>> >
>> > Am 2018-10-03 um 10:56 schrieb Olivier Lamy:
>> > > hehe we may see a lot of red :)
>> > >
>> > > On Wed, 3 Oct 2018 at 15:46, <[hidden email]> wrote:
>> > >
>> > >> This is an automated email from the ASF dual-hosted git repository.
>> > >>
>> > >> rfscholte pushed a commit to branch master
>> > >> in repository
>> https://gitbox.apache.org/repos/asf/maven-jenkins-lib.git
>> > >>
>> > >>
>> > >> The following commit(s) were added to refs/heads/master by this  
>> push:
>> > >>       new 097a623  Add Java 11 to defaults
>> > >> 097a623 is described below
>> > >>
>> > >> commit 097a623bb5c3f24e94f24a86f83e8b272a1aae61
>> > >> Author: rfscholte <[hidden email]>
>> > >> AuthorDate: Wed Oct 3 07:46:15 2018 +0200
>> > >>
>> > >>      Add Java 11 to defaults
>> > >> ---
>> > >>   vars/asfMavenTlpPlgnBuild.groovy | 2 +-
>> > >>   1 file changed, 1 insertion(+), 1 deletion(-)
>> > >>
>> > >> diff --git a/vars/asfMavenTlpPlgnBuild.groovy
>> > >> b/vars/asfMavenTlpPlgnBuild.groovy
>> > >> index dc07d6e..cf0bde1 100644
>> > >> --- a/vars/asfMavenTlpPlgnBuild.groovy
>> > >> +++ b/vars/asfMavenTlpPlgnBuild.groovy
>> > >> @@ -33,7 +33,7 @@ def call(Map params = [:]) {
>> > >>
>> > >>       // now determine the matrix of parallel builds
>> > >>       def oses = params.containsKey('os') ? params.os : ['linux',
>> > 'windows']
>> > >> -    def jdks = params.containsKey('jdks') ? params.jdks :
>> > >> params.containsKey('jdk') ? params.jdk : ['7','8','9','10']
>> > >> +    def jdks = params.containsKey('jdks') ? params.jdks :
>> > >> params.containsKey('jdk') ? params.jdk : ['7','8','9','10','11']
>> > >>       def jdkMin = jdks[0];
>> > >>       def mavens = params.containsKey('maven') ? params.maven :
>> > >> ['3.2.x','3.3.x','3.5.x']
>> > >>       // def failFast = params.containsKey('failFast') ?
>> > params.failFast :
>> > >> true
>> > >>
>> > >>
>> > >
>> >
>> >
>>
>> --
>> Olivier Lamy
>> http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]