Re: [maven-integration-testing] branch master updated: Sort ITs in reverse numerical order

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [maven-integration-testing] branch master updated: Sort ITs in reverse numerical order

Martin Kanters
Hi Michael,

Sounds like a good idea. I am about to go on holiday though, so will not be
able to host a vote.
It would be cool if somebody else could pick this up, otherwise I can do it
when I get back.

Martin

Op zo 9 aug. 2020 om 12:45 schreef Michael Osipov <[hidden email]>:

> Martin,
>
> please raise a vote/discussion or similar on dev@. I'd be happy accept
> either when if agree to something. It feels odd that tests are not
> sorted apparently.
>
> Michael
>
> Am 2020-08-09 um 12:42 schrieb Martin Kanters:
> > Hi Michael,
> >
> > I think Robert Scholte's vision on the ordering of this list is to order
> > them on the date of implementation [1].
> > The rationale being that the latest implemented tests are potentially the
> > least stable.
> >
> > I personally do not have a strong preference, but we should come to a
> > consensus.
> >
> > Regards,
> > Martin
> >
> > [1]
> >
> https://github.com/apache/maven-integration-testing/commit/077b9d3c9d9efcd9192082516d358b943ea3edcf#diff-02304634c9e39f8f1ec68f6cb88d51edR89
> >
> > Op wo 5 aug. 2020 om 20:57 schreef <[hidden email]>:
> >
> >> This is an automated email from the ASF dual-hosted git repository.
> >>
> >> michaelo pushed a commit to branch master
> >> in repository
> >> https://gitbox.apache.org/repos/asf/maven-integration-testing.git
> >>
> >>
> >> The following commit(s) were added to refs/heads/master by this push:
> >>       new 59bcf77  Sort ITs in reverse numerical order
> >> 59bcf77 is described below
> >>
> >> commit 59bcf77d4f43115e3779933e4eeef2676af60300
> >> Author: Michael Osipov <[hidden email]>
> >> AuthorDate: Wed Aug 5 20:57:33 2020 +0200
> >>
> >>      Sort ITs in reverse numerical order
> >> ---
> >>   .../java/org/apache/maven/it/IntegrationTestSuite.java     | 14
> >> +++++++-------
> >>   1 file changed, 7 insertions(+), 7 deletions(-)
> >>
> >> diff --git
> >>
> a/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
> >>
> b/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
> >> index 1198133..ee41a83 100644
> >> ---
> >>
> a/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
> >> +++
> >>
> b/core-it-suite/src/test/java/org/apache/maven/it/IntegrationTestSuite.java
> >> @@ -108,15 +108,10 @@ public class IntegrationTestSuite
> >>           // suite.addTestSuite( MavenIT0108SnapshotUpdateTest.class );
> --
> >> MNG-3137
> >>
> >>           suite.addTestSuite(
> >> MavenITmng6972AllowAccessToGraphPackageTest.class );
> >> -        suite.addTestSuite( MavenITmng5760ResumeFeatureTest.class );
> >> -        suite.addTestSuite( MavenITmng6656BuildConsumer.class );
> >> -        suite.addTestSuite( MavenITmng6562WarnDefaultBindings.class );
> >> -        suite.addTestSuite(
> >> MavenITmng5868NoDuplicateAttachedArtifacts.class );
> >> -        suite.addTestSuite( MavenITmng5937MavenWrapper.class );
> >> -        suite.addTestSuite( MavenITmng4660ResumeFromTest.class );
> >> -        suite.addTestSuite(
> MavenITmng4660OutdatedPackagedArtifact.class
> >> );
> >>           suite.addTestSuite(
> >> MavenITmng6759TransitiveDependencyRepositoriesTest.class );
> >>           suite.addTestSuite( MavenITmng6720FailFastTest.class );
> >> +        suite.addTestSuite( MavenITmng6656BuildConsumer.class );
> >> +        suite.addTestSuite( MavenITmng6562WarnDefaultBindings.class );
> >>           suite.addTestSuite(
> >> MavenITmng6558ToolchainsBuildingEventTest.class );
> >>           suite.addTestSuite( MavenITmng6506PackageAnnotationTest.class
> );
> >>           suite.addTestSuite( MavenITmng6391PrintVersionTest.class );
> >> @@ -139,10 +134,12 @@ public class IntegrationTestSuite
> >>           suite.addTestSuite( MavenITmng6057CheckReactorOrderTest.class
> );
> >>           suite.addTestSuite(
> >> MavenITmng5965ParallelBuildMultipliesWorkTest.class );
> >>           suite.addTestSuite(
> >> MavenITmng5958LifecyclePhaseBinaryCompat.class );
> >> +        suite.addTestSuite( MavenITmng5937MavenWrapper.class );
> >>           suite.addTestSuite(
> >> MavenITmng5935OptionalLostInTranstiveManagedDependenciesTest.class );
> >>           suite.addTestSuite(
> >> MavenITmng5898BuildMultimoduleWithEARFailsToResolveWARTest.class );
> >>           suite.addTestSuite(
> >> MavenITmng5895CIFriendlyUsageWithPropertyTest.class );
> >>           suite.addTestSuite( MavenITmng5889FindBasedir.class );
> >> +        suite.addTestSuite(
> >> MavenITmng5868NoDuplicateAttachedArtifacts.class );
> >>           suite.addTestSuite(
> >> MavenITmng5840RelativePathReactorMatching.class );
> >>           suite.addTestSuite( MavenITmng5840ParentVersionRanges.class );
> >>           suite.addTestSuite(
> MavenITmng5805PkgTypeMojoConfiguration2.class
> >> );
> >> @@ -151,6 +148,7 @@ public class IntegrationTestSuite
> >>           suite.addTestSuite(
> >> MavenITmng5774ConfigurationProcessorsTest.class );
> >>           suite.addTestSuite( MavenITmng5771CoreExtensionsTest.class );
> >>           suite.addTestSuite( MavenITmng5768CliExecutionIdTest.class );
> >> +        suite.addTestSuite( MavenITmng5760ResumeFeatureTest.class );
> >>           suite.addTestSuite(
> >> MavenITmng5753CustomMojoExecutionConfiguratorTest.class );
> >>           suite.addTestSuite(
> >> MavenITmng5742BuildExtensionClassloaderTest.class );
> >>           suite.addTestSuite( MavenITmng5716ToolchainsTypeTest.class );
> >> @@ -242,6 +240,8 @@ public class IntegrationTestSuite
> >>           suite.addTestSuite(
> >> MavenITmng4679SnapshotUpdateInPluginTest.class );
> >>           suite.addTestSuite(
> >> MavenITmng4677DisabledPluginConfigInheritanceTest.class );
> >>           suite.addTestSuite( MavenITmng4666CoreRealmImportTest.class );
> >> +        suite.addTestSuite( MavenITmng4660ResumeFromTest.class );
> >> +        suite.addTestSuite(
> MavenITmng4660OutdatedPackagedArtifact.class
> >> );
> >>           suite.addTestSuite(
> >> MavenITmng4654ArtifactHandlerForMainArtifactTest.class );
> >>           suite.addTestSuite(
> >> MavenITmng4644StrictPomParsingRejectsMisplacedTextTest.class );
> >>           // suite.addTestSuite(
> >> MavenITmng4633DualCompilerExecutionsWeaveModeTest.class );
> >>
> >>
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>