Re: [massembly] code question

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [massembly] code question

Anders Hammar
I agree. It's strange and the debug log output is actually
technically wrong. So I'd say remove it.

/Anders

On Thu, Dec 19, 2019 at 2:39 PM Mark Struberg <[hidden email]>
wrote:

> Hi!
>
> Feeling a bit rusty, so I thought I better ask for a 2nd opinion.
>
> To me it looks like the following code block is really obsolete and did
> not make anything useful ever since
>
>
> https://github.com/apache/maven-assembly-plugin/blob/master/src/main/java/org/apache/maven/plugins/assembly/archive/task/AddDependencySetsTask.java#L112
>
> > final List<Dependency> deps = project.getDependencies();
> > if ( ( deps == null ) || deps.isEmpty() )
> > {
> >     logger.debug( "Project " + project.getId() + " has no dependencies.
> Skipping dependency set addition." );
> > }
>
> 'deps' is never used. And it's just a logging.
> Plus all ITs plus a big custom project still fully pass if I remove the
> block.
>
> Any reason not to remove it?
>
> LieGrue,
> strub
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>