Quantcast

Re: [apache/maven-surefire] [SUREFIRE-1364] Report XML should contain system properties of forked JVM (9947103)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [apache/maven-surefire] [SUREFIRE-1364] Report XML should contain system properties of forked JVM (9947103)

Tibor Digana
I have one fix for parallel execution of JUnit parameterized tests which is
one year old bug, SUREFIRE-1264, see [1].
It's small commit. Can we check this as well?

In order to cut version 2.20.1 we need to proceed with next 6 issues.
I know this is annoying but after this phase the forked JVM will be stable
and blockers will be gone and then we can cut 3.0.0-alpha01 and add JUnit5
provider.

[1]
https://github.com/apache/maven-surefire/commit/92b39d6a04e0c60f4892ad7200d555fab99cc4dc

Thx
T

On Thu, May 4, 2017 at 5:12 PM, Tibor Digana <[hidden email]> wrote:

> Done. The *ObjectUtils.java* fixed.
>
> On Thu, May 4, 2017 at 11:56 AM, Michael Osipov <[hidden email]>
> wrote:
>
>> Looks ok to me. Only one issue found.
>>
>> —
>> You are receiving this because you authored the thread.
>> Reply to this email directly, view it on GitHub
>> <https://github.com/apache/maven-surefire/commit/99471032efed8f7ba7e3867974c97863d0c1878d#commitcomment-22013877>,
>> or mute the thread
>> <https://github.com/notifications/unsubscribe-auth/AA_yR7_uvwqbtkxBA0jM5G24yhgQ1NOdks5r2aC0gaJpZM4NQc7T>
>> .
>>
>
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: [apache/maven-surefire] [SUREFIRE-1364] Report XML should contain system properties of forked JVM (9947103)

Tibor Digana
Here is next fix in branch SUREFIRE-1367. Small code.
The point is that you print a log in your test and use JUnit assumption.
The log is reported by surefire-junit4 provider, but it is not by
surefire-junit47 when running tests in parallel. The behavior of reporter
is same now.
https://git-wip-us.apache.org/repos/asf?p=maven-surefire.git;a=shortlog;h=refs/heads/SUREFIRE-1367


On Thu, May 4, 2017 at 9:03 PM, Tibor Digana <[hidden email]> wrote:

> I have one fix for parallel execution of JUnit parameterized tests which
> is one year old bug, SUREFIRE-1264, see [1].
> It's small commit. Can we check this as well?
>
> In order to cut version 2.20.1 we need to proceed with next 6 issues.
> I know this is annoying but after this phase the forked JVM will be stable
> and blockers will be gone and then we can cut 3.0.0-alpha01 and add JUnit5
> provider.
>
> [1] https://github.com/apache/maven-surefire/commit/
> 92b39d6a04e0c60f4892ad7200d555fab99cc4dc
>
> Thx
> T
>
> On Thu, May 4, 2017 at 5:12 PM, Tibor Digana <[hidden email]>
> wrote:
>
>> Done. The *ObjectUtils.java* fixed.
>>
>> On Thu, May 4, 2017 at 11:56 AM, Michael Osipov <[hidden email]
>> > wrote:
>>
>>> Looks ok to me. Only one issue found.
>>>
>>> —
>>> You are receiving this because you authored the thread.
>>> Reply to this email directly, view it on GitHub
>>> <https://github.com/apache/maven-surefire/commit/99471032efed8f7ba7e3867974c97863d0c1878d#commitcomment-22013877>,
>>> or mute the thread
>>> <https://github.com/notifications/unsubscribe-auth/AA_yR7_uvwqbtkxBA0jM5G24yhgQ1NOdks5r2aC0gaJpZM4NQc7T>
>>> .
>>>
>>
>>
>
Loading...