Re: (anonymous) github user commits

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: (anonymous) github user commits

Benjamin Marwell
Checkstyle builds will fail of there is more than one commit in a PR.
Not saying I like it, but it's an option.




On Sat, 21 Mar 2020, 16:17 Elliotte Rusty Harold, <[hidden email]>
wrote:

> So it appears that if I do all squashing and merging locally and then
> push directly to master, I get listed as committer and author:
>
>
> https://gitbox.apache.org/repos/asf?p=maven-shared-utils.git&a=commit&h=4264899a152a6205b0f34a32e9c947edcd9cb1e8
>
> Github is no longer listed as the committer. This is what we want.
>
> However this is quite cumbersome, and I'm confident I'm going to mix
> this up, probably sooner rather than later. E.g. I might forget or
> squash or worse yet push commits into master I didn't want to push.
>
> Does anyone have an alternate workflow that lets us use the Github
> buttons? If not, is keeping Github out of the committer messages
> critical? It seems Author is still accurate.
>
>
>
>
> On Thu, Mar 12, 2020 at 2:46 PM Robert Scholte <[hidden email]>
> wrote:
> >
> > This week I was very surprised to see commits from the user call
> "github" in Jenkins:
> >
> https://builds.apache.org/job/maven-box/job/maven-shared-utils/job/master/changes
> >
> >
> > IMO we shouldn't want these kind of commits.
> > Based on the most recent activities I had a chat with Sylwester en
> Elliotte.
> >
> > The reason is the author of these commits was Elliotte, but the
> committer Github
> >
> https://gitbox.apache.org/repos/asf?p=maven-shared-utils.git&a=commit&h=8ed3e6827885a161a8802100f0f50968555356b0
> >
> >
> > Elliotte tried to figure it out, and his conclusion was that in case he
> squashed and merged commits via github, the committer became github.
> >
> > If this is indeed the case, we should always ask the author to squash
> his commits so we can track the commit better, and it makes it easier to
> find possible regressions (and revert them when necessary)
> >
> > Not sure if this would help, but my WOW is creating a patch from github,
> and applying it to the gitBOX url. Squashing and merging it from here would
> at least make me the committer.
> >
> > It there are other opinions, ideas, please share.
> >
> > Robert
>
>
>
> --
> Elliotte Rusty Harold
> [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>