Re: [VOTE] Release Maven Project Info Reports Plugin version 3.0.1

classic Classic list List threaded Threaded
5 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Maven Project Info Reports Plugin version 3.0.1

Gabriel Belingueres-2
Hi Tibor:

Please note I don't know if it's a plugin issue. Further tests shows that
it works OK when configuring the plugin in the reporting section:

  <reporting>
    <plugins>
        <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-project-info-reports-plugin</artifactId>
          <version>3.0.1</version>
          <configuration>
            <pluginManagementExcludes>

<pluginManagementExclude>org.eclipse.m2e</pluginManagementExclude>
            </pluginManagementExcludes>
          </configuration>
        </plugin>
    </plugins>
  </reporting>

*BUT* if I configure the plugin in BOTH the pluginManagement and reporting
section, then it fails again.
Sounds to me like some plugin resolution condition that causes the
pluginManagementExcludes list parameter to not be set.


El sáb., 24 de ago. de 2019 a la(s) 17:32, Tibor Digana (
[hidden email]) escribió:

> that's bad. We were too fast :-)
> Although my build passed but in this case as I saw the commit I have to
> give my -1, sorry!
>
> On Sat, Aug 24, 2019 at 9:41 PM Gabriel Belingueres <[hidden email]
> >
> wrote:
>
> > Hi:
> >
> > Regarding MPIR-375, I noted that the merge of the PR into master branch
> > was done *before* I made changes using PatternExcludesArtifactFilter
> based
> > on the reviews.
> >
> > See https://github.com/apache/maven-project-info-reports-plugin/pull/7.
> > The commit in master is:
> >
> https://github.com/apache/maven-project-info-reports-plugin/commit/82f4bf23b79fe87d2e414c70ab2058e8f1b4146b
> >
> > The patch should work anyway so I decided to test it with the
> > maven-shared-utils library.
> > I added this to the pom.xml file (in addition to adding the
> > staged-releases profile to settings.xml with the staged repo):
> >
> >     <pluginManagement>
> >       <plugins>
> >         <plugin>
> >           <groupId>org.apache.maven.plugins</groupId>
> >           <artifactId>maven-project-info-reports-plugin</artifactId>
> >           <version>3.0.1</version>
> >           <configuration>
> >             <pluginManagementExcludes>
> >
> > <pluginManagementExclude>org.eclipse.m2e</pluginManagementExclude>
> >             </pluginManagementExcludes>
> >           </configuration>
> >         </plugin>
> >       </plugins>
> >     </pluginManagement>
> >
> > With version 3.0.1, running 'mvn -V -Pstaged-releases clean site >
> > 3.0.1.log' throws an exception. (see 3.0.1.log attached file)
> >
> > However, when building 3.0.2-SNAPSHOT and installing in the local repo
> > (please see that in git repo there are no new commits after the 3.0.1
> > release), changing the version to 3.0.2-SNAPSHOT works as expected:
> >
> > mvn -V -Pstaged-releases clean site > 3.0.2-SNAPSHOT.log
> >
> > Does anyone else is having this problem? Or am I doing something wrong?
> >
> > Kind regards,
> > Gabriel
> >
> > El vie., 23 de ago. de 2019 a la(s) 16:33, Michael Osipov (
> > [hidden email]) escribió:
> >
> >> Hi,
> >>
> >> We solved 5 issues:
> >>
> >>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317821&version=12344828
> >>
> >> There are still a couple of issues left in JIRA:
> >> https://issues.apache.org/jira/projects/MPIR/issues
> >>
> >> Staging repo:
> >> https://repository.apache.org/content/repositories/maven-1528/
> >>
> >>
> https://repository.apache.org/content/repositories/maven-1528/org/apache/maven/plugins/maven-project-info-reports-plugin/3.0.1/maven-project-info-reports-plugin-3.0.1-source-release.zip
> >>
> >> Source release checksum(s):
> >> maven-project-info-reports-plugin-3.0.1-source-release.zip
> >> sha512:
> >>
> >>
> 7145430a6999ed65a886ac503793f0aa9488b6853431c494c3dee6360c05f3db53fe46ff77bd41514002e8c320b0f4623d23b85d3a9373450c90bb713d3e50be
> >>
> >> Staging site:
> >>
> >>
> https://maven.apache.org/plugins-archives/maven-project-info-reports-plugin-LATEST/
> >>
> >> Guide to testing staged releases:
> >> https://maven.apache.org/guides/development/guide-testing-releases.html
> >>
> >> Vote open for 72 hours.
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
> >>
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Maven Project Info Reports Plugin version 3.0.1

Michael Osipov-2
Am 2019-08-24 um 21:41 schrieb Gabriel Belingueres:

> Hi:
>
> Regarding MPIR-375, I noted that the merge of the PR into master branch was
> done *before* I made changes using PatternExcludesArtifactFilter based on
> the reviews.
>
> See https://github.com/apache/maven-project-info-reports-plugin/pull/7.
> The commit in master is:
> https://github.com/apache/maven-project-info-reports-plugin/commit/82f4bf23b79fe87d2e414c70ab2058e8f1b4146b
>
> The patch should work anyway so I decided to test it with the
> maven-shared-utils library.
> I added this to the pom.xml file (in addition to adding the staged-releases
> profile to settings.xml with the staged repo):
>
>      <pluginManagement>
>        <plugins>
>          <plugin>
>            <groupId>org.apache.maven.plugins</groupId>
>            <artifactId>maven-project-info-reports-plugin</artifactId>
>            <version>3.0.1</version>
>            <configuration>
>              <pluginManagementExcludes>
>
> <pluginManagementExclude>org.eclipse.m2e</pluginManagementExclude>
>              </pluginManagementExcludes>
>            </configuration>
>          </plugin>
>        </plugins>
>      </pluginManagement>

Reporting plugins don't go into pluginManagement. They go into
//reporting/plugins. Please with that section first.

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Maven Project Info Reports Plugin version 3.0.1

Tibor Digana
In reply to this post by Gabriel Belingueres-2
Michael, this is true but the second problem is a missed commit? Where is
the commit? It is not in the PR.
Gabriel, the log file was not attached.
And the third problem is an exception which we could not see because the
log is not in the attachements.

On Sun, Aug 25, 2019 at 5:14 PM Michael Osipov <[hidden email]> wrote:

> Am 2019-08-24 um 21:41 schrieb Gabriel Belingueres:
> > Hi:
> >
> > Regarding MPIR-375, I noted that the merge of the PR into master branch
> was
> > done *before* I made changes using PatternExcludesArtifactFilter based on
> > the reviews.
> >
> > See https://github.com/apache/maven-project-info-reports-plugin/pull/7.
> > The commit in master is:
> >
> https://github.com/apache/maven-project-info-reports-plugin/commit/82f4bf23b79fe87d2e414c70ab2058e8f1b4146b
> >
> > The patch should work anyway so I decided to test it with the
> > maven-shared-utils library.
> > I added this to the pom.xml file (in addition to adding the
> staged-releases
> > profile to settings.xml with the staged repo):
> >
> >      <pluginManagement>
> >        <plugins>
> >          <plugin>
> >            <groupId>org.apache.maven.plugins</groupId>
> >            <artifactId>maven-project-info-reports-plugin</artifactId>
> >            <version>3.0.1</version>
> >            <configuration>
> >              <pluginManagementExcludes>
> >
> > <pluginManagementExclude>org.eclipse.m2e</pluginManagementExclude>
> >              </pluginManagementExcludes>
> >            </configuration>
> >          </plugin>
> >        </plugins>
> >      </pluginManagement>
> >
> > With version 3.0.1, running 'mvn -V -Pstaged-releases clean site >
> > 3.0.1.log' throws an exception. (see 3.0.1.log attached file)
> >
> > However, when building 3.0.2-SNAPSHOT and installing in the local repo
> > (please see that in git repo there are no new commits after the 3.0.1
> > release), changing the version to 3.0.2-SNAPSHOT works as expected:
> >
> > mvn -V -Pstaged-releases clean site > 3.0.2-SNAPSHOT.log
> >
> > Does anyone else is having this problem? Or am I doing something wrong?
>
> I cannot confirm:
> > $ mvn -V -Pstaged-releases clean site
> > Apache Maven 3.5.4 (1edded0938998edf8bf061f1ceb3cfdeccf443fe;
> 2018-06-17T20:33:14+02:00)
> > Maven home: D:\Entwicklung\Programme\apache-maven-3.5.4
> > Java version: 1.8.0_192, vendor: Oracle Corporation, runtime: C:\Program
> Files\Java\jdk1.8.0_192\jre
> > Default locale: de_DE, platform encoding: Cp1252
> > OS name: "windows 10", version: "10.0", arch: "amd64", family: "windows"
> > [INFO] Scanning for projects...
> > [INFO]
> > [INFO] -------------< org.apache.maven.shared:maven-shared-utils
> >-------------
> > [INFO] Building Apache Maven Shared Utils 3.2.2-SNAPSHOT
> > [INFO] --------------------------------[ jar
> ]---------------------------------
> > [INFO]
> > [INFO] --- maven-clean-plugin:3.1.0:clean (default-clean) @
> maven-shared-utils ---
> > [INFO] Deleting D:\Entwicklung\Projekte\maven-shared-utils\target
> > [INFO]
> > [INFO] --- maven-site-plugin:3.7.1:site (default-site) @
> maven-shared-utils ---
> > [INFO] configuring report plugin
> org.apache.maven.plugins:maven-project-info-reports-plugin:3.0.1
> > [INFO] 15 reports configured for
> maven-project-info-reports-plugin:3.0.1: index, summary, dependency-info,
> modules, team, scm, issue-management, mailing-lists, dependency-management,
> dependencies, dependency-convergence, ci-management, plugin-management,
> plugins, distribution-management
> > [INFO] Rendering site with default locale English (en)
> > [INFO] Relativizing decoration links with respect to localized project
> URL: https://maven.apache.org/shared/maven-shared-utils/
> > [INFO] Rendering content with
> org.apache.maven.skins:maven-fluido-skin:jar:1.7 skin.
> > [INFO] Skipped "About" report
> (maven-project-info-reports-plugin:3.0.1:index), file "index.html" already
> exists.
> > [INFO] Rendering 2 Doxia documents: 1 apt, 1 xdoc
> > [INFO] Generating "Summary" report       ---
> maven-project-info-reports-plugin:3.0.1:summary
> > [INFO] Generating "Dependency Information" report ---
> maven-project-info-reports-plugin:3.0.1:dependency-info
> > [INFO] Generating "Team" report          ---
> maven-project-info-reports-plugin:3.0.1:team
> > [INFO] Generating "Source Code Management" report ---
> maven-project-info-reports-plugin:3.0.1:scm
> > [INFO] Generating "Issue Management" report ---
> maven-project-info-reports-plugin:3.0.1:issue-management
> > [INFO] Generating "Mailing Lists" report ---
> maven-project-info-reports-plugin:3.0.1:mailing-lists
> > [INFO] Generating "Dependency Management" report ---
> maven-project-info-reports-plugin:3.0.1:dependency-management
> > [INFO] Generating "Dependencies" report  ---
> maven-project-info-reports-plugin:3.0.1:dependencies
> > [INFO] Generating "Dependency Convergence" report ---
> maven-project-info-reports-plugin:3.0.1:dependency-convergence
> > [INFO] Generating "CI Management" report ---
> maven-project-info-reports-plugin:3.0.1:ci-management
> > [INFO] Generating "Plugin Management" report ---
> maven-project-info-reports-plugin:3.0.1:plugin-management
> > [INFO] Generating "Plugins" report       ---
> maven-project-info-reports-plugin:3.0.1:plugins
> > [INFO] Generating "Distribution Management" report ---
> maven-project-info-reports-plugin:3.0.1:distribution-management
> > [INFO]
> ------------------------------------------------------------------------
> > [INFO] BUILD SUCCESS
> > [INFO]
> ------------------------------------------------------------------------
> > [INFO] Total time: 7.428 s
> > [INFO] Finished at: 2019-08-25T17:12:40+02:00
> > [INFO]
> ------------------------------------------------------------------------
> > [WARNING] The requested profile "staged-releases" could not be activated
> because it does not exist.
>
> with this patch:
> > $ git diff
> > diff --git a/pom.xml b/pom.xml
> > index 01763d98f..f3b4d7882 100644
> > --- a/pom.xml
> > +++ b/pom.xml
> > @@ -154,5 +154,21 @@
> >        </plugin>
> >      </plugins>
> >    </build>
> > +
> > +  <reporting>
> > +  <plugins>
> > +       <plugin>
> > +          <groupId>org.apache.maven.plugins</groupId>
> > +          <artifactId>maven-project-info-reports-plugin</artifactId>
> > +          <version>3.0.1</version>
> > +          <configuration>
> > +            <pluginManagementExcludes>
> > +
> > +<pluginManagementExclude>org.eclipse.m2e</pluginManagementExclude>
> > +            </pluginManagementExcludes>
> > +          </configuration>
> > +        </plugin>
> > +               </plugins>
> > +  </reporting>
> >
> >  </project>
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Maven Project Info Reports Plugin version 3.0.1

Gabriel Belingueres-2
Created https://issues.apache.org/jira/browse/MPIR-384

Kind regards,
Gabriel

El lun., 26 de ago. de 2019 a la(s) 05:21, Michael Osipov (
[hidden email]) escribió:

> Am 2019-08-26 um 04:14 schrieb Gabriel Belingueres:
> > Hi:
> >
> > In the light of what Michael clarified, and after some doc reading [1],
> > quoting the following about 'mvn site':
> > "It uses *only* the parameters defined in the <configuration> element of
> > each reporting Plugin specified in the <reporting> element, i.e. site
> > always *ignores* the parameters defined in the <configuration> element of
> > each plugin specified in <build>."
> >
> > After testing with the plugin configuration in the <reporting> section,
> it
> > worked OK. Why it does not apply the reporting configuration when the
> > plugin is declared and configured in both the pluginManagement and
> > repoorting sections is another matter.
> >
> > I created a gist with the log files as it seems the mailing does not
> allow
> > attachments. Please see [2], but it seems less useful now.
> >
> > Regarding the missing commit, it was an improvement over the first commit
> > (which already had the IT in place). The feature is already there and
> > working. I have no problem to  raise a new issue for the next release.
>
> Please do so.
>
> @Tibor. Do you still insist on -1?
>
> @all if Tibor reverts his one, I still need another binding vote.
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Maven Project Info Reports Plugin version 3.0.1

Gabriel Belingueres-2
Hi:

Regarding the exception, there were several cases I checked:

Case 1:

    <pluginManagement>
      <plugins>
        <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-project-info-reports-plugin</artifactId>
          <version>3.0.1</version>
          <configuration>
            <pluginManagementExcludes>

<pluginManagementExclude>org.eclipse.m2e</pluginManagementExclude>
            </pluginManagementExcludes>
          </configuration>
        </plugin>
      </plugins>
    </pluginManagement>

it was not finding the very same plugin I was testing:
"org.apache.maven.project.ProjectBuildingException: Error resolving project
artifact: Failure to find
org.apache.maven.plugins:maven-project-info-reports-plugin:pom:3.0.1 in
https://repo.maven.apache.org/maven2 was cached in the local repository,
resolution will not be reattempted until the update interval of central has
elapsed or updates are forced for project
org.apache.maven.plugins:maven-project-info-reports-plugin:pom:3.0.1"

The reason for this exception is that it could not find it when declared in
the pluginManagement section, because it tries to get it as an artifact and
it was not found. Adding the same plugin staging repo like this solved the
exception:
  <repositories>
    <repository>
      <id>same-staged-repo</id>
      <url>https://repository.apache.org/content/repositories/maven-1528
</url>
    </repository>
  </repositories>

I think this condition should dissapear as soon as the plugin is deployed
to Central repo?

Case 2:
Executing again with the artifact repo added caused this exception:
Caused by: org.eclipse.aether.transfer.ArtifactNotFoundException: Failure
to find org.eclipse.m2e:lifecycle-mapping:pom:1.0.0 in http://.... was
cached in the local repository, resolution will not be reattempted until
the update interval of central has elapsed or updates are forced

which is what is expected as the 'mvn site' execution does not set the
parameters in the plugin configuration section of plugins.

Case 3:
Leave the pluginManagement section but configure it in the reporting
section:
    <pluginManagement>
      <plugins>
        <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-project-info-reports-plugin</artifactId>
          <version>3.0.1</version>
        </plugin>
      </plugins>
    </pluginManagement>
  <reporting>
    <plugins>
        <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-project-info-reports-plugin</artifactId>
          <configuration>
            <pluginManagementExcludes>

<pluginManagementExclude>org.eclipse.m2e</pluginManagementExclude>
            </pluginManagementExcludes>
          </configuration>
        </plugin>
    </plugins>
  </reporting>

Works OK as long as the artifact repository is kept.

Case 4:
If I delete the artifact repository, to avoid the exception "...Failure to
find
org.apache.maven.plugins:maven-project-info-reports-plugin:pom:3.0.1..." I
excluded the plugin in the configuration (showing that the added
functionality works for the plugin itself):
  <reporting>
    <plugins>
        <plugin>
          <groupId>org.apache.maven.plugins</groupId>
          <artifactId>maven-project-info-reports-plugin</artifactId>
          <configuration>
            <pluginManagementExcludes>

<pluginManagementExclude>org.eclipse.m2e</pluginManagementExclude>

<pluginManagementExclude>org.apache.maven.plugins:maven-project-info-reports-plugin</pluginManagementExclude>
            </pluginManagementExcludes>
          </configuration>
        </plugin>
    </plugins>
  </reporting>

HTH
Gabriel

El lun., 26 de ago. de 2019 a la(s) 09:59, Tibor Digana (
[hidden email]) escribió:

> I was waiting this this issue. Now it is clear for me too.
> So we are missing this commit, right? It's worth to complete the PR#7 and
> restart the vote.
>
> Gabriel, why the exception with plugin version 3.0.1 appears on your box?
> T
>
> On Mon, Aug 26, 2019 at 2:49 PM Gabriel Belingueres <[hidden email]
> >
> wrote:
>
> > Created https://issues.apache.org/jira/browse/MPIR-384
> >
> > Kind regards,
> > Gabriel
> >
> > El lun., 26 de ago. de 2019 a la(s) 05:21, Michael Osipov (
> > [hidden email]) escribió:
> >
> > > Am 2019-08-26 um 04:14 schrieb Gabriel Belingueres:
> > > > Hi:
> > > >
> > > > In the light of what Michael clarified, and after some doc reading
> [1],
> > > > quoting the following about 'mvn site':
> > > > "It uses *only* the parameters defined in the <configuration> element
> > of
> > > > each reporting Plugin specified in the <reporting> element, i.e. site
> > > > always *ignores* the parameters defined in the <configuration>
> element
> > of
> > > > each plugin specified in <build>."
> > > >
> > > > After testing with the plugin configuration in the <reporting>
> section,
> > > it
> > > > worked OK. Why it does not apply the reporting configuration when the
> > > > plugin is declared and configured in both the pluginManagement and
> > > > repoorting sections is another matter.
> > > >
> > > > I created a gist with the log files as it seems the mailing does not
> > > allow
> > > > attachments. Please see [2], but it seems less useful now.
> > > >
> > > > Regarding the missing commit, it was an improvement over the first
> > commit
> > > > (which already had the IT in place). The feature is already there and
> > > > working. I have no problem to  raise a new issue for the next
> release.
> > >
> > > Please do so.
> > >
> > > @Tibor. Do you still insist on -1?
> > >
> > > @all if Tibor reverts his one, I still need another binding vote.
> > >
> >
>