Re: [VOTE] Release Apache Maven maven-shared-resources 3

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven maven-shared-resources 3

rfscholte
(off-topic) +1 for adding an enforcer rule to verify both JDK and Maven. Officially we should verify OS version too, so we have all 3 critical parts for a release. But OS is most likely too hard and won't gain us anything.

Robert

On 1-1-2021 11:43:03, Hervé BOUTEMY <[hidden email]> wrote:
Happy New Year :)

Le jeudi 31 décembre 2020, 17:51:53 CET Sylwester Lachiewicz a écrit :
> Hi,
> Sorry for releasing with ea version - i use it on daily basis to test all
> Maven components. For future I'll be more careful.
thank you
we could eventually add a Maven Enforcer test in the release profile (in parent POM) to help detect and report if forgotten (because we're humans...)

>
> This packages contains only files, no compiled classes so it should not be
> affected by java version.
sure, it's only the MANIFEST.MF of main .jar that contains Build-Jdk-Spec entry: extra effort to configure the maven-jar-plugin to remove this entry would be overkill IMHO

> My build was created from fresh git clone on
> Windows 10.
> How i can verify if your procedure on my side?
mvn -Papache-release,run-its -Dgpg.skip clean verify artifact:buildinfo -Dreference.repo=https://repository.apache.org/content/repositories/maven-1619

(I did not add here the trick for emulating Windows newlines on Linux given you're building on Windows)

notice that I just installed JDK 17 EA +3 and I could as expected reproduce the build: but I strongly discourage doing releases with such a moving target, because it would not be surprising that in the next months, there are changes in generated bytecode of this EA
And I know that the Maven Docker image to automate rebuild on Reproducible Central won't be available for now...

Regards,

Hervé

>
> Sylwester
>
>
> czw., 31 gru 2020, 15:56 użytkownik Hervé BOUTEMY
>
> napisał:
> > +1
> >
> > even if I could not reproduce the build because it was done with JDK 17
> > (EA):
> > what's the interest of playing with such early JDK for doing public
> > release?
> > Didn't we already discuss about it before?
> >
> > Regards,
> >
> > Hervé
> >
> > Le mardi 29 décembre 2020, 22:52:44 CET Sylwester Lachiewicz a écrit :
> > > Hi,
> >
> > > We solved 3 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?version=12331412&st
> > yl>
> > > eName=Text&projectId=12317922
> > >
> > >
> > > Staging repo:
> > > https://repository.apache.org/content/repositories/maven-1619/
> >
> > https://repository.apache.org/content/repositories/maven-1619/org/apache/m
> > av
> >
> > en/shared/maven-shared-resources/3/maven-shared-resources-3-source-release
> > .z>
> > > ip
> > >
> > > Source release checksum(s):
> >
> > > maven-shared-resources-3-source-release.zip sha512:
> > 02d5ef00af267efddc6f7d1c6323cd3a2c0cab9f2786a58bd20b8289eda688f02afcf179dc
> > fb>
> > > 07a5abf7f08496d47a7470a2c5de8e76183ae89b36184d53f67f
> > >
> > > Staging site:
> > > https://maven.apache.org/shared-archives/maven-shared-resources-LATEST/
> > >
> > > Guide to testing staged releases:
> > > https://maven.apache.org/guides/development/guide-testing-releases.html
> > >
> > > Vote open for at least 72 hours.
> > >
> > > [ ] +1
> > > [ ] +0
> > > [ ] -1
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [hidden email]
> > > For additional commands, e-mail: [hidden email]
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]





---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]