Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M1 - TAKE 2

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M1 - TAKE 2

Eric Lilja
+1 (non-binding)

When testing on my personal projects, I did see one JUnit test failure
on some very old code, a test which didn't have any problems on surefire
2.18.1-2.22.1. I examined the test and came to the conclusion that is
was misbehaved as it tried to treat a classpath resource as a file
system resource. I re-wrote the test and now it works on both both
3.0.0-M1 and older versions. But I guess others will see similar
failures if they have poorly written code like I had in that testcase.

I tested using a clean .m2 and ran a script which builds all my projects
in dependency order. I noticed the process took a lot longer than usual
after adding the staging repo, but I solved that by adding the default
plugin repo as well.

By the way, there were five issues closed, not four, which is not a bad
thing, just a tiny error in the vote email text :)

- Eric Lilja

On 2018-11-04 11:48, Tibor Digana wrote:

> Hi,
>
> We solved 4 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12342871
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1466/
> https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire/3.0.0-M1/surefire-3.0.0-M1-source-release.zip
>
> Source release checksum(s):
> surefire-3.0.0-M1-source-release.zip sha512:
> 2817639681b8597a58c38dbb5616c481c263f04b722f6fafcbc3f33c17f5d4b165572c38a83789ed80097047601505b339df015617603f754319dfadf3089b94
> surefire-3.0.0-M1-source-release.zip sha1:
> 72830b8d82bd068ab7da5eaeb4da8a66b8ea600d
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M1 - TAKE 2

Tibor Digana
Well, yes there should be two repos.
One is Maven Central and the second is the staging because the ASF staging
Nexus is not a copy of Central. There are only our Apache artifacts
deployed.

On Sun, Nov 4, 2018 at 5:12 PM Eric Lilja <[hidden email]> wrote:

> +1 (non-binding)
>
> When testing on my personal projects, I did see one JUnit test failure
> on some very old code, a test which didn't have any problems on surefire
> 2.18.1-2.22.1. I examined the test and came to the conclusion that is
> was misbehaved as it tried to treat a classpath resource as a file
> system resource. I re-wrote the test and now it works on both both
> 3.0.0-M1 and older versions. But I guess others will see similar
> failures if they have poorly written code like I had in that testcase.
>
> I tested using a clean .m2 and ran a script which builds all my projects
> in dependency order. I noticed the process took a lot longer than usual
> after adding the staging repo, but I solved that by adding the default
> plugin repo as well.
>
> By the way, there were five issues closed, not four, which is not a bad
> thing, just a tiny error in the vote email text :)
>
> - Eric Lilja
>
> On 2018-11-04 11:48, Tibor Digana wrote:
> > Hi,
> >
> > We solved 4 issues:
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12342871
> >
> > There are still a couple of issues left in JIRA:
> >
> https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1466/
> >
> https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire/3.0.0-M1/surefire-3.0.0-M1-source-release.zip
> >
> > Source release checksum(s):
> > surefire-3.0.0-M1-source-release.zip sha512:
> >
> 2817639681b8597a58c38dbb5616c481c263f04b722f6fafcbc3f33c17f5d4b165572c38a83789ed80097047601505b339df015617603f754319dfadf3089b94
> > surefire-3.0.0-M1-source-release.zip sha1:
> > 72830b8d82bd068ab7da5eaeb4da8a66b8ea600d
> >
> > Staging site:
> > http://maven.apache.org/surefire-archives/surefire-LATEST/
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > Cheers
> > Tibor
> >
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M1 - TAKE 2

Olivier Lamy
In reply to this post by Eric Lilja
+1

On Sun, 4 Nov 2018 at 20:48, Tibor Digana <[hidden email]> wrote:

> Hi,
>
> We solved 4 issues:
>
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12342871
>
> There are still a couple of issues left in JIRA:
>
> https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1466/
>
> https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire/3.0.0-M1/surefire-3.0.0-M1-source-release.zip
>
> Source release checksum(s):
> surefire-3.0.0-M1-source-release.zip sha512:
>
> 2817639681b8597a58c38dbb5616c481c263f04b722f6fafcbc3f33c17f5d4b165572c38a83789ed80097047601505b339df015617603f754319dfadf3089b94
> surefire-3.0.0-M1-source-release.zip sha1:
> 72830b8d82bd068ab7da5eaeb4da8a66b8ea600d
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor
>


--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 3.0.0-M1 - TAKE 2

Sylwester Lachiewicz
In reply to this post by Eric Lilja
+1

wt., 6 lis 2018 o 19:45 u┼╝ytkownik Tibor Digana <[hidden email]>
napisał:

> +1, we need to have more participants in the Vote.
>
> On Sun, Nov 4, 2018 at 11:48 AM Tibor Digana <[hidden email]>
> wrote:
>
> > Hi,
> >
> > We solved 4 issues:
> >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&version=12342871
> >
> > There are still a couple of issues left in JIRA:
> >
> >
> https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1466/
> >
> >
> https://repository.apache.org/content/repositories/maven-1466/org/apache/maven/surefire/surefire/3.0.0-M1/surefire-3.0.0-M1-source-release.zip
> >
> > Source release checksum(s):
> > surefire-3.0.0-M1-source-release.zip sha512:
> >
> 2817639681b8597a58c38dbb5616c481c263f04b722f6fafcbc3f33c17f5d4b165572c38a83789ed80097047601505b339df015617603f754319dfadf3089b94
> > surefire-3.0.0-M1-source-release.zip sha1:
> > 72830b8d82bd068ab7da5eaeb4da8a66b8ea600d
> >
> > Staging site:
> > http://maven.apache.org/surefire-archives/surefire-LATEST/
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > Cheers
> > Tibor
> >
>