Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Tibor Digana
Hello Enrico,

Would you create an issue in Jira? I will fix it in the nearest release.
(Let's continue our discussion in Jira.)
Yes, it is minor issue however annoying because you see the dump file.
Details: The only problem is the order of these two lines. First line
writes to a native Std/Out and second line wraps the stream to surefire
format:

*Filter filter = jUnit48Reflector.isJUnit48Available() ?
createJUnit48Filter() : null;createRunListener( reporterFactory,
consoleStream )*

Cheers
Tibor

On Sun, Mar 4, 2018 at 9:14 AM, Enrico Olivelli <[hidden email]> wrote:

> Using the '-Dgroups' parameter I get this warning.
> It seems not a showstopper but the fix may be simple.
> Surefire itself is corrupting stdout while writing a WARNING.
> It is related to my issue
> https://issues.apache.org/jira/plugins/servlet/mobile#issue/SUREFIRE-1453
>
>
> Thoughts?
> Enrico
>
>
> # Created on 2018-03-04T08:36:54.490
> Corrupted STDOUT by directly writing to native stream in forked JVM 1.
> Stream '[WARNING] Couldn't load group class 'MinimumAcceptance' in
> Surefire|Failsafe plugin. The group class is ignored!'.
> java.lang.IllegalArgumentException: Stream stdin corrupted. Expected comma
> after third character in command '[WARNING] Couldn't load group class
> 'MinimumAcceptance' in Surefire|Failsafe plugin. The group class is
> ignored!'.
> at
> org.apache.maven.plugin.surefire.booterclient.output.
> ForkClient$OperationalData.<init>(ForkClient.java:511)
> at
> org.apache.maven.plugin.surefire.booterclient.output.
> ForkClient.processLine(ForkClient.java:209)
> at
> org.apache.maven.plugin.surefire.booterclient.output.
> ForkClient.consumeLine(ForkClient.java:176)
> at
> org.apache.maven.plugin.surefire.booterclient.output.
> ThreadedStreamConsumer$Pumper.run(ThreadedStreamConsumer.java:88)
> at java.base/java.lang.Thread.run(Thread.java:844)
> Il sab 3 mar 2018, 13:34 Tibor Digana <[hidden email]> ha scritto:
>
> > Maybe disappointed a bit on how we run the build with Java 1.8 and
> another
> > J7 - J10 used in all Tests (unit + integration tests).
> > $ mvn install -P run-its -nsu -Dintegration-test-port=8000
> > -Dintegration-test-stop-port=8001 "-Djdk.home=d:\Program
> Files\Java\jdk10"
> > -Djacoco.skip=true
> > There were several reasons.
> > Maven plugins failed with J9, JUnit 5 Provider in future Surefire
> requires
> > J8, and the last is the JavaDoc check which runs within JavaC and it
> forced
> > the contributors to write JavaDoc correctly in the beginning of
> > development.
> >
> > T
> >
> > On Sat, Mar 3, 2018 at 12:48 PM, Tibor Digana <[hidden email]>
> > wrote:
> >
> > > Typo, the version is 2.21.0 of course.
> > >
> > > On Sat, Mar 3, 2018 at 12:42 PM, Tibor Digana <[hidden email]>
> > > wrote:
> > >
> > >> Hi,
> > >>
> > >> We solved 33 issues:
> > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
> > >> ctId=12317927&version=12341630
> > >>
> > >> There are still a couple of issues left in JIRA:
> > >> https://issues.apache.org/jira/i#issues/?jql=project+%3D+
> > >> SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> > >>
> > >> Staging repo:
> > >> https://repository.apache.org/content/repositories/maven-1402/
> > >> https://repository.apache.org/content/repositories/maven-140
> > >> 2/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.
> > >> 0-source-release.zip
> > >>
> > >> Source release checksum(s):
> > >> surefire-2.21.0-source-release.zip sha1:
> 6927024eefa0b8c80dee70efa014f1
> > >> f421d7844b
> > >>
> > >> Staging site:
> > >> http://maven.apache.org/surefire-archives/surefire-LATEST/
> > >>
> > >> Guide to testing staged releases:
> > >> http://maven.apache.org/guides/development/guide-
> testing-releases.html
> > >>
> > >> Vote open for 72 hours.
> > >>
> > >> [ ] +1
> > >> [ ] +0
> > >> [ ] -1
> > >>
> > >> Cheers
> > >> Tibor
> > >>
> > >
> > >
> >
> --
>
>
> -- Enrico Olivelli
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Enrico Olivelli
+1 (non binding)

Tested on Fedora 26/27, with J9 and J10 on my applications.

Built from surces, got only error on Unicode names tests (already known
issue)

Great !
Enrico

Il lun 5 mar 2018, 07:11 Olivier Lamy <[hidden email]> ha scritto:

> +1
>
> On 3 March 2018 at 21:42, Tibor Digana <[hidden email]> wrote:
>
> > Hi,
> >
> > We solved 33 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > projectId=12317927&version=12341630
> >
> > There are still a couple of issues left in JIRA:
> > <a href="https://issues.apache.org/jira/i#issues/?jql=project+%">https://issues.apache.org/jira/i#issues/?jql=project+%
> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1402/
> > https://repository.apache.org/content/repositories/maven-
> > 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
> > release.zip
> >
> > Source release checksum(s):
> > surefire-2.21.0-source-release.zip sha1:
> > 6927024eefa0b8c80dee70efa014f1f421d7844b
> >
> > Staging site:
> > http://maven.apache.org/surefire-archives/surefire-LATEST/
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > Cheers
> > Tibor
> >
>
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
--


-- Enrico Olivelli
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Tibor Digana
In reply to this post by Tibor Digana
+1

On Tue, Mar 6, 2018 at 10:26 AM, Tibor Digana <[hidden email]>
wrote:

> Hi Herve,
>
> Can you send me a zip of the test which failed
> *surefire-its/target/Surefire1177TestngParallelSuitesIT_shouldRunTwoSuitesInParallel*
> ?
> It is a parallelism in TestNG. I will discuss it with the guys in TestNG
> team on GitHub.
> Thx.
> Tibor
>
>
> On Tue, Mar 6, 2018 at 7:50 AM, Hervé BOUTEMY <[hidden email]>
> wrote:
>
>> built from sources (with classic "mvn -Prun-its verify" & Java 8) and got
>> 2
>> failing unit tests:
>> Failed tests:
>> checkFileNamesWithUnicode(org.apache.maven.surefire.its.Unic
>> odeTestNamesIT):
>> Did not find expected message in log
>>   shouldRunTwoSuitesInParallel(org.apache.maven.surefire.its.j
>> iras.Surefire1177TestngParallelSuitesIT):
>> log pattern does not match nTimes(..)
>>
>> Unicode tests si already known, and I don't know for the second issue
>>
>> I don't see this as a blocker
>>
>> +1
>>
>> Regards,
>>
>> Hervé
>>
>> Le samedi 3 mars 2018, 12:42:48 CET Tibor Digana a écrit :
>> > Hi,
>> >
>> > We solved 33 issues:
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12317927&ve
>> > rsion=12341630
>> >
>> > There are still a couple of issues left in JIRA:
>> > https://issues.apache.org/jira/i#issues/?jql=project+%3D+
>> SUREFIRE+AND+status
>> > +%3D+Open+ORDER+BY+priority+DESC
>> >
>> > Staging repo:
>> > https://repository.apache.org/content/repositories/maven-1402/
>> > https://repository.apache.org/content/repositories/maven-140
>> 2/org/apache/mav
>> > en/surefire/surefire/2.21.0/surefire-2.21.0-source-release.zip
>> >
>> > Source release checksum(s):
>> > surefire-2.21.0-source-release.zip sha1:
>> > 6927024eefa0b8c80dee70efa014f1f421d7844b
>> >
>> > Staging site:
>> > http://maven.apache.org/surefire-archives/surefire-LATEST/
>> >
>> > Guide to testing staged releases:
>> > http://maven.apache.org/guides/development/guide-testing-releases.html
>> >
>> > Vote open for 72 hours.
>> >
>> > [ ] +1
>> > [ ] +0
>> > [ ] -1
>> >
>> > Cheers
>> > Tibor
>>
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Tibor Digana
Thx to everybody!

On Tue, Mar 6, 2018 at 2:27 PM, Tibor Digana <[hidden email]> wrote:

> +1
>
> On Tue, Mar 6, 2018 at 10:26 AM, Tibor Digana <[hidden email]>
> wrote:
>
>> Hi Herve,
>>
>> Can you send me a zip of the test which failed
>> *surefire-its/target/Surefire1177TestngParallelSuitesIT_shouldRunTwoSuitesInParallel*
>> ?
>> It is a parallelism in TestNG. I will discuss it with the guys in TestNG
>> team on GitHub.
>> Thx.
>> Tibor
>>
>>
>> On Tue, Mar 6, 2018 at 7:50 AM, Hervé BOUTEMY <[hidden email]>
>> wrote:
>>
>>> built from sources (with classic "mvn -Prun-its verify" & Java 8) and
>>> got 2
>>> failing unit tests:
>>> Failed tests:
>>> checkFileNamesWithUnicode(org.apache.maven.surefire.its.Unic
>>> odeTestNamesIT):
>>> Did not find expected message in log
>>>   shouldRunTwoSuitesInParallel(org.apache.maven.surefire.its.j
>>> iras.Surefire1177TestngParallelSuitesIT):
>>> log pattern does not match nTimes(..)
>>>
>>> Unicode tests si already known, and I don't know for the second issue
>>>
>>> I don't see this as a blocker
>>>
>>> +1
>>>
>>> Regards,
>>>
>>> Hervé
>>>
>>> Le samedi 3 mars 2018, 12:42:48 CET Tibor Digana a écrit :
>>> > Hi,
>>> >
>>> > We solved 33 issues:
>>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>>> ctId=12317927&ve
>>> > rsion=12341630
>>> >
>>> > There are still a couple of issues left in JIRA:
>>> > https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUR
>>> EFIRE+AND+status
>>> > +%3D+Open+ORDER+BY+priority+DESC
>>> >
>>> > Staging repo:
>>> > https://repository.apache.org/content/repositories/maven-1402/
>>> > https://repository.apache.org/content/repositories/maven-140
>>> 2/org/apache/mav
>>> > en/surefire/surefire/2.21.0/surefire-2.21.0-source-release.zip
>>> >
>>> > Source release checksum(s):
>>> > surefire-2.21.0-source-release.zip sha1:
>>> > 6927024eefa0b8c80dee70efa014f1f421d7844b
>>> >
>>> > Staging site:
>>> > http://maven.apache.org/surefire-archives/surefire-LATEST/
>>> >
>>> > Guide to testing staged releases:
>>> > http://maven.apache.org/guides/development/guide-testing-releases.html
>>> >
>>> > Vote open for 72 hours.
>>> >
>>> > [ ] +1
>>> > [ ] +0
>>> > [ ] -1
>>> >
>>> > Cheers
>>> > Tibor
>>>
>>>
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Eric Lilja
In reply to this post by Tibor Digana
On 2018-03-06 14:27, Tibor Digana wrote:

>
>> Hi Herve,
>>
>> Can you send me a zip of the test which failed
>> *surefire-its/target/Surefire1177TestngParallelSuitesIT_shouldRunTwoSuitesInParallel*
>> ?
>> It is a parallelism in TestNG. I will discuss it with the guys in TestNG
>> team on GitHub.
>> Thx.
>> Tibor
>>
>>

Congratulations on the release, looking forward to trying it! For us who
only read this mailing list, how was the issue mentioned above resolved
(parallelism in TestNG)?

- EL

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Tibor Digana
I will fix all mentioned issues above but this one. I only guess what has
happened. So I need to have a log from Herve to make sure my guess is right.

On Tue, Mar 6, 2018 at 3:38 PM, Eric Lilja <[hidden email]> wrote:

> On 2018-03-06 14:27, Tibor Digana wrote:
>
>>
>> Hi Herve,
>>>
>>> Can you send me a zip of the test which failed
>>> *surefire-its/target/Surefire1177TestngParallelSuitesIT_shou
>>> ldRunTwoSuitesInParallel*
>>> ?
>>> It is a parallelism in TestNG. I will discuss it with the guys in TestNG
>>> team on GitHub.
>>> Thx.
>>> Tibor
>>>
>>>
>>>
> Congratulations on the release, looking forward to trying it! For us who
> only read this mailing list, how was the issue mentioned above resolved
> (parallelism in TestNG)?
>
> - EL
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>