Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

classic Classic list List threaded Threaded
7 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Tibor Digana
Typo, the version is 2.21.0 of course.

On Sat, Mar 3, 2018 at 12:42 PM, Tibor Digana <[hidden email]>
wrote:

> Hi,
>
> We solved 33 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12317927&version=12341630
>
> There are still a couple of issues left in JIRA:
> <a href="https://issues.apache.org/jira/i#issues/?jql=project+%">https://issues.apache.org/jira/i#issues/?jql=project+%
> 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1402/
> https://repository.apache.org/content/repositories/maven-
> 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
> release.zip
>
> Source release checksum(s):
> surefire-2.21.0-source-release.zip sha1: 6927024eefa0b8c80dee70efa014f1
> f421d7844b
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Tibor Digana
Maybe disappointed a bit on how we run the build with Java 1.8 and another
J7 - J10 used in all Tests (unit + integration tests).
$ mvn install -P run-its -nsu -Dintegration-test-port=8000
-Dintegration-test-stop-port=8001 "-Djdk.home=d:\Program Files\Java\jdk10"
-Djacoco.skip=true
There were several reasons.
Maven plugins failed with J9, JUnit 5 Provider in future Surefire requires
J8, and the last is the JavaDoc check which runs within JavaC and it forced
the contributors to write JavaDoc correctly in the beginning of development.

T

On Sat, Mar 3, 2018 at 12:48 PM, Tibor Digana <[hidden email]>
wrote:

> Typo, the version is 2.21.0 of course.
>
> On Sat, Mar 3, 2018 at 12:42 PM, Tibor Digana <[hidden email]>
> wrote:
>
>> Hi,
>>
>> We solved 33 issues:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?proje
>> ctId=12317927&version=12341630
>>
>> There are still a couple of issues left in JIRA:
>> https://issues.apache.org/jira/i#issues/?jql=project+%3D+
>> SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>>
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-1402/
>> https://repository.apache.org/content/repositories/maven-140
>> 2/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.
>> 0-source-release.zip
>>
>> Source release checksum(s):
>> surefire-2.21.0-source-release.zip sha1: 6927024eefa0b8c80dee70efa014f1
>> f421d7844b
>>
>> Staging site:
>> http://maven.apache.org/surefire-archives/surefire-LATEST/
>>
>> Guide to testing staged releases:
>> http://maven.apache.org/guides/development/guide-testing-releases.html
>>
>> Vote open for 72 hours.
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> Cheers
>> Tibor
>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Hervé BOUTEMY
In reply to this post by Tibor Digana
built from sources (with classic "mvn -Prun-its verify" & Java 8) and got 2
failing unit tests:
Failed tests:  
checkFileNamesWithUnicode(org.apache.maven.surefire.its.UnicodeTestNamesIT):
Did not find expected message in log
  shouldRunTwoSuitesInParallel(org.apache.maven.surefire.its.jiras.Surefire1177TestngParallelSuitesIT):
log pattern does not match nTimes(..)

Unicode tests si already known, and I don't know for the second issue

I don't see this as a blocker

+1

Regards,

Hervé

Le samedi 3 mars 2018, 12:42:48 CET Tibor Digana a écrit :

> Hi,
>
> We solved 33 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317927&ve
> rsion=12341630
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/i#issues/?jql=project+%3D+SUREFIRE+AND+status
> +%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1402/
> https://repository.apache.org/content/repositories/maven-1402/org/apache/mav
> en/surefire/surefire/2.21.0/surefire-2.21.0-source-release.zip
>
> Source release checksum(s):
> surefire-2.21.0-source-release.zip sha1:
> 6927024eefa0b8c80dee70efa014f1f421d7844b
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Tibor Digana
Hi Herve,

Can you send me a zip of the test which failed
*surefire-its/target/Surefire1177TestngParallelSuitesIT_shouldRunTwoSuitesInParallel*
?
It is a parallelism in TestNG. I will discuss it with the guys in TestNG
team on GitHub.
Thx.
Tibor


On Tue, Mar 6, 2018 at 7:50 AM, Hervé BOUTEMY <[hidden email]> wrote:

> built from sources (with classic "mvn -Prun-its verify" & Java 8) and got 2
> failing unit tests:
> Failed tests:
> checkFileNamesWithUnicode(org.apache.maven.surefire.its.
> UnicodeTestNamesIT):
> Did not find expected message in log
>   shouldRunTwoSuitesInParallel(org.apache.maven.surefire.its.jiras.
> Surefire1177TestngParallelSuitesIT):
> log pattern does not match nTimes(..)
>
> Unicode tests si already known, and I don't know for the second issue
>
> I don't see this as a blocker
>
> +1
>
> Regards,
>
> Hervé
>
> Le samedi 3 mars 2018, 12:42:48 CET Tibor Digana a écrit :
> > Hi,
> >
> > We solved 33 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12317927&ve
> > rsion=12341630
> >
> > There are still a couple of issues left in JIRA:
> > <a href="https://issues.apache.org/jira/i#issues/?jql=project+%">https://issues.apache.org/jira/i#issues/?jql=project+%
> 3D+SUREFIRE+AND+status
> > +%3D+Open+ORDER+BY+priority+DESC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1402/
> > https://repository.apache.org/content/repositories/maven-
> 1402/org/apache/mav
> > en/surefire/surefire/2.21.0/surefire-2.21.0-source-release.zip
> >
> > Source release checksum(s):
> > surefire-2.21.0-source-release.zip sha1:
> > 6927024eefa0b8c80dee70efa014f1f421d7844b
> >
> > Staging site:
> > http://maven.apache.org/surefire-archives/surefire-LATEST/
> >
> > Guide to testing staged releases:
> > http://maven.apache.org/guides/development/guide-testing-releases.html
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > Cheers
> > Tibor
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Gary Gregory-2
In reply to this post by Tibor Digana
This thread has the wrong VERSION in its subject.

Gary

On Sat, Mar 3, 2018 at 4:42 AM, Tibor Digana <[hidden email]> wrote:

> Hi,
>
> We solved 33 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> projectId=12317927&version=12341630
>
> There are still a couple of issues left in JIRA:
> <a href="https://issues.apache.org/jira/i#issues/?jql=project+%">https://issues.apache.org/jira/i#issues/?jql=project+%
> 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1402/
> https://repository.apache.org/content/repositories/maven-
> 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
> release.zip
>
> Source release checksum(s):
> surefire-2.21.0-source-release.zip sha1:
> 6927024eefa0b8c80dee70efa014f1f421d7844b
>
> Staging site:
> http://maven.apache.org/surefire-archives/surefire-LATEST/
>
> Guide to testing staged releases:
> http://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Cheers
> Tibor
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Tibor Digana
Hi Enrico, Karl, Herve,

We reported the issues [1] found during the Vote. They are fixed in
branches [2] and CI builds [3].
We can make a code review.
Additionally, we fixed SUREFIRE-1490 which was in progress but we did not
have spare time to include it in the Release 2.21.0. Now it is fixed in [4].

[1]:
https://issues.apache.org/jira/browse/SUREFIRE-1495
https://issues.apache.org/jira/browse/SUREFIRE-1498

[2]:
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=c496ebf3b4518c25787d5eac9f54b2a220a59447
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=af7ae9ef933873a038b2817d6430859f2a5bd1c7

[3]:
https://builds.apache.org/job/maven-wip/job/maven-surefire/job/SUREFIRE-1495/4/
https://builds.apache.org/job/maven-wip/job/maven-surefire/job/SUREFIRE-1498/1/

[4]:
https://issues.apache.org/jira/browse/SUREFIRE-1490
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=6174be76f52ffc2873a18a5215f60767843d7479
https://builds.apache.org/job/maven-wip/job/maven-surefire/job/SUREFIRE-1490/2/

Cheers
Tibor


On Tue, Mar 6, 2018 at 5:33 PM, Tibor Digana <[hidden email]> wrote:

> Hello Gary, yes but my typo was corrected in the second e-mail.
>
> On Tue, Mar 6, 2018 at 5:16 PM, Gary Gregory <[hidden email]>
> wrote:
>
>> This thread has the wrong VERSION in its subject.
>>
>> Gary
>>
>> On Sat, Mar 3, 2018 at 4:42 AM, Tibor Digana <[hidden email]>
>> wrote:
>>
>> > Hi,
>> >
>> > We solved 33 issues:
>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> > projectId=12317927&version=12341630
>> >
>> > There are still a couple of issues left in JIRA:
>> > <a href="https://issues.apache.org/jira/i#issues/?jql=project+%">https://issues.apache.org/jira/i#issues/?jql=project+%
>> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
>> >
>> > Staging repo:
>> > https://repository.apache.org/content/repositories/maven-1402/
>> > https://repository.apache.org/content/repositories/maven-
>> > 1402/org/apache/maven/surefire/surefire/2.21.0/surefire-2.21.0-source-
>> > release.zip
>> >
>> > Source release checksum(s):
>> > surefire-2.21.0-source-release.zip sha1:
>> > 6927024eefa0b8c80dee70efa014f1f421d7844b
>> >
>> > Staging site:
>> > http://maven.apache.org/surefire-archives/surefire-LATEST/
>> >
>> > Guide to testing staged releases:
>> > http://maven.apache.org/guides/development/guide-testing-releases.html
>> >
>> > Vote open for 72 hours.
>> >
>> > [ ] +1
>> > [ ] +0
>> > [ ] -1
>> >
>> > Cheers
>> > Tibor
>> >
>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Surefire Plugin version 2.20.1

Jeff Jensen
Hi Tibor,

> I should maybe write some limitations regarding length of IT
class/method/package and length of Git branch name in README.md due to
problems with Windows paths length.

In case this helps: instead of shortening names for the Windows path length
limitation, we can configure Windows and Git:

1. For recent Windows versions, set this to 1 (0 is
disabled): HKEY_LOCAL_MACHINE\SYSTEM\CurrentControlSet\Control\FileSystem
-> LongPathsEnabled

2.  git config --global core.longpaths true
  Caveat per git doc and mitigated with step 1:

Enable long path (> 260) support for builtin commands in Git for Windows.
This is disabled by default, as long paths are not supported by Windows
Explorer, cmd.exe and the Git for Windows tool chain (msys, bash, tcl,
perl…​). Only enable this if you know what you’re doing and are prepared to
live with a few quirks.

On Sat, Mar 17, 2018 at 11:12 AM, Tibor Digana <[hidden email]>
wrote:

> I will push the Jira 1490 first.
> Sorry it took some time. Last days we solved issues INFRA-16168 and
> INFRA-16191.
> I should maybe write some limitations regarding length of IT
> class/method/package and length of Git branch name in README.md due to
> problems with Windows paths length.
>
> On Fri, Mar 9, 2018 at 11:12 AM, Enrico Olivelli <[hidden email]>
> wrote:
>
> > 2018-03-09 9:55 GMT+01:00 Tibor Digana <[hidden email]>:
> >
> > > Hi Enrico, Karl, Herve,
> > >
> > > We reported the issues [1] found during the Vote. They are fixed in
> > > branches [2] and CI builds [3].
> > > We can make a code review.
> > > Additionally, we fixed SUREFIRE-1490 which was in progress but we did
> not
> > > have spare time to include it in the Release 2.21.0. Now it is fixed in
> > [4].
> > >
> >
> >
> >
> > Thank you Tibor,
> > I did not have time to create issues yet and you already have resolved
> them
> > !!
> >
> > I can confirm that I am now using 2.21.0 and I am really happy with it.
> >
> > I have reviewed your commits and they looks good to me,
> > today I do not have time to test your fixes on my "real" projects but
> > surely I will do it next week, I guess we will not release 3.0.0M1
> > immediately
> >
> > Cheers
> > Enrico
> >
> >
> >
> > >
> > > [1]:
> > > https://issues.apache.org/jira/browse/SUREFIRE-1495
> > > https://issues.apache.org/jira/browse/SUREFIRE-1498
> > >
> > > [2]:
> > > https://git1-us-west.apache.org/repos/asf?p=maven-
> > surefire.git;a=commit;h=
> > > c496ebf3b4518c25787d5eac9f54b2a220a59447
> > > https://git1-us-west.apache.org/repos/asf?p=maven-
> > surefire.git;a=commit;h=
> > > af7ae9ef933873a038b2817d6430859f2a5bd1c7
> > >
> > > [3]:
> > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
> > > job/SUREFIRE-1495/4/
> > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
> > > job/SUREFIRE-1498/1/
> > >
> > > [4]:
> > > https://issues.apache.org/jira/browse/SUREFIRE-1490
> > > https://git1-us-west.apache.org/repos/asf?p=maven-
> > surefire.git;a=commit;h=
> > > 6174be76f52ffc2873a18a5215f60767843d7479
> > > https://builds.apache.org/job/maven-wip/job/maven-surefire/
> > > job/SUREFIRE-1490/2/
> > >
> > > Cheers
> > > Tibor
> > >
> > >
> > > On Tue, Mar 6, 2018 at 5:33 PM, Tibor Digana <[hidden email]>
> > > wrote:
> > >
> > >> Hello Gary, yes but my typo was corrected in the second e-mail.
> > >>
> > >> On Tue, Mar 6, 2018 at 5:16 PM, Gary Gregory <[hidden email]>
> > >> wrote:
> > >>
> > >>> This thread has the wrong VERSION in its subject.
> > >>>
> > >>> Gary
> > >>>
> > >>> On Sat, Mar 3, 2018 at 4:42 AM, Tibor Digana <[hidden email]
> >
> > >>> wrote:
> > >>>
> > >>> > Hi,
> > >>> >
> > >>> > We solved 33 issues:
> > >>> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > >>> > projectId=12317927&version=12341630
> > >>> >
> > >>> > There are still a couple of issues left in JIRA:
> > >>> > <a href="https://issues.apache.org/jira/i#issues/?jql=project+%">https://issues.apache.org/jira/i#issues/?jql=project+%
> > >>> > 3D+SUREFIRE+AND+status+%3D+Open+ORDER+BY+priority+DESC
> > >>> >
> > >>> > Staging repo:
> > >>> > https://repository.apache.org/content/repositories/maven-1402/
> > >>> > https://repository.apache.org/content/repositories/maven-
> > >>> > 1402/org/apache/maven/surefire/surefire/2.21.0/
> > surefire-2.21.0-source-
> > >>> > release.zip
> > >>> >
> > >>> > Source release checksum(s):
> > >>> > surefire-2.21.0-source-release.zip sha1:
> > >>> > 6927024eefa0b8c80dee70efa014f1f421d7844b
> > >>> >
> > >>> > Staging site:
> > >>> > http://maven.apache.org/surefire-archives/surefire-LATEST/
> > >>> >
> > >>> > Guide to testing staged releases:
> > >>> > http://maven.apache.org/guides/development/guide-
> > testing-releases.html
> > >>> >
> > >>> > Vote open for 72 hours.
> > >>> >
> > >>> > [ ] +1
> > >>> > [ ] +0
> > >>> > [ ] -1
> > >>> >
> > >>> > Cheers
> > >>> > Tibor
> > >>> >
> > >>>
> > >>
> > >>
> > >
> >
>