Re: [VOTE] Release Apache Maven Resolver version 1.1.1

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Resolver version 1.1.1

Hervé BOUTEMY
I'm not sure releasing Maven Resolver Ant Tasks in the same time as Maven
Resolver is ideal:
MR Ant Tasks 1.1.1 depends on Maven core artifacts version 3.5.0 (maven-
resolver-provider and its dependencies) and Maven Resolver 1.1.1

But Maven core 3.5.0 depends on Maven Resolver 1.0.3
Maven Resolver 1.1.1 will only be used by future Maven core 3.5.3


ideally, MR Ant Tasks should depend on the first Maven core version  that uses
Maven Resolver with the same version

I don't think we have made much changes in maven-resolver-provider, then I
don't really fear some bugs: it's just a question of clarity if something
subtle happens.

Notice, once this is told, MR Ant Tasks should perhaps get the version used of
maven-resolver-provider.

IMHO, this does not block this release, but is just to discuss and keep in
mind for later MR Ant Tasks releases.

Regards,

Hervé

Le jeudi 15 février 2018, 20:25:31 CET Robert Scholte a écrit :

> Hi,
>
> We solved 3 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&ve
> rsion=12341378&styleName=Text
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%2012320628%20AND%20
> status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1395/
> https://repository.apache.org/content/repositories/maven-1395/org/apache/mav
> en/resolver/maven-resolver/1.1.1/maven-resolver-1.1.1-source-release.zip
> https://repository.apache.org/content/repositories/maven-1395/org/apache/ma
> ven/resolver/maven-resolver-ant-tasks/1.1.1/maven-resolver-ant-tasks-1.1.1-s
> ource-release.zip
>
> Source release checksum(s):
> maven-resolver-1.1.1-source-release.zip           sha1:
> 8e98446e93e2810c84257194c67568e069765602
> maven-resolver-ant-tasks-1.1.1-source-release.zip sha1:
> 5953defeb41258eb47a1d10ce534e9b4bc5b74c4
>
> Staging site:
> https://maven.apache.org/resolver-archives/resolver-LATEST/
> https://maven.apache.org/resolver-archives/resolver-ant-tasks-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Resolver version 1.1.1

rfscholte
+1

On Thu, 15 Feb 2018 20:25:31 +0100, Robert Scholte <[hidden email]>  
wrote:

> Hi,
>
> We solved 3 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&version=12341378&styleName=Text
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%2012320628%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1395/
> https://repository.apache.org/content/repositories/maven-1395/org/apache/maven/resolver/maven-resolver/1.1.1/maven-resolver-1.1.1-source-release.zip
> https://repository.apache.org/content/repositories/maven-1395/org/apache/maven/resolver/maven-resolver-ant-tasks/1.1.1/maven-resolver-ant-tasks-1.1.1-source-release.zip
>
> Source release checksum(s):
> maven-resolver-1.1.1-source-release.zip           sha1:  
> 8e98446e93e2810c84257194c67568e069765602
> maven-resolver-ant-tasks-1.1.1-source-release.zip sha1:  
> 5953defeb41258eb47a1d10ce534e9b4bc5b74c4
>
> Staging site:
> https://maven.apache.org/resolver-archives/resolver-LATEST/
> https://maven.apache.org/resolver-archives/resolver-ant-tasks-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Resolver version 1.1.1

rfscholte
In reply to this post by Hervé BOUTEMY
Without talking about the dependencies: what it the main purpose of Maven  
Resolver Ant Tasks:
- is it the ability the use Maven Resolver as part of your Ant builds?  
This is what I would expect and why it makes sense to resolve these 2 at  
once. However that would not explain the dependencies on Maven.
- is it the ability to use dependency resolution with the logic from  
Maven? AFAIK resolution logic is inside the maven-resolver-provider and  
not core. But this could be a reason to release these Ant tasks at the  
same time as the Maven Distribution, so the version reflects the  
resolution implementation of Maven.

Or is it something else?

thanks,
Robert

On Sat, 17 Feb 2018 18:21:28 +0100, Hervé BOUTEMY <[hidden email]>  
wrote:

> I'm not sure releasing Maven Resolver Ant Tasks in the same time as Maven
> Resolver is ideal:
> MR Ant Tasks 1.1.1 depends on Maven core artifacts version 3.5.0 (maven-
> resolver-provider and its dependencies) and Maven Resolver 1.1.1
>
> But Maven core 3.5.0 depends on Maven Resolver 1.0.3
> Maven Resolver 1.1.1 will only be used by future Maven core 3.5.3
>
>
> ideally, MR Ant Tasks should depend on the first Maven core version  
> that uses
> Maven Resolver with the same version
>
> I don't think we have made much changes in maven-resolver-provider, then  
> I
> don't really fear some bugs: it's just a question of clarity if something
> subtle happens.
>
> Notice, once this is told, MR Ant Tasks should perhaps get the version  
> used of
> maven-resolver-provider.
>
> IMHO, this does not block this release, but is just to discuss and keep  
> in
> mind for later MR Ant Tasks releases.
>
> Regards,
>
> Hervé
>
> Le jeudi 15 février 2018, 20:25:31 CET Robert Scholte a écrit :
>> Hi,
>>
>> We solved 3 issues:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&ve
>> rsion=12341378&styleName=Text
>>
>> There are still a couple of issues left in JIRA:
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%2012320628%20AND%20
>> status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
>>
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-1395/
>> https://repository.apache.org/content/repositories/maven-1395/org/apache/mav
>> en/resolver/maven-resolver/1.1.1/maven-resolver-1.1.1-source-release.zip
>> https://repository.apache.org/content/repositories/maven-1395/org/apache/ma
>> ven/resolver/maven-resolver-ant-tasks/1.1.1/maven-resolver-ant-tasks-1.1.1-s
>> ource-release.zip
>>
>> Source release checksum(s):
>> maven-resolver-1.1.1-source-release.zip           sha1:
>> 8e98446e93e2810c84257194c67568e069765602
>> maven-resolver-ant-tasks-1.1.1-source-release.zip sha1:
>> 5953defeb41258eb47a1d10ce534e9b4bc5b74c4
>>
>> Staging site:
>> https://maven.apache.org/resolver-archives/resolver-LATEST/
>> https://maven.apache.org/resolver-archives/resolver-ant-tasks-LATEST/
>>
>> Guide to testing staged releases:
>> https://maven.apache.org/guides/development/guide-testing-releases.html
>>
>> Vote open for at least 72 hours.
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Resolver version 1.1.1

rfscholte
In reply to this post by Hervé BOUTEMY
It seems like I can delete parts of the staging repo, which means it  
should be possible to only release maven-resolver-1.1.1

Otherwise I have to drop the complete staging repo and start over with  
just maven-resolver.

Robert

On Mon, 19 Feb 2018 08:29:06 +0100, Hervé BOUTEMY <[hidden email]>  
wrote:

> +1 on maven-resolver-1.1.1-source-release.zip
>
> -1 on maven-resolver-ant-tasks-1.1.1-source-release.zip: it simply does  
> not work, just build with "-Prun-its" to see
> it seems there is an issue with shading configuration
> $ unzip -t target/maven-resolver-ant-tasks-1.1.1-uber.jar | grep  
> antlib.xml
>     testing:  
> org/apache/maven/resolver/internal/ant/org/apache/maven/resolver/ant/antlib.xml    
> OK
>
> notice I did not get any feedback on the releasing strategy for Ant  
> Tasks.
> But if the Ant tasks had worked, I would not have voted -1
>
> Regards,
>
> Hervé
>
> Le jeudi 15 février 2018, 20:25:31 CET Robert Scholte a écrit :
>> Hi,
>>
>> We solved 3 issues:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628&ve
>> rsion=12341378&styleName=Text
>>
>> There are still a couple of issues left in JIRA:
>> https://issues.apache.org/jira/issues/?jql=project%20%3D%2012320628%20AND%20
>> status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
>>
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-1395/
>> https://repository.apache.org/content/repositories/maven-1395/org/apache/mav
>> en/resolver/maven-resolver/1.1.1/maven-resolver-1.1.1-source-release.zip
>> https://repository.apache.org/content/repositories/maven-1395/org/apache/ma
>> ven/resolver/maven-resolver-ant-tasks/1.1.1/maven-resolver-ant-tasks-1.1.1-s
>> ource-release.zip
>>
>> Source release checksum(s):
>> maven-resolver-1.1.1-source-release.zip           sha1:
>> 8e98446e93e2810c84257194c67568e069765602
>> maven-resolver-ant-tasks-1.1.1-source-release.zip sha1:
>> 5953defeb41258eb47a1d10ce534e9b4bc5b74c4
>>
>> Staging site:
>> https://maven.apache.org/resolver-archives/resolver-LATEST/
>> https://maven.apache.org/resolver-archives/resolver-ant-tasks-LATEST/
>>
>> Guide to testing staged releases:
>> https://maven.apache.org/guides/development/guide-testing-releases.html
>>
>> Vote open for at least 72 hours.
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Resolver version 1.1.1

Hervé BOUTEMY
yes, if you can delete parts of the staging repo, it would be easier than
redoing the full release

Regards,

Hervé

Le lundi 19 février 2018, 19:08:29 CET Robert Scholte a écrit :

> It seems like I can delete parts of the staging repo, which means it
> should be possible to only release maven-resolver-1.1.1
>
> Otherwise I have to drop the complete staging repo and start over with
> just maven-resolver.
>
> Robert
>
> On Mon, 19 Feb 2018 08:29:06 +0100, Hervé BOUTEMY <[hidden email]>
>
> wrote:
> > +1 on maven-resolver-1.1.1-source-release.zip
> >
> > -1 on maven-resolver-ant-tasks-1.1.1-source-release.zip: it simply does
> > not work, just build with "-Prun-its" to see
> > it seems there is an issue with shading configuration
> > $ unzip -t target/maven-resolver-ant-tasks-1.1.1-uber.jar | grep
> > antlib.xml
> >
> >     testing:
> > org/apache/maven/resolver/internal/ant/org/apache/maven/resolver/ant/antli
> > b.xml OK
> >
> > notice I did not get any feedback on the releasing strategy for Ant
> > Tasks.
> > But if the Ant tasks had worked, I would not have voted -1
> >
> > Regards,
> >
> > Hervé
> >
> > Le jeudi 15 février 2018, 20:25:31 CET Robert Scholte a écrit :
> >> Hi,
> >>
> >> We solved 3 issues:
> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628
> >> &ve rsion=12341378&styleName=Text
> >>
> >> There are still a couple of issues left in JIRA:
> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%2012320628%20AND
> >> %20 status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
> >>
> >> Staging repo:
> >> https://repository.apache.org/content/repositories/maven-1395/
> >> https://repository.apache.org/content/repositories/maven-1395/org/apache/
> >> mav
> >> en/resolver/maven-resolver/1.1.1/maven-resolver-1.1.1-source-release.zip
> >> https://repository.apache.org/content/repositories/maven-1395/org/apache
> >> /ma
> >> ven/resolver/maven-resolver-ant-tasks/1.1.1/maven-resolver-ant-tasks-1.1
> >> .1-s ource-release.zip
> >>
> >> Source release checksum(s):
> >> maven-resolver-1.1.1-source-release.zip           sha1:
> >> 8e98446e93e2810c84257194c67568e069765602
> >> maven-resolver-ant-tasks-1.1.1-source-release.zip sha1:
> >> 5953defeb41258eb47a1d10ce534e9b4bc5b74c4
> >>
> >> Staging site:
> >> https://maven.apache.org/resolver-archives/resolver-LATEST/
> >> https://maven.apache.org/resolver-archives/resolver-ant-tasks-LATEST/
> >>
> >> Guide to testing staged releases:
> >> https://maven.apache.org/guides/development/guide-testing-releases.html
> >>
> >> Vote open for at least 72 hours.
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Resolver version 1.1.1

Hervé BOUTEMY
In reply to this post by rfscholte
Le lundi 19 février 2018, 19:06:31 CET Robert Scholte a écrit :
> Without talking about the dependencies: what it the main purpose of Maven
> Resolver Ant Tasks:
> - is it the ability the use Maven Resolver as part of your Ant builds?
+1

> This is what I would expect and why it makes sense to resolve these 2 at
> once. However that would not explain the dependencies on Maven.
> - is it the ability to use dependency resolution with the logic from
> Maven?
+1

> AFAIK resolution logic is inside the maven-resolver-provider and
> not core.
ah, here, there is a misunderstanding on what "Maven core" means: here, Maven
core is the full list of Maven artifacts, including maven-resolver-provider
see http://maven.apache.org/ref/3.5.2/

not only the maven-core artifact, which is only one artifact of Maven core

Yes, we're talking for years about Maven core, which is different from maven-
core artifact...

> But this could be a reason to release these Ant tasks at the
> same time as the Maven Distribution, so the version reflects the
> resolution implementation of Maven.
yes, we could do the release of Maven Resolver Ant Tasks at the same time as
we release Maven
But I'm not sure this would really help people understand
I think we'd better do Maven Resolver Ant Tasks as a separate release vote:
easier and safer (if we find a bug like currently we found)

Regards,

Hervé

>
> Or is it something else?
>
> thanks,
> Robert
>
> On Sat, 17 Feb 2018 18:21:28 +0100, Hervé BOUTEMY <[hidden email]>
>
> wrote:
> > I'm not sure releasing Maven Resolver Ant Tasks in the same time as Maven
> > Resolver is ideal:
> > MR Ant Tasks 1.1.1 depends on Maven core artifacts version 3.5.0 (maven-
> > resolver-provider and its dependencies) and Maven Resolver 1.1.1
> >
> > But Maven core 3.5.0 depends on Maven Resolver 1.0.3
> > Maven Resolver 1.1.1 will only be used by future Maven core 3.5.3
> >
> >
> > ideally, MR Ant Tasks should depend on the first Maven core version
> > that uses
> > Maven Resolver with the same version
> >
> > I don't think we have made much changes in maven-resolver-provider, then
> > I
> > don't really fear some bugs: it's just a question of clarity if something
> > subtle happens.
> >
> > Notice, once this is told, MR Ant Tasks should perhaps get the version
> > used of
> > maven-resolver-provider.
> >
> > IMHO, this does not block this release, but is just to discuss and keep
> > in
> > mind for later MR Ant Tasks releases.
> >
> > Regards,
> >
> > Hervé
> >
> > Le jeudi 15 février 2018, 20:25:31 CET Robert Scholte a écrit :
> >> Hi,
> >>
> >> We solved 3 issues:
> >> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12320628
> >> &ve rsion=12341378&styleName=Text
> >>
> >> There are still a couple of issues left in JIRA:
> >> https://issues.apache.org/jira/issues/?jql=project%20%3D%2012320628%20AND
> >> %20 status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
> >>
> >> Staging repo:
> >> https://repository.apache.org/content/repositories/maven-1395/
> >> https://repository.apache.org/content/repositories/maven-1395/org/apache/
> >> mav
> >> en/resolver/maven-resolver/1.1.1/maven-resolver-1.1.1-source-release.zip
> >> https://repository.apache.org/content/repositories/maven-1395/org/apache
> >> /ma
> >> ven/resolver/maven-resolver-ant-tasks/1.1.1/maven-resolver-ant-tasks-1.1
> >> .1-s ource-release.zip
> >>
> >> Source release checksum(s):
> >> maven-resolver-1.1.1-source-release.zip           sha1:
> >> 8e98446e93e2810c84257194c67568e069765602
> >> maven-resolver-ant-tasks-1.1.1-source-release.zip sha1:
> >> 5953defeb41258eb47a1d10ce534e9b4bc5b74c4
> >>
> >> Staging site:
> >> https://maven.apache.org/resolver-archives/resolver-LATEST/
> >> https://maven.apache.org/resolver-archives/resolver-ant-tasks-LATEST/
> >>
> >> Guide to testing staged releases:
> >> https://maven.apache.org/guides/development/guide-testing-releases.html
> >>
> >> Vote open for at least 72 hours.
> >>
> >> [ ] +1
> >> [ ] +0
> >> [ ] -1
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]