Re: [VOTE] Release Apache Maven Plugin Tools version 3.5.1

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Plugin Tools version 3.5.1

Karl Heinz Marbaise-3
Hi,

Using the following Maven versions for testing
Apache Maven 3.0.5 (r01de14724cdef164cd33c7c8c2fe155faf9602da;
2013-02-19 14:51:28+0100)
Apache Maven 3.1.1 (0728685237757ffbf44136acec0402957f723d9a; 2013-09-17
17:22:22+0200)
Apache Maven 3.2.5 (12a6b3acb947671f09b81f49094c53f426d8cea1;
2014-12-14T18:29:23+01:00)
Apache Maven 3.3.1 (cab6659f9874fa96462afef40fcf6bc033d58c1c;
2015-03-13T21:10:27+01:00)
Apache Maven 3.3.9 (bb52d8502b132ec0a5a3f4c09453c07478323dc5;
2015-11-10T17:41:47+01:00)
Apache Maven 3.5.0 (ff8f5e7444045639af65f6095c62210b5713f426;
2017-04-03T21:39:06+02:00)
Apache Maven 3.5.2 (138edd61fd100ec658bfa2d307c43b76940a5d7d;
2017-10-18T09:58:13+02:00)
Apache Maven 3.5.3-SNAPSHOT (899f452522ab811872e09d2f863b3b05d58ae173;
2017-12-22T16:05:53+01:00)
Start testing...
jdk1.7.0_79.jdk
   apache-maven-3.0.5..Unpacking done.Building failed.
   apache-maven-3.1.1..Unpacking done.Building failed.
   apache-maven-3.2.5..Unpacking donBuilding fine...
   apache-maven-3.3.1..Unpacking done.Building fine.
   apache-maven-3.3.9..Unpacking done.Building fine.
   apache-maven-3.5.0..Unpacking done.Building fine.
   apache-maven-3.5.2..Unpacking done.Building fine.
   apache-maven-3.5.3-SNAPSHOT..Unpacking donBuilding fine...
jdk1.8.0_131.jdk
   apache-maven-3.0.5..Unpacking done.Building failed.
   apache-maven-3.1.1..Unpacking done.Building failed.
   apache-maven-3.2.5..Unpacking done.Building fine.
   apache-maven-3.3.1..Unpacking done.Building fine.
   apache-maven-3.3.9..Unpacking done.Building fine.
   apache-maven-3.5.0..Unpacking done.Building fine.
   apache-maven-3.5.2..Unpacking done.Building fine.
   apache-maven-3.5.3-SNAPSHOT..Unpacking donBuilding fine...
jdk1.8.0_144.jdk
   apache-maven-3.0.5..Unpacking done.Building failed.
   apache-maven-3.1.1..Unpacking done.Building failed.
   apache-maven-3.2.5..Unpacking done.Building fine.
   apache-maven-3.3.1..Unpacking done.Building fine.
   apache-maven-3.3.9..Unpacking done.Building fine.
   apache-maven-3.5.0..Unpacking done.Building fine.
   apache-maven-3.5.2..Unpacking done.Building fine.
   apache-maven-3.5.3-SNAPSHOT..Unpacking done.Building fine.
jdk-9.0.1.jdk
   apache-maven-3.0.5..Unpacking donBuilding failed.
   apache-maven-3.1.1..Unpacking done.Building failed.
   apache-maven-3.2.5..Unpacking done.Building fine.
   apache-maven-3.3.1..Unpacking done.Building fine.
   apache-maven-3.3.9..Unpacking done.Building fine.
   apache-maven-3.5.0..Unpacking done.Building fine.
   apache-maven-3.5.2..Unpacking done.Building fine.
   apache-maven-3.5.3-SNAPSHOT..Unpacking done.Building fine.





So failing in JDK 7, JDK 8 for Maven 3.0.5, 3.1.1 for the asm-failure (IT):
[INFO] --- maven-plugin-plugin:3.5.1:descriptor (default-descriptor) @
asm-failure ---
[INFO] Using 'UTF-8' encoding to read mojo source files.
[WARNING] Error analyzing class
com/ibm/icu/impl/data/LocaleElements_zh__PINYIN.class in
/Users/kama/maven-release-checker/release-test/jdk1.7.0_79.jdk/apache-maven-3.0.5/maven-plugin-tools-3.5.1/maven-plugin-plugin/target/local-repo/com/ibm/icu/icu4j/2.6.1/icu4j-2.6.1.jar:
ignoring class
[INFO] java-annotations mojo extractor found 0 mojo descriptor.
[INFO] java-javadoc mojo extractor found 0 mojo descriptor.


for Maven 3.2.5+ on JDK 7 and JDK 8..got the correct output for the IT:

[INFO] --- maven-plugin-plugin:3.5.1:descriptor (default-descriptor) @
asm-failure ---
[INFO] Using 'UTF-8' encoding to read mojo source files.
[WARNING] Error analyzing class
com/ibm/icu/impl/data/LocaleElements_zh__PINYIN.class in
/Users/kama/maven-release-checker/release-test/jdk1.7.0_79.jdk/apache-maven-3.2.5/maven-plugin-tools-3.5.1/maven-plugin-plugin/target/local-repo/com/ibm/icu/icu4j/2.6.1/icu4j-2.6.1.jar:
ignoring class
[INFO] java-annotations mojo extractor found 1 mojo descriptor.
[INFO] java-javadoc mojo extractor found 0 mojo descriptor.

Furthermore:

The second part failing looks like this (JDK 9 related):

[INFO] Maven Plugin Tools Javadoc Taglets ................ FAILURE [0.021s]
[INFO] Maven Script Mojo Support ......................... SKIPPED
...
[ERROR] Failed to execute goal on project maven-plugin-tools-javadoc:
Could not resolve dependencies for project
org.apache.maven.plugin-tools:maven-plugin-tools-javadoc:jar:3.5.1:
Could not find artifact com.sun:tools:jar:1.4.2 at specified path
/Library/Java/JavaVirtualMachines/jdk-9.0.1.jdk/Contents/Home/../lib/tools.jar
-> [Help 1]


[WARNING] Some problems were encountered while building the effective
model for org.apache.maven.plugin-tools:maven-plugin-tools-javadoc:jar:3.5.1
[WARNING] 'dependencies.dependency.systemPath' for com.sun:tools:jar
refers to a non-existing file
/Library/Java/JavaVirtualMachines/jdk-9.0.1.jdk/Contents/Home/../lib/tools.jar.
Please verify that you run Maven using a JDK and not just a JRE. @ line
104, column 23

So it seemed to be activated in contradiction to my expectations...


So If i correctly see is that it means that the wrong activation of the
profile only happens in Maven 3.0.5 and Maven 3.1.1 for JDK 9..

This seemed to be related to the profile activation in Taglets which
seemed to be wrong...cause they are using a range like this:

<jdk>(,1.9)</jdk>

but for JDK 9 the version is 9.0.0 or 9.0.1 so
<jdk>(,9.0.0)</jdk>..

which means the above profile is activated for JDK 9 which is wrong
...I'm asking myself why...


Which I would say is not a release blocker...cause for JDK 9 dev you
should use the most recent version of Maven anyway...


I can offer the whole log files if you like...(ca. 20 MiB).

So +1 from me...

Kind regards
Karl Heinz Marbaise





On 19/01/18 19:08, Hervé BOUTEMY wrote:

> Hi,
>      
> We solved 15 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820&version=12338196&styleName=Text
>      
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MPLUGIN%20AND%20status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
>      
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1390/
> https://repository.apache.org/content/repositories/maven-1390/org/apache/maven/plugin-tools/maven-plugin-tools/3.5.1/maven-plugin-tools-3.5.1-source-release.zip
>      
> Source release checksum(s):
> maven-plugin-tools-3.5.1-source-release.zip sha1: d4a5b366f7ec8a5f6541025ad2ec9bfd35bf7210
>      
> Staging site:
> https://maven.apache.org/plugin-tools-archives/plugin-tools-LATEST/
>      
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>      
> Vote open for at least 72 hours.
>      
> [ ] +1
> [ ] +0
> [ ] -1
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Plugin Tools version 3.5.1

Hervé BOUTEMY
oh, true: I'll fix it, it's easy, but not now since it trigger a surprise in our Jenkins job
= the failure is not detected
see https://builds.apache.org/view/M-R/view/Maven/job/maven-box/job/maven-plugin-tools/job/master/

the failure on Windows node happens,  but is not detected by our Jenkinsfile :(

Regards,

Hervé

Le dimanche 21 janvier 2018, 14:01:24 CET Robert Scholte a écrit :

> +1
>
> However, the asm-failure is not Windows-proof:
>
> [INFO] --- maven-plugin-plugin:3.5.1:descriptor (default-descriptor) @
> asm-failure ---
>         [INFO] Using 'UTF-8' encoding to read mojo source files.
>         [INFO] java-javadoc mojo extractor found 0 mojo descriptor.
>         [WARNING] Error analyzing class
> com/ibm/icu/impl/data/LocaleElements_zh__PINYIN.class in
> E:\tmp-staging\maven-plugin-tools-3.5.1\maven-plugin-plugin\target\local-rep
> o\com\ibm\icu\icu4j\2.6.1\icu4j-2.6.1.jar: ignoring class
>         [INFO] java-annotations mojo extractor found 1 mojo descriptor.
>
> Verify.groofy:
> assert build.contains( "com/ibm/icu/icu4j/2.6.1/icu4j-2.6.1.jar: ignoring
> class" )
>
> thanks,
> Robert
>
> On Fri, 19 Jan 2018 19:08:34 +0100, Hervé BOUTEMY <[hidden email]>
>
> wrote:
> > Hi,
> > We solved 15 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820&
> > version=12338196&styleName=Text There are still a couple of issues left in
> > JIRA:
> > <a href="https://issues.apache.org/jira/issues/?jql=project%20%3D%20MPLUGIN%20AND%2">https://issues.apache.org/jira/issues/?jql=project%20%3D%20MPLUGIN%20AND%2
> > 0status%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1390/
> > https://repository.apache.org/content/repositories/maven-1390/org/apache/m
> > aven/plugin-tools/maven-plugin-tools/3.5.1/maven-plugin-tools-3.5.1-source
> > -release.zip Source release checksum(s):
> > maven-plugin-tools-3.5.1-source-release.zip sha1:
> > d4a5b366f7ec8a5f6541025ad2ec9bfd35bf7210
> > Staging site:
> > https://maven.apache.org/plugin-tools-archives/plugin-tools-LATEST/
> > Guide to testing staged releases:
> > https://maven.apache.org/guides/development/guide-testing-releases.html
> > Vote open for at least 72 hours.
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven Plugin Tools version 3.5.1

Hervé BOUTEMY
In reply to this post by Karl Heinz Marbaise-3
here is my +1

Regards,

Hervé

Le vendredi 19 janvier 2018, 19:08:34 CET Hervé BOUTEMY a écrit :

> Hi,
>
> We solved 15 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317820&ve
> rsion=12338196&styleName=Text
>
> There are still a couple of issues left in JIRA:
> https://issues.apache.org/jira/issues/?jql=project%20%3D%20MPLUGIN%20AND%20s
> tatus%20%3D%20Open%20ORDER%20BY%20key%20DESC%2C%20priority%20DESC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1390/
> https://repository.apache.org/content/repositories/maven-1390/org/apache/mav
> en/plugin-tools/maven-plugin-tools/3.5.1/maven-plugin-tools-3.5.1-source-rel
> ease.zip
>
> Source release checksum(s):
> maven-plugin-tools-3.5.1-source-release.zip sha1:
> d4a5b366f7ec8a5f6541025ad2ec9bfd35bf7210
>
> Staging site:
> https://maven.apache.org/plugin-tools-archives/plugin-tools-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]