Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)

Manfred Moser-4
+1

Ship it.

Karl Heinz Marbaise wrote on 2017-09-09 06:52:

> Hi,
>
> this is the VOTE for the first public release for Maven JMod Plugin...
>
> We solved 1 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363
>
> There are currently no issues left in JIRA.
>
> If you have any issue to report please open an issue in JIRA
> https://issues.apache.org/jira/projects/MJMOD
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1361/
>
> https://repository.apache.org/content/repositories/maven-1361/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip
>
> Source release checksum(s):
> [NAME-OF]-source-release.zip sha1: 8002767f6cffc7bbbcf76a8e7f0c1799a42caf93
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Kind regards
> Karl Heinz Marbaise
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)

Robert Scholte-6
Hi,

isn't it weird that jmod:create has parameters for classpath and  
modulepath?
why not start using the dependencies as specified in the pom?

and the plugin shouldn't use artifactId as default for the modulename.
Current best practice is to include the packagename as namespace.
And if the module-info.class is there, it is also possible to extract this  
value with plexus-java

I'm sorry, but I have to give this a -1.
I can help fix these things.

Robert


On Sat, 09 Sep 2017 15:52:24 +0200, Karl Heinz Marbaise  
<[hidden email]> wrote:

> Hi,
>
> this is the VOTE for the first public release for Maven JMod Plugin...
>
> We solved 1 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363
>
> There are currently no issues left in JIRA.
>
> If you have any issue to report please open an issue in JIRA
> https://issues.apache.org/jira/projects/MJMOD
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1361/
>
> https://repository.apache.org/content/repositories/maven-1361/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip
>
> Source release checksum(s):
> [NAME-OF]-source-release.zip sha1:  
> 8002767f6cffc7bbbcf76a8e7f0c1799a42caf93
>
> Staging site:
> https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/
>
> Guide to testing staged releases:
> https://maven.apache.org/guides/development/guide-testing-releases.html
>
> Vote open for at least 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Kind regards
> Karl Heinz Marbaise
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven JMod Plugin version 3.0.0-alpha-1 (First Public Release)

Karl Heinz Marbaise-3
Hi Robert,

On 11/09/17 21:11, Robert Scholte wrote:

> Hi,
>
> isn't it weird that jmod:create has parameters for classpath and
> modulepath?
> why not start using the dependencies as specified in the pom?
>
> and the plugin shouldn't use artifactId as default for the modulename.
> Current best practice is to include the packagename as namespace.
> And if the module-info.class is there, it is also possible to extract
> this value with plexus-java
>
> I'm sorry, but I have to give this a -1.

No need to applogize...Very good hints...

> I can help fix these things.

>
> Robert
>
>
> On Sat, 09 Sep 2017 15:52:24 +0200, Karl Heinz Marbaise
> <[hidden email]> wrote:
>
>> Hi,
>>
>> this is the VOTE for the first public release for Maven JMod Plugin...
>>
>> We solved 1 issues:
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12321433&version=12341363 
>>
>>
>> There are currently no issues left in JIRA.
>>
>> If you have any issue to report please open an issue in JIRA
>> https://issues.apache.org/jira/projects/MJMOD
>>
>> Staging repo:
>> https://repository.apache.org/content/repositories/maven-1361/
>>
>> https://repository.apache.org/content/repositories/maven-1361/org/apache/maven/plugins/maven-jmod-plugin/3.0.0-alpha-1/maven-jmod-plugin-3.0.0-alpha-1-source-release.zip 
>>
>>
>> Source release checksum(s):
>> [NAME-OF]-source-release.zip sha1:
>> 8002767f6cffc7bbbcf76a8e7f0c1799a42caf93
>>
>> Staging site:
>> https://maven.apache.org/plugins-archives/maven-jmod-plugin-LATEST/
>>
>> Guide to testing staged releases:
>> https://maven.apache.org/guides/development/guide-testing-releases.html
>>
>> Vote open for at least 72 hours.
>>
>> [ ] +1
>> [ ] +0
>> [ ] -1
>>
>> Kind regards
>> Karl Heinz Marbaise
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


Mit freundlichem Gruß
Karl-Heinz Marbaise
--
SoftwareEntwicklung Beratung Schulung    Tel.: +49 (0) 2405 / 415 893
Dipl.Ing.(FH) Karl-Heinz Marbaise        USt.IdNr: DE191347579
Hauptstrasse 177
52146 Würselen                           http://www.soebes.de

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]