Re: [VOTE] Release Apache Maven 3.5.1

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Mark Derricutt

+0 non-commital -

Tested on our tiles/osgi based projects and all seems to work, but for some reason - one project that uses the org.openqa.selenium.phantomjs.PhantomJSDriverService seems to blowing up when using 3.5.1 - need to do some more digging and see if I can spot whats going on.

Will try and dig into this after work tonight.

Mark

On 11 Sep 2017, at 8:01, Arnaud Héritier wrote:

Tested on several projects

+1

On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly <
[hidden email]> wrote:

Hi,

We solved 25 issues:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?
version=12338964&styleName=Text&projectId=12316922

There are 350 issues left in JIRA for Maven core:
<a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC

Staging repo:
https://repository.apache.org/content/repositories/maven-1364/

The distributable binaries and sources can be found here:
https://repository.apache.org/content/repositories/maven-
1364/org/apache/maven/apache-maven/3.5.1/

Specifically the zip, tarball and source archives can be found here:
https://repository.apache.org/content/repositories/maven-
1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip
https://repository.apache.org/content/repositories/maven-
1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz
https://repository.apache.org/content/repositories/maven-
1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip
https://repository.apache.org/content/repositories/maven-
1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz

Source release checksum(s):
apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7
bd2059560d
apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab69e698eb0e

Git tag:
https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
094e4e31a5af55bb17be87675da41d9aeca062f3

Staging site:
https://maven.apache.org/components/ref/3-LATEST/

Vote open for 72 hours.

[ ] +1
[ ] +0
[ ] -1

Thanks,

Stephen.

--
-----
Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier


"The ease with which a change can be implemented has no relevance at all to whether it is the right change for the (Java) Platform for all time." — Mark Reinhold.

Mark Derricutt
http://www.theoryinpractice.net
http://www.chaliceofblood.net
http://plus.google.com/+MarkDerricutt
http://twitter.com/talios
http://facebook.com/mderricutt


signature.asc (494 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

stephenconnolly
Building the source bundles with the binary bundles in the staging repo
using the Dockerfile environments in
https://github.com/apache/maven-integration-testing/tree/master/environments

Debian JDK 7
===========

Linux 65fb832dfe43 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
GNU/Linux
Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
2017-09-10T12:42:54Z)
Maven home: /work/bin
Java version: 1.7.0_151, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"

mvn verify => SUCCESS

Debian JDK 8
===========

Linux 11ef1c114b6b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
GNU/Linux
Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
2017-09-10T12:42:54Z)
Maven home: /work/bin
Java version: 1.8.0_141, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
Default locale: en, platform encoding: UTF-8
OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"

mvn verify => SUCCESS

Fedora JDK 8
===========

Linux 54211a0e694e 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
x86_64 x86_64 GNU/Linux
Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
2017-09-10T12:42:54Z)
Maven home: /work/bin
Java version: 1.8.0_144, vendor: Oracle Corporation
Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.144-5.b01.fc26.x86_64/jre
Default locale: en_US, platform encoding: ANSI_X3.4-1968
OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"

mvn verify => SUCCESS

IBM JDK 8
========

Linux 199631edceed 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
x86_64 x86_64 GNU/Linux
Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
2017-09-10T12:42:54Z)
Maven home: /work/bin
Java version: 1.8.0, vendor: IBM Corporation
Java home: /opt/ibm/java/jre
Default locale: en_US, platform encoding: ANSI_X3.4-1968
OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"

mvn verify => SUCCESS

Asul Zulu JDK 8
=============

Linux 10e8f4e46138 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
x86_64 x86_64 GNU/Linux
Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
2017-09-10T12:42:54Z)
Maven home: /work/bin
Java version: 1.8.0_144, vendor: Azul Systems, Inc.
Java home: /usr/lib/jvm/zulu-8-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"

mvn verify => SUCCESS

If I get time later I'll run the integration tests.

On 11 September 2017 at 00:20, Dan Tran <[hidden email]> wrote:

> False alarm, I missed configure global settings.xml, it is missing the
> default repository setup
>
> -D
>
> On Sun, Sep 10, 2017 at 11:47 PM, Tibor Digana <
> [hidden email]>
> wrote:
>
> > +1:
> > 3.5.1 works in my project like a charm ;-)
> >
> > On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly <
> > [hidden email]> wrote:
> >
> > > Hi,
> > >
> > > We solved 25 issues:
> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > version=12338964&styleName=Text&projectId=12316922
> > >
> > > There are 350 issues left in JIRA for Maven core:
> > > <a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
> > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
> > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> > >
> > > Staging repo:
> > > https://repository.apache.org/content/repositories/maven-1364/
> > >
> > > The distributable binaries and sources can be found here:
> > > https://repository.apache.org/content/repositories/maven-
> > > 1364/org/apache/maven/apache-maven/3.5.1/
> > >
> > > Specifically the zip, tarball and source archives can be found here:
> > > https://repository.apache.org/content/repositories/maven-
> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip
> > > https://repository.apache.org/content/repositories/maven-
> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz
> > > https://repository.apache.org/content/repositories/maven-
> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip
> > > https://repository.apache.org/content/repositories/maven-
> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz
> > >
> > > Source release checksum(s):
> > > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7
> > > bd2059560d
> > > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab
> > 69e698eb0e
> > >
> > > Git tag:
> > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
> > > 094e4e31a5af55bb17be87675da41d9aeca062f3
> > >
> > > Staging site:
> > > https://maven.apache.org/components/ref/3-LATEST/
> > >
> > > Vote open for 72 hours.
> > >
> > > [ ] +1
> > > [ ] +0
> > > [ ] -1
> > >
> > > Thanks,
> > >
> > > Stephen.
> > >
> >
> >
> >
> > --
> > Cheers
> > Tibor
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

stephenconnolly
With
https://github.com/apache/maven-integration-testing/commit/a08d65bfb5fedec9f684c13bf5a0dccb96f5cc56
I was able to get Michael's test failures:

Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
2017-09-10T12:42:54Z)
Maven home: /work/bin
Java version: 1.7.0_154, vendor: Azul Systems, Inc.
Java home: /usr/lib/jvm/zulu-7-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"


-------------------------------------------------------------------------------
Test set: org.apache.maven.classrealm.DefaultClassRealmManagerTest
-------------------------------------------------------------------------------
Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 2.128 sec
<<< FAILURE! - in org.apache.maven.classrealm.DefaultClassRealmManagerTest
testMNG6275_mavenApiRealmDefaultParentClassLoader(org.apache.maven.classrealm.DefaultClassRealmManagerTest)
 Time elapsed: 1.12 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at
org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_mavenApiRealmDefaultParentClassLoader(DefaultClassRealmManagerTest.java:91)

testMNG6275_coreRealmDefaultParentClassLoader(org.apache.maven.classrealm.DefaultClassRealmManagerTest)
 Time elapsed: 0.271 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at
org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_coreRealmDefaultParentClassLoader(DefaultClassRealmManagerTest.java:99)

testMNG6275_extensionRealmDefaultParentClassLoader(org.apache.maven.classrealm.DefaultClassRealmManagerTest)
 Time elapsed: 0.251 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at
org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_extensionRealmDefaultParentClassLoader(DefaultClassRealmManagerTest.java:73)

testMNG6275_pluginRealmDefaultParentClassLoader(org.apache.maven.classrealm.DefaultClassRealmManagerTest)
 Time elapsed: 0.244 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at
org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_pluginRealmDefaultParentClassLoader(DefaultClassRealmManagerTest.java:62)

testMNG6275_projectRealmDefaultParentClassLoader(org.apache.maven.classrealm.DefaultClassRealmManagerTest)
 Time elapsed: 0.242 sec  <<< FAILURE!
junit.framework.AssertionFailedError: null
at junit.framework.Assert.fail(Assert.java:55)
at junit.framework.Assert.assertTrue(Assert.java:22)
at junit.framework.Assert.assertTrue(Assert.java:31)
at junit.framework.TestCase.assertTrue(TestCase.java:201)
at
org.apache.maven.classrealm.DefaultClassRealmManagerTest.testMNG6275_projectRealmDefaultParentClassLoader(DefaultClassRealmManagerTest.java:83)

investigating...

On 11 September 2017 at 01:44, Stephen Connolly <
[hidden email]> wrote:

> Building the source bundles with the binary bundles in the staging repo
> using the Dockerfile environments in https://github.com/apache/
> maven-integration-testing/tree/master/environments
>
> Debian JDK 7
> ===========
>
> Linux 65fb832dfe43 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
> GNU/Linux
> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
> 2017-09-10T12:42:54Z)
> Maven home: /work/bin
> Java version: 1.7.0_151, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre
> Default locale: en, platform encoding: UTF-8
> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"
>
> mvn verify => SUCCESS
>
> Debian JDK 8
> ===========
>
> Linux 11ef1c114b6b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
> GNU/Linux
> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
> 2017-09-10T12:42:54Z)
> Maven home: /work/bin
> Java version: 1.8.0_141, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
> Default locale: en, platform encoding: UTF-8
> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"
>
> mvn verify => SUCCESS
>
> Fedora JDK 8
> ===========
>
> Linux 54211a0e694e 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
> x86_64 x86_64 GNU/Linux
> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
> 2017-09-10T12:42:54Z)
> Maven home: /work/bin
> Java version: 1.8.0_144, vendor: Oracle Corporation
> Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.144-5.b01.fc26.x86_64/jre
> Default locale: en_US, platform encoding: ANSI_X3.4-1968
> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"
>
> mvn verify => SUCCESS
>
> IBM JDK 8
> ========
>
> Linux 199631edceed 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
> x86_64 x86_64 GNU/Linux
> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
> 2017-09-10T12:42:54Z)
> Maven home: /work/bin
> Java version: 1.8.0, vendor: IBM Corporation
> Java home: /opt/ibm/java/jre
> Default locale: en_US, platform encoding: ANSI_X3.4-1968
> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"
>
> mvn verify => SUCCESS
>
> Asul Zulu JDK 8
> =============
>
> Linux 10e8f4e46138 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
> x86_64 x86_64 GNU/Linux
> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
> 2017-09-10T12:42:54Z)
> Maven home: /work/bin
> Java version: 1.8.0_144, vendor: Azul Systems, Inc.
> Java home: /usr/lib/jvm/zulu-8-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"
>
> mvn verify => SUCCESS
>
> If I get time later I'll run the integration tests.
>
> On 11 September 2017 at 00:20, Dan Tran <[hidden email]> wrote:
>
>> False alarm, I missed configure global settings.xml, it is missing the
>> default repository setup
>>
>> -D
>>
>> On Sun, Sep 10, 2017 at 11:47 PM, Tibor Digana <
>> [hidden email]>
>> wrote:
>>
>> > +1:
>> > 3.5.1 works in my project like a charm ;-)
>> >
>> > On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly <
>> > [hidden email]> wrote:
>> >
>> > > Hi,
>> > >
>> > > We solved 25 issues:
>> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>> > > version=12338964&styleName=Text&projectId=12316922
>> > >
>> > > There are 350 issues left in JIRA for Maven core:
>> > > <a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
>> > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
>> > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
>> > >
>> > > Staging repo:
>> > > https://repository.apache.org/content/repositories/maven-1364/
>> > >
>> > > The distributable binaries and sources can be found here:
>> > > https://repository.apache.org/content/repositories/maven-
>> > > 1364/org/apache/maven/apache-maven/3.5.1/
>> > >
>> > > Specifically the zip, tarball and source archives can be found here:
>> > > https://repository.apache.org/content/repositories/maven-
>> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip
>> > > https://repository.apache.org/content/repositories/maven-
>> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-
>> bin.tar.gz
>> > > https://repository.apache.org/content/repositories/maven-
>> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip
>> > > https://repository.apache.org/content/repositories/maven-
>> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-
>> src.tar.gz
>> > >
>> > > Source release checksum(s):
>> > > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7
>> > > bd2059560d
>> > > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab
>> > 69e698eb0e
>> > >
>> > > Git tag:
>> > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
>> > > 094e4e31a5af55bb17be87675da41d9aeca062f3
>> > >
>> > > Staging site:
>> > > https://maven.apache.org/components/ref/3-LATEST/
>> > >
>> > > Vote open for 72 hours.
>> > >
>> > > [ ] +1
>> > > [ ] +0
>> > > [ ] -1
>> > >
>> > > Thanks,
>> > >
>> > > Stephen.
>> > >
>> >
>> >
>> >
>> > --
>> > Cheers
>> > Tibor
>> >
>>
>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Robert Scholte-8
Nice fix

On Mon, 11 Sep 2017 11:31:34 +0200, Stephen Connolly  
<[hidden email]> wrote:

> http://git-wip-us.apache.org/repos/asf/maven/diff/542a7a89 to defang the
> test going forward, with that change on Azul's Zulu JDK 7 I get:
>
> Linux ddf0318b698b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
> x86_64 x86_64 GNU/Linux
> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
> 2017-09-10T12:42:54Z)
> Maven home: /work/bin
> Java version: 1.7.0_154, vendor: Azul Systems, Inc.
> Java home: /usr/lib/jvm/zulu-7-amd64/jre
> Default locale: en_US, platform encoding: UTF-8
> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"
>
> mvn verify => SUCCESS
>
>
> On 11 September 2017 at 02:00, Stephen Connolly <
> [hidden email]> wrote:
>
>> So Azul's Zulu 7 does not have
>>
>> com.sun.script.javascript.RhinoScriptEngineFactory or any
>> ScriptEngineFactory in the base classloader...
>>
>> Zulu 8 has jdk.nashorn.api.scripting.NashornScriptEngineFactory
>>
>> So at this point in time, my analysis is that the
>> DefaultClassRealmManagerTest is not a valid test when the default
>> classloader does not have any ScriptEngineFactory... I'm going to commit
>> a fix, but this should not invalidate the 3.5.1 release
>>
>> On 11 September 2017 at 01:53, Stephen Connolly <
>> [hidden email]> wrote:
>>
>>> With https://github.com/apache/maven-integration-testing/
>>> commit/a08d65bfb5fedec9f684c13bf5a0dccb96f5cc56 I was able to get
>>> Michael's test failures:
>>>
>>> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
>>> 2017-09-10T12:42:54Z)
>>> Maven home: /work/bin
>>> Java version: 1.7.0_154, vendor: Azul Systems, Inc.
>>> Java home: /usr/lib/jvm/zulu-7-amd64/jre
>>> Default locale: en_US, platform encoding: UTF-8
>>> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"
>>>
>>>
>>> ------------------------------------------------------------
>>> -------------------
>>> Test set: org.apache.maven.classrealm.DefaultClassRealmManagerTest
>>> ------------------------------------------------------------
>>> -------------------
>>> Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 2.128  
>>> sec
>>> <<< FAILURE! - in org.apache.maven.classrealm.De
>>> faultClassRealmManagerTest
>>> testMNG6275_mavenApiRealmDefaultParentClassLoader(org.
>>> apache.maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed:
>>> 1.12 sec  <<< FAILURE!
>>> junit.framework.AssertionFailedError: null
>>> at junit.framework.Assert.fail(Assert.java:55)
>>> at junit.framework.Assert.assertTrue(Assert.java:22)
>>> at junit.framework.Assert.assertTrue(Assert.java:31)
>>> at junit.framework.TestCase.assertTrue(TestCase.java:201)
>>> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
>>> tMNG6275_mavenApiRealmDefaultParentClassLoader(DefaultClassR
>>> ealmManagerTest.java:91)
>>>
>>> testMNG6275_coreRealmDefaultParentClassLoader(org.apache.
>>> maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed: 0.271 sec
>>>  <<< FAILURE!
>>> junit.framework.AssertionFailedError: null
>>> at junit.framework.Assert.fail(Assert.java:55)
>>> at junit.framework.Assert.assertTrue(Assert.java:22)
>>> at junit.framework.Assert.assertTrue(Assert.java:31)
>>> at junit.framework.TestCase.assertTrue(TestCase.java:201)
>>> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
>>> tMNG6275_coreRealmDefaultParentClassLoader(DefaultClassRealm
>>> ManagerTest.java:99)
>>>
>>> testMNG6275_extensionRealmDefaultParentClassLoader(org.
>>> apache.maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed:
>>> 0.251 sec  <<< FAILURE!
>>> junit.framework.AssertionFailedError: null
>>> at junit.framework.Assert.fail(Assert.java:55)
>>> at junit.framework.Assert.assertTrue(Assert.java:22)
>>> at junit.framework.Assert.assertTrue(Assert.java:31)
>>> at junit.framework.TestCase.assertTrue(TestCase.java:201)
>>> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
>>> tMNG6275_extensionRealmDefaultParentClassLoader(DefaultClass
>>> RealmManagerTest.java:73)
>>>
>>> testMNG6275_pluginRealmDefaultParentClassLoader(org.apache.
>>> maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed: 0.244 sec
>>>  <<< FAILURE!
>>> junit.framework.AssertionFailedError: null
>>> at junit.framework.Assert.fail(Assert.java:55)
>>> at junit.framework.Assert.assertTrue(Assert.java:22)
>>> at junit.framework.Assert.assertTrue(Assert.java:31)
>>> at junit.framework.TestCase.assertTrue(TestCase.java:201)
>>> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
>>> tMNG6275_pluginRealmDefaultParentClassLoader(DefaultClassRea
>>> lmManagerTest.java:62)
>>>
>>> testMNG6275_projectRealmDefaultParentClassLoader(org.apache.
>>> maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed: 0.242 sec
>>>  <<< FAILURE!
>>> junit.framework.AssertionFailedError: null
>>> at junit.framework.Assert.fail(Assert.java:55)
>>> at junit.framework.Assert.assertTrue(Assert.java:22)
>>> at junit.framework.Assert.assertTrue(Assert.java:31)
>>> at junit.framework.TestCase.assertTrue(TestCase.java:201)
>>> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
>>> tMNG6275_projectRealmDefaultParentClassLoader(DefaultClassRe
>>> almManagerTest.java:83)
>>>
>>> investigating...
>>>
>>> On 11 September 2017 at 01:44, Stephen Connolly <
>>> [hidden email]> wrote:
>>>
>>>> Building the source bundles with the binary bundles in the staging  
>>>> repo
>>>> using the Dockerfile environments in https://github.com/apache/mave
>>>> n-integration-testing/tree/master/environments
>>>>
>>>> Debian JDK 7
>>>> ===========
>>>>
>>>> Linux 65fb832dfe43 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017  
>>>> x86_64
>>>> GNU/Linux
>>>> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
>>>> 2017-09-10T12:42:54Z)
>>>> Maven home: /work/bin
>>>> Java version: 1.7.0_151, vendor: Oracle Corporation
>>>> Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre
>>>> Default locale: en, platform encoding: UTF-8
>>>> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family:  
>>>> "unix"
>>>>
>>>> mvn verify => SUCCESS
>>>>
>>>> Debian JDK 8
>>>> ===========
>>>>
>>>> Linux 11ef1c114b6b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017  
>>>> x86_64
>>>> GNU/Linux
>>>> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
>>>> 2017-09-10T12:42:54Z)
>>>> Maven home: /work/bin
>>>> Java version: 1.8.0_141, vendor: Oracle Corporation
>>>> Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
>>>> Default locale: en, platform encoding: UTF-8
>>>> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family:  
>>>> "unix"
>>>>
>>>> mvn verify => SUCCESS
>>>>
>>>> Fedora JDK 8
>>>> ===========
>>>>
>>>> Linux 54211a0e694e 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017  
>>>> x86_64
>>>> x86_64 x86_64 GNU/Linux
>>>> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
>>>> 2017-09-10T12:42:54Z)
>>>> Maven home: /work/bin
>>>> Java version: 1.8.0_144, vendor: Oracle Corporation
>>>> Java home:  
>>>> /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.144-5.b01.fc26.x86_64/
>>>> jre
>>>> Default locale: en_US, platform encoding: ANSI_X3.4-1968
>>>> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family:  
>>>> "unix"
>>>>
>>>> mvn verify => SUCCESS
>>>>
>>>> IBM JDK 8
>>>> ========
>>>>
>>>> Linux 199631edceed 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017  
>>>> x86_64
>>>> x86_64 x86_64 GNU/Linux
>>>> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
>>>> 2017-09-10T12:42:54Z)
>>>> Maven home: /work/bin
>>>> Java version: 1.8.0, vendor: IBM Corporation
>>>> Java home: /opt/ibm/java/jre
>>>> Default locale: en_US, platform encoding: ANSI_X3.4-1968
>>>> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family:  
>>>> "unix"
>>>>
>>>> mvn verify => SUCCESS
>>>>
>>>> Asul Zulu JDK 8
>>>> =============
>>>>
>>>> Linux 10e8f4e46138 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017  
>>>> x86_64
>>>> x86_64 x86_64 GNU/Linux
>>>> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
>>>> 2017-09-10T12:42:54Z)
>>>> Maven home: /work/bin
>>>> Java version: 1.8.0_144, vendor: Azul Systems, Inc.
>>>> Java home: /usr/lib/jvm/zulu-8-amd64/jre
>>>> Default locale: en_US, platform encoding: UTF-8
>>>> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family:  
>>>> "unix"
>>>>
>>>> mvn verify => SUCCESS
>>>>
>>>> If I get time later I'll run the integration tests.
>>>>
>>>> On 11 September 2017 at 00:20, Dan Tran <[hidden email]> wrote:
>>>>
>>>>> False alarm, I missed configure global settings.xml, it is missing  
>>>>> the
>>>>> default repository setup
>>>>>
>>>>> -D
>>>>>
>>>>> On Sun, Sep 10, 2017 at 11:47 PM, Tibor Digana <
>>>>> [hidden email]>
>>>>> wrote:
>>>>>
>>>>> > +1:
>>>>> > 3.5.1 works in my project like a charm ;-)
>>>>> >
>>>>> > On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly <
>>>>> > [hidden email]> wrote:
>>>>> >
>>>>> > > Hi,
>>>>> > >
>>>>> > > We solved 25 issues:
>>>>> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>>>>> > > version=12338964&styleName=Text&projectId=12316922
>>>>> > >
>>>>> > > There are 350 issues left in JIRA for Maven core:
>>>>> > > <a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
>>>>> > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
>>>>> > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
>>>>> > >
>>>>> > > Staging repo:
>>>>> > > https://repository.apache.org/content/repositories/maven-1364/
>>>>> > >
>>>>> > > The distributable binaries and sources can be found here:
>>>>> > > https://repository.apache.org/content/repositories/maven-
>>>>> > > 1364/org/apache/maven/apache-maven/3.5.1/
>>>>> > >
>>>>> > > Specifically the zip, tarball and source archives can be found  
>>>>> here:
>>>>> > > https://repository.apache.org/content/repositories/maven-
>>>>> > >  
>>>>> 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip
>>>>> > > https://repository.apache.org/content/repositories/maven-
>>>>> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-
>>>>> bin.tar.gz
>>>>> > > https://repository.apache.org/content/repositories/maven-
>>>>> > >  
>>>>> 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip
>>>>> > > https://repository.apache.org/content/repositories/maven-
>>>>> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-
>>>>> src.tar.gz
>>>>> > >
>>>>> > > Source release checksum(s):
>>>>> > > apache-maven-3.5.1-src.tar.gz sha1:  
>>>>> 9eb821f153c7667194aa11ccd099b7
>>>>> > > bd2059560d
>>>>> > > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab
>>>>> > 69e698eb0e
>>>>> > >
>>>>> > > Git tag:
>>>>> > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
>>>>> > > 094e4e31a5af55bb17be87675da41d9aeca062f3
>>>>> > >
>>>>> > > Staging site:
>>>>> > > https://maven.apache.org/components/ref/3-LATEST/
>>>>> > >
>>>>> > > Vote open for 72 hours.
>>>>> > >
>>>>> > > [ ] +1
>>>>> > > [ ] +0
>>>>> > > [ ] -1
>>>>> > >
>>>>> > > Thanks,
>>>>> > >
>>>>> > > Stephen.
>>>>> > >
>>>>> >
>>>>> >
>>>>> >
>>>>> > --
>>>>> > Cheers
>>>>> > Tibor
>>>>> >
>>>>>
>>>>
>>>>
>>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

aheritier
In reply to this post by Mark Derricutt
Damned, can't we be anonymous on Github ?
I maintain it is a big word, I'm trying to fix more bugs than I add new ones
I added Oleg in the loop as he contributed a lot on it too
I did a quick test to build on Jenkins 2.60.3 our maven core with the Evil
Maven plugin 2.17 on a local SSH agent and it is ok
But it is really a quick test ...

Cheers



On Wed, Sep 13, 2017 at 10:07 AM, Stephen Connolly <
[hidden email]> wrote:

> On 13 September 2017 at 01:05, Stephen Connolly <
> [hidden email]> wrote:
>
>> On 13 September 2017 at 00:26, Anders Hammar <[hidden email]> wrote:
>>
>>> On Tue, Sep 12, 2017 at 8:54 PM, Stephen Connolly <
>>> [hidden email]> wrote:
>>>
>>> > Have we got any feedback from the embedder integrations yet?
>>> >
>>>
>>> I haven't heard anything from the m2e people. Maybe we need to ping them
>>> directly. I can contact Fred Bricon.
>>>
>>> /Anders
>>>
>>>
>> Please do, also if anyone has a contact in netbeans or intellij and could
>> let them know we'd like either feedback or "we're ok if MNG-6275 makes
>> trouble for us, go ahead and release". I'd like to close the vote on Friday
>> 13:00 UTC.
>>
>>
>
> Olivier / Arnaud, have either of you had a chance to test this with the
> evil project type[1] as you two seem to be the active maintainers[2]
>
> [1]: https://javaadventure.blogspot.ie/2013/11/jenkins-
> maven-job-type-considered-evil.html
> [2]: https://github.com/jenkinsci/maven-plugin/commits/master
>



--

Arnaud
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Robert Scholte-3
In reply to this post by Mark Derricutt
Just received the confirmation that netbeans uses the cli, so there should be no issue there. 
Robert 
Verzonden vanaf mijn Samsung Galaxy-smartphone.
-------- Oorspronkelijk bericht --------Van: Stephen Connolly <[hidden email]> Datum: 13-09-17  10:05  (GMT+01:00) Aan: Maven Developers List <[hidden email]> Onderwerp: Re: [VOTE] Release Apache Maven 3.5.1
On 13 September 2017 at 00:26, Anders Hammar <[hidden email]> wrote:

> On Tue, Sep 12, 2017 at 8:54 PM, Stephen Connolly <
> [hidden email]> wrote:
>
> > Have we got any feedback from the embedder integrations yet?
> >
>
> I haven't heard anything from the m2e people. Maybe we need to ping them
> directly. I can contact Fred Bricon.
>
> /Anders
>
>
Please do, also if anyone has a contact in netbeans or intellij and could
let them know we'd like either feedback or "we're ok if MNG-6275 makes
trouble for us, go ahead and release". I'd like to close the vote on Friday
13:00 UTC.
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

jieryn
In reply to this post by Mark Derricutt
+1 non-binding

I tested with OpenJDK Java 8 on Linux x86_64 with a variety of
projects. Everything looks good, the only new behavior I'm seeing is a
warning:

[WARNING] The project <<project:version>> uses prerequisites which is
only intended for maven-plugin projects but not for non maven-plugin
projects. For such purposes you should use the maven-enforcer-plugin.
See https://maven.apache.org/enforcer/enforcer-rules/requireMavenVersion.html

But it looks like this is intentional and well documented, thank you!


On Wed, Sep 13, 2017 at 8:20 AM, Robert Scholte
<[hidden email]> wrote:

> Just received the confirmation that netbeans uses the cli, so there should be no issue there.
> Robert
> Verzonden vanaf mijn Samsung Galaxy-smartphone.
> -------- Oorspronkelijk bericht --------Van: Stephen Connolly <[hidden email]> Datum: 13-09-17  10:05  (GMT+01:00) Aan: Maven Developers List <[hidden email]> Onderwerp: Re: [VOTE] Release Apache Maven 3.5.1
> On 13 September 2017 at 00:26, Anders Hammar <[hidden email]> wrote:
>
>> On Tue, Sep 12, 2017 at 8:54 PM, Stephen Connolly <
>> [hidden email]> wrote:
>>
>> > Have we got any feedback from the embedder integrations yet?
>> >
>>
>> I haven't heard anything from the m2e people. Maybe we need to ping them
>> directly. I can contact Fred Bricon.
>>
>> /Anders
>>
>>
> Please do, also if anyone has a contact in netbeans or intellij and could
> let them know we'd like either feedback or "we're ok if MNG-6275 makes
> trouble for us, go ahead and release". I'd like to close the vote on Friday
> 13:00 UTC.

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Mark Derricutt
In reply to this post by Mark Derricutt

Calling -2 for vote if not too late.

Have git bisected from 3.5.0 to HEAD and found the commit that introduced the behaviour:

ec629f7d511eb910b4e80112a9fbe85ed8786f10 is the first bad commit
commit ec629f7d511eb910b4e80112a9fbe85ed8786f10
Author: Igor Fedorenko [hidden email]
Date: Tue Apr 11 07:59:34 2017 -0700

MNG-6209 better executeMojo thread context classloader

Signed-off-by: Igor Fedorenko <[hidden email]>

:040000 040000 570fa9308365b0ee98d57ac3f8006691bd9ade4d 3c6791665c9d41f0e4a3893ea99621cc50e8b91b M maven-core

Not exactly sure what/why/how this problem manifests in a testable manner yet however.

Mark

On 11 Sep 2017, at 23:19, Mark Derricutt wrote:

On 11 Sep 2017, at 18:10, Stephen Connolly wrote:

I wonder if mng-6275 is affecting that plugin

Didn't manage to get a chance to look into this tonight :( Tho that ticket mentions nashorn, phantonjs is a C/native headless browser library, so it doesn't feel like it could be related.

If there's a build available with a fix for that, welcome to give it a bash.

I'll try carve out some time in the morning to see if I can make a simple standalone project...


"The ease with which a change can be implemented has no relevance at all to whether it is the right change for the (Java) Platform for all time." — Mark Reinhold.

Mark Derricutt
http://www.theoryinpractice.net
http://www.chaliceofblood.net
http://plus.google.com/+MarkDerricutt
http://twitter.com/talios
http://facebook.com/mderricutt


"The ease with which a change can be implemented has no relevance at all to whether it is the right change for the (Java) Platform for all time." — Mark Reinhold.

Mark Derricutt
http://www.theoryinpractice.net
http://www.chaliceofblood.net
http://plus.google.com/+MarkDerricutt
http://twitter.com/talios
http://facebook.com/mderricutt


signature.asc (494 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Petr Široký
Hello,

I am seeing a (probably) similar issue with our custom plugin.

See the reproducer:
https://github.com/psiroky/reproducers/tree/mvn351-kie-maven-plugin (works
fine with maven 3.5.0, but fails with NPE with the RC of maven 3.5.1).

I am not yet sure if the plugin is just doing something it's not supposed
to, or if this is a regression in maven itself. I'll will take a deeper
look.

Petr

On Thu, Sep 14, 2017 at 1:53 PM Stephen Connolly <
[hidden email]> wrote:

> On 14 September 2017 at 04:43, Mark Derricutt <[hidden email]> wrote:
>
> > > +2 non-binding from Mark!
> >
> > I was discussing this with a coworker and he made the comment that if
> this
> > change could break Mojos, maybe it shouldn't be in a point release -
> whats
> > the policy on changes that may potentially break existing plugins?
> >
>
> Well we need to assess the issue. Right now I don't even have a description
> of what went wrong. Any chance you could provide a replication... or mail
> me directly if you cannot share it publically and I may be able to produce
> a minimal reproduction from it.
>
> If this breaks a mojo that was doing something wrong in the first place,
> well that will not stop 3.5.1... OTOH if this exposes a bug in the issue
> "fixed" then I'd likely revert and respin.
>
> We really need a reproducer first.
>
>
> >
> > --
> > "Great artists are extremely selfish and arrogant things" — Steven
> Wilson,
> > Porcupine Tree
> >
> > On Thu, Sep 14, 2017 at 10:29 AM, Mark Derricutt <[hidden email]>
> wrote:
> >
> > > On 14 Sep 2017, at 10:26, Mark Derricutt wrote:
> > >
> > > Calling -2 for vote if not too late.
> > >
> > > Actually - looking at the commit diff, I see in our code we did have
> > > <extensions>true</extensions> for the jasmine-maven-plugin which we
> don't
> > > actually need. Removing that from the mojo definition and running my
> > build
> > > with the staged 3.5.1 release and everything builds fine.
> > >
> > > +2 non-binding from Mark!
> > >
> > > Mark
> > > ------------------------------
> > >
> > > "The ease with which a change can be implemented has no relevance at
> all
> > > to whether it is the right change for the (Java) Platform for all
> time."
> > —
> > > Mark Reinhold.
> > >
> > > Mark Derricutt
> > > http://www.theoryinpractice.net
> > > http://www.chaliceofblood.net
> > > http://plus.google.com/+MarkDerricutt
> > > http://twitter.com/talios
> > > http://facebook.com/mderricutt
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

stephenconnolly
In reply to this post by Mark Derricutt
On Sat 16 Sep 2017 at 10:51, Stephen Connolly <
[hidden email]> wrote:

> On Sat 16 Sep 2017 at 04:07, Igor Fedorenko <[hidden email]> wrote:
>
>> I don't really have much to add, but let me answer anyways :-)
>>
>> 1) I am reasonably confident we can compensate for the new classloader
>> arrangement in m2e without much problems. The new setup does make plugin
>> runtime classpath less stable, so there are likely other scenarios where
>> plugins will behave differently (bad). On the other hand, I don't see
>> any better way to support ServiceLoader. For java 8 it may be possible
>> to use foreign-import of extensions classloader to fix MNG-6275, but
>> that classloader was removed in java 9, unless I am mistaken.
>
>
> Ok so I think the consensus is 6275 is probably a necessary fix for Java 8
> interoperability, but may expose bugs in plugins that made incorrect
> assumptions, and is a breaking change from the PoV of the eclipse
> integration. Netbeans is fine and IntelliJ seems to do its own think (given
> I have an open bug that suggests IntelliJ is ignorant of the extensions
> type mapping)
>
>
>>
>> 2) I believe TCCL is already set to project realm for projects that have
>> extensions (and to plugin realm otherwise) during plugin execution.
>
>
> So my question is why should TCCL *ever* be anything other than project
> realm?
>
> The pom reference says:
>
>    - *extensions*: true or false, whether or not to load extensions of
>    this plugin. It is by default false. Extensions are covered later in this
>    document.
>
> It does not say that this flag affects the classloader of the plugin,
> rather to me says when true the project realm shall include the plugin's
> extensions.
>
> My understanding was that a plugin would always see its own extensions,
> but if you set this flag then the project would be able to see them too...
>
> Now granted my understanding may be incorrect, but this change seems to be
> turning things in an entirely different direction
>

Ok discussed this on #maven-dev

I need to confirm my analysis, but if correct, then the fix for MNG-6209 is
correct... will need careful release noting

>
> Problem is, neither project realm nor any of the plugin realms have
>> access to jvm extensions classloader, so ServiceLoader can't get classes
>> from there.
>
>
> That is another set of issues... but this should have been fixed by 6275
> unless I am mistaken
>
>
>>
>> --
>> Regards,
>> Igor
>>
>> On Fri, Sep 15, 2017, at 12:09 PM, Stephen Connolly wrote:
>> > I'm going to hold off closing the vote over the weekend to give Igor a
>> > chance to:
>> >
>> > 1. comment on whether we need an alternative fix for MNG-6275 (and
>> indeed
>> > ideally provide one ;- );
>> > 2. comment on whether the fix for MNG-6209 is exposing bugs in plugins
>> > that
>> > made incorrect assumptions about TCCL, or whether the fix is invalid or
>> > even incomplete (I wonder if TCCL should always be
>> > project.getClassRealm()
>> > as extensions should be available to all plugins not just those that
>> > declare they are providing extensions - unless I misunderstand)
>> >
>> > Once I have the required information I will be better able to assess
>> > whether we should release 3.5.1 and follow up with a quick 3.5.2 or just
>> > drop 3.5.1 and go straight to 3.5.2.
>> >
>> > -Stephen
>> >
>> > On 15 September 2017 at 05:45, Igor Fedorenko <[hidden email]>
>> > wrote:
>> >
>> > > Has anyone tried wiring jvm extensions ClassLoader as foreign import
>> to
>> > > plugin/extensions realms? Jvm extensions classloader is little tricky
>> to
>> > > get to (see how this is done in
>> java.util.ServiceLoader.loadInstalled),
>> > > but I think this will solve ServiceLoader/MNG-6275 without polluting
>> > > plugin classpath too much.
>> > >
>> > > --
>> > > Regards,
>> > > Igor
>> > >
>> > > On Fri, Sep 15, 2017, at 08:32 AM, Mark Derricutt wrote:
>> > > > Would it be possible to handle this in a somewhat similar way to
>> > > > threadSafe
>> > > > mojos - some form of plugin flag that says "extensionSafe" [1],
>> that if
>> > > > the
>> > > > plugin has <extensions>true</extensions> declared and doesn't
>> declare
>> > > > itself as being extensionSafe/extensionAware then we log a build
>> warning
>> > > > -
>> > > > it wouldn't solve anything, other than giving some feedback to
>> users some
>> > > > indication of WHY their build fails under 3.5.1 - and to either
>> remove
>> > > > <extensions> or fix/update their plugins.
>> > > >
>> > > > [1] Or even just infer the applicability of extensions by the
>> presence of
>> > > > custom lifecycles, or Mojos implementing the extension interfaces (
>> it's
>> > > > midnight, and a hazy tired thought ).
>> > > >
>> > > > --
>> > > > "Great artists are extremely selfish and arrogant things" — Steven
>> > > > Wilson,
>> > > > Porcupine Tree
>> > > >
>> > > > On Sat, Sep 16, 2017 at 12:22 AM, Anders Hammar <[hidden email]>
>> > > > wrote:
>> > > >
>> > > > > Based on Igor's feedback I'm changing my vote to +1.
>> > > > >
>> > > > > Having this class loader change in a bug fix release is probably
>> not
>> > > > > (semver) ideal though.
>> > > > >
>> > > > > /Anders
>> > > > >
>> > > > > On Fri, Sep 15, 2017 at 2:12 PM, Igor Fedorenko <
>> [hidden email]>
>> > > > > wrote:
>> > > > >
>> > > > > > I answered in more details on m2e-dev, but I believe we can
>> > > compensate
>> > > > > > for the change from m2e end. In the worst case we'll bundle
>> hacked
>> > > > > > version of DefaultClassRealmManager with m2e, not ideal, but
>> not the
>> > > end
>> > > > > > of the world either.
>> > > > > >
>> > > > > > --
>> > > > > > Regards,
>> > > > > > Igor
>> > > > > >
>> > > > > > On Fri, Sep 15, 2017, at 07:21 AM, Anders Hammar wrote:
>> > > > > > > On Fri, Sep 15, 2017 at 8:29 AM, Anders Hammar <
>> [hidden email]>
>> > > > > > wrote:
>> > > > > > >
>> > > > > > > > Reporting back from tests of m2e with embedded Maven 3.5.1,
>> we
>> > > see
>> > > > > > problem
>> > > > > > > > with the jaxws-maven-plugin mojo. We're two people seeing
>> the
>> > > issue
>> > > > > > > > independently, but unfortunately Fred Bricon hasn't been
>> able to
>> > > > > > reproduce.
>> > > > > > > >
>> > > > > > >
>> > > > > > > To follow up on this, my tests indicate that Maven 3.5.1
>> causes
>> > > changed
>> > > > > > > class loading that could cause issues for plugins in m2e. I've
>> > > asked
>> > > > > for
>> > > > > > > input from the m2e devs if it is possible to handle in m2e
>> but they
>> > > > > > > haven't
>> > > > > > > responded yet.
>> > > > > > >
>> > > > > > > /Anders
>> > > > > > >
>> > > > > > >
>> > > > > > > >
>> > > > > > > > So currently I'm 0 on the voting but I'll investigate some
>> more.
>> > > > > > > >
>> > > > > > > > /Anders
>> > > > > > > >
>> > > > > > > > On Wed, Sep 13, 2017 at 9:26 AM, Anders Hammar <
>> > > [hidden email]>
>> > > > > > wrote:
>> > > > > > > >
>> > > > > > > >>
>> > > > > > > >>
>> > > > > > > >> On Tue, Sep 12, 2017 at 8:54 PM, Stephen Connolly <
>> > > > > > > >> [hidden email]> wrote:
>> > > > > > > >>
>> > > > > > > >>> Have we got any feedback from the embedder integrations
>> yet?
>> > > > > > > >>>
>> > > > > > > >>
>> > > > > > > >> I haven't heard anything from the m2e people. Maybe we
>> need to
>> > > ping
>> > > > > > them
>> > > > > > > >> directly. I can contact Fred Bricon.
>> > > > > > > >>
>> > > > > > > >> /Anders
>> > > > > > > >>
>> > > > > > > >>
>> > > > > > > >>>
>> > > > > > > >>> On Mon 11 Sep 2017 at 22:57, Hervé BOUTEMY <
>> > > [hidden email]>
>> > > > > > > >>> wrote:
>> > > > > > > >>>
>> > > > > > > >>> > just for the records: it is Windows + Git Bash
>> (MINGW64) only
>> > > > > > > >>> >
>> > > > > > > >>> > and there is a chance that adding -Djansi.force=true can
>> > > force
>> > > > > > JAnsi
>> > > > > > > >>> > activation (even if JAnsi fails to detect that it should
>> > > > > > auto-activate)
>> > > > > > > >>> >
>> > > > > > > >>> > details on issue in https://issues.apache.org/
>> > > > > jira/browse/MNG-6282
>> > > > > > ,
>> > > > > > > >>> and a
>> > > > > > > >>> > future JAnsi issue...
>> > > > > > > >>> >
>> > > > > > > >>> > Regards,
>> > > > > > > >>> >
>> > > > > > > >>> > Hervé
>> > > > > > > >>> >
>> > > > > > > >>> > Le lundi 11 septembre 2017, 12:53:46 CEST Stephen
>> Connolly a
>> > > > > écrit
>> > > > > > :
>> > > > > > > >>> > > So that is windows only, or were they lost on other
>> OSes
>> > > for
>> > > > > you.
>> > > > > > > >>> > >
>> > > > > > > >>> > > I have colours on linux (via docker) and os-x
>> > > > > > > >>> > >
>> > > > > > > >>> > > On 11 September 2017 at 12:35, [hidden email] <
>> > > > > > > >>> [hidden email]>
>> > > > > > > >>> > >
>> > > > > > > >>> > > wrote:
>> > > > > > > >>> > > > +1 (conditionally).
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > Tested via project that includes dozen of plugins:
>> 1st
>> > > tier,
>> > > > > > > >>> MojoHaus
>> > > > > > > >>> > and
>> > > > > > > >>> > > > few 3rd party plugins (so to say).
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > Everything looks good with one notable regression:
>> > > > > > > >>> > > > https://issues.apache.org/jira/browse/MNG-6282
>> Console
>> > > > > output
>> > > > > > has
>> > > > > > > >>> no
>> > > > > > > >>> > > > colors (regression in Maven 3.5.1)
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > Regards,
>> > > > > > > >>> > > > Dejan
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > On 2017-09-10 17:39, Stephen Connolly <
>> > > > > > > >>> [hidden email]
>> > > > > > > >>> > >
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > wrote:
>> > > > > > > >>> > > > > Hi,
>> > > > > > > >>> > > > >
>> > > > > > > >>> > > > > We solved 25 issues:
>> > > > > > > >>> > > > >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa
>> > > ?
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > version=12338964&styleName=Text&projectId=12316922
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > > There are 350 issues left in JIRA for Maven core:
>> > > > > > > >>> > > > >
>> <a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
>> > > > > > > >>> > > >
>> > > > > > > >>> > > >
>> 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
>> > > > > > > >>> > > >
>> 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > > Staging repo:
>> > > > > > > >>> > > > > https://repository.apache.org/
>> > > content/repositories/maven-
>> > > > > > 1364/
>> > > > > > > >>> > > > >
>> > > > > > > >>> > > > > The distributable binaries and sources can be
>> found
>> > > here:
>> > > > > > > >>> > > > > https://repository.apache.org/
>> > > content/repositories/maven->
>> > > > > >
>> > > > > > > >>> > > > 1364/org/apache/maven/apache-maven/3.5.1/
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > > Specifically the zip, tarball and source archives
>> can
>> > > be
>> > > > > > found
>> > > > > > > >>> here:
>> > > > > > > >>> > > > > https://repository.apache.org/
>> > > content/repositories/maven->
>> > > > > >
>> > > > > > > >>> > > > 1364/org/apache/maven/apache-
>> > > maven/3.5.1/apache-maven-3.5.1-
>> > > > > > > >>> bin.zip
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > > https://repository.apache.org/
>> > > content/repositories/maven->
>> > > > > >
>> > > > > > > >>> > > > 1364/org/apache/maven/apache-
>> > > maven/3.5.1/apache-maven-3.5.1-
>> > > > > > > >>> bin.tar.gz
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > > https://repository.apache.org/
>> > > content/repositories/maven->
>> > > > > >
>> > > > > > > >>> > > > 1364/org/apache/maven/apache-
>> > > maven/3.5.1/apache-maven-3.5.1-
>> > > > > > > >>> src.zip
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > > https://repository.apache.org/
>> > > content/repositories/maven->
>> > > > > >
>> > > > > > > >>> > > > 1364/org/apache/maven/apache-
>> > > maven/3.5.1/apache-maven-3.5.1-
>> > > > > > > >>> src.tar.gz
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > > Source release checksum(s):
>> > > > > > > >>> > > > > apache-maven-3.5.1-src.tar.gz sha1:
>> > > > > > > >>> 9eb821f153c7667194aa11ccd099b7
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > bd2059560d
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > > apache-maven-3.5.1-src.zip: sha1:
>> > > > > > 121d54b045380a8a4895eb137970ab
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > 69e698eb0e
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > > Git tag:
>> > > > > > > >>> > > > >
>> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=
>> > > > > > commit;h=
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > 094e4e31a5af55bb17be87675da41d9aeca062f3
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > > Staging site:
>> > > > > > > >>> > > > > https://maven.apache.org/components/ref/3-LATEST/
>> > > > > > > >>> > > > >
>> > > > > > > >>> > > > > Vote open for 72 hours.
>> > > > > > > >>> > > > >
>> > > > > > > >>> > > > > [ ] +1
>> > > > > > > >>> > > > > [ ] +0
>> > > > > > > >>> > > > > [ ] -1
>> > > > > > > >>> > > > >
>> > > > > > > >>> > > > > Thanks,
>> > > > > > > >>> > > > >
>> > > > > > > >>> > > > > Stephen.
>> > > > > > > >>> > > >
>> > > > > > > >>> > > > ------------------------------
>> > > ------------------------------
>> > > > > > > >>> ---------
>> > > > > > > >>> > > > To unsubscribe, e-mail:
>> [hidden email]
>> > > > > > > >>> > > > For additional commands, e-mail:
>> > > [hidden email]
>> > > > > > > >>> >
>> > > > > > > >>> >
>> > > > > > > >>> >
>> > > > > > > >>> >
>> ------------------------------------------------------------
>> > > > > > ---------
>> > > > > > > >>> > To unsubscribe, e-mail:
>> [hidden email]
>> > > > > > > >>> > For additional commands, e-mail:
>> [hidden email]
>> > > > > > > >>> >
>> > > > > > > >>> > --
>> > > > > > > >>> Sent from my phone
>> > > > > > > >>>
>> > > > > > > >>
>> > > > > > > >>
>> > > > > > > >
>> > > > > >
>> > > > > > ------------------------------------------------------------
>> > > ---------
>> > > > > > To unsubscribe, e-mail: [hidden email]
>> > > > > > For additional commands, e-mail: [hidden email]
>> > > > > >
>> > > > > >
>> > > > >
>> > >
>> > > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: [hidden email]
>> > > For additional commands, e-mail: [hidden email]
>> > >
>> > >
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>> --
> Sent from my phone
>
--
Sent from my phone