Re: [VOTE] Release Apache Maven 3.5.1

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
12 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Arnaud Héritier
Tested on several projects

+1

On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly <
[hidden email]> wrote:

> Hi,
>
> We solved 25 issues:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> version=12338964&styleName=Text&projectId=12316922
>
> There are 350 issues left in JIRA for Maven core:
> <a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
> 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
> 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
>
> Staging repo:
> https://repository.apache.org/content/repositories/maven-1364/
>
> The distributable binaries and sources can be found here:
> https://repository.apache.org/content/repositories/maven-
> 1364/org/apache/maven/apache-maven/3.5.1/
>
> Specifically the zip, tarball and source archives can be found here:
> https://repository.apache.org/content/repositories/maven-
> 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip
> https://repository.apache.org/content/repositories/maven-
> 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz
> https://repository.apache.org/content/repositories/maven-
> 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip
> https://repository.apache.org/content/repositories/maven-
> 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz
>
> Source release checksum(s):
> apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7
> bd2059560d
> apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab69e698eb0e
>
> Git tag:
> https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
> 094e4e31a5af55bb17be87675da41d9aeca062f3
>
> Staging site:
> https://maven.apache.org/components/ref/3-LATEST/
>
> Vote open for 72 hours.
>
> [ ] +1
> [ ] +0
> [ ] -1
>
> Thanks,
>
> Stephen.
>



--
-----
Arnaud Héritier
http://aheritier.net
Mail/GTalk: aheritier AT gmail DOT com
Twitter/Skype : aheritier
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Dan Tran
Looks like 3.5.1 not able to resolve snapshot dependencies

i just clone out apache-maven and, change directory to apache-maven and
build from there

here is error

[ERROR] Failed to execute goal on project apache-maven: Could not resolve
dependencies for project org.apache.maven:apache-maven:pom:3.5.2-SNAPSHOT:
The following artifacts could not be resolved:
org.apache.maven:maven-embedder:jar:3.5.2-SNAPSHOT,
org.apache.maven:maven-core:jar:3.5.2-SNAPSHOT,
org.apache.maven:maven-compat:jar:3.5.2-SNAPSHOT,
org.apache.maven:maven-slf4j-provider:jar:3.5.2-SNAPSHOT: Could not find
artifact org.apache.maven:maven-embedder:jar:3.5.2-SNAPSHOT -> [Help 1]

my build is behind artifactory

Same issue also found at my  internal project


-Dan

On Sun, Sep 10, 2017 at 1:01 PM, Arnaud Héritier <[hidden email]>
wrote:

> Tested on several projects
>
> +1
>
> On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly <
> [hidden email]> wrote:
>
> > Hi,
> >
> > We solved 25 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > version=12338964&styleName=Text&projectId=12316922
> >
> > There are 350 issues left in JIRA for Maven core:
> > <a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
> > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
> > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1364/
> >
> > The distributable binaries and sources can be found here:
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/
> >
> > Specifically the zip, tarball and source archives can be found here:
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz
> >
> > Source release checksum(s):
> > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7
> > bd2059560d
> > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab
> 69e698eb0e
> >
> > Git tag:
> > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
> > 094e4e31a5af55bb17be87675da41d9aeca062f3
> >
> > Staging site:
> > https://maven.apache.org/components/ref/3-LATEST/
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > Thanks,
> >
> > Stephen.
> >
>
>
>
> --
> -----
> Arnaud Héritier
> http://aheritier.net
> Mail/GTalk: aheritier AT gmail DOT com
> Twitter/Skype : aheritier
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Dan Tran
In reply to this post by Arnaud Héritier
False alarm, I missed configure global settings.xml, it is missing the
default repository setup

-D

On Sun, Sep 10, 2017 at 11:47 PM, Tibor Digana <[hidden email]>
wrote:

> +1:
> 3.5.1 works in my project like a charm ;-)
>
> On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly <
> [hidden email]> wrote:
>
> > Hi,
> >
> > We solved 25 issues:
> > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > version=12338964&styleName=Text&projectId=12316922
> >
> > There are 350 issues left in JIRA for Maven core:
> > <a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
> > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
> > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> >
> > Staging repo:
> > https://repository.apache.org/content/repositories/maven-1364/
> >
> > The distributable binaries and sources can be found here:
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/
> >
> > Specifically the zip, tarball and source archives can be found here:
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip
> > https://repository.apache.org/content/repositories/maven-
> > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz
> >
> > Source release checksum(s):
> > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7
> > bd2059560d
> > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab
> 69e698eb0e
> >
> > Git tag:
> > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
> > 094e4e31a5af55bb17be87675da41d9aeca062f3
> >
> > Staging site:
> > https://maven.apache.org/components/ref/3-LATEST/
> >
> > Vote open for 72 hours.
> >
> > [ ] +1
> > [ ] +0
> > [ ] -1
> >
> > Thanks,
> >
> > Stephen.
> >
>
>
>
> --
> Cheers
> Tibor
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

stephenconnolly
http://git-wip-us.apache.org/repos/asf/maven/diff/542a7a89 to defang the
test going forward, with that change on Azul's Zulu JDK 7 I get:

Linux ddf0318b698b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
x86_64 x86_64 GNU/Linux
Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
2017-09-10T12:42:54Z)
Maven home: /work/bin
Java version: 1.7.0_154, vendor: Azul Systems, Inc.
Java home: /usr/lib/jvm/zulu-7-amd64/jre
Default locale: en_US, platform encoding: UTF-8
OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"

mvn verify => SUCCESS


On 11 September 2017 at 02:00, Stephen Connolly <
[hidden email]> wrote:

> So Azul's Zulu 7 does not have
>
> com.sun.script.javascript.RhinoScriptEngineFactory or any
> ScriptEngineFactory in the base classloader...
>
> Zulu 8 has jdk.nashorn.api.scripting.NashornScriptEngineFactory
>
> So at this point in time, my analysis is that the
> DefaultClassRealmManagerTest is not a valid test when the default
> classloader does not have any ScriptEngineFactory... I'm going to commit
> a fix, but this should not invalidate the 3.5.1 release
>
> On 11 September 2017 at 01:53, Stephen Connolly <
> [hidden email]> wrote:
>
>> With https://github.com/apache/maven-integration-testing/
>> commit/a08d65bfb5fedec9f684c13bf5a0dccb96f5cc56 I was able to get
>> Michael's test failures:
>>
>> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
>> 2017-09-10T12:42:54Z)
>> Maven home: /work/bin
>> Java version: 1.7.0_154, vendor: Azul Systems, Inc.
>> Java home: /usr/lib/jvm/zulu-7-amd64/jre
>> Default locale: en_US, platform encoding: UTF-8
>> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"
>>
>>
>> ------------------------------------------------------------
>> -------------------
>> Test set: org.apache.maven.classrealm.DefaultClassRealmManagerTest
>> ------------------------------------------------------------
>> -------------------
>> Tests run: 5, Failures: 5, Errors: 0, Skipped: 0, Time elapsed: 2.128 sec
>> <<< FAILURE! - in org.apache.maven.classrealm.De
>> faultClassRealmManagerTest
>> testMNG6275_mavenApiRealmDefaultParentClassLoader(org.
>> apache.maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed:
>> 1.12 sec  <<< FAILURE!
>> junit.framework.AssertionFailedError: null
>> at junit.framework.Assert.fail(Assert.java:55)
>> at junit.framework.Assert.assertTrue(Assert.java:22)
>> at junit.framework.Assert.assertTrue(Assert.java:31)
>> at junit.framework.TestCase.assertTrue(TestCase.java:201)
>> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
>> tMNG6275_mavenApiRealmDefaultParentClassLoader(DefaultClassR
>> ealmManagerTest.java:91)
>>
>> testMNG6275_coreRealmDefaultParentClassLoader(org.apache.
>> maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed: 0.271 sec
>>  <<< FAILURE!
>> junit.framework.AssertionFailedError: null
>> at junit.framework.Assert.fail(Assert.java:55)
>> at junit.framework.Assert.assertTrue(Assert.java:22)
>> at junit.framework.Assert.assertTrue(Assert.java:31)
>> at junit.framework.TestCase.assertTrue(TestCase.java:201)
>> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
>> tMNG6275_coreRealmDefaultParentClassLoader(DefaultClassRealm
>> ManagerTest.java:99)
>>
>> testMNG6275_extensionRealmDefaultParentClassLoader(org.
>> apache.maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed:
>> 0.251 sec  <<< FAILURE!
>> junit.framework.AssertionFailedError: null
>> at junit.framework.Assert.fail(Assert.java:55)
>> at junit.framework.Assert.assertTrue(Assert.java:22)
>> at junit.framework.Assert.assertTrue(Assert.java:31)
>> at junit.framework.TestCase.assertTrue(TestCase.java:201)
>> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
>> tMNG6275_extensionRealmDefaultParentClassLoader(DefaultClass
>> RealmManagerTest.java:73)
>>
>> testMNG6275_pluginRealmDefaultParentClassLoader(org.apache.
>> maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed: 0.244 sec
>>  <<< FAILURE!
>> junit.framework.AssertionFailedError: null
>> at junit.framework.Assert.fail(Assert.java:55)
>> at junit.framework.Assert.assertTrue(Assert.java:22)
>> at junit.framework.Assert.assertTrue(Assert.java:31)
>> at junit.framework.TestCase.assertTrue(TestCase.java:201)
>> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
>> tMNG6275_pluginRealmDefaultParentClassLoader(DefaultClassRea
>> lmManagerTest.java:62)
>>
>> testMNG6275_projectRealmDefaultParentClassLoader(org.apache.
>> maven.classrealm.DefaultClassRealmManagerTest)  Time elapsed: 0.242 sec
>>  <<< FAILURE!
>> junit.framework.AssertionFailedError: null
>> at junit.framework.Assert.fail(Assert.java:55)
>> at junit.framework.Assert.assertTrue(Assert.java:22)
>> at junit.framework.Assert.assertTrue(Assert.java:31)
>> at junit.framework.TestCase.assertTrue(TestCase.java:201)
>> at org.apache.maven.classrealm.DefaultClassRealmManagerTest.tes
>> tMNG6275_projectRealmDefaultParentClassLoader(DefaultClassRe
>> almManagerTest.java:83)
>>
>> investigating...
>>
>> On 11 September 2017 at 01:44, Stephen Connolly <
>> [hidden email]> wrote:
>>
>>> Building the source bundles with the binary bundles in the staging repo
>>> using the Dockerfile environments in https://github.com/apache/mave
>>> n-integration-testing/tree/master/environments
>>>
>>> Debian JDK 7
>>> ===========
>>>
>>> Linux 65fb832dfe43 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
>>> GNU/Linux
>>> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
>>> 2017-09-10T12:42:54Z)
>>> Maven home: /work/bin
>>> Java version: 1.7.0_151, vendor: Oracle Corporation
>>> Java home: /usr/lib/jvm/java-7-openjdk-amd64/jre
>>> Default locale: en, platform encoding: UTF-8
>>> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"
>>>
>>> mvn verify => SUCCESS
>>>
>>> Debian JDK 8
>>> ===========
>>>
>>> Linux 11ef1c114b6b 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
>>> GNU/Linux
>>> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
>>> 2017-09-10T12:42:54Z)
>>> Maven home: /work/bin
>>> Java version: 1.8.0_141, vendor: Oracle Corporation
>>> Java home: /usr/lib/jvm/java-8-openjdk-amd64/jre
>>> Default locale: en, platform encoding: UTF-8
>>> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"
>>>
>>> mvn verify => SUCCESS
>>>
>>> Fedora JDK 8
>>> ===========
>>>
>>> Linux 54211a0e694e 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
>>> x86_64 x86_64 GNU/Linux
>>> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
>>> 2017-09-10T12:42:54Z)
>>> Maven home: /work/bin
>>> Java version: 1.8.0_144, vendor: Oracle Corporation
>>> Java home: /usr/lib/jvm/java-1.8.0-openjdk-1.8.0.144-5.b01.fc26.x86_64/
>>> jre
>>> Default locale: en_US, platform encoding: ANSI_X3.4-1968
>>> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"
>>>
>>> mvn verify => SUCCESS
>>>
>>> IBM JDK 8
>>> ========
>>>
>>> Linux 199631edceed 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
>>> x86_64 x86_64 GNU/Linux
>>> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
>>> 2017-09-10T12:42:54Z)
>>> Maven home: /work/bin
>>> Java version: 1.8.0, vendor: IBM Corporation
>>> Java home: /opt/ibm/java/jre
>>> Default locale: en_US, platform encoding: ANSI_X3.4-1968
>>> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"
>>>
>>> mvn verify => SUCCESS
>>>
>>> Asul Zulu JDK 8
>>> =============
>>>
>>> Linux 10e8f4e46138 4.9.46-moby #1 SMP Thu Sep 7 02:53:42 UTC 2017 x86_64
>>> x86_64 x86_64 GNU/Linux
>>> Apache Maven 3.5.1 (094e4e31a5af55bb17be87675da41d9aeca062f3;
>>> 2017-09-10T12:42:54Z)
>>> Maven home: /work/bin
>>> Java version: 1.8.0_144, vendor: Azul Systems, Inc.
>>> Java home: /usr/lib/jvm/zulu-8-amd64/jre
>>> Default locale: en_US, platform encoding: UTF-8
>>> OS name: "linux", version: "4.9.46-moby", arch: "amd64", family: "unix"
>>>
>>> mvn verify => SUCCESS
>>>
>>> If I get time later I'll run the integration tests.
>>>
>>> On 11 September 2017 at 00:20, Dan Tran <[hidden email]> wrote:
>>>
>>>> False alarm, I missed configure global settings.xml, it is missing the
>>>> default repository setup
>>>>
>>>> -D
>>>>
>>>> On Sun, Sep 10, 2017 at 11:47 PM, Tibor Digana <
>>>> [hidden email]>
>>>> wrote:
>>>>
>>>> > +1:
>>>> > 3.5.1 works in my project like a charm ;-)
>>>> >
>>>> > On Sun, Sep 10, 2017 at 5:39 PM, Stephen Connolly <
>>>> > [hidden email]> wrote:
>>>> >
>>>> > > Hi,
>>>> > >
>>>> > > We solved 25 issues:
>>>> > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
>>>> > > version=12338964&styleName=Text&projectId=12316922
>>>> > >
>>>> > > There are 350 issues left in JIRA for Maven core:
>>>> > > <a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
>>>> > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
>>>> > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
>>>> > >
>>>> > > Staging repo:
>>>> > > https://repository.apache.org/content/repositories/maven-1364/
>>>> > >
>>>> > > The distributable binaries and sources can be found here:
>>>> > > https://repository.apache.org/content/repositories/maven-
>>>> > > 1364/org/apache/maven/apache-maven/3.5.1/
>>>> > >
>>>> > > Specifically the zip, tarball and source archives can be found here:
>>>> > > https://repository.apache.org/content/repositories/maven-
>>>> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip
>>>> > > https://repository.apache.org/content/repositories/maven-
>>>> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-
>>>> bin.tar.gz
>>>> > > https://repository.apache.org/content/repositories/maven-
>>>> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip
>>>> > > https://repository.apache.org/content/repositories/maven-
>>>> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-
>>>> src.tar.gz
>>>> > >
>>>> > > Source release checksum(s):
>>>> > > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7
>>>> > > bd2059560d
>>>> > > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab
>>>> > 69e698eb0e
>>>> > >
>>>> > > Git tag:
>>>> > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
>>>> > > 094e4e31a5af55bb17be87675da41d9aeca062f3
>>>> > >
>>>> > > Staging site:
>>>> > > https://maven.apache.org/components/ref/3-LATEST/
>>>> > >
>>>> > > Vote open for 72 hours.
>>>> > >
>>>> > > [ ] +1
>>>> > > [ ] +0
>>>> > > [ ] -1
>>>> > >
>>>> > > Thanks,
>>>> > >
>>>> > > Stephen.
>>>> > >
>>>> >
>>>> >
>>>> >
>>>> > --
>>>> > Cheers
>>>> > Tibor
>>>> >
>>>>
>>>
>>>
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

thomas COLLIGNON
In reply to this post by Arnaud Héritier
Hello

+1 for me

2017-09-12 20:54 GMT+02:00 Stephen Connolly <[hidden email]
>:

> Have we got any feedback from the embedder integrations yet?
>
> On Mon 11 Sep 2017 at 22:57, Hervé BOUTEMY <[hidden email]> wrote:
>
> > just for the records: it is Windows + Git Bash (MINGW64) only
> >
> > and there is a chance that adding -Djansi.force=true can force JAnsi
> > activation (even if JAnsi fails to detect that it should auto-activate)
> >
> > details on issue in https://issues.apache.org/jira/browse/MNG-6282 ,
> and a
> > future JAnsi issue...
> >
> > Regards,
> >
> > Hervé
> >
> > Le lundi 11 septembre 2017, 12:53:46 CEST Stephen Connolly a écrit :
> > > So that is windows only, or were they lost on other OSes for you.
> > >
> > > I have colours on linux (via docker) and os-x
> > >
> > > On 11 September 2017 at 12:35, [hidden email] <
> [hidden email]>
> > >
> > > wrote:
> > > > +1 (conditionally).
> > > >
> > > > Tested via project that includes dozen of plugins: 1st tier, MojoHaus
> > and
> > > > few 3rd party plugins (so to say).
> > > >
> > > > Everything looks good with one notable regression:
> > > > https://issues.apache.org/jira/browse/MNG-6282 Console output has no
> > > > colors (regression in Maven 3.5.1)
> > > >
> > > > Regards,
> > > > Dejan
> > > >
> > > > On 2017-09-10 17:39, Stephen Connolly <stephen.alan.connolly@gmail.
> com
> > >
> > > >
> > > > wrote:
> > > > > Hi,
> > > > >
> > > > > We solved 25 issues:
> > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > >
> > > > version=12338964&styleName=Text&projectId=12316922
> > > >
> > > > > There are 350 issues left in JIRA for Maven core:
> > > > > <a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
> > > >
> > > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
> > > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> > > >
> > > > > Staging repo:
> > > > > https://repository.apache.org/content/repositories/maven-1364/
> > > > >
> > > > > The distributable binaries and sources can be found here:
> > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > 1364/org/apache/maven/apache-maven/3.5.1/
> > > >
> > > > > Specifically the zip, tarball and source archives can be found
> here:
> > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip
> > > >
> > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.
> 1-bin.tar.gz
> > > >
> > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip
> > > >
> > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.
> 1-src.tar.gz
> > > >
> > > > > Source release checksum(s):
> > > > > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7
> > > >
> > > > bd2059560d
> > > >
> > > > > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab
> > > >
> > > > 69e698eb0e
> > > >
> > > > > Git tag:
> > > > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
> > > >
> > > > 094e4e31a5af55bb17be87675da41d9aeca062f3
> > > >
> > > > > Staging site:
> > > > > https://maven.apache.org/components/ref/3-LATEST/
> > > > >
> > > > > Vote open for 72 hours.
> > > > >
> > > > > [ ] +1
> > > > > [ ] +0
> > > > > [ ] -1
> > > > >
> > > > > Thanks,
> > > > >
> > > > > Stephen.
> > > >
> > > > ------------------------------------------------------------
> ---------
> > > > To unsubscribe, e-mail: [hidden email]
> > > > For additional commands, e-mail: [hidden email]
> >
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> > --
> Sent from my phone
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Grzegorz Grzybek
Hello

+1 (non-binding) - tested Fuse/Karaf/OSGi projects

regards
Grzegorz Grzybek

2017-09-13 8:00 GMT+02:00 Thomas Collignon <[hidden email]>:

> Hello
>
> +1 for me
>
> 2017-09-12 20:54 GMT+02:00 Stephen Connolly <stephen.alan.connolly@gmail.
> com
> >:
>
> > Have we got any feedback from the embedder integrations yet?
> >
> > On Mon 11 Sep 2017 at 22:57, Hervé BOUTEMY <[hidden email]>
> wrote:
> >
> > > just for the records: it is Windows + Git Bash (MINGW64) only
> > >
> > > and there is a chance that adding -Djansi.force=true can force JAnsi
> > > activation (even if JAnsi fails to detect that it should auto-activate)
> > >
> > > details on issue in https://issues.apache.org/jira/browse/MNG-6282 ,
> > and a
> > > future JAnsi issue...
> > >
> > > Regards,
> > >
> > > Hervé
> > >
> > > Le lundi 11 septembre 2017, 12:53:46 CEST Stephen Connolly a écrit :
> > > > So that is windows only, or were they lost on other OSes for you.
> > > >
> > > > I have colours on linux (via docker) and os-x
> > > >
> > > > On 11 September 2017 at 12:35, [hidden email] <
> > [hidden email]>
> > > >
> > > > wrote:
> > > > > +1 (conditionally).
> > > > >
> > > > > Tested via project that includes dozen of plugins: 1st tier,
> MojoHaus
> > > and
> > > > > few 3rd party plugins (so to say).
> > > > >
> > > > > Everything looks good with one notable regression:
> > > > > https://issues.apache.org/jira/browse/MNG-6282 Console output has
> no
> > > > > colors (regression in Maven 3.5.1)
> > > > >
> > > > > Regards,
> > > > > Dejan
> > > > >
> > > > > On 2017-09-10 17:39, Stephen Connolly <stephen.alan.connolly@gmail.
> > com
> > > >
> > > > >
> > > > > wrote:
> > > > > > Hi,
> > > > > >
> > > > > > We solved 25 issues:
> > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > > >
> > > > > version=12338964&styleName=Text&projectId=12316922
> > > > >
> > > > > > There are 350 issues left in JIRA for Maven core:
> > > > > > <a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
> > > > >
> > > > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
> > > > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> > > > >
> > > > > > Staging repo:
> > > > > > https://repository.apache.org/content/repositories/maven-1364/
> > > > > >
> > > > > > The distributable binaries and sources can be found here:
> > > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > > 1364/org/apache/maven/apache-maven/3.5.1/
> > > > >
> > > > > > Specifically the zip, tarball and source archives can be found
> > here:
> > > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.
> 1-bin.zip
> > > > >
> > > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.
> > 1-bin.tar.gz
> > > > >
> > > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.
> 1-src.zip
> > > > >
> > > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.
> > 1-src.tar.gz
> > > > >
> > > > > > Source release checksum(s):
> > > > > > apache-maven-3.5.1-src.tar.gz sha1:
> 9eb821f153c7667194aa11ccd099b7
> > > > >
> > > > > bd2059560d
> > > > >
> > > > > > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab
> > > > >
> > > > > 69e698eb0e
> > > > >
> > > > > > Git tag:
> > > > > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
> > > > >
> > > > > 094e4e31a5af55bb17be87675da41d9aeca062f3
> > > > >
> > > > > > Staging site:
> > > > > > https://maven.apache.org/components/ref/3-LATEST/
> > > > > >
> > > > > > Vote open for 72 hours.
> > > > > >
> > > > > > [ ] +1
> > > > > > [ ] +0
> > > > > > [ ] -1
> > > > > >
> > > > > > Thanks,
> > > > > >
> > > > > > Stephen.
> > > > >
> > > > > ------------------------------------------------------------
> > ---------
> > > > > To unsubscribe, e-mail: [hidden email]
> > > > > For additional commands, e-mail: [hidden email]
> > >
> > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [hidden email]
> > > For additional commands, e-mail: [hidden email]
> > >
> > > --
> > Sent from my phone
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Petar Tahchiev
+1 - go for it.


2017-09-13 9:04 GMT+03:00 Grzegorz Grzybek <[hidden email]>:

> Hello
>
> +1 (non-binding) - tested Fuse/Karaf/OSGi projects
>
> regards
> Grzegorz Grzybek
>
> 2017-09-13 8:00 GMT+02:00 Thomas Collignon <[hidden email]>:
>
> > Hello
> >
> > +1 for me
> >
> > 2017-09-12 20:54 GMT+02:00 Stephen Connolly <stephen.alan.connolly@gmail.
> > com
> > >:
> >
> > > Have we got any feedback from the embedder integrations yet?
> > >
> > > On Mon 11 Sep 2017 at 22:57, Hervé BOUTEMY <[hidden email]>
> > wrote:
> > >
> > > > just for the records: it is Windows + Git Bash (MINGW64) only
> > > >
> > > > and there is a chance that adding -Djansi.force=true can force JAnsi
> > > > activation (even if JAnsi fails to detect that it should
> auto-activate)
> > > >
> > > > details on issue in https://issues.apache.org/jira/browse/MNG-6282 ,
> > > and a
> > > > future JAnsi issue...
> > > >
> > > > Regards,
> > > >
> > > > Hervé
> > > >
> > > > Le lundi 11 septembre 2017, 12:53:46 CEST Stephen Connolly a écrit :
> > > > > So that is windows only, or were they lost on other OSes for you.
> > > > >
> > > > > I have colours on linux (via docker) and os-x
> > > > >
> > > > > On 11 September 2017 at 12:35, [hidden email] <
> > > [hidden email]>
> > > > >
> > > > > wrote:
> > > > > > +1 (conditionally).
> > > > > >
> > > > > > Tested via project that includes dozen of plugins: 1st tier,
> > MojoHaus
> > > > and
> > > > > > few 3rd party plugins (so to say).
> > > > > >
> > > > > > Everything looks good with one notable regression:
> > > > > > https://issues.apache.org/jira/browse/MNG-6282 Console output
> has
> > no
> > > > > > colors (regression in Maven 3.5.1)
> > > > > >
> > > > > > Regards,
> > > > > > Dejan
> > > > > >
> > > > > > On 2017-09-10 17:39, Stephen Connolly
> <stephen.alan.connolly@gmail.
> > > com
> > > > >
> > > > > >
> > > > > > wrote:
> > > > > > > Hi,
> > > > > > >
> > > > > > > We solved 25 issues:
> > > > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > > > >
> > > > > > version=12338964&styleName=Text&projectId=12316922
> > > > > >
> > > > > > > There are 350 issues left in JIRA for Maven core:
> > > > > > > <a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
> > > > > >
> > > > > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
> > > > > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> > > > > >
> > > > > > > Staging repo:
> > > > > > > https://repository.apache.org/content/repositories/maven-1364/
> > > > > > >
> > > > > > > The distributable binaries and sources can be found here:
> > > > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > > > 1364/org/apache/maven/apache-maven/3.5.1/
> > > > > >
> > > > > > > Specifically the zip, tarball and source archives can be found
> > > here:
> > > > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.
> > 1-bin.zip
> > > > > >
> > > > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.
> > > 1-bin.tar.gz
> > > > > >
> > > > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.
> > 1-src.zip
> > > > > >
> > > > > > > https://repository.apache.org/content/repositories/maven-> >
> > > > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.
> > > 1-src.tar.gz
> > > > > >
> > > > > > > Source release checksum(s):
> > > > > > > apache-maven-3.5.1-src.tar.gz sha1:
> > 9eb821f153c7667194aa11ccd099b7
> > > > > >
> > > > > > bd2059560d
> > > > > >
> > > > > > > apache-maven-3.5.1-src.zip: sha1:
> 121d54b045380a8a4895eb137970ab
> > > > > >
> > > > > > 69e698eb0e
> > > > > >
> > > > > > > Git tag:
> > > > > > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=
> commit;h=
> > > > > >
> > > > > > 094e4e31a5af55bb17be87675da41d9aeca062f3
> > > > > >
> > > > > > > Staging site:
> > > > > > > https://maven.apache.org/components/ref/3-LATEST/
> > > > > > >
> > > > > > > Vote open for 72 hours.
> > > > > > >
> > > > > > > [ ] +1
> > > > > > > [ ] +0
> > > > > > > [ ] -1
> > > > > > >
> > > > > > > Thanks,
> > > > > > >
> > > > > > > Stephen.
> > > > > >
> > > > > > ------------------------------------------------------------
> > > ---------
> > > > > > To unsubscribe, e-mail: [hidden email]
> > > > > > For additional commands, e-mail: [hidden email]
> > > >
> > > >
> > > >
> > > > ------------------------------------------------------------
> ---------
> > > > To unsubscribe, e-mail: [hidden email]
> > > > For additional commands, e-mail: [hidden email]
> > > >
> > > > --
> > > Sent from my phone
> > >
> >
>



--
Regards, Petar!
Karlovo, Bulgaria.
---
Public PGP Key at:
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x19658550C3110611
Key Fingerprint: A369 A7EE 61BC 93A3 CDFF  55A5 1965 8550 C311 0611
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Robert Scholte-3
In reply to this post by Arnaud Héritier
Just received the confirmation that netbeans uses the cli, so there should be no issue there. 
Robert 
Verzonden vanaf mijn Samsung Galaxy-smartphone.
-------- Oorspronkelijk bericht --------Van: Stephen Connolly <[hidden email]> Datum: 13-09-17  10:05  (GMT+01:00) Aan: Maven Developers List <[hidden email]> Onderwerp: Re: [VOTE] Release Apache Maven 3.5.1
On 13 September 2017 at 00:26, Anders Hammar <[hidden email]> wrote:

> On Tue, Sep 12, 2017 at 8:54 PM, Stephen Connolly <
> [hidden email]> wrote:
>
> > Have we got any feedback from the embedder integrations yet?
> >
>
> I haven't heard anything from the m2e people. Maybe we need to ping them
> directly. I can contact Fred Bricon.
>
> /Anders
>
>
Please do, also if anyone has a contact in netbeans or intellij and could
let them know we'd like either feedback or "we're ok if MNG-6275 makes
trouble for us, go ahead and release". I'd like to close the vote on Friday
13:00 UTC.
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Mark Derricutt
In reply to this post by Arnaud Héritier

On 14 Sep 2017, at 10:26, Mark Derricutt wrote:

Calling -2 for vote if not too late.

Actually - looking at the commit diff, I see in our code we did have <extensions>true</extensions> for the jasmine-maven-plugin which we don't actually need. Removing that from the mojo definition and running my build with the staged 3.5.1 release and everything builds fine.

+2 non-binding from Mark!

Mark


"The ease with which a change can be implemented has no relevance at all to whether it is the right change for the (Java) Platform for all time." — Mark Reinhold.

Mark Derricutt
http://www.theoryinpractice.net
http://www.chaliceofblood.net
http://plus.google.com/+MarkDerricutt
http://twitter.com/talios
http://facebook.com/mderricutt


signature.asc (494 bytes) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Hervé BOUTEMY
In reply to this post by Arnaud Héritier
+1
works well in everything I tested, colour on Windows with GitBash or Cygwin or
any other Unix layer taken apart (in fact anything on WIndows that provides
"TERM=xterm")

workaround for those Windows users: add -Djansi.force=true to MAVEN_OPTS
the only drawback will only be if you redirect stdout/stderr to a file: ANSI
escape codes will be present, unless you run "mvn -B" or disable color at
Maven level

I know, this is a little bit tricky, but not so complex (it may help people
discover how JAnsi is working and how Maven integrates it): I still need to
continue investigation in JAnsi, provide a complete analysis with a fix, get it
merged, have a release, then integrate in Maven...
Maven Jira issue: https://issues.apache.org/jira/browse/MNG-6282
JAnsi GitHub issue: https://github.com/fusesource/jansi/issues/94

Thank you to Dejan Stojadinović for reporting the issue then working with me
to investigate in detail: such contribution is greatly appreciated.
And thanks in advance to JAnsi team who will surely help me when I'll ping
them, as they did in the past (cross projects contribution is great!) :)

Regards,

Hervé

Le lundi 11 septembre 2017, 23:56:58 CEST Hervé BOUTEMY a écrit :

> just for the records: it is Windows + Git Bash (MINGW64) only
>
> and there is a chance that adding -Djansi.force=true can force JAnsi
> activation (even if JAnsi fails to detect that it should auto-activate)
>
> details on issue in https://issues.apache.org/jira/browse/MNG-6282 , and a
> future JAnsi issue...
>
> Regards,
>
> Hervé
>
> Le lundi 11 septembre 2017, 12:53:46 CEST Stephen Connolly a écrit :
> > So that is windows only, or were they lost on other OSes for you.
> >
> > I have colours on linux (via docker) and os-x
> >
> > On 11 September 2017 at 12:35, [hidden email] <[hidden email]>
> >
> > wrote:
> > > +1 (conditionally).
> > >
> > > Tested via project that includes dozen of plugins: 1st tier, MojoHaus
> > > and
> > > few 3rd party plugins (so to say).
> > >
> > > Everything looks good with one notable regression:
> > > https://issues.apache.org/jira/browse/MNG-6282 Console output has no
> > > colors (regression in Maven 3.5.1)
> > >
> > > Regards,
> > > Dejan
> > >
> > > On 2017-09-10 17:39, Stephen Connolly <[hidden email]>
> > >
> > > wrote:
> > > > Hi,
> > > >
> > > > We solved 25 issues:
> > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > >
> > > version=12338964&styleName=Text&projectId=12316922
> > >
> > > > There are 350 issues left in JIRA for Maven core:
> > > > <a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
> > >
> > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
> > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> > >
> > > > Staging repo:
> > > > https://repository.apache.org/content/repositories/maven-1364/
> > > >
> > > > The distributable binaries and sources can be found here:
> > > > https://repository.apache.org/content/repositories/maven-> >
> > >
> > > 1364/org/apache/maven/apache-maven/3.5.1/
> > >
> > > > Specifically the zip, tarball and source archives can be found here:
> > > > https://repository.apache.org/content/repositories/maven-> >
> > >
> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.zip
> > >
> > > > https://repository.apache.org/content/repositories/maven-> >
> > >
> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-bin.tar.gz
> > >
> > > > https://repository.apache.org/content/repositories/maven-> >
> > >
> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.zip
> > >
> > > > https://repository.apache.org/content/repositories/maven-> >
> > >
> > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-src.tar.gz
> > >
> > > > Source release checksum(s):
> > > > apache-maven-3.5.1-src.tar.gz sha1: 9eb821f153c7667194aa11ccd099b7
> > >
> > > bd2059560d
> > >
> > > > apache-maven-3.5.1-src.zip: sha1: 121d54b045380a8a4895eb137970ab
> > >
> > > 69e698eb0e
> > >
> > > > Git tag:
> > > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=commit;h=
> > >
> > > 094e4e31a5af55bb17be87675da41d9aeca062f3
> > >
> > > > Staging site:
> > > > https://maven.apache.org/components/ref/3-LATEST/
> > > >
> > > > Vote open for 72 hours.
> > > >
> > > > [ ] +1
> > > > [ ] +0
> > > > [ ] -1
> > > >
> > > > Thanks,
> > > >
> > > > Stephen.
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [hidden email]
> > > For additional commands, e-mail: [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Igor Fedorenko-3
In reply to this post by Arnaud Héritier
Has anyone tried wiring jvm extensions ClassLoader as foreign import to
plugin/extensions realms? Jvm extensions classloader is little tricky to
get to (see how this is done in java.util.ServiceLoader.loadInstalled),
but I think this will solve ServiceLoader/MNG-6275 without polluting
plugin classpath too much.

--
Regards,
Igor

On Fri, Sep 15, 2017, at 08:32 AM, Mark Derricutt wrote:

> Would it be possible to handle this in a somewhat similar way to
> threadSafe
> mojos - some form of plugin flag that says "extensionSafe" [1], that if
> the
> plugin has <extensions>true</extensions> declared and doesn't declare
> itself as being extensionSafe/extensionAware then we log a build warning
> -
> it wouldn't solve anything, other than giving some feedback to users some
> indication of WHY their build fails under 3.5.1 - and to either remove
> <extensions> or fix/update their plugins.
>
> [1] Or even just infer the applicability of extensions by the presence of
> custom lifecycles, or Mojos implementing the extension interfaces ( it's
> midnight, and a hazy tired thought ).
>
> --
> "Great artists are extremely selfish and arrogant things" — Steven
> Wilson,
> Porcupine Tree
>
> On Sat, Sep 16, 2017 at 12:22 AM, Anders Hammar <[hidden email]>
> wrote:
>
> > Based on Igor's feedback I'm changing my vote to +1.
> >
> > Having this class loader change in a bug fix release is probably not
> > (semver) ideal though.
> >
> > /Anders
> >
> > On Fri, Sep 15, 2017 at 2:12 PM, Igor Fedorenko <[hidden email]>
> > wrote:
> >
> > > I answered in more details on m2e-dev, but I believe we can compensate
> > > for the change from m2e end. In the worst case we'll bundle hacked
> > > version of DefaultClassRealmManager with m2e, not ideal, but not the end
> > > of the world either.
> > >
> > > --
> > > Regards,
> > > Igor
> > >
> > > On Fri, Sep 15, 2017, at 07:21 AM, Anders Hammar wrote:
> > > > On Fri, Sep 15, 2017 at 8:29 AM, Anders Hammar <[hidden email]>
> > > wrote:
> > > >
> > > > > Reporting back from tests of m2e with embedded Maven 3.5.1, we see
> > > problem
> > > > > with the jaxws-maven-plugin mojo. We're two people seeing the issue
> > > > > independently, but unfortunately Fred Bricon hasn't been able to
> > > reproduce.
> > > > >
> > > >
> > > > To follow up on this, my tests indicate that Maven 3.5.1 causes changed
> > > > class loading that could cause issues for plugins in m2e. I've asked
> > for
> > > > input from the m2e devs if it is possible to handle in m2e but they
> > > > haven't
> > > > responded yet.
> > > >
> > > > /Anders
> > > >
> > > >
> > > > >
> > > > > So currently I'm 0 on the voting but I'll investigate some more.
> > > > >
> > > > > /Anders
> > > > >
> > > > > On Wed, Sep 13, 2017 at 9:26 AM, Anders Hammar <[hidden email]>
> > > wrote:
> > > > >
> > > > >>
> > > > >>
> > > > >> On Tue, Sep 12, 2017 at 8:54 PM, Stephen Connolly <
> > > > >> [hidden email]> wrote:
> > > > >>
> > > > >>> Have we got any feedback from the embedder integrations yet?
> > > > >>>
> > > > >>
> > > > >> I haven't heard anything from the m2e people. Maybe we need to ping
> > > them
> > > > >> directly. I can contact Fred Bricon.
> > > > >>
> > > > >> /Anders
> > > > >>
> > > > >>
> > > > >>>
> > > > >>> On Mon 11 Sep 2017 at 22:57, Hervé BOUTEMY <[hidden email]>
> > > > >>> wrote:
> > > > >>>
> > > > >>> > just for the records: it is Windows + Git Bash (MINGW64) only
> > > > >>> >
> > > > >>> > and there is a chance that adding -Djansi.force=true can force
> > > JAnsi
> > > > >>> > activation (even if JAnsi fails to detect that it should
> > > auto-activate)
> > > > >>> >
> > > > >>> > details on issue in https://issues.apache.org/
> > jira/browse/MNG-6282
> > > ,
> > > > >>> and a
> > > > >>> > future JAnsi issue...
> > > > >>> >
> > > > >>> > Regards,
> > > > >>> >
> > > > >>> > Hervé
> > > > >>> >
> > > > >>> > Le lundi 11 septembre 2017, 12:53:46 CEST Stephen Connolly a
> > écrit
> > > :
> > > > >>> > > So that is windows only, or were they lost on other OSes for
> > you.
> > > > >>> > >
> > > > >>> > > I have colours on linux (via docker) and os-x
> > > > >>> > >
> > > > >>> > > On 11 September 2017 at 12:35, [hidden email] <
> > > > >>> [hidden email]>
> > > > >>> > >
> > > > >>> > > wrote:
> > > > >>> > > > +1 (conditionally).
> > > > >>> > > >
> > > > >>> > > > Tested via project that includes dozen of plugins: 1st tier,
> > > > >>> MojoHaus
> > > > >>> > and
> > > > >>> > > > few 3rd party plugins (so to say).
> > > > >>> > > >
> > > > >>> > > > Everything looks good with one notable regression:
> > > > >>> > > > https://issues.apache.org/jira/browse/MNG-6282 Console
> > output
> > > has
> > > > >>> no
> > > > >>> > > > colors (regression in Maven 3.5.1)
> > > > >>> > > >
> > > > >>> > > > Regards,
> > > > >>> > > > Dejan
> > > > >>> > > >
> > > > >>> > > > On 2017-09-10 17:39, Stephen Connolly <
> > > > >>> [hidden email]
> > > > >>> > >
> > > > >>> > > >
> > > > >>> > > > wrote:
> > > > >>> > > > > Hi,
> > > > >>> > > > >
> > > > >>> > > > > We solved 25 issues:
> > > > >>> > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?
> > > > >>> > > >
> > > > >>> > > > version=12338964&styleName=Text&projectId=12316922
> > > > >>> > > >
> > > > >>> > > > > There are 350 issues left in JIRA for Maven core:
> > > > >>> > > > > <a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
> > > > >>> > > >
> > > > >>> > > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
> > > > >>> > > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> > > > >>> > > >
> > > > >>> > > > > Staging repo:
> > > > >>> > > > > https://repository.apache.org/content/repositories/maven-
> > > 1364/
> > > > >>> > > > >
> > > > >>> > > > > The distributable binaries and sources can be found here:
> > > > >>> > > > > https://repository.apache.org/content/repositories/maven->
> > >
> > > > >>> > > > 1364/org/apache/maven/apache-maven/3.5.1/
> > > > >>> > > >
> > > > >>> > > > > Specifically the zip, tarball and source archives can be
> > > found
> > > > >>> here:
> > > > >>> > > > > https://repository.apache.org/content/repositories/maven->
> > >
> > > > >>> > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-
> > > > >>> bin.zip
> > > > >>> > > >
> > > > >>> > > > > https://repository.apache.org/content/repositories/maven->
> > >
> > > > >>> > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-
> > > > >>> bin.tar.gz
> > > > >>> > > >
> > > > >>> > > > > https://repository.apache.org/content/repositories/maven->
> > >
> > > > >>> > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-
> > > > >>> src.zip
> > > > >>> > > >
> > > > >>> > > > > https://repository.apache.org/content/repositories/maven->
> > >
> > > > >>> > > > 1364/org/apache/maven/apache-maven/3.5.1/apache-maven-3.5.1-
> > > > >>> src.tar.gz
> > > > >>> > > >
> > > > >>> > > > > Source release checksum(s):
> > > > >>> > > > > apache-maven-3.5.1-src.tar.gz sha1:
> > > > >>> 9eb821f153c7667194aa11ccd099b7
> > > > >>> > > >
> > > > >>> > > > bd2059560d
> > > > >>> > > >
> > > > >>> > > > > apache-maven-3.5.1-src.zip: sha1:
> > > 121d54b045380a8a4895eb137970ab
> > > > >>> > > >
> > > > >>> > > > 69e698eb0e
> > > > >>> > > >
> > > > >>> > > > > Git tag:
> > > > >>> > > > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=
> > > commit;h=
> > > > >>> > > >
> > > > >>> > > > 094e4e31a5af55bb17be87675da41d9aeca062f3
> > > > >>> > > >
> > > > >>> > > > > Staging site:
> > > > >>> > > > > https://maven.apache.org/components/ref/3-LATEST/
> > > > >>> > > > >
> > > > >>> > > > > Vote open for 72 hours.
> > > > >>> > > > >
> > > > >>> > > > > [ ] +1
> > > > >>> > > > > [ ] +0
> > > > >>> > > > > [ ] -1
> > > > >>> > > > >
> > > > >>> > > > > Thanks,
> > > > >>> > > > >
> > > > >>> > > > > Stephen.
> > > > >>> > > >
> > > > >>> > > > ------------------------------------------------------------
> > > > >>> ---------
> > > > >>> > > > To unsubscribe, e-mail: [hidden email]
> > > > >>> > > > For additional commands, e-mail: [hidden email]
> > > > >>> >
> > > > >>> >
> > > > >>> >
> > > > >>> > ------------------------------------------------------------
> > > ---------
> > > > >>> > To unsubscribe, e-mail: [hidden email]
> > > > >>> > For additional commands, e-mail: [hidden email]
> > > > >>> >
> > > > >>> > --
> > > > >>> Sent from my phone
> > > > >>>
> > > > >>
> > > > >>
> > > > >
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [hidden email]
> > > For additional commands, e-mail: [hidden email]
> > >
> > >
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: [VOTE] Release Apache Maven 3.5.1

Igor Fedorenko-3
I don't really have much to add, but let me answer anyways :-)

1) I am reasonably confident we can compensate for the new classloader
arrangement in m2e without much problems. The new setup does make plugin
runtime classpath less stable, so there are likely other scenarios where
plugins will behave differently (bad). On the other hand, I don't see
any better way to support ServiceLoader. For java 8 it may be possible
to use foreign-import of extensions classloader to fix MNG-6275, but
that classloader was removed in java 9, unless I am mistaken.

2) I believe TCCL is already set to project realm for projects that have
extensions (and to plugin realm otherwise) during plugin execution.
Problem is, neither project realm nor any of the plugin realms have
access to jvm extensions classloader, so ServiceLoader can't get classes
from there.

--
Regards,
Igor

On Fri, Sep 15, 2017, at 12:09 PM, Stephen Connolly wrote:

> I'm going to hold off closing the vote over the weekend to give Igor a
> chance to:
>
> 1. comment on whether we need an alternative fix for MNG-6275 (and indeed
> ideally provide one ;- );
> 2. comment on whether the fix for MNG-6209 is exposing bugs in plugins
> that
> made incorrect assumptions about TCCL, or whether the fix is invalid or
> even incomplete (I wonder if TCCL should always be
> project.getClassRealm()
> as extensions should be available to all plugins not just those that
> declare they are providing extensions - unless I misunderstand)
>
> Once I have the required information I will be better able to assess
> whether we should release 3.5.1 and follow up with a quick 3.5.2 or just
> drop 3.5.1 and go straight to 3.5.2.
>
> -Stephen
>
> On 15 September 2017 at 05:45, Igor Fedorenko <[hidden email]>
> wrote:
>
> > Has anyone tried wiring jvm extensions ClassLoader as foreign import to
> > plugin/extensions realms? Jvm extensions classloader is little tricky to
> > get to (see how this is done in java.util.ServiceLoader.loadInstalled),
> > but I think this will solve ServiceLoader/MNG-6275 without polluting
> > plugin classpath too much.
> >
> > --
> > Regards,
> > Igor
> >
> > On Fri, Sep 15, 2017, at 08:32 AM, Mark Derricutt wrote:
> > > Would it be possible to handle this in a somewhat similar way to
> > > threadSafe
> > > mojos - some form of plugin flag that says "extensionSafe" [1], that if
> > > the
> > > plugin has <extensions>true</extensions> declared and doesn't declare
> > > itself as being extensionSafe/extensionAware then we log a build warning
> > > -
> > > it wouldn't solve anything, other than giving some feedback to users some
> > > indication of WHY their build fails under 3.5.1 - and to either remove
> > > <extensions> or fix/update their plugins.
> > >
> > > [1] Or even just infer the applicability of extensions by the presence of
> > > custom lifecycles, or Mojos implementing the extension interfaces ( it's
> > > midnight, and a hazy tired thought ).
> > >
> > > --
> > > "Great artists are extremely selfish and arrogant things" — Steven
> > > Wilson,
> > > Porcupine Tree
> > >
> > > On Sat, Sep 16, 2017 at 12:22 AM, Anders Hammar <[hidden email]>
> > > wrote:
> > >
> > > > Based on Igor's feedback I'm changing my vote to +1.
> > > >
> > > > Having this class loader change in a bug fix release is probably not
> > > > (semver) ideal though.
> > > >
> > > > /Anders
> > > >
> > > > On Fri, Sep 15, 2017 at 2:12 PM, Igor Fedorenko <[hidden email]>
> > > > wrote:
> > > >
> > > > > I answered in more details on m2e-dev, but I believe we can
> > compensate
> > > > > for the change from m2e end. In the worst case we'll bundle hacked
> > > > > version of DefaultClassRealmManager with m2e, not ideal, but not the
> > end
> > > > > of the world either.
> > > > >
> > > > > --
> > > > > Regards,
> > > > > Igor
> > > > >
> > > > > On Fri, Sep 15, 2017, at 07:21 AM, Anders Hammar wrote:
> > > > > > On Fri, Sep 15, 2017 at 8:29 AM, Anders Hammar <[hidden email]>
> > > > > wrote:
> > > > > >
> > > > > > > Reporting back from tests of m2e with embedded Maven 3.5.1, we
> > see
> > > > > problem
> > > > > > > with the jaxws-maven-plugin mojo. We're two people seeing the
> > issue
> > > > > > > independently, but unfortunately Fred Bricon hasn't been able to
> > > > > reproduce.
> > > > > > >
> > > > > >
> > > > > > To follow up on this, my tests indicate that Maven 3.5.1 causes
> > changed
> > > > > > class loading that could cause issues for plugins in m2e. I've
> > asked
> > > > for
> > > > > > input from the m2e devs if it is possible to handle in m2e but they
> > > > > > haven't
> > > > > > responded yet.
> > > > > >
> > > > > > /Anders
> > > > > >
> > > > > >
> > > > > > >
> > > > > > > So currently I'm 0 on the voting but I'll investigate some more.
> > > > > > >
> > > > > > > /Anders
> > > > > > >
> > > > > > > On Wed, Sep 13, 2017 at 9:26 AM, Anders Hammar <
> > [hidden email]>
> > > > > wrote:
> > > > > > >
> > > > > > >>
> > > > > > >>
> > > > > > >> On Tue, Sep 12, 2017 at 8:54 PM, Stephen Connolly <
> > > > > > >> [hidden email]> wrote:
> > > > > > >>
> > > > > > >>> Have we got any feedback from the embedder integrations yet?
> > > > > > >>>
> > > > > > >>
> > > > > > >> I haven't heard anything from the m2e people. Maybe we need to
> > ping
> > > > > them
> > > > > > >> directly. I can contact Fred Bricon.
> > > > > > >>
> > > > > > >> /Anders
> > > > > > >>
> > > > > > >>
> > > > > > >>>
> > > > > > >>> On Mon 11 Sep 2017 at 22:57, Hervé BOUTEMY <
> > [hidden email]>
> > > > > > >>> wrote:
> > > > > > >>>
> > > > > > >>> > just for the records: it is Windows + Git Bash (MINGW64) only
> > > > > > >>> >
> > > > > > >>> > and there is a chance that adding -Djansi.force=true can
> > force
> > > > > JAnsi
> > > > > > >>> > activation (even if JAnsi fails to detect that it should
> > > > > auto-activate)
> > > > > > >>> >
> > > > > > >>> > details on issue in https://issues.apache.org/
> > > > jira/browse/MNG-6282
> > > > > ,
> > > > > > >>> and a
> > > > > > >>> > future JAnsi issue...
> > > > > > >>> >
> > > > > > >>> > Regards,
> > > > > > >>> >
> > > > > > >>> > Hervé
> > > > > > >>> >
> > > > > > >>> > Le lundi 11 septembre 2017, 12:53:46 CEST Stephen Connolly a
> > > > écrit
> > > > > :
> > > > > > >>> > > So that is windows only, or were they lost on other OSes
> > for
> > > > you.
> > > > > > >>> > >
> > > > > > >>> > > I have colours on linux (via docker) and os-x
> > > > > > >>> > >
> > > > > > >>> > > On 11 September 2017 at 12:35, [hidden email] <
> > > > > > >>> [hidden email]>
> > > > > > >>> > >
> > > > > > >>> > > wrote:
> > > > > > >>> > > > +1 (conditionally).
> > > > > > >>> > > >
> > > > > > >>> > > > Tested via project that includes dozen of plugins: 1st
> > tier,
> > > > > > >>> MojoHaus
> > > > > > >>> > and
> > > > > > >>> > > > few 3rd party plugins (so to say).
> > > > > > >>> > > >
> > > > > > >>> > > > Everything looks good with one notable regression:
> > > > > > >>> > > > https://issues.apache.org/jira/browse/MNG-6282 Console
> > > > output
> > > > > has
> > > > > > >>> no
> > > > > > >>> > > > colors (regression in Maven 3.5.1)
> > > > > > >>> > > >
> > > > > > >>> > > > Regards,
> > > > > > >>> > > > Dejan
> > > > > > >>> > > >
> > > > > > >>> > > > On 2017-09-10 17:39, Stephen Connolly <
> > > > > > >>> [hidden email]
> > > > > > >>> > >
> > > > > > >>> > > >
> > > > > > >>> > > > wrote:
> > > > > > >>> > > > > Hi,
> > > > > > >>> > > > >
> > > > > > >>> > > > > We solved 25 issues:
> > > > > > >>> > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa
> > ?
> > > > > > >>> > > >
> > > > > > >>> > > > version=12338964&styleName=Text&projectId=12316922
> > > > > > >>> > > >
> > > > > > >>> > > > > There are 350 issues left in JIRA for Maven core:
> > > > > > >>> > > > > <a href="https://issues.apache.org/jira/issues/?jql=project%20%">https://issues.apache.org/jira/issues/?jql=project%20%
> > > > > > >>> > > >
> > > > > > >>> > > > 3D%20MNG%20AND%20resolution%20%3D%20Unresolved%20ORDER%
> > > > > > >>> > > > 20BY%20due%20ASC%2C%20priority%20DESC%2C%20created%20ASC
> > > > > > >>> > > >
> > > > > > >>> > > > > Staging repo:
> > > > > > >>> > > > > https://repository.apache.org/
> > content/repositories/maven-
> > > > > 1364/
> > > > > > >>> > > > >
> > > > > > >>> > > > > The distributable binaries and sources can be found
> > here:
> > > > > > >>> > > > > https://repository.apache.org/
> > content/repositories/maven->
> > > > >
> > > > > > >>> > > > 1364/org/apache/maven/apache-maven/3.5.1/
> > > > > > >>> > > >
> > > > > > >>> > > > > Specifically the zip, tarball and source archives can
> > be
> > > > > found
> > > > > > >>> here:
> > > > > > >>> > > > > https://repository.apache.org/
> > content/repositories/maven->
> > > > >
> > > > > > >>> > > > 1364/org/apache/maven/apache-
> > maven/3.5.1/apache-maven-3.5.1-
> > > > > > >>> bin.zip
> > > > > > >>> > > >
> > > > > > >>> > > > > https://repository.apache.org/
> > content/repositories/maven->
> > > > >
> > > > > > >>> > > > 1364/org/apache/maven/apache-
> > maven/3.5.1/apache-maven-3.5.1-
> > > > > > >>> bin.tar.gz
> > > > > > >>> > > >
> > > > > > >>> > > > > https://repository.apache.org/
> > content/repositories/maven->
> > > > >
> > > > > > >>> > > > 1364/org/apache/maven/apache-
> > maven/3.5.1/apache-maven-3.5.1-
> > > > > > >>> src.zip
> > > > > > >>> > > >
> > > > > > >>> > > > > https://repository.apache.org/
> > content/repositories/maven->
> > > > >
> > > > > > >>> > > > 1364/org/apache/maven/apache-
> > maven/3.5.1/apache-maven-3.5.1-
> > > > > > >>> src.tar.gz
> > > > > > >>> > > >
> > > > > > >>> > > > > Source release checksum(s):
> > > > > > >>> > > > > apache-maven-3.5.1-src.tar.gz sha1:
> > > > > > >>> 9eb821f153c7667194aa11ccd099b7
> > > > > > >>> > > >
> > > > > > >>> > > > bd2059560d
> > > > > > >>> > > >
> > > > > > >>> > > > > apache-maven-3.5.1-src.zip: sha1:
> > > > > 121d54b045380a8a4895eb137970ab
> > > > > > >>> > > >
> > > > > > >>> > > > 69e698eb0e
> > > > > > >>> > > >
> > > > > > >>> > > > > Git tag:
> > > > > > >>> > > > > https://git-wip-us.apache.org/repos/asf?p=maven.git;a=
> > > > > commit;h=
> > > > > > >>> > > >
> > > > > > >>> > > > 094e4e31a5af55bb17be87675da41d9aeca062f3
> > > > > > >>> > > >
> > > > > > >>> > > > > Staging site:
> > > > > > >>> > > > > https://maven.apache.org/components/ref/3-LATEST/
> > > > > > >>> > > > >
> > > > > > >>> > > > > Vote open for 72 hours.
> > > > > > >>> > > > >
> > > > > > >>> > > > > [ ] +1
> > > > > > >>> > > > > [ ] +0
> > > > > > >>> > > > > [ ] -1
> > > > > > >>> > > > >
> > > > > > >>> > > > > Thanks,
> > > > > > >>> > > > >
> > > > > > >>> > > > > Stephen.
> > > > > > >>> > > >
> > > > > > >>> > > > ------------------------------
> > ------------------------------
> > > > > > >>> ---------
> > > > > > >>> > > > To unsubscribe, e-mail: [hidden email]
> > > > > > >>> > > > For additional commands, e-mail:
> > [hidden email]
> > > > > > >>> >
> > > > > > >>> >
> > > > > > >>> >
> > > > > > >>> > ------------------------------------------------------------
> > > > > ---------
> > > > > > >>> > To unsubscribe, e-mail: [hidden email]
> > > > > > >>> > For additional commands, e-mail: [hidden email]
> > > > > > >>> >
> > > > > > >>> > --
> > > > > > >>> Sent from my phone
> > > > > > >>>
> > > > > > >>
> > > > > > >>
> > > > > > >
> > > > >
> > > > > ------------------------------------------------------------
> > ---------
> > > > > To unsubscribe, e-mail: [hidden email]
> > > > > For additional commands, e-mail: [hidden email]
> > > > >
> > > > >
> > > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]