Re: Surefire 3.0.0-M4 release?

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: Surefire 3.0.0-M4 release?

Tibor Digana
Romain, You have to understand also me, users, contributors. You are not
alone. Olivier is also not alone.
See the others, e.g. Enrico, Jonathan, Matt, etc. They are greatly
communicating, understanding, and they are petitioned what it means to
accept requirements from others and making a compromises!
I think Olivier undeerstood it very well on Slack and he made a compromise.
We all understand that he needs to use this version in Jenkins project and
he understands that the issue SUREFIRE-1584 is incomplete and that's what
we are fixing right now because it is worth to spend a day to say that the
rerun works for parameterized tests as well. The users want it and it is
not so time spending issue acctualy.

On Mon, Nov 11, 2019 at 5:50 PM Romain Manni-Bucau <[hidden email]>
wrote:

> @Tibor: I'd like to gently remind you that we - asf - are community driven
> and holding a release is generally bad if it does not bite us after which
> is the case there. As mentionned by Olivier we already agreed to release
> and it got delayed for no reason compared to the original agreement. Please
> understand this is not about the work you are doing - we can discuss it at
> another moment since, as you mentionned we don't fully agree here, but the
> point there was totally different and user centric. Please take care to
> re-read and see you just forked that thread alone. No big deal while the
> release pops up next week but no need to start an argument too ;).
>
> Romain Manni-Bucau
> @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> <https://rmannibucau.metawerx.net/> | Old Blog
> <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau> |
> LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> >
>
>
> Le lun. 11 nov. 2019 à 17:26, Tibor Digana <[hidden email]> a
> écrit :
>
> > Roman, it does not make sense to continue with you because you do not
> > understand the whole track with this project, and again nobody said
> > anything about architecture. It's your permanent opinions and very bad
> > attitude. So it is waste of the time to continue to explain the same
> things
> > over rand over again to You.
> > Read emails and understand them first or or just watch the ML if you do
> not
> > want to understand it.
> >
> > On Mon, Nov 11, 2019 at 5:21 PM Romain Manni-Bucau <
> [hidden email]>
> > wrote:
> >
> > > @Tibor: point is more that we don't need to hold a milestone for a
> > feature,
> > > we can just release and let fixes get out and get this huge
> architectural
> > > change in another milestone. Only valid reason to delay a release is
> IMO
> > a
> > > regression or a major change we can't revert later (3.0.0 would be in
> > this
> > > bucket, not a milestone).
> > >
> > > Romain Manni-Bucau
> > > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > > <https://rmannibucau.metawerx.net/> | Old Blog
> > > <http://rmannibucau.wordpress.com> | Github <
> > > https://github.com/rmannibucau> |
> > > LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > > <
> > >
> >
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > > >
> > >
> > >
> > > Le lun. 11 nov. 2019 à 16:54, Tibor Digana <[hidden email]> a
> > > écrit :
> > >
> > > > The reason of M4 was to introduce TCP communication.
> > > > Meanwhile first we wanted to cut the release one month ago but we
> > > postponed
> > > > it and we were waiting for clarifying license issues and fixed J13
> > issue
> > > > yesterday.
> > > > I was working on TCP/Pipes together with Jonathan Bell and we wanted
> to
> > > > make it in M4 which was our plan but we still have only 35% of the
> > total
> > > > work and there are several things which are too detailed to mention.
> So
> > > > this has to continue and my estimation is that we need to spend 20
> > days.
> > > We
> > > > were working on it quite intensively in the background created few
> PRs
> > > and
> > > > moved the code from one PR to another and clarified it.
> > > > Yesterday I proposed to Jonathan that it does not make sense to work
> on
> > > our
> > > > taks like a hell because it would prolong the development which would
> > > take
> > > > too long.
> > > > So this is the whole reason, otherwise we could already include
> > TCP/Pipes
> > > > into M4.
> > > > T
> > > >
> > > >
> > > >
> > > > On Mon, Nov 11, 2019 at 2:29 PM Romain Manni-Bucau <
> > > [hidden email]>
> > > > wrote:
> > > >
> > > > > +1 to release next week, no reason to wait since it is another "m"
> > > > release
> > > > > IMHO
> > > > >
> > > > > Le lun. 11 nov. 2019 à 12:44, Olivier Lamy <[hidden email]> a
> > écrit
> > > :
> > > > >
> > > > > > That will be great.
> > > > > > If you don't have time before end of the week. I'm happy to help
> > and
> > > do
> > > > > it.
> > > > > > cheers
> > > > > > Olivier
> > > > > >
> > > > > > On Mon, 11 Nov 2019 at 21:35, Tibor Digana <
> [hidden email]
> > >
> > > > > wrote:
> > > > > >
> > > > > > > @Olivier as we clarified this Slack. The release will be fast.
> No
> > > > > delay!
> > > > > > >
> > > > > > > On Mon, Nov 11, 2019 at 12:07 PM Olivier Lamy <
> [hidden email]>
> > > > > wrote:
> > > > > > >
> > > > > > > > Why? delay again
> > > > > > > > I thought 1 month ago we agreed ago to move non finished
> stuff
> > to
> > > > > > > 3.0.0-M5
> > > > > > > > and release 3.0.0-M5 later.
> > > > > > > >
> > > > > > > >
> > > > > > > > On Mon, 11 Nov 2019 at 20:59, Tibor Digana <
> > > [hidden email]
> > > > >
> > > > > > > wrote:
> > > > > > > >
> > > > > > > > > Pls don't do it.
> > > > > > > > > I will cut it and move some issues to M5 but I need Matt to
> > > > finish
> > > > > > his
> > > > > > > > > work. I am in contact with Mat.
> > > > > > > > > I talked about it with the contributor Jonathan Bell about
> > > > > reasoning.
> > > > > > > > > T
> > > > > > > > >
> > > > > > > > > On Mon, Nov 11, 2019 at 11:41 AM Olivier Lamy <
> > > [hidden email]>
> > > > > > > wrote:
> > > > > > > > >
> > > > > > > > > > Hi
> > > > > > > > > > Starting again this thread as we agreed but I didn't do
> it.
> > > > > > > > > > So I'd like to cut release 3.0.0-M4 by the end of this
> > week.
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > > On Mon, 14 Oct 2019 at 11:40, Tibor Digana <
> > > > > [hidden email]
> > > > > > >
> > > > > > > > > wrote:
> > > > > > > > > >
> > > > > > > > > > > The SUREFIRE-1689 progress has been finished until the
> CI
> > > > build
> > > > > > > > > succeeds.
> > > > > > > > > > > T
> > > > > > > > > > >
> > > > > > > > > > > On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <
> > > > > > > > [hidden email]>
> > > > > > > > > > > wrote:
> > > > > > > > > > >
> > > > > > > > > > > > Ah, there it is :)
> > > > > > > > > > > >
> > > > > > > > > > > > On Sun, 13 Oct 2019 08:21:53 +0200, Romain
> Manni-Bucau
> > > > > > > > > > > > <[hidden email]> wrote:
> > > > > > > > > > > >
> > > > > > > > > > > > > Didnt expect my comment about shade to take so much
> > > space
> > > > > in
> > > > > > > this
> > > > > > > > > > > thread
> > > > > > > > > > > > > but yes we rely on asm for relocation:
> > > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> > > > > > > > > > > > >
> > > > > > > > > > > > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <
> > > > > > > > [hidden email]
> > > > > > > > > >
> > > > > > > > > > a
> > > > > > > > > > > > > écrit :
> > > > > > > > > > > > >
> > > > > > > > > > > > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain
> > Manni-Bucau
> > > > > > > > > > > > >> <[hidden email]> wrote:
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <
> > > > > > > > > > [hidden email]>
> > > > > > > > > > > a
> > > > > > > > > > > > >> > écrit :
> > > > > > > > > > > > >> >
> > > > > > > > > > > > >> >> As far as I know, surefire won't touch the
> Plexus
> > > > Java
> > > > > > code
> > > > > > > > > that
> > > > > > > > > > > > >> >> requires
> > > > > > > > > > > > >> >> ASM.
> > > > > > > > > > > > >> >> It is ONLY required when the runtime is Java 8
> or
> > > > lower
> > > > > > AND
> > > > > > > > you
> > > > > > > > > > > > need
> > > > > > > > > > > > >> to
> > > > > > > > > > > > >> >> read the module descriptors.
> > > > > > > > > > > > >> >>
> > > > > > > > > > > > >> >> Maven Shade is a different case: it must parse
> > the
> > > > Java
> > > > > > > > > bytecode
> > > > > > > > > > > (and
> > > > > > > > > > > > >> >> only
> > > > > > > > > > > > >> >> when using minifyJar), hence it needs the
> latest
> > > ASM.
> > > > > > > > > > > > >> >>
> > > > > > > > > > > > >> >
> > > > > > > > > > > > >> > + Relocation ;)
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> Well, the unexpected answer is actually No, see
> > > > > > > > > > > > >>
> > > > > > > > > > > > >>
> > > > > > > > > > > > >>
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > >
> > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> (but it might be better to do so...)
> > > > > > > > > > > > >>
> > > > > > > > > > > > >> >
> > > > > > > > > > > > >> >
> > > > > > > > > > > > >> >> Robert
> > > > > > > > > > > > >> >>
> > > > > > > > > > > > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor
> Digana
> > > > > > > > > > > > >> >> <[hidden email]>
> > > > > > > > > > > > >> >>
> > > > > > > > > > > > >> >> wrote:
> > > > > > > > > > > > >> >>
> > > > > > > > > > > > >> >> > We still use plexus-java:1.0.3 which depends
> on
> > > ASM
> > > > > > 7.0.
> > > > > > > > > > > > >> >> > The support for JDk 13 and 14 is in the
> version
> > > > 7.2.
> > > > > > > > > > > > >> >> > We have similar upgrade in
> > > > > > > > > > > > >> >> >
> > > > https://github.com/apache/maven-shade-plugin/pull/29
> > > > > > > > > > > > >> >> >
> > > > > > > > > > > > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy
> <
> > > > > > > > > [hidden email]
> > > > > > > > > > >
> > > > > > > > > > > > >> wrote:
> > > > > > > > > > > > >> >> >
> > > > > > > > > > > > >> >> >> Hi,
> > > > > > > > > > > > >> >> >> It's now almost 10 months since last and
> > around
> > > 30
> > > > > > > issues
> > > > > > > > > > fixed.
> > > > > > > > > > > > >> >> >> Maybe time for a new release?
> > > > > > > > > > > > >> >> >> Moving issues still open to 3.0.0-M5?
> > > > > > > > > > > > >> >> >>
> > > > > > > > > > > > >> >> >> cheers
> > > > > > > > > > > > >> >> >> --
> > > > > > > > > > > > >> >> >> Olivier Lamy
> > > > > > > > > > > > >> >>
> > > > > > > > > > > > >> >>
> > > > > > > > > > >
> > > > > > >
> > > ---------------------------------------------------------------------
> > > > > > > > > > > > >> >> To unsubscribe, e-mail:
> > > > > [hidden email]
> > > > > > > > > > > > >> >> For additional commands, e-mail:
> > > > > > [hidden email]
> > > > > > > > > > > > >> >>
> > > > > > > > > > > > >>
> > > > > > > > > > > > >>
> > > > > > > > > >
> > > > > >
> > ---------------------------------------------------------------------
> > > > > > > > > > > > >> To unsubscribe, e-mail:
> > > > [hidden email]
> > > > > > > > > > > > >> For additional commands, e-mail:
> > > > > [hidden email]
> > > > > > > > > > > > >>
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > >
> > > > ---------------------------------------------------------------------
> > > > > > > > > > > > To unsubscribe, e-mail:
> > [hidden email]
> > > > > > > > > > > > For additional commands, e-mail:
> > > [hidden email]
> > > > > > > > > > > >
> > > > > > > > > > > >
> > > > > > > > > > >
> > > > > > > > > >
> > > > > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>