Re: Surefire 3.0.0-M4 release?

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Surefire 3.0.0-M4 release?

Tibor Digana
I have noticed this happening only with snapshot versions. The snapshot and
release repos have different h/w?!

On Sat, Oct 12, 2019 at 12:44 PM Romain Manni-Bucau <[hidden email]>
wrote:

> They work on it with some rate limiting until it gets resolved.
> They had some abnormal load.
>
> Le sam. 12 oct. 2019 à 12:24, Tibor Digana <[hidden email]> a
> écrit :
>
> > Romain, I have enabled JUnit5 5.6.0/1.6.0-SNAPSHOT.
> > I want to know if the bug OSSRH-51220 is fixed.
> >
> >
> https://builds.apache.org/job/maven-box/job/maven-surefire/job/junit5-snapshots/
> >
> > On Sat, Oct 12, 2019 at 12:10 PM Tibor Digana <[hidden email]>
> > wrote:
> >
> > > Here is the pull request
> > > https://github.com/codehaus-plexus/plexus-languages/pull/29
> > >
> > > On Sat, Oct 12, 2019 at 11:49 AM Romain Manni-Bucau <
> > [hidden email]>
> > > wrote:
> > >
> > >> I understand and if we can we must do but not a blocker - was my point
> > >> Also keep in mind we could do the update automatically with asm
> > versioning
> > >> scheme using our resolver in the mojo.
> > >> So let's fix issues for most users - once again j > 11 is a play area,
> > not
> > >> for prod today - and maybe enhance our asm integration layer later.
> > >>
> > >> Le sam. 12 oct. 2019 à 11:42, Tibor Digana <[hidden email]> a
> > >> écrit :
> > >>
> > >> > all bad, see the stackoverflow. It happens that the users argue that
> > >> they
> > >> > have to update our dependencies which is our responsibility!
> > >> >
> > >> > On Sat, Oct 12, 2019 at 11:40 AM Romain Manni-Bucau <
> > >> [hidden email]
> > >> > >
> > >> > wrote:
> > >> >
> > >> > > Dont think there is an api version upgrade between 7.0 and 7.2 so
> > can
> > >> be
> > >> > > upgraded in user pom so not a blocker for a milestone release
> > >> IMHO....j13
> > >> > > and j14 are still not adopted too so all good.
> > >> > >
> > >> > > Le sam. 12 oct. 2019 à 11:35, Tibor Digana <
> [hidden email]>
> > a
> > >> > > écrit :
> > >> > >
> > >> > > > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > >> > > > The support for JDk 13 and 14 is in the version 7.2.
> > >> > > > We have similar upgrade in
> > >> > > > https://github.com/apache/maven-shade-plugin/pull/29
> > >> > > >
> > >> > > > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <[hidden email]>
> > >> wrote:
> > >> > > >
> > >> > > > > Hi,
> > >> > > > > It's now almost 10 months since last and around 30 issues
> fixed.
> > >> > > > > Maybe time for a new release?
> > >> > > > > Moving issues still open to 3.0.0-M5?
> > >> > > > >
> > >> > > > > cheers
> > >> > > > > --
> > >> > > > > Olivier Lamy
> > >> > > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >> > > > >
> > >> > > >
> > >> > >
> > >> >
> > >>
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Surefire 3.0.0-M4 release?

Romain Manni-Bucau
Have to admit I dont know, clearly a different load though. Feel free to
ask Joel on the ticket.

Le sam. 12 oct. 2019 à 12:49, Tibor Digana <[hidden email]> a
écrit :

> I have noticed this happening only with snapshot versions. The snapshot and
> release repos have different h/w?!
>
> On Sat, Oct 12, 2019 at 12:44 PM Romain Manni-Bucau <[hidden email]
> >
> wrote:
>
> > They work on it with some rate limiting until it gets resolved.
> > They had some abnormal load.
> >
> > Le sam. 12 oct. 2019 à 12:24, Tibor Digana <[hidden email]> a
> > écrit :
> >
> > > Romain, I have enabled JUnit5 5.6.0/1.6.0-SNAPSHOT.
> > > I want to know if the bug OSSRH-51220 is fixed.
> > >
> > >
> >
> https://builds.apache.org/job/maven-box/job/maven-surefire/job/junit5-snapshots/
> > >
> > > On Sat, Oct 12, 2019 at 12:10 PM Tibor Digana <[hidden email]>
> > > wrote:
> > >
> > > > Here is the pull request
> > > > https://github.com/codehaus-plexus/plexus-languages/pull/29
> > > >
> > > > On Sat, Oct 12, 2019 at 11:49 AM Romain Manni-Bucau <
> > > [hidden email]>
> > > > wrote:
> > > >
> > > >> I understand and if we can we must do but not a blocker - was my
> point
> > > >> Also keep in mind we could do the update automatically with asm
> > > versioning
> > > >> scheme using our resolver in the mojo.
> > > >> So let's fix issues for most users - once again j > 11 is a play
> area,
> > > not
> > > >> for prod today - and maybe enhance our asm integration layer later.
> > > >>
> > > >> Le sam. 12 oct. 2019 à 11:42, Tibor Digana <[hidden email]>
> a
> > > >> écrit :
> > > >>
> > > >> > all bad, see the stackoverflow. It happens that the users argue
> that
> > > >> they
> > > >> > have to update our dependencies which is our responsibility!
> > > >> >
> > > >> > On Sat, Oct 12, 2019 at 11:40 AM Romain Manni-Bucau <
> > > >> [hidden email]
> > > >> > >
> > > >> > wrote:
> > > >> >
> > > >> > > Dont think there is an api version upgrade between 7.0 and 7.2
> so
> > > can
> > > >> be
> > > >> > > upgraded in user pom so not a blocker for a milestone release
> > > >> IMHO....j13
> > > >> > > and j14 are still not adopted too so all good.
> > > >> > >
> > > >> > > Le sam. 12 oct. 2019 à 11:35, Tibor Digana <
> > [hidden email]>
> > > a
> > > >> > > écrit :
> > > >> > >
> > > >> > > > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > > >> > > > The support for JDk 13 and 14 is in the version 7.2.
> > > >> > > > We have similar upgrade in
> > > >> > > > https://github.com/apache/maven-shade-plugin/pull/29
> > > >> > > >
> > > >> > > > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <
> [hidden email]>
> > > >> wrote:
> > > >> > > >
> > > >> > > > > Hi,
> > > >> > > > > It's now almost 10 months since last and around 30 issues
> > fixed.
> > > >> > > > > Maybe time for a new release?
> > > >> > > > > Moving issues still open to 3.0.0-M5?
> > > >> > > > >
> > > >> > > > > cheers
> > > >> > > > > --
> > > >> > > > > Olivier Lamy
> > > >> > > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > >> > > > >
> > > >> > > >
> > > >> > >
> > > >> >
> > > >>
> > > >
> > >
> >
>
Reply | Threaded
Open this post in threaded view
|

Re: Surefire 3.0.0-M4 release?

rfscholte
In reply to this post by Tibor Digana
As far as I know, surefire won't touch the Plexus Java code that requires  
ASM.
It is ONLY required when the runtime is Java 8 or lower AND you need to  
read the module descriptors.

Maven Shade is a different case: it must parse the Java bytecode (and only  
when using minifyJar), hence it needs the latest ASM.

Robert

On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana <[hidden email]>  
wrote:

> We still use plexus-java:1.0.3 which depends on ASM 7.0.
> The support for JDk 13 and 14 is in the version 7.2.
> We have similar upgrade in
> https://github.com/apache/maven-shade-plugin/pull/29
>
> On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <[hidden email]> wrote:
>
>> Hi,
>> It's now almost 10 months since last and around 30 issues fixed.
>> Maybe time for a new release?
>> Moving issues still open to 3.0.0-M5?
>>
>> cheers
>> --
>> Olivier Lamy
>> http://twitter.com/olamy | http://linkedin.com/in/olamy

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Surefire 3.0.0-M4 release?

Romain Manni-Bucau
Le sam. 12 oct. 2019 à 13:33, Robert Scholte <[hidden email]> a
écrit :

> As far as I know, surefire won't touch the Plexus Java code that requires
> ASM.
> It is ONLY required when the runtime is Java 8 or lower AND you need to
> read the module descriptors.
>
> Maven Shade is a different case: it must parse the Java bytecode (and
> only
> when using minifyJar), hence it needs the latest ASM.
>

+ Relocation ;)


> Robert
>
> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana <[hidden email]>
>
> wrote:
>
> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > The support for JDk 13 and 14 is in the version 7.2.
> > We have similar upgrade in
> > https://github.com/apache/maven-shade-plugin/pull/29
> >
> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <[hidden email]> wrote:
> >
> >> Hi,
> >> It's now almost 10 months since last and around 30 issues fixed.
> >> Maybe time for a new release?
> >> Moving issues still open to 3.0.0-M5?
> >>
> >> cheers
> >> --
> >> Olivier Lamy
> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Surefire 3.0.0-M4 release?

Romain Manni-Bucau
Didnt expect my comment about shade to take so much space in this thread
but yes we rely on asm for relocation:
https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453

Le dim. 13 oct. 2019 à 00:20, Robert Scholte <[hidden email]> a
écrit :

> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
> <[hidden email]> wrote:
>
> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <[hidden email]> a
> > écrit :
> >
> >> As far as I know, surefire won't touch the Plexus Java code that
> >> requires
> >> ASM.
> >> It is ONLY required when the runtime is Java 8 or lower AND you need to
> >> read the module descriptors.
> >>
> >> Maven Shade is a different case: it must parse the Java bytecode (and
> >> only
> >> when using minifyJar), hence it needs the latest ASM.
> >>
> >
> > + Relocation ;)
>
> Well, the unexpected answer is actually No, see
>
>
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
>
> (but it might be better to do so...)
>
> >
> >
> >> Robert
> >>
> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> >> <[hidden email]>
> >>
> >> wrote:
> >>
> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> >> > The support for JDk 13 and 14 is in the version 7.2.
> >> > We have similar upgrade in
> >> > https://github.com/apache/maven-shade-plugin/pull/29
> >> >
> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <[hidden email]>
> wrote:
> >> >
> >> >> Hi,
> >> >> It's now almost 10 months since last and around 30 issues fixed.
> >> >> Maybe time for a new release?
> >> >> Moving issues still open to 3.0.0-M5?
> >> >>
> >> >> cheers
> >> >> --
> >> >> Olivier Lamy
> >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> >>
> >> ---------------------------------------------------------------------
> >> To unsubscribe, e-mail: [hidden email]
> >> For additional commands, e-mail: [hidden email]
> >>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Surefire 3.0.0-M4 release?

olamy
Hi
Starting again this thread as we agreed but I didn't do it.
So I'd like to cut release 3.0.0-M4 by the end of this week.



On Mon, 14 Oct 2019 at 11:40, Tibor Digana <[hidden email]> wrote:

> The SUREFIRE-1689 progress has been finished until the CI build succeeds.
> T
>
> On Sun, Oct 13, 2019 at 10:27 AM Robert Scholte <[hidden email]>
> wrote:
>
> > Ah, there it is :)
> >
> > On Sun, 13 Oct 2019 08:21:53 +0200, Romain Manni-Bucau
> > <[hidden email]> wrote:
> >
> > > Didnt expect my comment about shade to take so much space in this
> thread
> > > but yes we rely on asm for relocation:
> > >
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/DefaultShader.java#L453
> > >
> > > Le dim. 13 oct. 2019 à 00:20, Robert Scholte <[hidden email]> a
> > > écrit :
> > >
> > >> On Sat, 12 Oct 2019 13:44:48 +0200, Romain Manni-Bucau
> > >> <[hidden email]> wrote:
> > >>
> > >> > Le sam. 12 oct. 2019 à 13:33, Robert Scholte <[hidden email]>
> a
> > >> > écrit :
> > >> >
> > >> >> As far as I know, surefire won't touch the Plexus Java code that
> > >> >> requires
> > >> >> ASM.
> > >> >> It is ONLY required when the runtime is Java 8 or lower AND you
> > need
> > >> to
> > >> >> read the module descriptors.
> > >> >>
> > >> >> Maven Shade is a different case: it must parse the Java bytecode
> (and
> > >> >> only
> > >> >> when using minifyJar), hence it needs the latest ASM.
> > >> >>
> > >> >
> > >> > + Relocation ;)
> > >>
> > >> Well, the unexpected answer is actually No, see
> > >>
> > >>
> > >>
> >
> https://github.com/apache/maven-shade-plugin/blob/master/src/main/java/org/apache/maven/plugins/shade/relocation/SimpleRelocator.java
> > >>
> > >> (but it might be better to do so...)
> > >>
> > >> >
> > >> >
> > >> >> Robert
> > >> >>
> > >> >> On Sat, 12 Oct 2019 11:35:05 +0200, Tibor Digana
> > >> >> <[hidden email]>
> > >> >>
> > >> >> wrote:
> > >> >>
> > >> >> > We still use plexus-java:1.0.3 which depends on ASM 7.0.
> > >> >> > The support for JDk 13 and 14 is in the version 7.2.
> > >> >> > We have similar upgrade in
> > >> >> > https://github.com/apache/maven-shade-plugin/pull/29
> > >> >> >
> > >> >> > On Thu, Oct 10, 2019 at 2:53 AM Olivier Lamy <[hidden email]>
> > >> wrote:
> > >> >> >
> > >> >> >> Hi,
> > >> >> >> It's now almost 10 months since last and around 30 issues fixed.
> > >> >> >> Maybe time for a new release?
> > >> >> >> Moving issues still open to 3.0.0-M5?
> > >> >> >>
> > >> >> >> cheers
> > >> >> >> --
> > >> >> >> Olivier Lamy
> > >> >> >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >> >>
> > >> >>
> ---------------------------------------------------------------------
> > >> >> To unsubscribe, e-mail: [hidden email]
> > >> >> For additional commands, e-mail: [hidden email]
> > >> >>
> > >>
> > >> ---------------------------------------------------------------------
> > >> To unsubscribe, e-mail: [hidden email]
> > >> For additional commands, e-mail: [hidden email]
> > >>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>


--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy