Re: Short guide "Working with Github pull requests"

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Short guide "Working with Github pull requests"

Elliotte Rusty Harold
> > So then the conclusion is, we can use Github for accepting & merging
> > pull requests, but shouldn't use "Squash & merge"?

Buttons that shouldn't be used can be turned off by project owners in
the repo settings. There's no need to bother devs with remembering
which buttons should and should not be pressed (especially since
you'll get different answers to this question depending on who you
ask.)

--
Elliotte Rusty Harold
[hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Short guide "Working with Github pull requests"

Maarten Mulders-2
Good point. I'll start by disabling the "Squash & merge" button using
asf.yaml for the repositories I have cloned locally.

Maarten

On 13/07/2020 22:03, Elliotte Rusty Harold wrote:
>>> So then the conclusion is, we can use Github for accepting & merging
>>> pull requests, but shouldn't use "Squash & merge"?
>
> Buttons that shouldn't be used can be turned off by project owners in
> the repo settings. There's no need to bother devs with remembering
> which buttons should and should not be pressed (especially since
> you'll get different answers to this question depending on who you
> ask.)
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]