Re: Second review for MNG-6118

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Second review for MNG-6118

Maarten Mulders-3
Hi all,

May I please remind you of this question? We'd appreciate if anyone
could spend some time on these changes and provide us with feedback on
the approach. Robert has already shared his 2 cents but since these
changes happen in Core, we are still waiting for a second reviewer.

Thanks,

Maarten

On Oct 1st, 2020 at 21:11, Maarten Mulders wrote:

> Hi all,
>
> Over the last month, Martin Kanters and myself have been working to make
> it possible to execute goals on a specific module while building a
> multi-module project [1]. The pull request [2] enables resolving
> inter-module dependencies of the whole multi-module project while
> building a part of a multi-module project (by using -f or by navigating
> to a subdirectory).
>
> These changes make the following scenarios behave in a consistent way:
>
> * mvn -pl module-a
> * mvn -f module-a/pom.xml
> * cd module-a && mvn
>
> There are also integration tests [3] that demonstrate and verify this
> behaviour. The changes have run through Jenkins in an earlier stage, and
> are running again now that I have merged master into our feature branch.
> Robert has done a first round of review and we would appreciate if
> somebody else could also take a look at the proposed changes.
>
> Thanks,
>
> Maarten
>
> [1] https://issues.apache.org/jira/browse/MNG-6118
> [2] https://github.com/apache/maven/pull/373
> [3] https://github.com/apache/maven-integration-testing/pull/68

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Second review for MNG-6118

Enrico Olivelli
I sent my review.

But I don't know very much that part of the codebase.
More expert eyes are needed

Thanks for contributing that useful fix

Enrico

Il Ven 16 Ott 2020, 08:51 Maarten Mulders <[hidden email]> ha
scritto:

> Hi all,
>
> May I please remind you of this question? We'd appreciate if anyone
> could spend some time on these changes and provide us with feedback on
> the approach. Robert has already shared his 2 cents but since these
> changes happen in Core, we are still waiting for a second reviewer.
>
> Thanks,
>
> Maarten
>
> On Oct 1st, 2020 at 21:11, Maarten Mulders wrote:
> > Hi all,
> >
> > Over the last month, Martin Kanters and myself have been working to make
> > it possible to execute goals on a specific module while building a
> > multi-module project [1]. The pull request [2] enables resolving
> > inter-module dependencies of the whole multi-module project while
> > building a part of a multi-module project (by using -f or by navigating
> > to a subdirectory).
> >
> > These changes make the following scenarios behave in a consistent way:
> >
> > * mvn -pl module-a
> > * mvn -f module-a/pom.xml
> > * cd module-a && mvn
> >
> > There are also integration tests [3] that demonstrate and verify this
> > behaviour. The changes have run through Jenkins in an earlier stage, and
> > are running again now that I have merged master into our feature branch.
> > Robert has done a first round of review and we would appreciate if
> > somebody else could also take a look at the proposed changes.
> >
> > Thanks,
> >
> > Maarten
> >
> > [1] https://issues.apache.org/jira/browse/MNG-6118
> > [2] https://github.com/apache/maven/pull/373
> > [3] https://github.com/apache/maven-integration-testing/pull/68
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>