Re: Plugin ITs with toolchain on ci-builds.a.o

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: Plugin ITs with toolchain on ci-builds.a.o

adangel
Thanks for the mentioning the trick. I experimented a bit and it seems,
"invoker.toolchain.jdk.version" is indeed working as expected. It was
probably a temporary hickup on the jenkins build nodes.

However, toolchains.xml is only available on linux nodes, not on Windows
nodes. I've create a INFRA ticket for that [1].

In order to have my new integration test working for both linux and
windows, I'm using now a custom selector script [2]. This script copies
the user's (jenkin's) toolchains.xml file into the integration test, if
available. Under Windows, it creates a new toolchains.xml using a fixed
path to the jdk (F:\jenkins\tools\java\latest11).

While looking at other plugins, I found two integration tests in
m-compiler-p which were not being executed due to referencing a
non-existing toolchain. I've fixed and enabled these tests (for linux only).

Regards,

Andreas


[1]: https://issues.apache.org/jira/browse/INFRA-20938
[2]:
https://github.com/apache/maven-pmd-plugin/blob/mpmd-304/src/it/MPMD-304-toolchain-support/selector.groovy

Am 03.10.20 um 11:20 schrieb Robert Scholte:

> that's actually a question for [hidden email]
> IIRC the trick done by other plugins is to write an integration test with a toolchains.xm, filtering it with the Java Runtime path.
> Best it to search for ITs by one of the toolchain-aware plugins[1]
>
> thanks,
> Robert
>
> [1] https://maven.apache.org/guides/mini/guide-using-toolchains.html
> On 2-10-2020 20:40:23, Andreas Dangel <[hidden email]> wrote:
> Hi all,
>
> I'm trying to create a IT that uses toolchain. I've configured it in the
> test's pom [1] and in invoker.properties [2]. Locally, the IT executed,
> but on ci-builds.a.o the test "MPMD-304-toolchain-support" is skipped
> "due to Toolchain" [3]. I was assuming, that the toolchains configured
> by puppet [4] are available...
>
> Any idea what I'm missing? This is about implementing MPMD-304 [5].
>
> Thanks,
>
> Andreas
>
> [1]
> https://github.com/apache/maven-pmd-plugin/pull/31/files#diff-1c38d38a7b5627065f01e2758630a0b2R83-R88
> [2]
> https://github.com/apache/maven-pmd-plugin/pull/31/files#diff-fc4ff6f6b9b97eeed9bf34122d18b660R20-R24
> [3]
> https://ci-builds.apache.org/blue/organizations/jenkins/Maven%2Fmaven-box%2Fmaven-pmd-plugin/detail/mpmd-304/2/pipeline/118#step-141-log-417
> [4]
> https://github.com/apache/infrastructure-p6/blob/production/modules/build_nodes/files/toolchains.xml#L64
> [5] https://issues.apache.org/jira/browse/MPMD-304
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]