Re: Open pull requests

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Open pull requests

Robert Scholte-8
Hi Joseph,

great to hear you want to contribute, we appreciate that a lot!
But you mind have noticed there are a huge amount of open issues and pull request and we simple can not catch up due to the limited amount of time and volunteers.

Regarding the open PRs, I expect that most were created in a period where Maven itself was still on subversion, but the Apache Software Foundation provided read-only copies at Github.
The integration between both systems was bad, we didn't get notifications and trying to patch it back to subversion was a nightmare.
Things are better nowadays, but we still suffer from that period.

My main activity is currently reading and writing daily e-mails and trying to get and keep everything stable.So development is not even in the top 3 activities.
Going through older PRs is something that should be done, but I'm afraid it is not getting the highest priority.

Don't let this be a message to stop contributing, just be aware that it requires some patience.

thanks,
Robert


On 14-5-2019 06:21:17, Joseph Walton <[hidden email]> wrote:
--------------------------------------------------------------------- To unsubscribe, e-mail: [hidden email] For additional commands, e-mail: [hidden email]
As an interested contributor, I've opened a couple of pull requests, and it's not always clear what the next step is for a non-project-member to get things merged.

To see how other PRs (https://github.com/apache/maven/pulls [https://github.com/apache/maven/pulls] -- currently, '32 open') are being handled, I thought it might make sense to chart them; chart attached.

Notable:
* a significant number were opened more than a year ago (as far back as 2014), haven't been merged and now have conflicts. Could they be closed?

* some more recent ones are mergeable, and approved. Can these be merged?
* for the other PRs in between -- do they need work, or would closing them send a clearer message?

Thanks.
Reply | Threaded
Open this post in threaded view
|

Re: Open pull requests

Enrico Olivelli
Thank you Joseph,
If you have time you can help us review the pending pulls and see if they
are still useful and/or suggest changes before merge.
Every eye on patches is very valuable and it helps commiters of the project
in their work.

Enrico

Il mer 15 mag 2019, 19:08 Robert Scholte <[hidden email]> ha scritto:

> Hi Joseph,
>
> great to hear you want to contribute, we appreciate that a lot!
> But you mind have noticed there are a huge amount of open issues and pull
> request and we simple can not catch up due to the limited amount of time
> and volunteers.
>
> Regarding the open PRs, I expect that most were created in a period where
> Maven itself was still on subversion, but the Apache Software Foundation
> provided read-only copies at Github.
> The integration between both systems was bad, we didn't get notifications
> and trying to patch it back to subversion was a nightmare.
> Things are better nowadays, but we still suffer from that period.
>
> My main activity is currently reading and writing daily e-mails and trying
> to get and keep everything stable.So development is not even in the top 3
> activities.
> Going through older PRs is something that should be done, but I'm afraid
> it is not getting the highest priority.
>
> Don't let this be a message to stop contributing, just be aware that it
> requires some patience.
>
> thanks,
> Robert
>
>
> On 14-5-2019 06:21:17, Joseph Walton <[hidden email]> wrote:
> --------------------------------------------------------------------- To
> unsubscribe, e-mail: [hidden email] For additional
> commands, e-mail: [hidden email]
> As an interested contributor, I've opened a couple of pull requests, and
> it's not always clear what the next step is for a non-project-member to get
> things merged.
>
> To see how other PRs (https://github.com/apache/maven/pulls [
> https://github.com/apache/maven/pulls] -- currently, '32 open') are being
> handled, I thought it might make sense to chart them; chart attached.
>
> Notable:
> * a significant number were opened more than a year ago (as far back as
> 2014), haven't been merged and now have conflicts. Could they be closed?
>
> * some more recent ones are mergeable, and approved. Can these be merged?
> * for the other PRs in between -- do they need work, or would closing them
> send a clearer message?
>
> Thanks.
>