Re: Need help merging pull requests for maven-site

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Need help merging pull requests for maven-site

olamy
Hi Dennis
I just merged your pr.
But for those changes just push to master branch you do not really need
approval and it's a bit useless...
(and this will avoid some notifications noise)

On Tue, 11 Aug 2020 at 19:25, Dennis Lundberg <[hidden email]> wrote:

> Hi,
>
> During the release I've made recently I have updated maven-site@github
> with
> the new versions and release dates. These turn into pull requests that have
> now been approved. However I seem to lack some permissions (or knowledge)
> to merge these pull requests from the GitHub UI.
>
> Can someone point me in the right direction, or help me merge these:
> https://github.com/apache/maven-site/pull/189
> https://github.com/apache/maven-site/pull/192
> https://github.com/apache/maven-site/pull/193
>
> Thanks in advance,
> Dennis Lundberg
>


--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Reply | Threaded
Open this post in threaded view
|

Re: Need help merging pull requests for maven-site

Dennis Lundberg-3
Thanks Olivier,

I was just following our release process at
https://maven.apache.org/developers/release/maven-project-release-procedure.html

Under step 2 of "Promote the release" it says
"In case there's an overview table with version (e.g. plugins
<https://maven.apache.org/plugins/index.html> and shared
<https://maven.apache.org/shared/index.html>) you can directly edit it on
the github page."

Should i change those instructions to push to master if you have those
permissions?

--
Dennis Lundberg


Den tis 11 aug. 2020 kl 13:29 skrev Olivier Lamy <[hidden email]>:

> Hi Dennis
> I just merged your pr.
> But for those changes just push to master branch you do not really need
> approval and it's a bit useless...
> (and this will avoid some notifications noise)
>
> On Tue, 11 Aug 2020 at 19:25, Dennis Lundberg <[hidden email]> wrote:
>
> > Hi,
> >
> > During the release I've made recently I have updated maven-site@github
> > with
> > the new versions and release dates. These turn into pull requests that
> have
> > now been approved. However I seem to lack some permissions (or knowledge)
> > to merge these pull requests from the GitHub UI.
> >
> > Can someone point me in the right direction, or help me merge these:
> > https://github.com/apache/maven-site/pull/189
> > https://github.com/apache/maven-site/pull/192
> > https://github.com/apache/maven-site/pull/193
> >
> > Thanks in advance,
> > Dennis Lundberg
> >
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
Reply | Threaded
Open this post in threaded view
|

Re: Need help merging pull requests for maven-site

olamy
On Tue, 11 Aug 2020 at 20:37, Dennis Lundberg <[hidden email]>
wrote:

> Den tis 11 aug. 2020 kl 13:46 skrev Olivier Lamy <[hidden email]>:
>
> > On Tue, 11 Aug 2020 at 19:40, Dennis Lundberg <[hidden email]>
> > wrote:
> >
> > > Thanks Olivier,
> > >
> > > I was just following our release process at
> > >
> > >
> >
> https://maven.apache.org/developers/release/maven-project-release-procedure.html
> >
> >
> > I do not see anything related to create pull request for such easy change
> >
>
> The pull requests are created automatically when you edit the github page.
>
I'm sure there is an option to commit/push directly..
 look at the options next time ;)


> >
> > >
> > > Under step 2 of "Promote the release" it says
> > > "In case there's an overview table with version (e.g. plugins
> > > <https://maven.apache.org/plugins/index.html> and shared
> > > <https://maven.apache.org/shared/index.html>) you can directly edit it
> > on
> > > the github page."
> > >
> > > Should i change those instructions to push to master if you have those
> > > permissions?
> >
> >
> > frankly we are adults we do not need instructions to create pr request
> for
> > such obvious change :)
> >
>
> I agree :)
>
> >
> >
> >
> > > --
> > > Dennis Lundberg
> > >
> > >
> > > Den tis 11 aug. 2020 kl 13:29 skrev Olivier Lamy <[hidden email]>:
> > >
> > > > Hi Dennis
> > > > I just merged your pr.
> > > > But for those changes just push to master branch you do not really
> need
> > > > approval and it's a bit useless...
> > > > (and this will avoid some notifications noise)
> > > >
> > > > On Tue, 11 Aug 2020 at 19:25, Dennis Lundberg <[hidden email]>
> > > wrote:
> > > >
> > > > > Hi,
> > > > >
> > > > > During the release I've made recently I have updated
> > maven-site@github
> > > > > with
> > > > > the new versions and release dates. These turn into pull requests
> > that
> > > > have
> > > > > now been approved. However I seem to lack some permissions (or
> > > knowledge)
> > > > > to merge these pull requests from the GitHub UI.
> > > > >
> > > > > Can someone point me in the right direction, or help me merge
> these:
> > > > > https://github.com/apache/maven-site/pull/189
> > > > > https://github.com/apache/maven-site/pull/192
> > > > > https://github.com/apache/maven-site/pull/193
> > > > >
> > > > > Thanks in advance,
> > > > > Dennis Lundberg
> > > > >
> > > >
> > > >
> > > > --
> > > > Olivier Lamy
> > > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > >
> > >
> >
> >
> > --
> > Olivier Lamy
> > http://twitter.com/olamy | http://linkedin.com/in/olamy
> >
>


--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy