Re: Maven Shade and MSHADE-352 (timestamp support), mitigate the breaking change of last release

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: Maven Shade and MSHADE-352 (timestamp support), mitigate the breaking change of last release

Romain Manni-Bucau
Perfect, merci Hervé ;).

Romain Manni-Bucau
@rmannibucau <https://twitter.com/rmannibucau> |  Blog
<https://rmannibucau.metawerx.net/> | Old Blog
<http://rmannibucau.wordpress.com> | Github <https://github.com/rmannibucau> |
LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
<https://www.packtpub.com/application-development/java-ee-8-high-performance>


Le mar. 12 mai 2020 à 12:37, Hervé BOUTEMY <[hidden email]> a écrit :

> Hi,
>
> I created MSHADE-363 Jira issue and did a fix in corresponding Git branch,
> implementing exactly your strategy, even if I called the new interface
> "ReproducibleResourceTransformer" instead of TimeAware... :)
>
> I just transformed the Git branch into a PR to get review:
> https://github.com/apache/maven-shade-plugin/pull/47
>
> feedback welcome
>
> Regards,
>
> Hervé
>
> Le mardi 12 mai 2020, 12:21:51 CEST Romain Manni-Bucau a écrit :
> > Hi everyone,
> >
> > Wonder if we can't mitigate the breaking change in the last minor of
> shade
> > plugin (due to MSHADE-352).
> >
> > Idea would be to have a TimeAwareResourceTransformer extends
> > ResourceTransformer and handle an instanceof or equivalent in our
> codebase
> > to avoid to break all transformers outside maven-shade project.
> >
> > Wdyt?
> >
> > Romain Manni-Bucau
> > @rmannibucau <https://twitter.com/rmannibucau> |  Blog
> > <https://rmannibucau.metawerx.net/> | Old Blog
> > <http://rmannibucau.wordpress.com> | Github <
> https://github.com/rmannibucau>
> > | LinkedIn <https://www.linkedin.com/in/rmannibucau> | Book
> > <
> https://www.packtpub.com/application-development/java-ee-8-high-performance
> > >
>
>
>
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>