Re: Maven 3.5.3: MNG-6305

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Maven 3.5.3: MNG-6305

Karl Heinz Marbaise-3
Hi Robert,

On 29/12/17 11:18, Robert Scholte wrote:
> Hi Karl Heinz,
>
> I think the REgExp usage can be improved.
> Now it used for building up a new String followed by searching, I would
> expect that searching for ${(.+)} groups to be more efficient.

Do you have some suggestions what you exactly have in mind?

Kind regards
Karl Heinz Marbaise

>
> thanks,
> Robert
>
>
> On Fri, 29 Dec 2017 11:10:36 +0100, Karl Heinz Marbaise
> <[hidden email]> wrote:
>
>> Hi,
>>
>> I would like to know if there are any objections to merge MNG-6305
>> into master (Jenkins is fine [1]).
>>
>> Kind regards
>> Karl Heinz Marbaise
>>
>> [1]:
>> https://builds.apache.org/job/maven-wip/job/maven/job/MNG-6305-validation-of-ci-friendly/ 
>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Maven 3.5.3: MNG-6305

Karl Heinz Marbaise-3
Hi,


On 30/12/17 18:33, Robert Scholte wrote:
> Sure, let me pick this up

I have already implemented different solutions but based on performance
measurements the one I have implemented seemed to be the fastest
solution ?...


Kind regards
Karl Heinz Marbaise

>
> Robert
>
> On Sat, 30 Dec 2017 15:15:41 +0100, Karl Heinz Marbaise
> <[hidden email]> wrote:
>
>> Hi Robert,
>>
>> On 29/12/17 11:18, Robert Scholte wrote:
>>> Hi Karl Heinz,
>>>  I think the REgExp usage can be improved.
>>> Now it used for building up a new String followed by searching, I
>>> would expect that searching for ${(.+)} groups to be more efficient.
>>
>> Do you have some suggestions what you exactly have in mind?
>>
>> Kind regards
>> Karl Heinz Marbaise
>>>  thanks,
>>> Robert
>>>   On Fri, 29 Dec 2017 11:10:36 +0100, Karl Heinz Marbaise
>>> <[hidden email]> wrote:
>>>
>>>> Hi,
>>>>
>>>> I would like to know if there are any objections to merge MNG-6305
>>>> into master (Jenkins is fine [1]).
>>>>
>>>> Kind regards
>>>> Karl Heinz Marbaise
>>>>
>>>> [1]:
>>>> https://builds.apache.org/job/maven-wip/job/maven/job/MNG-6305-validation-of-ci-friendly/ 
>>>>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Maven 3.5.3: MNG-6305

rfscholte
+1 to merge with the latest commits.

Robert

On Sat, 30 Dec 2017 19:12:31 +0100, Robert Scholte <[hidden email]>  
wrote:

> Hi Karl Heinz,
>
> Please verify my commit.
>
> thanks,
> Robert
>
> On Sat, 30 Dec 2017 18:36:29 +0100, Karl Heinz Marbaise  
> <[hidden email]> wrote:
>
>> Hi,
>>
>>
>> On 30/12/17 18:33, Robert Scholte wrote:
>>> Sure, let me pick this up
>>
>> I have already implemented different solutions but based on performance  
>> measurements the one I have implemented seemed to be the fastest  
>> solution ?...
>>
>>
>> Kind regards
>> Karl Heinz Marbaise
>>>  Robert
>>>  On Sat, 30 Dec 2017 15:15:41 +0100, Karl Heinz Marbaise  
>>> <[hidden email]> wrote:
>>>
>>>> Hi Robert,
>>>>
>>>> On 29/12/17 11:18, Robert Scholte wrote:
>>>>> Hi Karl Heinz,
>>>>>  I think the REgExp usage can be improved.
>>>>> Now it used for building up a new String followed by searching, I  
>>>>> would expect that searching for ${(.+)} groups to be more efficient.
>>>>
>>>> Do you have some suggestions what you exactly have in mind?
>>>>
>>>> Kind regards
>>>> Karl Heinz Marbaise
>>>>>  thanks,
>>>>> Robert
>>>>>   On Fri, 29 Dec 2017 11:10:36 +0100, Karl Heinz Marbaise  
>>>>> <[hidden email]> wrote:
>>>>>
>>>>>> Hi,
>>>>>>
>>>>>> I would like to know if there are any objections to merge MNG-6305  
>>>>>> into master (Jenkins is fine [1]).
>>>>>>
>>>>>> Kind regards
>>>>>> Karl Heinz Marbaise
>>>>>>
>>>>>> [1]:  
>>>>>> https://builds.apache.org/job/maven-wip/job/maven/job/MNG-6305-validation-of-ci-friendly/
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]