Re: MNG-6999/e7eef9d34f15a5da5c36f51fea11dc645875d143 completey breaks Maven

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: MNG-6999/e7eef9d34f15a5da5c36f51fea11dc645875d143 completey breaks Maven

Hervé BOUTEMY
wow, nice finding, both for reporting and finding/fixing the root cause

Le lundi 9 novembre 2020, 21:47:53 CET Robert Scholte a écrit :

> For those interested, root cause has been found and fixed.[1]
>
> thanks,
> Robert
>
> [1] https://github.com/apache/maven/commit/a89a3d315d335a2ca670b3d0ec7eab41c
> 5354ea3 On 5-11-2020 12:10:20, Robert Scholte <[hidden email]> wrote:
> What's interesting is that MNG-6999 introduced the issue (right?), which is
> mainly about proper lexicalHandler processing.
> AbstractModelSourceTransformer.java [1] is most likely the root cause
>
> Regarding build/consumer this commit is relatively small, so a bigger chance
> to fix it.
>
> Robert
>
> [1] https://github.com/apache/maven/commit/e7eef9d34f15a5da5c36f51fea11dc645
> 875d143/#diff-7b360a99383759ea66111f9c11dd617a09227ab0d0ed4712993b683bfad181
> 95
>
>
> On 5-11-2020 10:19:05, Michael Osipov <[hidden email]> wrote:
> Of couse, I prefer a fix too, but as you can see our testbed's coverage
> isn't good enough to find race conditions.
> I can provide you SSH access to a box to recreate, test and fix that
> issue if you like.
>
> Michael
>
> Am 2020-11-04 um 23:48 schrieb Robert Scholte:
> > I hope we can focus on a fix instead a revert, this concept is quite
> > critical if we ever want to move Maven forward. There's actually a second
> > branch waiting to be merged to solve the reverse order of modules when
> > using build/consumer. I'll try to have a look this weekend, and of course
> > any help here is appreciated.
> >
> > thanks,
> > Robert
> >
> > On 3-11-2020 12:23:55, Michael Osipov wrote:
> > Folks,
> >
> > just tried to run tests with latest master and Maven is fundamentally
> >
> > broken for me regardless of the project or Java vesion:
> >> $
> >> ~/apache-maven-3.7.0-SNAPSHOT-e7eef9d34f15a5da5c36f51fea11dc645875d143/b
> >> in/mvn -V package Apache Maven 3.7.0-SNAPSHOT
> >> (e7eef9d34f15a5da5c36f51fea11dc645875d143) Maven home:
> >> /home/mosipov/apache-maven-3.7.0-SNAPSHOT-e7eef9d34f15a5da5c36f51fea11dc
> >> 645875d143 Java version: 1.8.0_265, vendor: OpenJDK BSD Porting Team,
> >> runtime: /usr/local/openjdk8/jre Default locale: de_DE, platform
> >> encoding: UTF-8
> >> OS name: "freebsd", version: "12.2-stable", arch: "amd64", family: "unix"
> >> [INFO] Scanning for projects...
> >> ERROR: 'Pipe not connected'
> >> ERROR: 'Pipe not connected'
> >> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> >> [FATAL] input contained no data @
> >> [FATAL] input contained no data @
> >> @
> >> [ERROR] The build could not read 2 projects -> [Help 1]
> >> [ERROR]
> >> [ERROR] The project
> >> org.apache.maven.resolver:maven-resolver-transport-http:1.6.2-SNAPSHOT
> >> (/var/mosipov/Projekte/maven-resolver/maven-resolver-transport-http/pom.
> >> xml) has 1 error [ERROR] input contained no data
> >> [ERROR]
> >> [ERROR] The project
> >> org.apache.maven.resolver:maven-resolver-synccontext-global:1.6.2-SNAPSH
> >> OT
> >> (/var/mosipov/Projekte/maven-resolver/maven-resolver-synccontext-global/
> >> pom.xml) has 1 error [ERROR] input contained no data
> >> [ERROR]
> >> [ERROR] To see the full stack trace of the errors, re-run Maven with the
> >> -e switch. [ERROR] Re-run Maven using the -X switch to enable full debug
> >> logging. [ERROR]
> >> [ERROR] For more information about the errors and possible solutions,
> >> please read the following articles: [ERROR] [Help 1]
> >> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingExceptio
> >> n>
> > but the previous commit:
> >> $
> >> ~/apache-maven-3.7.0-SNAPSHOT-449e6dc9db8152b1c67728a0fb8b16dc04e8976f/b
> >> in/mvn -V package Apache Maven 3.7.0-SNAPSHOT
> >> (449e6dc9db8152b1c67728a0fb8b16dc04e8976f) Maven home:
> >> /home/mosipov/apache-maven-3.7.0-SNAPSHOT-449e6dc9db8152b1c67728a0fb8b16
> >> dc04e8976f Java version: 1.8.0_265, vendor: OpenJDK BSD Porting Team,
> >> runtime: /usr/local/openjdk8/jre Default locale: de_DE, platform
> >> encoding: UTF-8
> >> OS name: "freebsd", version: "12.2-stable", arch: "amd64", family: "unix"
> >> [INFO] Scanning for projects...
> >> [INFO]
> >> ------------------------------------------------------------------------
> >> [INFO] Reactor Build Order:
> >> [INFO]
> >> [INFO] Maven Artifact Resolver [pom]
> >> [INFO] Maven Artifact Resolver API [jar]
> >> [INFO] Maven Artifact Resolver SPI [jar]
> >> [INFO] Maven Artifact Resolver Test Utilities [jar]
> >> [INFO] Maven Artifact Resolver Utilities [jar]
> >> [INFO] Maven Artifact Resolver Implementation [jar]
> >> [INFO] Maven Artifact Resolver Connector Basic [jar]
> >> [INFO] Maven Artifact Resolver Transport Classpath [jar]
> >> [INFO] Maven Artifact Resolver Transport File [jar]
> >> [INFO] Maven Artifact Resolver Transport HTTP [jar]
> >> [INFO] Maven Artifact Resolver Transport Wagon [jar]
> >> [INFO] Maven Artifact Resolver Demos [pom]
> >> [INFO] Maven Artifact Resolver Demo Snippets [jar]
> >> [INFO] Maven Artifact Resolver Demo Maven Plugin [maven-plugin]
> >> [INFO] Maven Artifact Resolver Sync Context Global [jar]
> >
> > The "pipe not connected" happens in more than 50% of all cases.
> > When running Core ITs some ITs just hang forever.
> >
> >>From googling, this is a race condition in the code.
> >>
> > Debug output:
> >> [ERROR] [ERROR] Some problems were encountered while processing the POMs:
> >> [FATAL] input contained no data @
> >> @
> >> [ERROR] The build could not read 1 project -> [Help 1]
> >> org.apache.maven.project.ProjectBuildingException: Some problems were
> >> encountered while processing the POMs: [FATAL] input contained no data @
> >>
> >> at org.apache.maven.project.DefaultProjectBuilder.build
> >> (DefaultProjectBuilder.java:438) at
> >> org.apache.maven.project.collector.DefaultProjectsCollector.collectProje
> >> cts (DefaultProjectsCollector.java:62) at
> >> org.apache.maven.project.collector.MultiModuleCollectionStrategy.collect
> >> Projects (MultiModuleCollectionStrategy.java:72) at
> >> org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor
> >> (DefaultGraphBuilder.java:426) at
> >> org.apache.maven.graph.DefaultGraphBuilder.build
> >> (DefaultGraphBuilder.java:97) at
> >> org.apache.maven.DefaultMaven.buildGraph (DefaultMaven.java:557) at
> >> org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:233) at
> >> org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206) at
> >> org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> >> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> >> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> >> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> >> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> >> at sun.reflect.NativeMethodAccessorImpl.invoke
> >> (NativeMethodAccessorImpl.java:62) at
> >> sun.reflect.DelegatingMethodAccessorImpl.invoke
> >> (DelegatingMethodAccessorImpl.java:43) at
> >> java.lang.reflect.Method.invoke (Method.java:498)
> >> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> >> (Launcher.java:282) at
> >> org.codehaus.plexus.classworlds.launcher.Launcher.launch
> >> (Launcher.java:225) at
> >> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> >> (Launcher.java:406) at
> >> org.codehaus.plexus.classworlds.launcher.Launcher.main
> >> (Launcher.java:347) [ERROR]
> >> [ERROR] The project
> >> org.apache.maven.resolver:maven-resolver-transport-http:1.6.2-SNAPSHOT
> >> (/var/mosipov/Projekte/maven-resolver/maven-resolver-transport-http/pom.
> >> xml) has 1 error [ERROR] input contained no data
> >> java.io.EOFException: input contained no data
> >> at org.codehaus.plexus.util.xml.pull.MXParser.fillBuf
> >> (MXParser.java:3694)
> >> at org.codehaus.plexus.util.xml.pull.MXParser.more (MXParser.java:3776)
> >> at org.codehaus.plexus.util.xml.pull.MXParser.parseProlog
> >> (MXParser.java:1717) at
> >> org.codehaus.plexus.util.xml.pull.MXParser.nextImpl (MXParser.java:1700)
> >> at org.codehaus.plexus.util.xml.pull.MXParser.next (MXParser.java:1319)
> >> at org.apache.maven.model.io.xpp3.MavenXpp3Reader.read
> >> (MavenXpp3Reader.java:3876) at
> >> org.apache.maven.model.io.xpp3.MavenXpp3Reader.read
> >> (MavenXpp3Reader.java:595) at
> >> org.apache.maven.model.io.DefaultModelReader.read
> >> (DefaultModelReader.java:149) at
> >> org.apache.maven.model.io.DefaultModelReader.read
> >> (DefaultModelReader.java:122) at
> >> org.apache.maven.model.io.DefaultModelReader.read
> >> (DefaultModelReader.java:94) at
> >> org.apache.maven.model.building.DefaultModelProcessor.read
> >> (DefaultModelProcessor.java:97) at
> >> org.apache.maven.model.building.DefaultModelBuilder.readModel
> >> (DefaultModelBuilder.java:670) at
> >> org.apache.maven.model.building.DefaultModelBuilder.build
> >> (DefaultModelBuilder.java:293) at
> >> org.apache.maven.project.DefaultProjectBuilder.build
> >> (DefaultProjectBuilder.java:492) at
> >> org.apache.maven.project.DefaultProjectBuilder.build
> >> (DefaultProjectBuilder.java:456) at
> >> org.apache.maven.project.DefaultProjectBuilder.build
> >> (DefaultProjectBuilder.java:605) at
> >> org.apache.maven.project.DefaultProjectBuilder.build
> >> (DefaultProjectBuilder.java:456) at
> >> org.apache.maven.project.DefaultProjectBuilder.build
> >> (DefaultProjectBuilder.java:420) at
> >> org.apache.maven.project.collector.DefaultProjectsCollector.collectProje
> >> cts (DefaultProjectsCollector.java:62) at
> >> org.apache.maven.project.collector.MultiModuleCollectionStrategy.collect
> >> Projects (MultiModuleCollectionStrategy.java:72) at
> >> org.apache.maven.graph.DefaultGraphBuilder.getProjectsForMavenReactor
> >> (DefaultGraphBuilder.java:426) at
> >> org.apache.maven.graph.DefaultGraphBuilder.build
> >> (DefaultGraphBuilder.java:97) at
> >> org.apache.maven.DefaultMaven.buildGraph (DefaultMaven.java:557) at
> >> org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:233) at
> >> org.apache.maven.DefaultMaven.doExecute (DefaultMaven.java:206) at
> >> org.apache.maven.DefaultMaven.execute (DefaultMaven.java:119)
> >> at org.apache.maven.cli.MavenCli.execute (MavenCli.java:982)
> >> at org.apache.maven.cli.MavenCli.doMain (MavenCli.java:296)
> >> at org.apache.maven.cli.MavenCli.main (MavenCli.java:200)
> >> at sun.reflect.NativeMethodAccessorImpl.invoke0 (Native Method)
> >> at sun.reflect.NativeMethodAccessorImpl.invoke
> >> (NativeMethodAccessorImpl.java:62) at
> >> sun.reflect.DelegatingMethodAccessorImpl.invoke
> >> (DelegatingMethodAccessorImpl.java:43) at
> >> java.lang.reflect.Method.invoke (Method.java:498)
> >> at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced
> >> (Launcher.java:282) at
> >> org.codehaus.plexus.classworlds.launcher.Launcher.launch
> >> (Launcher.java:225) at
> >> org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode
> >> (Launcher.java:406) at
> >> org.codehaus.plexus.classworlds.launcher.Launcher.main
> >> (Launcher.java:347) [ERROR]
> >> [ERROR]
> >> [ERROR] For more information about the errors and possible solutions,
> >> please read the following articles: [ERROR] [Help 1]
> >> http://cwiki.apache.org/confluence/display/MAVEN/ProjectBuildingExceptio
> >> n mosipov@bsd1srv:~/var/Projekte/maven-resolver (master=)
> >
> > Robert, please revise the code otherwise I will have to revert the
> > offending commit.
> >
> > Michael
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]





---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]