Re: JIRA issues for dependency upgrades

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: JIRA issues for dependency upgrades

michaelo
Am 2020-04-27 um 16:20 schrieb Elliotte Rusty Harold:

> Does the community have an consensus on whether to file JIRA tickets
> for minor dependency upgrades that don't require large code changes?
> I've been getting conflicting advice about this in code reviews.
>
> Here's what our docs currently say, but you'll notice that dependency
> upgrades fall somewhere in between the two cases mentioned:
>
> When To Create a JIRA Issue?
>
> This section discusses when to create a JIRA issue versus just
> committing a change in Git (eventually through a PR).
>
> Minor changes such as code reformatting, documentation fixes, etc.
> that aren’t going to impact other users can be committed without a
> JIRA issue.
>
> Larger changes such as bug fixes, API changes, significant
> refactoring, new classes, and pretty much any change of more than 100
> lines, should have JIRA tickets.

My opinion is clearly, yes. There must be a ticket for dep upgrades. You
have seen recently where a patch update of a Plexus Component has caused
a regression and you have spent time to track it down. Such changes
should be user visible.

The reason my I prefer JIRA issues for almost everything is that I don't
want to maintain a changelog manually. In case of a regression one can
always refer to the JIRA issue.

M


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: JIRA issues for dependency upgrades

Karl Heinz Marbaise-3
Hi,

On 27.04.20 17:10, Michael Osipov wrote:

> Am 2020-04-27 um 16:20 schrieb Elliotte Rusty Harold:
>> Does the community have an consensus on whether to file JIRA tickets
>> for minor dependency upgrades that don't require large code changes?
>> I've been getting conflicting advice about this in code reviews.
>>
>> Here's what our docs currently say, but you'll notice that dependency
>> upgrades fall somewhere in between the two cases mentioned:
>>
>> When To Create a JIRA Issue?
>>
>> This section discusses when to create a JIRA issue versus just
>> committing a change in Git (eventually through a PR).
>>
>> Minor changes such as code reformatting, documentation fixes, etc.
>> that aren’t going to impact other users can be committed without a
>> JIRA issue.
>>
>> Larger changes such as bug fixes, API changes, significant
>> refactoring, new classes, and pretty much any change of more than 100
>> lines, should have JIRA tickets.
>
> My opinion is clearly, yes. There must be a ticket for dep upgrades. You
> have seen recently where a patch update of a Plexus Component has caused
> a regression and you have spent time to track it down. Such changes
> should be user visible.
>
> The reason my I prefer JIRA issues for almost everything is that I don't
> want to maintain a changelog manually. In case of a regression one can
> always refer to the JIRA issue.

+1 from me for that approach

Kind regards
Karl Heinz Marbaise

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]