Re: Integration Tests of Maven Core

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: Integration Tests of Maven Core

Mirko Friedenhagen-5
I would agree with Elliotte here. If someone creates a patch for Maven 2.2.x, he or she should just branch from the old tag and have all ITs available at that point of time.

Keeping tests and mark them as to be skipped for newer versions is strange.

After reading Tibor’s comment:
* Tibor just did update the sources to newer Jetty versions but the corresponding tests were never run so no one can really say for sure that they would run at all, would they?
* Looks to me like a waste of time.

Regards
Mirko


> Am 15.12.2019 um 12:18 schrieb Elliotte Rusty Harold <[hidden email]>:
>
> If it's necessary to maintain Maven 2.x or whatever old version,
> that's what version control systems and branches provide. I strongly
> prefer not to have work at head confused by tests that don;t run or
> code that's commented out. In this case, refactorings at head such as
> renaming a method could easily break the ability of an integration
> test to even compile with the version that matters. Project history
> belongs in the source code control system, not the current HEAD
> branch.
>
> On Sun, Dec 8, 2019 at 2:10 PM Karl Heinz Marbaise <[hidden email]> wrote:
>>
>> Hi,
>> I'm diving a little bit into the integration tests of maven core...
>>
>> and I realized that at the moment this list of IT's is SKIPPED
>> based on the version of Maven Core:
>>
>> mng5889FindBasedir(MvnFileLongOptionModule).................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [3.5.0,3.5.1)
>> mng5889FindBasedir(MvnFileShortOptionModule)................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [3.5.0,3.5.1)
>> mng5889FindBasedir(MvnFileShortOption)......................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [3.5.0,3.5.1)
>> mng5889FindBasedir(MvnFileLongOption).......................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [3.5.0,3.5.1)
>> mng5805PkgTypeMojoConfiguration(PkgTypeMojoConfiguration)...SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (3.3.3,3.5.0-alpha)
>> mng4428FollowHttpRedirect(itHttpToHttps)....................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.2.0,2.2.0]
>> mng4428FollowHttpRedirect(itHttpsToHttp)....................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.2.0,2.2.0]
>> mng4279WagonProviderFailover(it)............................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.2.1,3.0-alpha-1)
>> mng4254SelectableWagonProviders(DefaultHttpsWagon)..........SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.2.0,3.0-alpha-1)
>> mng4254SelectableWagonProviders(DefaultHttpWagon)...........SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.2.0,3.0-alpha-1)
>> mng4254SelectableWagonProviders(SettingsUsage)..............SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.2.0,3.0-alpha-1)
>> mng4254SelectableWagonProviders(CliUsage)...................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.2.0,3.0-alpha-1)
>> mng4126ParentProfilesXml(itReactorBuild)....................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,2.1.0),(2.1.0,3.0-alpha-1)
>> mng4126ParentProfilesXml(itChildOnlyBuild)..................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,2.1.0),(2.1.0,3.0-alpha-1)
>> mng4086ExplicitPluginMetaversion(itRelease).................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0.6,3.0-alpha-3)
>> mng4086ExplicitPluginMetaversion(itLatest)..................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0.6,3.0-alpha-3)
>> mng4036ParentResolutionFromSettingsRepo(itLegacyLayout).....SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-3)
>> mng3991ValidDependencyScope(it).............................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [4.0,)
>> mng3983PluginResolutionFromProfileRepos(itFromProfilesXml)..SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1)
>> mng3970DepResolutionFromProfileRepos(itFromProfilesXml).....SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1)
>> mng3948ParentResolutionFromProfileRepos(itFromProfilesXml)..SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1)
>> mng3933ProfilesXmlActivation(itMNG3933).....................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1)
>> mng3885UniqueVersionFromParentProfile(itUniqueVersionReactor)SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.0.10,3.0-alpha-1)
>> mng3885UniqueVersionFromParentProfile(itUniqueVersionStandalone)SKIPPED
>> - Maven version 3.7.0-SNAPSHOT not in range (2.0.10,3.0-alpha-1)
>> mng3885UniqueVersionFromParentProfile(itNonUniqueVersionStandalone)SKIPPED
>> - Maven version 3.7.0-SNAPSHOT not in range (2.0.10,3.0-alpha-1)
>> mng3885UniqueVersionFromParentProfile(itNonUniqueVersionReactor)SKIPPED
>> - Maven version 3.7.0-SNAPSHOT not in range (2.0.10,3.0-alpha-1)
>> mng3760BaseUriProperty(itMNG3760)...........................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range
>> (2.1.0-M1,3.0-alpha-1),(3.0-alpha-2,3.5.4)
>> mng3760BaseUriProperty(itMNG3760SystemPropertyOverride).....SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range
>> (2.1.0-M1,3.0-alpha-1),(3.0-alpha-2,3.5.4)
>> mng3743ForkWithPluginManagement(itMNG3743)..................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.0.8,3.1-SNAPSHOT)
>> mng3704LifecycleExecutorWrapper(itMNG3704)..................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0.9,3.0-alpha-1)
>> mng3599useHttpProxyForWebDAV(itUseHttpProxyForWebDAV).......SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.0.9,3.3.9)
>> mng3599useHttpProxyForWebDAV(itUseHttpProxyForHttp).........SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.0.9,3.3.9)
>> mng3530DynamicPOMInterpolation(itMNG3530_POMProperty).......SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.1.0-M1,3.0-alpha-1)
>> mng3530DynamicPOMInterpolation(itMNG3530_BuildPath).........SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.1.0-M1,3.0-alpha-1)
>> mng3530DynamicPOMInterpolation(itMNG3530_ResourceDirectoryInterpolation)SKIPPED
>> - Maven version 3.7.0-SNAPSHOT not in range [2.1.0-M1,3.0-alpha-1)
>> mng3428PluginDescriptorArtifactsIncomplete(itMNG3428).......SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.0.8,3.0-alpha-1)
>> mng3271DefaultReportsSuppression(itMNG3271).................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range
>> (2.0.9,2.1.0-M1),(2.1.0-M1,3.0-alpha-1)
>> mng3221InfiniteForking(itMNG3221a)..........................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.0.8,3.0-alpha-1)
>> mng3221InfiniteForking(itMNG3221b)..........................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.0.8,3.0-alpha-1)
>> mng3106ProfileMultipleActivators(ProfilesWithMultipleActivators)SKIPPED
>> - Maven version 3.7.0-SNAPSHOT not in range (2.0.9,3.2.2)
>> mng3057VersionExprTransformations(itMNG3057)................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.1.0,2.1.1)
>> mng2883LegacyRepoOffline(DependencyUnresolvable)............SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range
>> (2.0.9,2.1.0-M1),(2.1.0-M1,3.0-alpha-1)
>> mng2883LegacyRepoOffline(PluginUnresolvable)................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range
>> (2.0.9,2.1.0-M1),(2.1.0-M1,3.0-alpha-1)
>> mng2883LegacyRepoOffline(ParentUnresolvable)................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range
>> (2.0.9,2.1.0-M1),(2.1.0-M1,3.0-alpha-1)
>> mng2878DefaultReportXmlImport(itMNG2878)....................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (,3.0-alpha-1)
>> mng2562Timestamp(itCustomFormat)............................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.1.0-M1,3.2.2)
>> mng2562Timestamp(itDefaultFormat)...........................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.1.0-M1,3.2.2)
>> mng2562Timestamp(itSameValueAcrossModules)..................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.1.0-M1,3.2.2)
>> mng2539PluginDependenciesComeFromPluginRepos(itMNG2539).....SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.0.4,3.0-alpha-3)
>> mng1999DefaultReportsInheritance(itInheritSuppression)......SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range
>> (2.0.9,2.1.0-M1),(2.1.0-M1,3.0-alpha-1)
>> mng1999DefaultReportsInheritance(itOverrideSuppression).....SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range
>> (2.0.9,2.1.0-M1),(2.1.0-M1,3.0-alpha-1)
>> mng1908LegacySnapshotUpdate(itMNG1908)......................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-3)
>> mng1830ShowVersion(Version).................................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range
>> (2.0.10,2.1.0-M1),(2.1.0-M1,3.0-alpha-1),[3.0-alpha-3,3.2)
>> mng0731LegacyRepoLayout(itMNG731)...........................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-3)
>> mng0469ReportConfig(itReportConfigOverridesBuildDefaults)...SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0.0,3.0-alpha-1)
>> 0145ReactorWithIncludesExcludes(itCustomExcludes)...........SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1)
>> 0145ReactorWithIncludesExcludes(itDefaultIncludesExcludes)..SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1)
>> 0145ReactorWithIncludesExcludes(itCustomIncludes)...........SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1)
>> 0039ReleasePomInReactor(it0039).............................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [2.0,3.0-alpha-1)
>> 0036ReleasePom(it0036)......................................SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range (2.0,3.0-alpha-1)
>> mng6352PrintVersion(itShouldPrintVersionAtTopAndAtBottom)...SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [3.5.3-SNAPSHOT,3.5.4-SNAPSHOT]
>> mng6352PrintVersion(itShouldPrintVersionInAllLines).........SKIPPED -
>> Maven version 3.7.0-SNAPSHOT not in range [3.5.3-SNAPSHOT,3.5.4-SNAPSHOT]
>>
>>
>> which are 62 IT's in total
>>
>> Should we keep them or should we remove them?
>>
>> Several of them are Maven 2 related...?
>>
>> Kind regards
>> Karl Heinz Marbaise
>>
>> [1]: https://issues.apache.org/jira/browse/MNG-6744
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>
>
> --
> Elliotte Rusty Harold
> [hidden email]
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]