Re: GitHub "merge button" is active ?

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: GitHub "merge button" is active ?

olamy
I'm happy to use it for simple merge.
I don't see the point of hiding it.

On Thu, 20 Dec 2018 at 04:01, Tibor Digana <[hidden email]> wrote:

> Try and you will see what happens.
> I do not use it because I am the old school using IDEA and command line. I
> need to see the code in IDE because this Diff in GitHub does not show me
> the changes as good as IDEA does.
>
> On Wed, Dec 19, 2018 at 6:01 PM Enrico Olivelli <[hidden email]>
> wrote:
>
> > self anwsered:
> > just read the docs here:
> > https://gitbox.apache.org/
> >
> > All repositories present on gitbox are available on GitHub with
> > write-access enabled, including rights to open/close/merge pull
> > requests and address issue
> >
> >
> > So back to the question....should I use the "merge button" ?
> >
> > Enrico
> >
> > Il giorno mer 19 dic 2018 alle ore 17:59 Enrico Olivelli
> > <[hidden email]> ha scritto:
> > >
> > >  t"
> > >
> > > Il giorno mer 19 dic 2018 alle ore 17:56 Karl Heinz Marbaise
> > > <[hidden email]> ha scritto:
> > > >
> > > > Hi,
> > > >
> > > > On 19/12/18 17:10, Enrico Olivelli wrote:
> > > > > Is github the primary "source of truth" ?
> > > > > I was thinking that it is a mirror for ASF repo.
> > > > >
> > > > > If github is the primary repo that things are really easier.
> > > > >
> > > > > So which is the 'official' position ? I did not find it on
> > "Committers guide"
> > > >
> > > > The offical truth are the git repositories at gitbox.apache.org/...
> > > >
> > > > GitHub are only mirrors...
> > >
> > > Karl,
> > > So how the 'merge button' can work ?
> > >
> > > for instance on Apache BookKeeper we have switched to github and the
> > > "Merge button" works as expected.
> > > If in Maven we are not using github as primary we should not "allow"
> it.
> > >
> > > Something is not clear to me "gitbox.apache.org" is the new repository
> > > for projects with the new github based flow.
> > > So are you sure that gitbox.apache.org is not the mirror and/or there
> > > is no magic multi-master sync setup ?
> > >
> > >
> > > Enrico
> > >
> > > >
> > > > Kind regards
> > > > Karl Heinz Marbaise
> > > > >
> > > > > Enrico
> > > > >
> > > > >
> > > > >
> > > > > Il giorno mer 19 dic 2018 alle ore 17:08 Christian Stein
> > > > > <[hidden email]> ha scritto:
> > > > >>
> > > > >> I do use the button now and then.
> > > > >>
> > > > >> I'd vote to install https://github.com/apps/wip which disables
> the
> > button
> > > > >> on GitHub ... "allow authors of pull requests to set status to
> > pending
> > > > >> while still working on it."
> > > > >>
> > > > >> Cheers,
> > > > >> Christian
> > > > >>
> > > > >> On Wed, Dec 19, 2018 at 3:57 PM Enrico Olivelli <
> > [hidden email]> wrote:
> > > > >>
> > > > >>> Hi,
> > > > >>> I see that on github we have the 'Merge Button"
> > > > >>>
> > > > >>> like here:
> > > > >>> https://github.com/apache/maven-shade-plugin/pull/12
> > > > >>>
> > > > >>> We are not using that tool, aren't we ?
> > > > >>>
> > > > >>> Can we ask INFRA to hide it ?
> > > > >>>
> > > > >>> Enrico
> > > > >>>
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
> >
>


--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Reply | Threaded
Open this post in threaded view
|

Re: GitHub "merge button" is active ?

Enrico Olivelli
Il mer 19 dic 2018, 23:21 Olivier Lamy <[hidden email]> ha scritto:

> I'm happy to use it for simple merge.
> I don't see the point of hiding it.
>

Yes, given that is works let's use it!

Thank you
Enrico


> On Thu, 20 Dec 2018 at 04:01, Tibor Digana <[hidden email]> wrote:
>
> > Try and you will see what happens.
> > I do not use it because I am the old school using IDEA and command line.
> I
> > need to see the code in IDE because this Diff in GitHub does not show me
> > the changes as good as IDEA does.
> >
> > On Wed, Dec 19, 2018 at 6:01 PM Enrico Olivelli <[hidden email]>
> > wrote:
> >
> > > self anwsered:
> > > just read the docs here:
> > > https://gitbox.apache.org/
> > >
> > > All repositories present on gitbox are available on GitHub with
> > > write-access enabled, including rights to open/close/merge pull
> > > requests and address issue
> > >
> > >
> > > So back to the question....should I use the "merge button" ?
> > >
> > > Enrico
> > >
> > > Il giorno mer 19 dic 2018 alle ore 17:59 Enrico Olivelli
> > > <[hidden email]> ha scritto:
> > > >
> > > >  t"
> > > >
> > > > Il giorno mer 19 dic 2018 alle ore 17:56 Karl Heinz Marbaise
> > > > <[hidden email]> ha scritto:
> > > > >
> > > > > Hi,
> > > > >
> > > > > On 19/12/18 17:10, Enrico Olivelli wrote:
> > > > > > Is github the primary "source of truth" ?
> > > > > > I was thinking that it is a mirror for ASF repo.
> > > > > >
> > > > > > If github is the primary repo that things are really easier.
> > > > > >
> > > > > > So which is the 'official' position ? I did not find it on
> > > "Committers guide"
> > > > >
> > > > > The offical truth are the git repositories at gitbox.apache.org/.
> ..
> > > > >
> > > > > GitHub are only mirrors...
> > > >
> > > > Karl,
> > > > So how the 'merge button' can work ?
> > > >
> > > > for instance on Apache BookKeeper we have switched to github and the
> > > > "Merge button" works as expected.
> > > > If in Maven we are not using github as primary we should not "allow"
> > it.
> > > >
> > > > Something is not clear to me "gitbox.apache.org" is the new
> repository
> > > > for projects with the new github based flow.
> > > > So are you sure that gitbox.apache.org is not the mirror and/or
> there
> > > > is no magic multi-master sync setup ?
> > > >
> > > >
> > > > Enrico
> > > >
> > > > >
> > > > > Kind regards
> > > > > Karl Heinz Marbaise
> > > > > >
> > > > > > Enrico
> > > > > >
> > > > > >
> > > > > >
> > > > > > Il giorno mer 19 dic 2018 alle ore 17:08 Christian Stein
> > > > > > <[hidden email]> ha scritto:
> > > > > >>
> > > > > >> I do use the button now and then.
> > > > > >>
> > > > > >> I'd vote to install https://github.com/apps/wip which disables
> > the
> > > button
> > > > > >> on GitHub ... "allow authors of pull requests to set status to
> > > pending
> > > > > >> while still working on it."
> > > > > >>
> > > > > >> Cheers,
> > > > > >> Christian
> > > > > >>
> > > > > >> On Wed, Dec 19, 2018 at 3:57 PM Enrico Olivelli <
> > > [hidden email]> wrote:
> > > > > >>
> > > > > >>> Hi,
> > > > > >>> I see that on github we have the 'Merge Button"
> > > > > >>>
> > > > > >>> like here:
> > > > > >>> https://github.com/apache/maven-shade-plugin/pull/12
> > > > > >>>
> > > > > >>> We are not using that tool, aren't we ?
> > > > > >>>
> > > > > >>> Can we ask INFRA to hide it ?
> > > > > >>>
> > > > > >>> Enrico
> > > > > >>>
> > >
> > > ---------------------------------------------------------------------
> > > To unsubscribe, e-mail: [hidden email]
> > > For additional commands, e-mail: [hidden email]
> > >
> > >
> >
>
>
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
--


-- Enrico Olivelli