Re: Fwd: Maven builds out of control

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Fwd: Maven builds out of control

Michael Osipov-2
Am 2020-08-17 um 09:55 schrieb Olivier Lamy:
> Furthermore, we need to clean up unused branches.
> What about removing branches older than 1yo?
> Then older than 6months?

I consider branches which have been merged obsolete, but there is no
hard rule that an unmerged branch is obsolete. It may prepresent an
unfished state or something which was not agreed on. Dropping work does
not feel right. It needs to be decided on a case-by-case approach.
I have done this recently for Wagon and Resolver.

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Fwd: Maven builds out of control

Arnaud Héritier
If we are consuming too much resources couldn't we have a dedicated Jenkins
controller and/or limit our agents capacities to be the one ones to be
impacted by these problems instead of all the users or this Jenkins
controller ?
Beam, Cassandra, CouchDB and few more have a dedicated controller :
https://jenkins-ccos.apache.org/job/masters/
What are the rules to have a dedicated one ?

On Mon, Aug 17, 2020 at 10:02 AM Michael Osipov <[hidden email]> wrote:

> Am 2020-08-17 um 09:55 schrieb Olivier Lamy:
> > Furthermore, we need to clean up unused branches.
> > What about removing branches older than 1yo?
> > Then older than 6months?
>
> I consider branches which have been merged obsolete, but there is no
> hard rule that an unmerged branch is obsolete. It may prepresent an
> unfished state or something which was not agreed on. Dropping work does
> not feel right. It needs to be decided on a case-by-case approach.
> I have done this recently for Wagon and Resolver.
>
> Michael
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

--
Arnaud Héritier
Twitter/Skype : aheritier
Reply | Threaded
Open this post in threaded view
|

Re: Fwd: Maven builds out of control

mthmulders
In reply to this post by Michael Osipov-2
On 17/08/2020 09:55, Olivier Lamy wrote:
> Hi there
> we definitely need to reduce the matrix we have and cleanup branches ...
> so I reduced the matrix (no more 14,15)
> and only '3.3.x','3.6.x'
>
> Furthermore, we need to clean up unused branches.
> What about removing branches older than 1yo?
> Then older than 6months?

Nowadays there are a lot of branches created by Dependabot.
I think it's good to update dependencies more frequently than we
currently do. But we shouldn't be building all those branches on Jenkins
immediately, and without (human) review. There's a risk of unreviewed
code being ran on Jenkins. Also, as we can see from this situation, it
creates so many branches that are never cleaned up.

If there would be a way to prevent those branches being built, that
would definitely save space in the build queue. All branches start with
dependabot/, but I haven't found a way yet to filter those out.

Thanks,

Maarten

> ---------- Forwarded message ---------
> From: Richard Eckart de Castilho <[hidden email]>
> Date: Mon, 17 Aug 2020 at 15:37
> Subject: Re: Maven builds out of control
> To: <[hidden email]>
>
>
> Dear Maven developers,
>
> please fix or disable your CI builds ... other people need to use the
> servers as well and in particular those who need to test jobs as part of
> their job migration.
>
> @INFRA: Maybe confine all Maven Jobs to a single specific slave for the
> time being? That way, they only starve themselves.
>
> Cheers,
>
> -- Richard
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Fwd: Maven builds out of control

gmcdonald
In reply to this post by Arnaud Héritier
Hi,

On Mon, Aug 17, 2020 at 10:35 AM Olivier Lamy <[hidden email]> wrote:

> +infra
>
> On Mon, 17 Aug 2020 at 4:23 pm, Arnaud Héritier <[hidden email]>
> wrote:
>
>> If we are consuming too much resources couldn't we have a dedicated
>> Jenkins
>>
>> controller and/or limit our agents capacities to be the one ones to be
>>
>> impacted by these problems instead of all the users or this Jenkins
>>
>> controller ?
>>
>> Beam, Cassandra, CouchDB and few more have a dedicated controller :
>>
>> https://jenkins-ccos.apache.org/job/masters/
>>
>> What are the rules to have a dedicated one ?
>>
>
All of those projects got their own master as they are contributing their
own nodes and not using the ASF provided ones

HTH


>
>>
>>
>> On Mon, Aug 17, 2020 at 10:02 AM Michael Osipov <[hidden email]>
>> wrote:
>>
>>
>>
>> > Am 2020-08-17 um 09:55 schrieb Olivier Lamy:
>>
>> > > Furthermore, we need to clean up unused branches.
>>
>> > > What about removing branches older than 1yo?
>>
>> > > Then older than 6months?
>>
>> >
>>
>> > I consider branches which have been merged obsolete, but there is no
>>
>> > hard rule that an unmerged branch is obsolete. It may prepresent an
>>
>> > unfished state or something which was not agreed on. Dropping work does
>>
>> > not feel right. It needs to be decided on a case-by-case approach.
>>
>> > I have done this recently for Wagon and Resolver.
>>
>> >
>>
>> > Michael
>>
>> >
>>
>> > ---------------------------------------------------------------------
>>
>> > To unsubscribe, e-mail: [hidden email]
>>
>> > For additional commands, e-mail: [hidden email]
>>
>> >
>>
>> >
>>
>>
>>
>> --
>>
>> Arnaud Héritier
>>
>> Twitter/Skype : aheritier
>>
>> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>


--

*Gavin McDonald*
Systems Administrator
ASF Infrastructure Team
Reply | Threaded
Open this post in threaded view
|

Re: Fwd: Maven builds out of control

olamy
In reply to this post by mthmulders
Yes, we can limit branches using regex.
if use @dependabot merge the branch is deleted


On Mon, 17 Aug 2020 at 16:41, Maarten Mulders <[hidden email]> wrote:

> On 17/08/2020 09:55, Olivier Lamy wrote:
> > Hi there
> > we definitely need to reduce the matrix we have and cleanup branches ...
> > so I reduced the matrix (no more 14,15)
> > and only '3.3.x','3.6.x'
> >
> > Furthermore, we need to clean up unused branches.
> > What about removing branches older than 1yo?
> > Then older than 6months?
>
> Nowadays there are a lot of branches created by Dependabot.
> I think it's good to update dependencies more frequently than we
> currently do. But we shouldn't be building all those branches on Jenkins
> immediately, and without (human) review. There's a risk of unreviewed
> code being ran on Jenkins. Also, as we can see from this situation, it
> creates so many branches that are never cleaned up.
>
> If there would be a way to prevent those branches being built, that
> would definitely save space in the build queue. All branches start with
> dependabot/, but I haven't found a way yet to filter those out.
>
> Thanks,
>
> Maarten
>
> > ---------- Forwarded message ---------
> > From: Richard Eckart de Castilho <[hidden email]>
> > Date: Mon, 17 Aug 2020 at 15:37
> > Subject: Re: Maven builds out of control
> > To: <[hidden email]>
> >
> >
> > Dear Maven developers,
> >
> > please fix or disable your CI builds ... other people need to use the
> > servers as well and in particular those who need to test jobs as part of
> > their job migration.
> >
> > @INFRA: Maybe confine all Maven Jobs to a single specific slave for the
> > time being? That way, they only starve themselves.
> >
> > Cheers,
> >
> > -- Richard
> >
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>

--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy
Reply | Threaded
Open this post in threaded view
|

Re: Fwd: Maven builds out of control

olamy
In reply to this post by gmcdonald
traditional slaves
I have a goal to help moving to kubernetes but this will not fix this
problem :)


On Mon, 17 Aug 2020 at 16:46, Arnaud Héritier <[hidden email]> wrote:

> Thanks for the feedback Gavin, it makes a lot of sense to me.
> The new infrastructure is a traditional one (ie not hosted on Kubernetes) ?
>
> On Mon, Aug 17, 2020 at 10:44 AM Gavin McDonald <[hidden email]>
> wrote:
>
> > Hi,
> >
> > On Mon, Aug 17, 2020 at 10:35 AM Olivier Lamy <[hidden email]> wrote:
> >
> > > +infra
> > >
> > > On Mon, 17 Aug 2020 at 4:23 pm, Arnaud Héritier <[hidden email]>
> > > wrote:
> > >
> > >> If we are consuming too much resources couldn't we have a dedicated
> > >> Jenkins
> > >>
> > >> controller and/or limit our agents capacities to be the one ones to be
> > >>
> > >> impacted by these problems instead of all the users or this Jenkins
> > >>
> > >> controller ?
> > >>
> > >> Beam, Cassandra, CouchDB and few more have a dedicated controller :
> > >>
> > >> https://jenkins-ccos.apache.org/job/masters/
> > >>
> > >> What are the rules to have a dedicated one ?
> > >>
> > >
> > All of those projects got their own master as they are contributing their
> > own nodes and not using the ASF provided ones
> >
> > HTH
> >
> >
> > >
> > >>
> > >>
> > >> On Mon, Aug 17, 2020 at 10:02 AM Michael Osipov <[hidden email]>
> > >> wrote:
> > >>
> > >>
> > >>
> > >> > Am 2020-08-17 um 09:55 schrieb Olivier Lamy:
> > >>
> > >> > > Furthermore, we need to clean up unused branches.
> > >>
> > >> > > What about removing branches older than 1yo?
> > >>
> > >> > > Then older than 6months?
> > >>
> > >> >
> > >>
> > >> > I consider branches which have been merged obsolete, but there is no
> > >>
> > >> > hard rule that an unmerged branch is obsolete. It may prepresent an
> > >>
> > >> > unfished state or something which was not agreed on. Dropping work
> > does
> > >>
> > >> > not feel right. It needs to be decided on a case-by-case approach.
> > >>
> > >> > I have done this recently for Wagon and Resolver.
> > >>
> > >> >
> > >>
> > >> > Michael
> > >>
> > >> >
> > >>
> > >> >
> ---------------------------------------------------------------------
> > >>
> > >> > To unsubscribe, e-mail: [hidden email]
> > >>
> > >> > For additional commands, e-mail: [hidden email]
> > >>
> > >> >
> > >>
> > >> >
> > >>
> > >>
> > >>
> > >> --
> > >>
> > >> Arnaud Héritier
> > >>
> > >> Twitter/Skype : aheritier
> > >>
> > >> --
> > > Olivier Lamy
> > > http://twitter.com/olamy | http://linkedin.com/in/olamy
> > >
> >
> >
> > --
> >
> > *Gavin McDonald*
> > Systems Administrator
> > ASF Infrastructure Team
> >
>
>
> --
> Arnaud Héritier
> Twitter/Skype : aheritier
>


--
Olivier Lamy
http://twitter.com/olamy | http://linkedin.com/in/olamy