Re: Current master is broken

classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Current master is broken

Enrico Olivelli
Il Dom 8 Mar 2020, 13:06 Robert Scholte <[hidden email]> ha scritto:

>
> https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=a151f10c7823cbbbe98446acad68da0ff82f2e04
> should fix it, please verify.
>

I can't do it today, I am sorry.
I will check as soon as I have my laptop :)

Thanks for addressing the problem so soon

Enrico

>
>
> thanks,
> Robert
> On 6-3-2020 11:13:52, Enrico Olivelli <[hidden email]> wrote:
> Il giorno ven 6 mar 2020 alle ore 10:43 Robert Scholte
> ha scritto:
> >
> > I found the root cause, and it is quite exclusive for maven-shade-plugin
> (rewriting reduced-pom where excludes need to be updated). No need to
> revert, this is on top of my list to fix.
>
> Good.
> It is important that we keep compatibility with current version of
> maven shade plugin.
> It would be a too big burden to force uses to update a plugin in order
> to work with Maven 3.7.0
>
> Enrico
>
> >
> > Robert
> > On 3-3-2020 23:23:47, Enrico Olivelli wrote:
> > Hi guys,
> > I am trying current master and the build of a simple project
> > (https://github.com/diennea/herddb) is stuck in the Maven Shade Plugin
> >
> > The bad commit is
> > 716cc1fe02661897232a7cc3e4c1bb3b3df3b832
> https://github.com/apache/maven/commit/716cc1fe02661897232a7cc3e4c1bb3b3df3b832
> >
> > With a
> > git revert 716cc1fe02661897232a7cc3e4c1bb3b3df3b832
> >
> > The build passes
> > The commit is from Robert.
> > I feel it is good to push such a revert if we do not have time to
> > investigate, otherwise code will diverge too much and we will not be
> > able to find a fix easily
> >
> > Enrico
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: [hidden email]
> > For additional commands, e-mail: [hidden email]
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|

Re: Current master is broken

rfscholte
you mean it was broken with current master and after applying this patch it is fixed?
On 8-3-2020 14:22:21, Michael Osipov <[hidden email]> wrote:
Am 2020-03-08 um 13:06 schrieb Robert Scholte:
> https://gitbox.apache.org/repos/asf?p=maven.git;a=commit;h=a151f10c7823cbbbe98446acad68da0ff82f2e04 should fix it, please verify.

This perfectly works now for MSITE 3.9.0

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]