Re: Current master is broken

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

Re: Current master is broken

Enrico Olivelli
Il giorno ven 6 mar 2020 alle ore 10:43 Robert Scholte
<[hidden email]> ha scritto:
>
> I found the root cause, and it is quite exclusive for maven-shade-plugin (rewriting reduced-pom where excludes need to be updated). No need to revert, this is on top of my list to fix.

Good.
It is important that we keep compatibility with current version of
maven shade plugin.
It would be a too big burden to force uses to update a plugin in order
to work with Maven 3.7.0

Enrico

>
> Robert
> On 3-3-2020 23:23:47, Enrico Olivelli <[hidden email]> wrote:
> Hi guys,
> I am trying current master and the build of a simple project
> (https://github.com/diennea/herddb) is stuck in the Maven Shade Plugin
>
> The bad commit is
> 716cc1fe02661897232a7cc3e4c1bb3b3df3b832https://github.com/apache/maven/commit/716cc1fe02661897232a7cc3e4c1bb3b3df3b832
>
> With a
> git revert 716cc1fe02661897232a7cc3e4c1bb3b3df3b832
>
> The build passes
> The commit is from Robert.
> I feel it is good to push such a revert if we do not have time to
> investigate, otherwise code will diverge too much and we will not be
> able to find a fix easily
>
> Enrico
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]