Re: Add permissions to close Pull Requests in ASF projects at GitHub

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Add permissions to close Pull Requests in ASF projects at GitHub

Karl Heinz Marbaise-3
Hi Tibor,

On 18/03/18 19:50, Tibor Digana wrote:
> Do you have permissions to close pull requests in our ASF Maven projects?

Are you allowed to do merge a pull request via GitHub ?


Kind regards
Karl Heinz Marbaise

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Add permissions to close Pull Requests in ASF projects at GitHub

Hervé BOUTEMY
Le dimanche 18 mars 2018, 20:41:05 CET Michael Osipov a écrit :

> Am 2018-03-18 um 20:28 schrieb Karl Heinz Marbaise:
> > Hi Tibor,
> >
> > On 18/03/18 19:50, Tibor Digana wrote:
> >> Do you have permissions to close pull requests in our ASF Maven projects?
> >
> > Are you allowed to do merge a pull request via GitHub ?
>
> Please don't do that. GitHub will -- by default -- do a no-ff merge with
> ugly and useless merge commits.
AFAIK, now you can choose if you want the merge commit or fast-forward: then
merging directly from GitHub can be a good option (yes, with fast-forward
merge)

> You have either to explicitly say ff
> merge or do via shell.
>
> Michael
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]



---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Add permissions to close Pull Requests in ASF projects at GitHub

Karl Heinz Marbaise-3
Hi,
On 18/03/18 21:01, Hervé BOUTEMY wrote:

> Le dimanche 18 mars 2018, 20:41:05 CET Michael Osipov a écrit :
>> Am 2018-03-18 um 20:28 schrieb Karl Heinz Marbaise:
>>> Hi Tibor,
>>>
>>> On 18/03/18 19:50, Tibor Digana wrote:
>>>> Do you have permissions to close pull requests in our ASF Maven projects?
>>>
>>> Are you allowed to do merge a pull request via GitHub ?
>>
>> Please don't do that. GitHub will -- by default -- do a no-ff merge with
>> ugly and useless merge commits.
> AFAIK, now you can choose if you want the merge commit or fast-forward: then
> merging directly from GitHub can be a good option (yes, with fast-forward
> merge)

>
>> You have either to explicitly say ff
>> merge or do via shell.

Yes that's possible to do via GitHub.

which I would also recommend to keep the history clean and strait...

Kind regards
Karl Heinz Marbaise
>>
>> Michael
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]