Re: Add permissions to close Pull Requests in ASF projects at GitHub

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Add permissions to close Pull Requests in ASF projects at GitHub

michaelo
Am 2018-03-18 um 19:50 schrieb Tibor Digana:
> Do you have permissions to close pull requests in our ASF Maven projects?
> Me either!
> I would like to close completed PRs which leak in the list at GitHub and
> the particular person does not respond to my request.

Two options:

1. If you have merged, ammend the commit message and say: "This closes #XY"
2. If you reject, create a ticket with INFRA

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|

Re: Add permissions to close Pull Requests in ASF projects at GitHub

michaelo
Am 2018-03-18 um 20:28 schrieb Karl Heinz Marbaise:
> Hi Tibor,
>
> On 18/03/18 19:50, Tibor Digana wrote:
>> Do you have permissions to close pull requests in our ASF Maven projects?
>
> Are you allowed to do merge a pull request via GitHub ?

Please don't do that. GitHub will -- by default -- do a no-ff merge with
ugly and useless merge commits. You have either to explicitly say ff
merge or do via shell.

Michael

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]