Re: [ANN] Apache Maven Shade Plugin Version 3.2.0 Released

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: [ANN] Apache Maven Shade Plugin Version 3.2.0 Released

Yuri
It turns out there is already a JIRA issue for this: MSHADE-301
<https://issues.apache.org/jira/browse/MSHADE-301>. And it has been fixed
by Olivier Lamy.

thanks,

On Wed, Oct 10, 2018 at 8:56 AM Yuri de Wit <[hidden email]> wrote:

> Hi Enrico,
>
> This is the error I get:
>
> org.apache.maven.plugin.MojoExecutionException: Error in ASM processing
> class org/test/A/ext/StateExtension.class: This feature requires ASM7 ->
> [Help 1]
>
> My understanding is that asm version 6.2.1 doesn't support Java 11 nested
> classes unless the ASM7 is explicitly enabled from the API. The version
> 7.0+ does seem to make ASM7 the default, but so far only a 7.0-beta asm
> release.
>
> thanks,
>
>
>
>
> On Wed, Oct 10, 2018 at 8:48 AM Enrico Olivelli <[hidden email]>
> wrote:
>
>> Il mer 10 ott 2018, 13:02 Yuri de Wit <[hidden email]> ha scritto:
>>
>> > Hi,
>> >
>> > Any plans to release 3.2.1 with Java 11 support?
>> >
>>
>> I am using jdk11 with current stable version.
>> Which is your problem?
>>
>> Enrico
>>
>> >
>> > thanks,
>> >
>> > On Wed, Sep 12, 2018 at 5:34 PM Karl Heinz Marbaise <
>> [hidden email]
>> > >
>> > wrote:
>> >
>> > > The Apache Maven team is pleased to announce the release of the
>> > > Apache Maven Shade Plugin Version 3.2.0
>> > >
>> > > https://maven.apache.org/plugins/maven-shade-plugin/
>> > >
>> > > Important Note since 3.2.0:
>> > >
>> > >  * Maven 3.X only
>> > >  * If you like to use minimizeJar you have to use JDK8+
>> > >    otherwise you can keep running with JDK7.
>> > >
>> > > You should specify the version in your project's plugin configuration:
>> > >
>> > > <plugin>
>> > >   <groupId>org.apache.maven.plugins</groupId>
>> > >   <artifactId>maven-shade-plugin</artifactId>
>> > >   <version>3.2.0</version>
>> > > </plugin>
>> > >
>> > > You can download the appropriate sources etc. from the download page:
>> > >
>> > > https://maven.apache.org/plugins/maven-shade-plugin/download.cgi
>> > >
>> > > Release Notes Maven Shade Plugin 3.2.0
>> > >
>> > >
>> > >
>> >
>> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12343491
>> > >
>> > > Bug:
>> > >
>> > >  * [MSHADE-289] - Maven Shade Plugin does not work under Java 10
>> > >
>> > > Improvement:
>> > >
>> > >  * [MSHADE-293] - Require Java 7
>> > >
>> > > Dependency upgrades:
>> > >
>> > >  * [MSHADE-294] - Upgrade maven-plugins parent to version 32
>> > >  * [MSHADE-296] - Upgrade maven-artifact-transfer 0.10.0
>> > >
>> > > Enjoy
>> > >
>> > > - The Apache Maven team
>> > >
>> > > ---------------------------------------------------------------------
>> > > To unsubscribe, e-mail: [hidden email]
>> > > For additional commands, e-mail: [hidden email]
>> > >
>> > >
>> >
>> --
>>
>>
>> -- Enrico Olivelli
>>
>
Reply | Threaded
Open this post in threaded view
|

Re: [ANN] Apache Maven Shade Plugin Version 3.2.0 Released

Yuri
Hi Olivier,

Thanks for the head up!



On Wed, Oct 10, 2018 at 9:16 AM Olivier Lamy <[hidden email]> wrote:

> Hi
> On my TODO for next week with pmd and maven-plugin-plugin
> Cheers
> Olivier
>
> On Wed, 10 Oct 2018 at 10:01 pm, Yuri de Wit <[hidden email]> wrote:
>
> > It turns out there is already a JIRA issue for this: MSHADE-301
> > <https://issues.apache.org/jira/browse/MSHADE-301>. And it has been
> fixed
> > by Olivier Lamy.
> >
> > thanks,
> >
> > On Wed, Oct 10, 2018 at 8:56 AM Yuri de Wit <[hidden email]> wrote:
> >
> > > Hi Enrico,
> > >
> > > This is the error I get:
> > >
> > > org.apache.maven.plugin.MojoExecutionException: Error in ASM processing
> > > class org/test/A/ext/StateExtension.class: This feature requires ASM7
> ->
> > > [Help 1]
> > >
> > > My understanding is that asm version 6.2.1 doesn't support Java 11
> nested
> > > classes unless the ASM7 is explicitly enabled from the API. The version
> > > 7.0+ does seem to make ASM7 the default, but so far only a 7.0-beta asm
> > > release.
> > >
> > > thanks,
> > >
> > >
> > >
> > >
> > > On Wed, Oct 10, 2018 at 8:48 AM Enrico Olivelli <[hidden email]>
> > > wrote:
> > >
> > >> Il mer 10 ott 2018, 13:02 Yuri de Wit <[hidden email]> ha scritto:
> > >>
> > >> > Hi,
> > >> >
> > >> > Any plans to release 3.2.1 with Java 11 support?
> > >> >
> > >>
> > >> I am using jdk11 with current stable version.
> > >> Which is your problem?
> > >>
> > >> Enrico
> > >>
> > >> >
> > >> > thanks,
> > >> >
> > >> > On Wed, Sep 12, 2018 at 5:34 PM Karl Heinz Marbaise <
> > >> [hidden email]
> > >> > >
> > >> > wrote:
> > >> >
> > >> > > The Apache Maven team is pleased to announce the release of the
> > >> > > Apache Maven Shade Plugin Version 3.2.0
> > >> > >
> > >> > > https://maven.apache.org/plugins/maven-shade-plugin/
> > >> > >
> > >> > > Important Note since 3.2.0:
> > >> > >
> > >> > >  * Maven 3.X only
> > >> > >  * If you like to use minimizeJar you have to use JDK8+
> > >> > >    otherwise you can keep running with JDK7.
> > >> > >
> > >> > > You should specify the version in your project's plugin
> > configuration:
> > >> > >
> > >> > > <plugin>
> > >> > >   <groupId>org.apache.maven.plugins</groupId>
> > >> > >   <artifactId>maven-shade-plugin</artifactId>
> > >> > >   <version>3.2.0</version>
> > >> > > </plugin>
> > >> > >
> > >> > > You can download the appropriate sources etc. from the download
> > page:
> > >> > >
> > >> > > https://maven.apache.org/plugins/maven-shade-plugin/download.cgi
> > >> > >
> > >> > > Release Notes Maven Shade Plugin 3.2.0
> > >> > >
> > >> > >
> > >> > >
> > >> >
> > >>
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12343491
> > >> > >
> > >> > > Bug:
> > >> > >
> > >> > >  * [MSHADE-289] - Maven Shade Plugin does not work under Java 10
> > >> > >
> > >> > > Improvement:
> > >> > >
> > >> > >  * [MSHADE-293] - Require Java 7
> > >> > >
> > >> > > Dependency upgrades:
> > >> > >
> > >> > >  * [MSHADE-294] - Upgrade maven-plugins parent to version 32
> > >> > >  * [MSHADE-296] - Upgrade maven-artifact-transfer 0.10.0
> > >> > >
> > >> > > Enjoy
> > >> > >
> > >> > > - The Apache Maven team
> > >> > >
> > >> > >
> > ---------------------------------------------------------------------
> > >> > > To unsubscribe, e-mail: [hidden email]
> > >> > > For additional commands, e-mail: [hidden email]
> > >> > >
> > >> > >
> > >> >
> > >> --
> > >>
> > >>
> > >> -- Enrico Olivelli
> > >>
> > >
> >
> --
> Olivier Lamy
> http://twitter.com/olamy | http://linkedin.com/in/olamy
>
Reply | Threaded
Open this post in threaded view
|

Re: [ANN] Apache Maven Shade Plugin Version 3.2.0 Released

Yuri
We use the org.springframework.build:aws-maven extension to deploy our
artifacts directly to S3 and we have had issues where some plugins would
not find the S3 wagon. So we ended up adding to all plugins: we just want
all plugins to use the aws-maven S3 wagon at all times.

I am happy to try and what happens although I am not sure why would
enabling extensions change the dependency resolution mechanism.




On Wed, Oct 10, 2018 at 5:12 PM Enrico Olivelli <[hidden email]> wrote:

> Il mer 10 ott 2018, 21:44 Yuri de Wit <[hidden email]> ha scritto:
>
> > Here it is:
> >
> > parent/pom.xml (independent parent pom):
> >                 <plugin>
> >                     <groupId>org.apache.maven.plugins</groupId>
> >                  <artifactId>maven-shade-plugin</artifactId>
> >                     <version>3.2.0</version>
> >                     <extensions>true</extensions>
> >
>
> Why extensions? I think you can drop this tag
>
> Enrico
>
>                     <dependencies>
> >                         <dependency>
> >                             <groupId>org.ow2.asm</groupId>
> >                             <artifactId>asm</artifactId>
> >                             <version>7.0-beta</version>
> >                         </dependency>
> >                     </dependencies>
> >                 </plugin>
> >
> > root/pom.xml (aggregate):
> > (no shade-plugin entry)
> >
> > root/module/pom.xml (module with root/pom.xml as parent):
> >             <plugin>
> >                 <groupId>org.apache.maven.plugins</groupId>
> >                 <artifactId>maven-shade-plugin</artifactId>
> >                 <configuration>
> >                     <artifactSet>
> >                         <includes>
> >                             <include>com.google.collections:*</include>
> >                             <include>com.google.gdata:*</include>
> >                         </includes>
> >                     </artifactSet>
> >                     <relocations>
> >                         <relocation>
> >                             <pattern>com.google.common</pattern>
> >                             <shadedPattern>shaded.com.google.common
> > </shadedPattern>
> >                         </relocation>
> >                     </relocations>
> >                 </configuration>
> >                 <executions>
> >                     <execution>
> >                         <phase>package</phase>
> >                         <goals>
> >                             <goal>shade</goal>
> >                         </goals>
> >                     </execution>
> >                 </executions>
> >             </plugin>
> >
> > On Wed, Oct 10, 2018 at 4:34 PM Enrico Olivelli <[hidden email]>
> > wrote:
> >
> > > Il mer 10 ott 2018, 21:07 Yuri de Wit <[hidden email]> ha scritto:
> > >
> > > > Hi Enrico,
> > > >
> > > > I tried, but I could not get the dependency upgraded. I don't know
> > why. I
> > > > even tried setting the asmVersion property but without luck.
> > > > thanks,
> > > >
> > >
> > > Can you share your plugin config?
> > > Enrico
> > >
> > > >
> > > > On Wed, Oct 10, 2018 at 2:01 PM Enrico Olivelli <[hidden email]
> >
> > > > wrote:
> > > >
> > > > > You can override the dependency on asm inside the plugin
> > configuration
> > > if
> > > > > it is only a matter for upgrade
> > > > > This should work and unblock you
> > > > > Enrico
> > > > >
> > > > > Il mer 10 ott 2018, 16:17 Yuri de Wit <[hidden email]> ha
> scritto:
> > > > >
> > > > > > For what is worth:
> > > > > >
> > > > > > Caused by: java.lang.UnsupportedOperationException: This feature
> > > > requires
> > > > > > ASM7
> > > > > >     at org.objectweb.asm.ClassVisitor.visitNestHost
> > > > > (ClassVisitor.java:150)
> > > > > >     at org.objectweb.asm.ClassReader.accept
> (ClassReader.java:541)
> > > > > >     at org.objectweb.asm.ClassReader.accept
> (ClassReader.java:391)
> > > > > >     at
> > org.apache.maven.plugins.shade.DefaultShader.addRemappedClass
> > > > > > (DefaultShader.java:466)
> > > > > >     at
> org.apache.maven.plugins.shade.DefaultShader.shadeSingleJar
> > > > > > (DefaultShader.java:237)
> > > > > >     at org.apache.maven.plugins.shade.DefaultShader.shadeJars
> > > > > > (DefaultShader.java:192)
> > > > > >     at org.apache.maven.plugins.shade.DefaultShader.shade
> > > > > > (DefaultShader.java:106)
> > > > > >     at org.apache.maven.plugins.shade.mojo.ShadeMojo.execute
> > > > > > (ShadeMojo.java:442)
> > > > > >     at
> > org.apache.maven.plugin.DefaultBuildPluginManager.executeMojo
> > > > > > (DefaultBuildPluginManager.java:137)
> > > > > >
> > > > > >
> > > > > > On Wed, Oct 10, 2018 at 10:33 AM Yuri de Wit <[hidden email]>
> > > wrote:
> > > > > >
> > > > > > > Hi Olivier,
> > > > > > >
> > > > > > > Thanks for the head up!
> > > > > > >
> > > > > > >
> > > > > > >
> > > > > > > On Wed, Oct 10, 2018 at 9:16 AM Olivier Lamy <[hidden email]
> >
> > > > wrote:
> > > > > > >
> > > > > > >> Hi
> > > > > > >> On my TODO for next week with pmd and maven-plugin-plugin
> > > > > > >> Cheers
> > > > > > >> Olivier
> > > > > > >>
> > > > > > >> On Wed, 10 Oct 2018 at 10:01 pm, Yuri de Wit <
> [hidden email]>
> > > > > wrote:
> > > > > > >>
> > > > > > >> > It turns out there is already a JIRA issue for this:
> > MSHADE-301
> > > > > > >> > <https://issues.apache.org/jira/browse/MSHADE-301>. And it
> > has
> > > > been
> > > > > > >> fixed
> > > > > > >> > by Olivier Lamy.
> > > > > > >> >
> > > > > > >> > thanks,
> > > > > > >> >
> > > > > > >> > On Wed, Oct 10, 2018 at 8:56 AM Yuri de Wit <
> [hidden email]
> > >
> > > > > wrote:
> > > > > > >> >
> > > > > > >> > > Hi Enrico,
> > > > > > >> > >
> > > > > > >> > > This is the error I get:
> > > > > > >> > >
> > > > > > >> > > org.apache.maven.plugin.MojoExecutionException: Error in
> ASM
> > > > > > >> processing
> > > > > > >> > > class org/test/A/ext/StateExtension.class: This feature
> > > requires
> > > > > > ASM7
> > > > > > >> ->
> > > > > > >> > > [Help 1]
> > > > > > >> > >
> > > > > > >> > > My understanding is that asm version 6.2.1 doesn't support
> > > Java
> > > > 11
> > > > > > >> nested
> > > > > > >> > > classes unless the ASM7 is explicitly enabled from the
> API.
> > > The
> > > > > > >> version
> > > > > > >> > > 7.0+ does seem to make ASM7 the default, but so far only a
> > > > > 7.0-beta
> > > > > > >> asm
> > > > > > >> > > release.
> > > > > > >> > >
> > > > > > >> > > thanks,
> > > > > > >> > >
> > > > > > >> > >
> > > > > > >> > >
> > > > > > >> > >
> > > > > > >> > > On Wed, Oct 10, 2018 at 8:48 AM Enrico Olivelli <
> > > > > > [hidden email]>
> > > > > > >> > > wrote:
> > > > > > >> > >
> > > > > > >> > >> Il mer 10 ott 2018, 13:02 Yuri de Wit <[hidden email]>
> > ha
> > > > > > scritto:
> > > > > > >> > >>
> > > > > > >> > >> > Hi,
> > > > > > >> > >> >
> > > > > > >> > >> > Any plans to release 3.2.1 with Java 11 support?
> > > > > > >> > >> >
> > > > > > >> > >>
> > > > > > >> > >> I am using jdk11 with current stable version.
> > > > > > >> > >> Which is your problem?
> > > > > > >> > >>
> > > > > > >> > >> Enrico
> > > > > > >> > >>
> > > > > > >> > >> >
> > > > > > >> > >> > thanks,
> > > > > > >> > >> >
> > > > > > >> > >> > On Wed, Sep 12, 2018 at 5:34 PM Karl Heinz Marbaise <
> > > > > > >> > >> [hidden email]
> > > > > > >> > >> > >
> > > > > > >> > >> > wrote:
> > > > > > >> > >> >
> > > > > > >> > >> > > The Apache Maven team is pleased to announce the
> > release
> > > of
> > > > > the
> > > > > > >> > >> > > Apache Maven Shade Plugin Version 3.2.0
> > > > > > >> > >> > >
> > > > > > >> > >> > > https://maven.apache.org/plugins/maven-shade-plugin/
> > > > > > >> > >> > >
> > > > > > >> > >> > > Important Note since 3.2.0:
> > > > > > >> > >> > >
> > > > > > >> > >> > >  * Maven 3.X only
> > > > > > >> > >> > >  * If you like to use minimizeJar you have to use
> JDK8+
> > > > > > >> > >> > >    otherwise you can keep running with JDK7.
> > > > > > >> > >> > >
> > > > > > >> > >> > > You should specify the version in your project's
> plugin
> > > > > > >> > configuration:
> > > > > > >> > >> > >
> > > > > > >> > >> > > <plugin>
> > > > > > >> > >> > >   <groupId>org.apache.maven.plugins</groupId>
> > > > > > >> > >> > >   <artifactId>maven-shade-plugin</artifactId>
> > > > > > >> > >> > >   <version>3.2.0</version>
> > > > > > >> > >> > > </plugin>
> > > > > > >> > >> > >
> > > > > > >> > >> > > You can download the appropriate sources etc. from
> the
> > > > > download
> > > > > > >> > page:
> > > > > > >> > >> > >
> > > > > > >> > >> > >
> > > > > > https://maven.apache.org/plugins/maven-shade-plugin/download.cgi
> > > > > > >> > >> > >
> > > > > > >> > >> > > Release Notes Maven Shade Plugin 3.2.0
> > > > > > >> > >> > >
> > > > > > >> > >> > >
> > > > > > >> > >> > >
> > > > > > >> > >> >
> > > > > > >> > >>
> > > > > > >> >
> > > > > > >>
> > > > > >
> > > > >
> > > >
> > >
> >
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12317921&version=12343491
> > > > > > >> > >> > >
> > > > > > >> > >> > > Bug:
> > > > > > >> > >> > >
> > > > > > >> > >> > >  * [MSHADE-289] - Maven Shade Plugin does not work
> > under
> > > > Java
> > > > > > 10
> > > > > > >> > >> > >
> > > > > > >> > >> > > Improvement:
> > > > > > >> > >> > >
> > > > > > >> > >> > >  * [MSHADE-293] - Require Java 7
> > > > > > >> > >> > >
> > > > > > >> > >> > > Dependency upgrades:
> > > > > > >> > >> > >
> > > > > > >> > >> > >  * [MSHADE-294] - Upgrade maven-plugins parent to
> > version
> > > > 32
> > > > > > >> > >> > >  * [MSHADE-296] - Upgrade maven-artifact-transfer
> > 0.10.0
> > > > > > >> > >> > >
> > > > > > >> > >> > > Enjoy
> > > > > > >> > >> > >
> > > > > > >> > >> > > - The Apache Maven team
> > > > > > >> > >> > >
> > > > > > >> > >> > >
> > > > > > >> >
> > > > >
> ---------------------------------------------------------------------
> > > > > > >> > >> > > To unsubscribe, e-mail:
> > [hidden email]
> > > > > > >> > >> > > For additional commands, e-mail:
> > > [hidden email]
> > > > > > >> > >> > >
> > > > > > >> > >> > >
> > > > > > >> > >> >
> > > > > > >> > >> --
> > > > > > >> > >>
> > > > > > >> > >>
> > > > > > >> > >> -- Enrico Olivelli
> > > > > > >> > >>
> > > > > > >> > >
> > > > > > >> >
> > > > > > >> --
> > > > > > >> Olivier Lamy
> > > > > > >> http://twitter.com/olamy | http://linkedin.com/in/olamy
> > > > > > >>
> > > > > > >
> > > > > >
> > > > > --
> > > > >
> > > > >
> > > > > -- Enrico Olivelli
> > > > >
> > > >
> > > --
> > >
> > >
> > > -- Enrico Olivelli
> > >
> >
> --
>
>
> -- Enrico Olivelli
>