Need for code review and test of branch SUREFIRE-1400 (see Jira ticket)

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
2 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Need for code review and test of branch SUREFIRE-1400 (see Jira ticket)

Tibor Digana-2
Hi devs,
Hi Guillaume Boué,

Can you please test this branch on Maven Assembly build and make a code
review? On Windows.

Here we have a commit in branch SUREFIRE-1400, see [1].

The point of this fix is to start Surefire Booter JAR from
${java.io.tmpdir}/surefire-***/surefire*.jar
instead of target/surefire/surefire*.jar

The base dir ${user.dir} in urser's tests did not change.

[1]:
https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=7a6f3e6c829e86aba663de4f90963070666d2654

Thx.

--
Cheers
Tibor
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Need for code review and test of branch SUREFIRE-1400 (see Jira ticket)

gboue
This is very nice Tibor! All the ITs of maven-assembly-plugin that were
failing on my Windows set-up are now running fine. I tested this branch
both with JDK 7 and 8 on Windows 10.

I also checked that the temporary "surefire<NNNN>" directories located
in %TEMP% were correctly deleted at the end of the tests. Small note:
they aren't deleted when Maven is run in debug mode with -X, I think it
should be noted in "tempDir" javadoc.

Guillaume


Le 03/08/2017 à 15:32, Tibor Digana a écrit :

> Hi devs,
> Hi Guillaume Boué,
>
> Can you please test this branch on Maven Assembly build and make a code
> review? On Windows.
>
> Here we have a commit in branch SUREFIRE-1400, see [1].
>
> The point of this fix is to start Surefire Booter JAR from
> ${java.io.tmpdir}/surefire-***/surefire*.jar
> instead of target/surefire/surefire*.jar
>
> The base dir ${user.dir} in urser's tests did not change.
>
> [1]:
> https://git1-us-west.apache.org/repos/asf?p=maven-surefire.git;a=commit;h=7a6f3e6c829e86aba663de4f90963070666d2654
>
> Thx.
>


---
L'absence de virus dans ce courrier électronique a été vérifiée par le logiciel antivirus Avast.
https://www.avast.com/antivirus


---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Loading...