Quantcast

Maven EAR Plugin test failure

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Maven EAR Plugin test failure

dennisl
Hi

We have a problem with the current trunk of the EAR Plugin.

The pseudo-IT project-077 fails on our Jenkins Ubuntu slave with the
following message. On my local Ubuntu it also fails. It works for me on
Windows though.

"Failed tests:
testProject077(org.apache.maven.plugin.ear.it.EarMojoIT): Wrong
deployment descriptor generated for[application.xml],
org.custommonkey.xmlunit.Diff"

The expected <env-entry>s are not there.


I think the problems started with the patch for MEAR-141 that was
applied in r1235631. It's a bit difficult to tell because at that time
the builds in Jenkins failed due to Maven Archiver 2.5 not being
available during the release of it and EAR Plugin 2.7.

--
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Maven EAR Plugin test failure

Stephane Nicoll
Hi,

Can you attach the generated application.xml ?

S.

On Thursday, February 2, 2012, Dennis Lundberg <[hidden email]> wrote:

> Hi
>
> We have a problem with the current trunk of the EAR Plugin.
>
> The pseudo-IT project-077 fails on our Jenkins Ubuntu slave with the
> following message. On my local Ubuntu it also fails. It works for me on
> Windows though.
>
> "Failed tests:
> testProject077(org.apache.maven.plugin.ear.it.EarMojoIT): Wrong
> deployment descriptor generated for[application.xml],
> org.custommonkey.xmlunit.Diff"
>
> The expected <env-entry>s are not there.
>
>
> I think the problems started with the patch for MEAR-141 that was
> applied in r1235631. It's a bit difficult to tell because at that time
> the builds in Jenkins failed due to Maven Archiver 2.5 not being
> available during the release of it and EAR Plugin 2.7.
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Maven EAR Plugin test failure

dennisl
Hi,

It's available in Jenkins:
https://builds.apache.org/job/maven-plugins-ITs-m2/ws/maven-ear-plugin/target/test-classes/projects/project-077/target/application.xml/*view*/

and the expected one:
https://builds.apache.org/job/maven-plugins-ITs-m2/ws/maven-ear-plugin/target/test-classes/projects/project-077/expected-META-INF/application.xml/*view*/


On 2012-02-03 06:48, Stephane Nicoll wrote:

> Hi,
>
> Can you attach the generated application.xml ?
>
> S.
>
> On Thursday, February 2, 2012, Dennis Lundberg <[hidden email]> wrote:
>> Hi
>>
>> We have a problem with the current trunk of the EAR Plugin.
>>
>> The pseudo-IT project-077 fails on our Jenkins Ubuntu slave with the
>> following message. On my local Ubuntu it also fails. It works for me on
>> Windows though.
>>
>> "Failed tests:
>> testProject077(org.apache.maven.plugin.ear.it.EarMojoIT): Wrong
>> deployment descriptor generated for[application.xml],
>> org.custommonkey.xmlunit.Diff"
>>
>> The expected <env-entry>s are not there.
>>
>>
>> I think the problems started with the patch for MEAR-141 that was
>> applied in r1235631. It's a bit difficult to tell because at that time
>> the builds in Jenkins failed due to Maven Archiver 2.5 not being
>> available during the release of it and EAR Plugin 2.7.
>>
>> --
>> Dennis Lundberg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>


--
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Maven EAR Plugin test failure

Stephane Nicoll
In reply to this post by dennisl
Hi,

I am a bit puzzled by the issue. I agree it makes the whole work
for MEAR-141 useless on Linux or Ubuntu but I really don't understand why
it's failing for you or Jenkins.

I am actually on MacOS and I can't reproduce the issue. If you can't
reproduce the issue on Windows, it remains a linux specific issue. Looking
at the code, I don't see what could be wrong.

Can you maybe try to track down the issue a bit? My best guess is
GenerateApplicationXmlMojo#buildEnvEntries which may not found the
<env-entries> element at all in the pom. But that would be a plexus bug
then.

Thanks,
S.

On Thu, Feb 2, 2012 at 10:46 PM, Dennis Lundberg <[hidden email]> wrote:

> Hi
>
> We have a problem with the current trunk of the EAR Plugin.
>
> The pseudo-IT project-077 fails on our Jenkins Ubuntu slave with the
> following message. On my local Ubuntu it also fails. It works for me on
> Windows though.
>
> "Failed tests:
> testProject077(org.apache.maven.plugin.ear.it.EarMojoIT): Wrong
> deployment descriptor generated for[application.xml],
> org.custommonkey.xmlunit.Diff"
>
> The expected <env-entry>s are not there.
>
>
> I think the problems started with the patch for MEAR-141 that was
> applied in r1235631. It's a bit difficult to tell because at that time
> the builds in Jenkins failed due to Maven Archiver 2.5 not being
> available during the release of it and EAR Plugin 2.7.
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Maven EAR Plugin test failure

Stephane Nicoll
Anyone? Or I'll have to install a VM with ubuntu on it but I guess this
shouldn't take too long to spot.

If that's a bug in plexus, I can revert the feature and reopen the related
issue until we get a fix for it.

S.

On Wed, Feb 8, 2012 at 1:05 AM, Stephane Nicoll
<[hidden email]>wrote:

> Hi,
>
> I am a bit puzzled by the issue. I agree it makes the whole work
> for MEAR-141 useless on Linux or Ubuntu but I really don't understand why
> it's failing for you or Jenkins.
>
> I am actually on MacOS and I can't reproduce the issue. If you can't
> reproduce the issue on Windows, it remains a linux specific issue. Looking
> at the code, I don't see what could be wrong.
>
> Can you maybe try to track down the issue a bit? My best guess is
> GenerateApplicationXmlMojo#buildEnvEntries which may not found the
> <env-entries> element at all in the pom. But that would be a plexus bug
> then.
>
> Thanks,
> S.
>
>
> On Thu, Feb 2, 2012 at 10:46 PM, Dennis Lundberg <[hidden email]>wrote:
>
>> Hi
>>
>> We have a problem with the current trunk of the EAR Plugin.
>>
>> The pseudo-IT project-077 fails on our Jenkins Ubuntu slave with the
>> following message. On my local Ubuntu it also fails. It works for me on
>> Windows though.
>>
>> "Failed tests:
>> testProject077(org.apache.maven.plugin.ear.it.EarMojoIT): Wrong
>> deployment descriptor generated for[application.xml],
>> org.custommonkey.xmlunit.Diff"
>>
>> The expected <env-entry>s are not there.
>>
>>
>> I think the problems started with the patch for MEAR-141 that was
>> applied in r1235631. It's a bit difficult to tell because at that time
>> the builds in Jenkins failed due to Maven Archiver 2.5 not being
>> available during the release of it and EAR Plugin 2.7.
>>
>> --
>> Dennis Lundberg
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: [hidden email]
>> For additional commands, e-mail: [hidden email]
>>
>>
>
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Maven EAR Plugin test failure

dennisl
I'll have a closer look at it in a little while.

On 2012-02-09 06:59, Stephane Nicoll wrote:

> Anyone? Or I'll have to install a VM with ubuntu on it but I guess this
> shouldn't take too long to spot.
>
> If that's a bug in plexus, I can revert the feature and reopen the related
> issue until we get a fix for it.
>
> S.
>
> On Wed, Feb 8, 2012 at 1:05 AM, Stephane Nicoll
> <[hidden email]>wrote:
>
>> Hi,
>>
>> I am a bit puzzled by the issue. I agree it makes the whole work
>> for MEAR-141 useless on Linux or Ubuntu but I really don't understand why
>> it's failing for you or Jenkins.
>>
>> I am actually on MacOS and I can't reproduce the issue. If you can't
>> reproduce the issue on Windows, it remains a linux specific issue. Looking
>> at the code, I don't see what could be wrong.
>>
>> Can you maybe try to track down the issue a bit? My best guess is
>> GenerateApplicationXmlMojo#buildEnvEntries which may not found the
>> <env-entries> element at all in the pom. But that would be a plexus bug
>> then.
>>
>> Thanks,
>> S.
>>
>>
>> On Thu, Feb 2, 2012 at 10:46 PM, Dennis Lundberg <[hidden email]>wrote:
>>
>>> Hi
>>>
>>> We have a problem with the current trunk of the EAR Plugin.
>>>
>>> The pseudo-IT project-077 fails on our Jenkins Ubuntu slave with the
>>> following message. On my local Ubuntu it also fails. It works for me on
>>> Windows though.
>>>
>>> "Failed tests:
>>> testProject077(org.apache.maven.plugin.ear.it.EarMojoIT): Wrong
>>> deployment descriptor generated for[application.xml],
>>> org.custommonkey.xmlunit.Diff"
>>>
>>> The expected <env-entry>s are not there.
>>>
>>>
>>> I think the problems started with the patch for MEAR-141 that was
>>> applied in r1235631. It's a bit difficult to tell because at that time
>>> the builds in Jenkins failed due to Maven Archiver 2.5 not being
>>> available during the release of it and EAR Plugin 2.7.
>>>
>>> --
>>> Dennis Lundberg
>>>
>>> ---------------------------------------------------------------------
>>> To unsubscribe, e-mail: [hidden email]
>>> For additional commands, e-mail: [hidden email]
>>>
>>>
>>
>


--
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Maven EAR Plugin test failure

dennisl
Hi

Okay, so my initial finding turned out to be wrong. This is actually a
good thing, because OS-dependent bugs are a pain to track down and
shouldn't really exist in our Java eco-system.

The IT fails when run with Maven 2.2.1 and succeeds when run with Maven
3.0.4, consistently on both Ubuntu *and* Windows. Same thing in Jenkins
when I looked closer:

Expected:

https://builds.apache.org/job/maven-plugins-ITs-m3/ws/maven-ear-plugin/target/test-classes/projects/project-077/expected-META-INF/application.xml/*view*/

Actual:
https://builds.apache.org/job/maven-plugins-ITs-m3/ws/maven-ear-plugin/target/test-classes/projects/project-077/target/application.xml/*view*/


Stephane, can you verify this on OSX?

On 2012-02-09 20:49, Dennis Lundberg wrote:

> I'll have a closer look at it in a little while.
>
> On 2012-02-09 06:59, Stephane Nicoll wrote:
>> Anyone? Or I'll have to install a VM with ubuntu on it but I guess this
>> shouldn't take too long to spot.
>>
>> If that's a bug in plexus, I can revert the feature and reopen the related
>> issue until we get a fix for it.
>>
>> S.
>>
>> On Wed, Feb 8, 2012 at 1:05 AM, Stephane Nicoll
>> <[hidden email]>wrote:
>>
>>> Hi,
>>>
>>> I am a bit puzzled by the issue. I agree it makes the whole work
>>> for MEAR-141 useless on Linux or Ubuntu but I really don't understand why
>>> it's failing for you or Jenkins.
>>>
>>> I am actually on MacOS and I can't reproduce the issue. If you can't
>>> reproduce the issue on Windows, it remains a linux specific issue. Looking
>>> at the code, I don't see what could be wrong.
>>>
>>> Can you maybe try to track down the issue a bit? My best guess is
>>> GenerateApplicationXmlMojo#buildEnvEntries which may not found the
>>> <env-entries> element at all in the pom. But that would be a plexus bug
>>> then.
>>>
>>> Thanks,
>>> S.
>>>
>>>
>>> On Thu, Feb 2, 2012 at 10:46 PM, Dennis Lundberg <[hidden email]>wrote:
>>>
>>>> Hi
>>>>
>>>> We have a problem with the current trunk of the EAR Plugin.
>>>>
>>>> The pseudo-IT project-077 fails on our Jenkins Ubuntu slave with the
>>>> following message. On my local Ubuntu it also fails. It works for me on
>>>> Windows though.
>>>>
>>>> "Failed tests:
>>>> testProject077(org.apache.maven.plugin.ear.it.EarMojoIT): Wrong
>>>> deployment descriptor generated for[application.xml],
>>>> org.custommonkey.xmlunit.Diff"
>>>>
>>>> The expected <env-entry>s are not there.
>>>>
>>>>
>>>> I think the problems started with the patch for MEAR-141 that was
>>>> applied in r1235631. It's a bit difficult to tell because at that time
>>>> the builds in Jenkins failed due to Maven Archiver 2.5 not being
>>>> available during the release of it and EAR Plugin 2.7.
>>>>
>>>> --
>>>> Dennis Lundberg
>>>>
>>>> ---------------------------------------------------------------------
>>>> To unsubscribe, e-mail: [hidden email]
>>>> For additional commands, e-mail: [hidden email]
>>>>
>>>>
>>>
>>
>
>


--
Dennis Lundberg

---------------------------------------------------------------------
To unsubscribe, e-mail: [hidden email]
For additional commands, e-mail: [hidden email]

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Maven EAR Plugin test failure

Stephane Nicoll
Hi,

Yes it's failing with 2.2.1 on MacOS as well. I vaguely remember that some
plexus dependencies could not be upgraded to a certain version with Maven
2.x. I can see that plexus-utils was moved to 3.0 and I am sure there was
some incompatibility issue back then.

I am a bit puzzled by the issue actually. I can debug to see what's going
on for sure but if someone used with plexus dependency chain can have a
look, that would be great.

S.

On Fri, Feb 10, 2012 at 8:07 PM, Dennis Lundberg <[hidden email]> wrote:

> Hi
>
> Okay, so my initial finding turned out to be wrong. This is actually a
> good thing, because OS-dependent bugs are a pain to track down and
> shouldn't really exist in our Java eco-system.
>
> The IT fails when run with Maven 2.2.1 and succeeds when run with Maven
> 3.0.4, consistently on both Ubuntu *and* Windows. Same thing in Jenkins
> when I looked closer:
>
> Expected:
>
>
> https://builds.apache.org/job/maven-plugins-ITs-m3/ws/maven-ear-plugin/target/test-classes/projects/project-077/expected-META-INF/application.xml/*view*/
>
> Actual:
>
> https://builds.apache.org/job/maven-plugins-ITs-m3/ws/maven-ear-plugin/target/test-classes/projects/project-077/target/application.xml/*view*/
>
>
> Stephane, can you verify this on OSX?
>
> On 2012-02-09 20:49, Dennis Lundberg wrote:
> > I'll have a closer look at it in a little while.
> >
> > On 2012-02-09 06:59, Stephane Nicoll wrote:
> >> Anyone? Or I'll have to install a VM with ubuntu on it but I guess this
> >> shouldn't take too long to spot.
> >>
> >> If that's a bug in plexus, I can revert the feature and reopen the
> related
> >> issue until we get a fix for it.
> >>
> >> S.
> >>
> >> On Wed, Feb 8, 2012 at 1:05 AM, Stephane Nicoll
> >> <[hidden email]>wrote:
> >>
> >>> Hi,
> >>>
> >>> I am a bit puzzled by the issue. I agree it makes the whole work
> >>> for MEAR-141 useless on Linux or Ubuntu but I really don't understand
> why
> >>> it's failing for you or Jenkins.
> >>>
> >>> I am actually on MacOS and I can't reproduce the issue. If you can't
> >>> reproduce the issue on Windows, it remains a linux specific issue.
> Looking
> >>> at the code, I don't see what could be wrong.
> >>>
> >>> Can you maybe try to track down the issue a bit? My best guess is
> >>> GenerateApplicationXmlMojo#buildEnvEntries which may not found the
> >>> <env-entries> element at all in the pom. But that would be a plexus bug
> >>> then.
> >>>
> >>> Thanks,
> >>> S.
> >>>
> >>>
> >>> On Thu, Feb 2, 2012 at 10:46 PM, Dennis Lundberg <[hidden email]
> >wrote:
> >>>
> >>>> Hi
> >>>>
> >>>> We have a problem with the current trunk of the EAR Plugin.
> >>>>
> >>>> The pseudo-IT project-077 fails on our Jenkins Ubuntu slave with the
> >>>> following message. On my local Ubuntu it also fails. It works for me
> on
> >>>> Windows though.
> >>>>
> >>>> "Failed tests:
> >>>> testProject077(org.apache.maven.plugin.ear.it.EarMojoIT): Wrong
> >>>> deployment descriptor generated for[application.xml],
> >>>> org.custommonkey.xmlunit.Diff"
> >>>>
> >>>> The expected <env-entry>s are not there.
> >>>>
> >>>>
> >>>> I think the problems started with the patch for MEAR-141 that was
> >>>> applied in r1235631. It's a bit difficult to tell because at that time
> >>>> the builds in Jenkins failed due to Maven Archiver 2.5 not being
> >>>> available during the release of it and EAR Plugin 2.7.
> >>>>
> >>>> --
> >>>> Dennis Lundberg
> >>>>
> >>>> ---------------------------------------------------------------------
> >>>> To unsubscribe, e-mail: [hidden email]
> >>>> For additional commands, e-mail: [hidden email]
> >>>>
> >>>>
> >>>
> >>
> >
> >
>
>
> --
> Dennis Lundberg
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: [hidden email]
> For additional commands, e-mail: [hidden email]
>
>
Loading...